Message ID | 20190528110748.10772-1-bruce.richardson@intel.com (mailing list archive) |
---|---|
Headers |
Return-Path: <dev-bounces@dpdk.org> X-Original-To: patchwork@dpdk.org Delivered-To: patchwork@dpdk.org Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 99E722E8F; Tue, 28 May 2019 13:08:06 +0200 (CEST) Received: from mga17.intel.com (mga17.intel.com [192.55.52.151]) by dpdk.org (Postfix) with ESMTP id 11B80137D; Tue, 28 May 2019 13:08:04 +0200 (CEST) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga007.jf.intel.com ([10.7.209.58]) by fmsmga107.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 28 May 2019 04:08:03 -0700 X-ExtLoop1: 1 Received: from silpixa00399126.ir.intel.com (HELO silpixa00399126.ger.corp.intel.com) ([10.237.223.2]) by orsmga007.jf.intel.com with ESMTP; 28 May 2019 04:07:58 -0700 From: Bruce Richardson <bruce.richardson@intel.com> To: dev@dpdk.org Cc: Shreyansh Jain <shreyansh.jain@nxp.com>, Alejandro Lucero <alejandro.lucero@netronome.com>, Anatoly Burakov <anatoly.burakov@intel.com>, stable@dpdk.org, Maxime Coquelin <maxime.coquelin@redhat.com>, Zhihong Wang <zhihong.wang@intel.com>, Luca Boccassi <bluca@debian.org>, Zhang XuemingX <xuemingx.zhang@intel.com>, Bruce Richardson <bruce.richardson@intel.com> Date: Tue, 28 May 2019 12:07:43 +0100 Message-Id: <20190528110748.10772-1-bruce.richardson@intel.com> X-Mailer: git-send-email 2.21.0 In-Reply-To: <20190527161509.50252-1-bruce.richardson@intel.com> References: <20190527161509.50252-1-bruce.richardson@intel.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Subject: [dpdk-dev] [PATCH v2 0/5] fix 32-bit meson builds X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions <dev.dpdk.org> List-Unsubscribe: <https://mails.dpdk.org/options/dev>, <mailto:dev-request@dpdk.org?subject=unsubscribe> List-Archive: <http://mails.dpdk.org/archives/dev/> List-Post: <mailto:dev@dpdk.org> List-Help: <mailto:dev-request@dpdk.org?subject=help> List-Subscribe: <https://mails.dpdk.org/listinfo/dev>, <mailto:dev-request@dpdk.org?subject=subscribe> Errors-To: dev-bounces@dpdk.org Sender: "dev" <dev-bounces@dpdk.org> |
Series |
fix 32-bit meson builds
|
|
Message
Bruce Richardson
May 28, 2019, 11:07 a.m. UTC
This set fixes some issues seen on the automated CI system with building on 32-bit Linux distro's using meson and ninja. The fixes are to disable unsupported parts of the build, and switch the 32-bit builds to always having large file support, so that make and meson are consistent in that regard. V2: add two additional patches to fix clang builds. This allows the test-meson-builds.sh script to run successfully on 32-bit Ubuntu 16.04 systems. Bruce Richardson (5): net/nfp: disable nfp for 32-bit meson builds build: enable large file support on 32-bit build: remove unnecessary large file support defines eal: mark unused function in 32-bit builds build: add libatomic dependency for 32-bit clang compile drivers/common/dpaax/dpaax_iova_table.c | 4 ++-- drivers/event/octeontx/meson.build | 5 +++++ drivers/event/opdl/meson.build | 5 +++++ drivers/net/nfp/meson.build | 2 +- examples/vhost_crypto/meson.build | 1 - examples/vhost_scsi/meson.build | 1 - lib/librte_eal/linux/eal/eal_memalloc.c | 1 - lib/librte_eal/linux/eal/eal_memory.c | 2 +- lib/librte_rcu/meson.build | 5 +++++ lib/librte_vhost/Makefile | 2 +- mk/arch/arm/rte.vars.mk | 2 +- mk/arch/i686/rte.vars.mk | 2 +- 12 files changed, 22 insertions(+), 10 deletions(-)
Comments
28/05/2019 13:07, Bruce Richardson: > This set fixes some issues seen on the automated CI system with building > on 32-bit Linux distro's using meson and ninja. The fixes are to disable > unsupported parts of the build, and switch the 32-bit builds to always > having large file support, so that make and meson are consistent in that > regard. > > V2: add two additional patches to fix clang builds. This allows the > test-meson-builds.sh script to run successfully on 32-bit Ubuntu > 16.04 systems. > > Bruce Richardson (5): > net/nfp: disable nfp for 32-bit meson builds > build: enable large file support on 32-bit > build: remove unnecessary large file support defines > eal: mark unused function in 32-bit builds > build: add libatomic dependency for 32-bit clang compile Applied, thanks
On 28/05/2019 12:07, Bruce Richardson wrote: > This set fixes some issues seen on the automated CI system with building > on 32-bit Linux distro's using meson and ninja. The fixes are to disable > unsupported parts of the build, and switch the 32-bit builds to always > having large file support, so that make and meson are consistent in that > regard. > > V2: add two additional patches to fix clang builds. This allows the > test-meson-builds.sh script to run successfully on 32-bit Ubuntu > 16.04 systems. > > Bruce Richardson (5): > net/nfp: disable nfp for 32-bit meson builds > build: enable large file support on 32-bit > build: remove unnecessary large file support defines > eal: mark unused function in 32-bit builds > build: add libatomic dependency for 32-bit clang compile > Hi Bruce, Intel validation team reported failures with some 32-bit builds with meson on 18.11.3-rc1. I've tested with these patches and it fixes the problems. I also took d23e141ffa52 ("build: set RTE_ARCH_64 based on pointer size"), to avoid rebasing the other patches to check 'void *' size multiple times. Any objection to applying for 18.11 branch? Kevin. > drivers/common/dpaax/dpaax_iova_table.c | 4 ++-- > drivers/event/octeontx/meson.build | 5 +++++ > drivers/event/opdl/meson.build | 5 +++++ > drivers/net/nfp/meson.build | 2 +- > examples/vhost_crypto/meson.build | 1 - > examples/vhost_scsi/meson.build | 1 - > lib/librte_eal/linux/eal/eal_memalloc.c | 1 - > lib/librte_eal/linux/eal/eal_memory.c | 2 +- > lib/librte_rcu/meson.build | 5 +++++ > lib/librte_vhost/Makefile | 2 +- > mk/arch/arm/rte.vars.mk | 2 +- > mk/arch/i686/rte.vars.mk | 2 +- > 12 files changed, 22 insertions(+), 10 deletions(-) >
On Wed, Oct 02, 2019 at 04:11:56PM +0100, Kevin Traynor wrote: > On 28/05/2019 12:07, Bruce Richardson wrote: > > This set fixes some issues seen on the automated CI system with building > > on 32-bit Linux distro's using meson and ninja. The fixes are to disable > > unsupported parts of the build, and switch the 32-bit builds to always > > having large file support, so that make and meson are consistent in that > > regard. > > > > V2: add two additional patches to fix clang builds. This allows the > > test-meson-builds.sh script to run successfully on 32-bit Ubuntu > > 16.04 systems. > > > > Bruce Richardson (5): > > net/nfp: disable nfp for 32-bit meson builds > > build: enable large file support on 32-bit > > build: remove unnecessary large file support defines > > eal: mark unused function in 32-bit builds > > build: add libatomic dependency for 32-bit clang compile > > > > Hi Bruce, Intel validation team reported failures with some 32-bit > builds with meson on 18.11.3-rc1. I've tested with these patches and it > fixes the problems. > > I also took d23e141ffa52 ("build: set RTE_ARCH_64 based on pointer > size"), to avoid rebasing the other patches to check 'void *' size > multiple times. > > Any objection to applying for 18.11 branch? > > Kevin. > Nope, no objections. Thanks.