[dpdk-dev,2/2] app/testpmd: fix RSS structure initialisation
Checks
Commit Message
Struct rss_conf.rss_key_len is not initialised forcing the user to verify
the rss_conf.rss_key pointer to know if the key is present or not.
rss_conf.rss_key_len should have a valid length according to the size of
the rss_key pointed.
Fixes: 560e02ee5237 ("app/testpmd: configure RSS without restart")
Cc: ivan.boule@6wind.com
Cc: stable@dpdk.org
Signed-off-by: Nelio Laranjeiro <nelio.laranjeiro@6wind.com>
Acked-by: Yongseok Koh <yskoh@mellanox.com>
---
app/test-pmd/cmdline.c | 2 +-
drivers/net/mlx5/mlx5_rss.c | 2 +-
2 files changed, 2 insertions(+), 2 deletions(-)
Comments
On 10/13/2017 5:09 AM, Nelio Laranjeiro wrote:
> Struct rss_conf.rss_key_len is not initialised forcing the user to verify
> the rss_conf.rss_key pointer to know if the key is present or not.
> rss_conf.rss_key_len should have a valid length according to the size of
> the rss_key pointed.
>
> Fixes: 560e02ee5237 ("app/testpmd: configure RSS without restart")
> Cc: ivan.boule@6wind.com
> Cc: stable@dpdk.org
>
> Signed-off-by: Nelio Laranjeiro <nelio.laranjeiro@6wind.com>
> Acked-by: Yongseok Koh <yskoh@mellanox.com>
> ---
> app/test-pmd/cmdline.c | 2 +-
> drivers/net/mlx5/mlx5_rss.c | 2 +-
Hi Nelio,
Can you please separate test-pmd and driver patch please?
Thanks,
ferruh
@@ -1750,7 +1750,7 @@ cmd_config_rss_parsed(void *parsed_result,
__attribute__((unused)) void *data)
{
struct cmd_config_rss *res = parsed_result;
- struct rte_eth_rss_conf rss_conf;
+ struct rte_eth_rss_conf rss_conf = { .rss_key_len = 0, };
int diag;
uint8_t i;
@@ -72,7 +72,7 @@ mlx5_rss_hash_update(struct rte_eth_dev *dev,
int ret = 0;
priv_lock(priv);
- if (rss_conf->rss_key_len) {
+ if (rss_conf->rss_key && rss_conf->rss_key_len) {
priv->rss_conf.rss_key = rte_realloc(priv->rss_conf.rss_key,
rss_conf->rss_key_len, 0);
if (!priv->rss_conf.rss_key) {