From patchwork Fri Oct 13 12:09:45 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: =?utf-8?q?N=C3=A9lio_Laranjeiro?= X-Patchwork-Id: 30351 X-Patchwork-Delegate: ferruh.yigit@amd.com Return-Path: X-Original-To: patchwork@dpdk.org Delivered-To: patchwork@dpdk.org Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id A896F1B674; Fri, 13 Oct 2017 14:10:13 +0200 (CEST) Received: from mail-wm0-f47.google.com (mail-wm0-f47.google.com [74.125.82.47]) by dpdk.org (Postfix) with ESMTP id C160A1B65D for ; Fri, 13 Oct 2017 14:10:10 +0200 (CEST) Received: by mail-wm0-f47.google.com with SMTP id 196so27800065wma.1 for ; Fri, 13 Oct 2017 05:10:10 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=6wind-com.20150623.gappssmtp.com; s=20150623; h=from:to:cc:subject:date:message-id:in-reply-to:references :in-reply-to:references; bh=S1+CykoHg2nMD8y3QlaLImN7gAUwmoX/K/mxIJ95As4=; b=TtJLjveorecsCtd6MfMKaQpzZIfIxbIHeH1bDEMh69FeLRVxlAZSiYk2PKVvUuHV7W wS7MHp6V08INJxNQUeeCKNM1PizCPJ3PwTseg5ocASls/mb2u8espHEayTwRq4cHBopS pmXyDh6Kq1jrd+nVoO4sGYiMnjzd3sSPOC1Qq93a3JgIz3/w4gP86//dSh/0G7Z8KLTg SuIZHO2AQ0+sfaqRormYTeP6ygPWFblnTjDjzvGPI1QDNtbLkBQxmFepiFOthK1QxiiM WfLs7crT9zjZcw0+BI0hWyxjzCa3yjHgX4pU/0SZliN4pTzKteLbqedgPayKfgWCHjL0 /Ciw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:in-reply-to:references; bh=S1+CykoHg2nMD8y3QlaLImN7gAUwmoX/K/mxIJ95As4=; b=KFvfRV3OfrdmINs0c5wPXJhK+NtmiLbkV1X5CCzaj3ykUelghNrXb5Y7lCo8ERzAi3 uwqzsqTc64Ll3vmecnoYLKWKi+Yla6ooK4zZApBFJps6xbTiKQtsiCYYwTfRLqSSRfte pdj8tzOBe6A8NJtS+mOFQ/kDo0obzo27T6YdOI/nZAfrhQHFptYJQ25iLJHiHQdLPBvo IYSefaLUct4iDVD03zdHlc7lt8EGhLpa8v1rdXzYaO4moMbTIBGtjQO3PZeCIiUTEef1 RAlPi8C+hsnH55/HYz0h7hCrcwECncz8ZSVstIPX3vXsQrRo7J3fglifLllEQQewn5uz ClkQ== X-Gm-Message-State: AMCzsaXLrwh+ox2dFMbIed8DZMDbWYQrHVnIcI3fcR+qcQoXcIBETQUA qSMiNZAbkWyLJP3Pz9+17vMwKuK24Q== X-Google-Smtp-Source: AOwi7QC0xcBr6IRnPP+TuvxxZ+if5TuBOQ8vCnqzVctBKruiuyw8kzT6nltTldJBOBG6WgsbqkOXTw== X-Received: by 10.223.173.165 with SMTP id w34mr1255783wrc.22.1507896610039; Fri, 13 Oct 2017 05:10:10 -0700 (PDT) Received: from laranjeiro-vm.dev.6wind.com. (host.78.145.23.62.rev.coltfrance.com. [62.23.145.78]) by smtp.gmail.com with ESMTPSA id r123sm802284wmf.41.2017.10.13.05.10.09 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Fri, 13 Oct 2017 05:10:09 -0700 (PDT) From: Nelio Laranjeiro To: dev@dpdk.org Cc: Yongseok Koh , Adrien Mazarguil , ivan.boule@6wind.com, stable@dpdk.org Date: Fri, 13 Oct 2017 14:09:45 +0200 Message-Id: <8b28426c813b6811a15ee18d51d44dae748b04c8.1507896510.git.nelio.laranjeiro@6wind.com> X-Mailer: git-send-email 2.11.0 In-Reply-To: References: In-Reply-To: References: Subject: [dpdk-dev] [PATCH 2/2] app/testpmd: fix RSS structure initialisation X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Struct rss_conf.rss_key_len is not initialised forcing the user to verify the rss_conf.rss_key pointer to know if the key is present or not. rss_conf.rss_key_len should have a valid length according to the size of the rss_key pointed. Fixes: 560e02ee5237 ("app/testpmd: configure RSS without restart") Cc: ivan.boule@6wind.com Cc: stable@dpdk.org Signed-off-by: Nelio Laranjeiro Acked-by: Yongseok Koh --- app/test-pmd/cmdline.c | 2 +- drivers/net/mlx5/mlx5_rss.c | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/app/test-pmd/cmdline.c b/app/test-pmd/cmdline.c index 120460452..abbe52ad6 100644 --- a/app/test-pmd/cmdline.c +++ b/app/test-pmd/cmdline.c @@ -1750,7 +1750,7 @@ cmd_config_rss_parsed(void *parsed_result, __attribute__((unused)) void *data) { struct cmd_config_rss *res = parsed_result; - struct rte_eth_rss_conf rss_conf; + struct rte_eth_rss_conf rss_conf = { .rss_key_len = 0, }; int diag; uint8_t i; diff --git a/drivers/net/mlx5/mlx5_rss.c b/drivers/net/mlx5/mlx5_rss.c index ad6d9ab70..dd9ddf2e0 100644 --- a/drivers/net/mlx5/mlx5_rss.c +++ b/drivers/net/mlx5/mlx5_rss.c @@ -72,7 +72,7 @@ mlx5_rss_hash_update(struct rte_eth_dev *dev, int ret = 0; priv_lock(priv); - if (rss_conf->rss_key_len) { + if (rss_conf->rss_key && rss_conf->rss_key_len) { priv->rss_conf.rss_key = rte_realloc(priv->rss_conf.rss_key, rss_conf->rss_key_len, 0); if (!priv->rss_conf.rss_key) {