[v3,1/2] config/arm: allow WFE to be enabled config time

Message ID 20240121152128.6360-1-pbhagavatula@marvell.com (mailing list archive)
State Superseded, archived
Delegated to: Jerin Jacob
Headers
Series [v3,1/2] config/arm: allow WFE to be enabled config time |

Checks

Context Check Description
ci/checkpatch success coding style OK

Commit Message

Pavan Nikhilesh Bhagavatula Jan. 21, 2024, 3:21 p.m. UTC
  From: Pavan Nikhilesh <pbhagavatula@marvell.com>

Allow RTE_ARM_USE_WFE to be enabled at meson configuration
time by passing it via c_args instead of modifying
`config/arm/meson.build`.

Example usage:
 meson build -Dc_args='-DRTE_ARM_USE_WFE' \
	--cross-file config/arm/arm64_cn10k_linux_gcc

Signed-off-by: Pavan Nikhilesh <pbhagavatula@marvell.com>
---
 v3 Changes:
 - Comment the meson option instead of removing it.

 config/arm/meson.build | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)

--
2.25.1
  

Comments

fengchengwen Jan. 22, 2024, 6:37 a.m. UTC | #1
Acked-by: Chengwen Feng <fengchengwen@huawei.com>

On 2024/1/21 23:21, pbhagavatula@marvell.com wrote:
> From: Pavan Nikhilesh <pbhagavatula@marvell.com>
> 
> Allow RTE_ARM_USE_WFE to be enabled at meson configuration
> time by passing it via c_args instead of modifying
> `config/arm/meson.build`.
> 
> Example usage:
>  meson build -Dc_args='-DRTE_ARM_USE_WFE' \
> 	--cross-file config/arm/arm64_cn10k_linux_gcc
> 
> Signed-off-by: Pavan Nikhilesh <pbhagavatula@marvell.com>
> ---
>  v3 Changes:
>  - Comment the meson option instead of removing it.
> 
>  config/arm/meson.build | 4 +++-
>  1 file changed, 3 insertions(+), 1 deletion(-)
> 
> diff --git a/config/arm/meson.build b/config/arm/meson.build
> index 36f21d2259..89e1de312b 100644
> --- a/config/arm/meson.build
> +++ b/config/arm/meson.build
> @@ -17,7 +17,9 @@ flags_common = [
>          #    ['RTE_ARM64_MEMCPY_ALIGN_MASK', 0xF],
>          #    ['RTE_ARM64_MEMCPY_STRICT_ALIGN', false],
> 
> -        ['RTE_ARM_USE_WFE', false],
> +        # Enable use of ARM wait for event instruction.
> +        # ['RTE_ARM_USE_WFE', false],
> +
>          ['RTE_ARCH_ARM64', true],
>          ['RTE_CACHE_LINE_SIZE', 128]
>  ]
> --
> 2.25.1
> 
> .
>
  
Ruifeng Wang Jan. 22, 2024, 6:43 a.m. UTC | #2
On 2024/1/21 11:21 PM, pbhagavatula@marvell.com wrote:
> From: Pavan Nikhilesh <pbhagavatula@marvell.com>
>
> Allow RTE_ARM_USE_WFE to be enabled at meson configuration
> time by passing it via c_args instead of modifying
> `config/arm/meson.build`.
>
> Example usage:
>   meson build -Dc_args='-DRTE_ARM_USE_WFE' \
>       --cross-file config/arm/arm64_cn10k_linux_gcc
>
> Signed-off-by: Pavan Nikhilesh <pbhagavatula@marvell.com>
> ---
>   v3 Changes:
>   - Comment the meson option instead of removing it.
>
>   config/arm/meson.build | 4 +++-
>   1 file changed, 3 insertions(+), 1 deletion(-)
>
> diff --git a/config/arm/meson.build b/config/arm/meson.build
> index 36f21d2259..89e1de312b 100644
> --- a/config/arm/meson.build
> +++ b/config/arm/meson.build
> @@ -17,7 +17,9 @@ flags_common = [
>           #    ['RTE_ARM64_MEMCPY_ALIGN_MASK', 0xF],
>           #    ['RTE_ARM64_MEMCPY_STRICT_ALIGN', false],
>
> -        ['RTE_ARM_USE_WFE', false],
> +        # Enable use of ARM wait for event instruction.
> +        # ['RTE_ARM_USE_WFE', false],
> +
>           ['RTE_ARCH_ARM64', true],
>           ['RTE_CACHE_LINE_SIZE', 128]
>   ]
> --
> 2.25.1
>
Acked-by: Ruifeng Wang <ruifeng.wang@arm.com>
IMPORTANT NOTICE: The contents of this email and any attachments are confidential and may also be privileged. If you are not the intended recipient, please notify the sender immediately and do not disclose the contents to any other person, use it for any purpose, or store or copy the information in any medium. Thank you.
  
Jerin Jacob Feb. 1, 2024, 4:37 p.m. UTC | #3
On Mon, Jan 22, 2024 at 12:13 PM Ruifeng Wang <Ruifeng.Wang@arm.com> wrote:
>
>
> On 2024/1/21 11:21 PM, pbhagavatula@marvell.com wrote:
> > From: Pavan Nikhilesh <pbhagavatula@marvell.com>
> >
> > Allow RTE_ARM_USE_WFE to be enabled at meson configuration
> > time by passing it via c_args instead of modifying
> > `config/arm/meson.build`.
> >
> > Example usage:
> >   meson build -Dc_args='-DRTE_ARM_USE_WFE' \
> >       --cross-file config/arm/arm64_cn10k_linux_gcc
> >
> > Signed-off-by: Pavan Nikhilesh <pbhagavatula@marvell.com>

Could you split and resend this series a two separate patch as this
patch needs to go through main tree.
  

Patch

diff --git a/config/arm/meson.build b/config/arm/meson.build
index 36f21d2259..89e1de312b 100644
--- a/config/arm/meson.build
+++ b/config/arm/meson.build
@@ -17,7 +17,9 @@  flags_common = [
         #    ['RTE_ARM64_MEMCPY_ALIGN_MASK', 0xF],
         #    ['RTE_ARM64_MEMCPY_STRICT_ALIGN', false],

-        ['RTE_ARM_USE_WFE', false],
+        # Enable use of ARM wait for event instruction.
+        # ['RTE_ARM_USE_WFE', false],
+
         ['RTE_ARCH_ARM64', true],
         ['RTE_CACHE_LINE_SIZE', 128]
 ]