diff mbox series

app/testpmd: add the check for port and queue Rx/Tx offload

Message ID 20231115103323.65182-1-lihuisong@huawei.com (mailing list archive)
State Accepted, archived
Delegated to: Ferruh Yigit
Headers
Series app/testpmd: add the check for port and queue Rx/Tx offload |

Checks

Context Check Description
ci/checkpatch success coding style OK
ci/loongarch-compilation success Compilation OK
ci/loongarch-unit-testing success Unit Testing PASS
ci/iol-intel-Performance success Performance Testing PASS
ci/iol-mellanox-Performance success Performance Testing PASS
ci/iol-intel-Functional success Functional Testing PASS
ci/iol-compile-amd64-testing success Testing PASS
ci/github-robot: build success github build: passed
ci/iol-sample-apps-testing success Testing PASS
ci/iol-unit-arm64-testing success Testing PASS
ci/iol-unit-amd64-testing success Testing PASS
ci/iol-compile-arm64-testing success Testing PASS
ci/Intel-compilation success Compilation OK
ci/intel-Testing success Testing PASS
ci/iol-broadcom-Performance success Performance Testing PASS
ci/iol-broadcom-Functional success Functional Testing PASS

Commit Message

lihuisong (C) Nov. 15, 2023, 10:33 a.m. UTC 
  This patch adds the check for port and per queue Rx/Tx offload to avoid the
failure of "port start all" when config a offload driver didn't support.

Signed-off-by: Huisong Li <lihuisong@huawei.com>
---
 app/test-pmd/cmdline.c | 20 ++++++++++++++++++++
 1 file changed, 20 insertions(+)

Comments

Ferruh Yigit Nov. 15, 2023, 12:50 p.m. UTC | #1 
On 11/15/2023 10:33 AM, Huisong Li wrote:
> This patch adds the check for port and per queue Rx/Tx offload to avoid the
> failure of "port start all" when config a offload driver didn't support.
> 
> Signed-off-by: Huisong Li <lihuisong@huawei.com>
> 

Reviewed-by: Ferruh Yigit <ferruh.yigit@amd.com>

Applied to dpdk-next-net/main, thanks.
diff mbox series

Patch

diff --git a/app/test-pmd/cmdline.c b/app/test-pmd/cmdline.c
index a231d112b0..c040de7a79 100644
--- a/app/test-pmd/cmdline.c
+++ b/app/test-pmd/cmdline.c
@@ -11186,6 +11186,11 @@  config_port_rx_offload(portid_t port_id, char *name, bool on)
 			fprintf(stderr, "Unknown offload name: %s\n", name);
 			return;
 		}
+		if ((offload & dev_info.rx_offload_capa) == 0) {
+			fprintf(stderr, "Error: port %u doesn't support offload: %s.\n",
+				port_id, name);
+			return;
+		}
 	}
 
 	nb_rx_queues = dev_info.nb_rx_queues;
@@ -11388,6 +11393,11 @@  cmd_config_per_queue_rx_offload_parsed(void *parsed_result,
 			fprintf(stderr, "Unknown offload name: %s\n", res->offload);
 			return;
 		}
+		if ((offload & dev_info.rx_queue_offload_capa) == 0) {
+			fprintf(stderr, "Error: port %u doesn't support per queue offload: %s.\n",
+				port_id, res->offload);
+			return;
+		}
 	}
 
 	if (!strcmp(res->on_off, "on"))
@@ -11698,6 +11708,11 @@  config_port_tx_offload(portid_t port_id, char *name, bool on)
 			fprintf(stderr, "Unknown offload name: %s\n", name);
 			return;
 		}
+		if ((offload & dev_info.tx_offload_capa) == 0) {
+			fprintf(stderr, "Error: port %u doesn't support offload: %s.\n",
+				port_id, name);
+			return;
+		}
 	}
 
 	nb_tx_queues = dev_info.nb_tx_queues;
@@ -11904,6 +11919,11 @@  cmd_config_per_queue_tx_offload_parsed(void *parsed_result,
 			fprintf(stderr, "Unknown offload name: %s\n", res->offload);
 			return;
 		}
+		if ((offload & dev_info.tx_queue_offload_capa) == 0) {
+			fprintf(stderr, "Error: port %u doesn't support per queue offload: %s.\n",
+				port_id, res->offload);
+			return;
+		}
 	}
 
 	if (!strcmp(res->on_off, "on"))