From patchwork Wed Nov 15 10:33:23 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: "lihuisong (C)" X-Patchwork-Id: 134374 X-Patchwork-Delegate: ferruh.yigit@amd.com Return-Path: X-Original-To: patchwork@inbox.dpdk.org Delivered-To: patchwork@inbox.dpdk.org Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id AACB843337; Wed, 15 Nov 2023 11:33:17 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 39F45402C0; Wed, 15 Nov 2023 11:33:17 +0100 (CET) Received: from szxga02-in.huawei.com (szxga02-in.huawei.com [45.249.212.188]) by mails.dpdk.org (Postfix) with ESMTP id C7D5E40285 for ; Wed, 15 Nov 2023 11:33:15 +0100 (CET) Received: from kwepemm000004.china.huawei.com (unknown [172.30.72.56]) by szxga02-in.huawei.com (SkyGuard) with ESMTP id 4SVfcy1CMlzWh8C; Wed, 15 Nov 2023 18:32:50 +0800 (CST) Received: from localhost.localdomain (10.69.192.56) by kwepemm000004.china.huawei.com (7.193.23.18) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.31; Wed, 15 Nov 2023 18:33:12 +0800 From: Huisong Li To: , , Aman Singh , Yuying Zhang CC: , , Subject: [PATCH] app/testpmd: add the check for port and queue Rx/Tx offload Date: Wed, 15 Nov 2023 18:33:23 +0800 Message-ID: <20231115103323.65182-1-lihuisong@huawei.com> X-Mailer: git-send-email 2.33.0 MIME-Version: 1.0 X-Originating-IP: [10.69.192.56] X-ClientProxiedBy: dggems706-chm.china.huawei.com (10.3.19.183) To kwepemm000004.china.huawei.com (7.193.23.18) X-CFilter-Loop: Reflected X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org This patch adds the check for port and per queue Rx/Tx offload to avoid the failure of "port start all" when config a offload driver didn't support. Signed-off-by: Huisong Li Reviewed-by: Ferruh Yigit --- app/test-pmd/cmdline.c | 20 ++++++++++++++++++++ 1 file changed, 20 insertions(+) diff --git a/app/test-pmd/cmdline.c b/app/test-pmd/cmdline.c index a231d112b0..c040de7a79 100644 --- a/app/test-pmd/cmdline.c +++ b/app/test-pmd/cmdline.c @@ -11186,6 +11186,11 @@ config_port_rx_offload(portid_t port_id, char *name, bool on) fprintf(stderr, "Unknown offload name: %s\n", name); return; } + if ((offload & dev_info.rx_offload_capa) == 0) { + fprintf(stderr, "Error: port %u doesn't support offload: %s.\n", + port_id, name); + return; + } } nb_rx_queues = dev_info.nb_rx_queues; @@ -11388,6 +11393,11 @@ cmd_config_per_queue_rx_offload_parsed(void *parsed_result, fprintf(stderr, "Unknown offload name: %s\n", res->offload); return; } + if ((offload & dev_info.rx_queue_offload_capa) == 0) { + fprintf(stderr, "Error: port %u doesn't support per queue offload: %s.\n", + port_id, res->offload); + return; + } } if (!strcmp(res->on_off, "on")) @@ -11698,6 +11708,11 @@ config_port_tx_offload(portid_t port_id, char *name, bool on) fprintf(stderr, "Unknown offload name: %s\n", name); return; } + if ((offload & dev_info.tx_offload_capa) == 0) { + fprintf(stderr, "Error: port %u doesn't support offload: %s.\n", + port_id, name); + return; + } } nb_tx_queues = dev_info.nb_tx_queues; @@ -11904,6 +11919,11 @@ cmd_config_per_queue_tx_offload_parsed(void *parsed_result, fprintf(stderr, "Unknown offload name: %s\n", res->offload); return; } + if ((offload & dev_info.tx_queue_offload_capa) == 0) { + fprintf(stderr, "Error: port %u doesn't support per queue offload: %s.\n", + port_id, res->offload); + return; + } } if (!strcmp(res->on_off, "on"))