diff mbox series

ethdev: fix flow action async query coverity

Message ID 20231017082317.735106-1-suanmingm@nvidia.com (mailing list archive)
State Accepted, archived
Delegated to: Ferruh Yigit
Headers
Series ethdev: fix flow action async query coverity |

Checks

Context Check Description
ci/checkpatch warning coding style issues
ci/loongarch-compilation success Compilation OK
ci/loongarch-unit-testing success Unit Testing PASS
ci/github-robot: build success github build: passed
ci/iol-testing warning apply patch failure

Commit Message

Suanming Mou Oct. 17, 2023, 8:23 a.m. UTC 
  This commit adds the ops chcek to fix the coverity issue.

Coverity issue: 403258
Fixes: c9dc03840873 ("ethdev: add indirect action async query")

Signed-off-by: Suanming Mou <suanmingm@nvidia.com>
---
 lib/ethdev/rte_flow.c | 2 ++
 1 file changed, 2 insertions(+)

Comments

Ori Kam Oct. 17, 2023, 12:21 p.m. UTC | #1 
Hi Suanming,

> -----Original Message-----
> From: Suanming Mou <suanmingm@nvidia.com>
> Sent: Tuesday, October 17, 2023 11:23 AM
> 
> This commit adds the ops chcek to fix the coverity issue.
> 
> Coverity issue: 403258
> Fixes: c9dc03840873 ("ethdev: add indirect action async query")
> 
> Signed-off-by: Suanming Mou <suanmingm@nvidia.com>
> ---
>  lib/ethdev/rte_flow.c | 2 ++
>  1 file changed, 2 insertions(+)
> 
> diff --git a/lib/ethdev/rte_flow.c b/lib/ethdev/rte_flow.c
> index 874f845513..3a67f1aaba 100644
> --- a/lib/ethdev/rte_flow.c
> +++ b/lib/ethdev/rte_flow.c
> @@ -2226,6 +2226,8 @@ rte_flow_async_action_handle_query(uint16_t
> port_id,
>  	const struct rte_flow_ops *ops = rte_flow_ops_get(port_id, error);
>  	int ret;
> 
> +	if (unlikely(!ops))
> +		return -rte_errno;
>  	ret = ops->async_action_handle_query(dev, queue_id, op_attr,
>  					  action_handle, data, user_data,
> error);
>  	ret = flow_err(port_id, ret, error);
> --
> 2.34.1

Acked-by: Ori Kam <orika@nvidia.com>
Ferruh Yigit Oct. 17, 2023, 1:18 p.m. UTC | #2 
On 10/17/2023 1:21 PM, Ori Kam wrote:
> Hi Suanming,
> 
>> -----Original Message-----
>> From: Suanming Mou <suanmingm@nvidia.com>
>> Sent: Tuesday, October 17, 2023 11:23 AM
>>
>> This commit adds the ops chcek to fix the coverity issue.
>>
>> Coverity issue: 403258
>> Fixes: c9dc03840873 ("ethdev: add indirect action async query")
>>
>> Signed-off-by: Suanming Mou <suanmingm@nvidia.com>
> 
> Acked-by: Ori Kam <orika@nvidia.com>
>

Applied to dpdk-next-net/main, thanks.
diff mbox series

Patch

diff --git a/lib/ethdev/rte_flow.c b/lib/ethdev/rte_flow.c
index 874f845513..3a67f1aaba 100644
--- a/lib/ethdev/rte_flow.c
+++ b/lib/ethdev/rte_flow.c
@@ -2226,6 +2226,8 @@  rte_flow_async_action_handle_query(uint16_t port_id,
 	const struct rte_flow_ops *ops = rte_flow_ops_get(port_id, error);
 	int ret;
 
+	if (unlikely(!ops))
+		return -rte_errno;
 	ret = ops->async_action_handle_query(dev, queue_id, op_attr,
 					  action_handle, data, user_data, error);
 	ret = flow_err(port_id, ret, error);