From patchwork Tue Oct 17 08:23:17 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Suanming Mou X-Patchwork-Id: 132737 X-Patchwork-Delegate: ferruh.yigit@amd.com Return-Path: X-Original-To: patchwork@inbox.dpdk.org Delivered-To: patchwork@inbox.dpdk.org Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 342344318A; Tue, 17 Oct 2023 10:23:59 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 0979240279; Tue, 17 Oct 2023 10:23:59 +0200 (CEST) Received: from NAM02-DM3-obe.outbound.protection.outlook.com (mail-dm3nam02on2067.outbound.protection.outlook.com [40.107.95.67]) by mails.dpdk.org (Postfix) with ESMTP id 067DA40269 for ; Tue, 17 Oct 2023 10:23:57 +0200 (CEST) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=DSEooeKDgQip1qXCAGzS37icsvIqGMMPsvdaWmC2k9MykgUBH6iPEqprrPYbxGEoQfcQqc/UWs1fNtV/+LAI4QassjaEdaVSkTDU5NwLEqXJlxdX0s1DnilyWsCGCQiGQ/hUl5Cnj0RoxNKEW/ltGkPN4GnEncp6sRjvPLOXU/4cDlgd/LAHNLsoqytXVjtLoFNlRziA/z4mM8OXFCCXslhf53mXZ1xWKrSJ4cRnvLzeMfxfymmdqjnx+gxRsPMVwh5bRnlfIGcCmlrhA32MkvxEJ6N2opC4kA/3R4LYxK0toGoFlXTNmjMzAvrr8f7xcdFxTLL3cETVJ/EynYPnFw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=DLvG/9wpRxtChc1XVN9sv+ZNZo3JaShx51hR/PXIv/o=; b=UWOz9EdutKugkrM4OJM78Y19+3iUy2LaFEwc0IQBeXpJOJhJqU+ZHbfB6Nr5J2xfjX8gY1cINF4JYnGXvBXt26my8KwHC1VS1sDYB6tNCKb7Ux7CdKTUvwnjKV5pCu42KRn9LgPPH3Fr6UJs80pwxPHoJ7ZoKotD2fC0ZcXwJgjMX+okiXVui5Z05xksICqgKkoGy/xHVeoGvwmPzEfN6frjL1LBELJrpSsknAbyqIppp+ztqbsEYwAKoPcJE3g63v8SxNNAy9/LbSZer9ySvV+hVQqy1/b8zfS/TlUP3n5qt82HDq0ew2tcMuikb+j6yPaDOcvxz1xy3PRsOQhl2w== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 216.228.117.160) smtp.rcpttodomain=monjalon.net smtp.mailfrom=nvidia.com; dmarc=pass (p=reject sp=reject pct=100) action=none header.from=nvidia.com; dkim=none (message not signed); arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Nvidia.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=DLvG/9wpRxtChc1XVN9sv+ZNZo3JaShx51hR/PXIv/o=; b=A5jfRAUyLtYWp1B7f+K05vF8dkOARzN/Ank8XaybU/Gke6dwmmHM+2lDloaRM2HaEp4gWby2OsUC/lKHpn/blKRCG+ahNsLiGI74JZJ/R72dyKR7jE926vd+ASfA2mK09QaK0pZEuoQK2PGhj6vEIFFyBd4UVUOVD4tlmHtCAtDgY4SrfOdJP2nIDgzpO6kJfH0MspJm0qcLPY6Mvr+S660h8xUKsdHsNPMLlCve1TR+pK5WFDMgs9Gu+mhnrsx4cGh7y5G0C8GWxDT/pDww5O3JbJwH3QEt1bhH4cTt943Dz0ghKKJ5e/11izVq3LnY544Dq7HSOZI1FDFuS13+dQ== Received: from MW4PR03CA0116.namprd03.prod.outlook.com (2603:10b6:303:b7::31) by BN9PR12MB5260.namprd12.prod.outlook.com (2603:10b6:408:101::15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6886.35; Tue, 17 Oct 2023 08:23:55 +0000 Received: from CO1PEPF000042AB.namprd03.prod.outlook.com (2603:10b6:303:b7:cafe::d1) by MW4PR03CA0116.outlook.office365.com (2603:10b6:303:b7::31) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6886.36 via Frontend Transport; Tue, 17 Oct 2023 08:23:54 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 216.228.117.160) smtp.mailfrom=nvidia.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=nvidia.com; Received-SPF: Pass (protection.outlook.com: domain of nvidia.com designates 216.228.117.160 as permitted sender) receiver=protection.outlook.com; client-ip=216.228.117.160; helo=mail.nvidia.com; pr=C Received: from mail.nvidia.com (216.228.117.160) by CO1PEPF000042AB.mail.protection.outlook.com (10.167.243.40) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6907.20 via Frontend Transport; Tue, 17 Oct 2023 08:23:54 +0000 Received: from rnnvmail201.nvidia.com (10.129.68.8) by mail.nvidia.com (10.129.200.66) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.986.41; Tue, 17 Oct 2023 01:23:42 -0700 Received: from nvidia.com (10.126.230.35) by rnnvmail201.nvidia.com (10.129.68.8) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.986.41; Tue, 17 Oct 2023 01:23:38 -0700 From: Suanming Mou To: Ori Kam , Thomas Monjalon , "Ferruh Yigit" , Andrew Rybchenko CC: Subject: [PATCH] ethdev: fix flow action async query coverity Date: Tue, 17 Oct 2023 16:23:17 +0800 Message-ID: <20231017082317.735106-1-suanmingm@nvidia.com> X-Mailer: git-send-email 2.34.1 MIME-Version: 1.0 X-Originating-IP: [10.126.230.35] X-ClientProxiedBy: rnnvmail203.nvidia.com (10.129.68.9) To rnnvmail201.nvidia.com (10.129.68.8) X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: CO1PEPF000042AB:EE_|BN9PR12MB5260:EE_ X-MS-Office365-Filtering-Correlation-Id: f63e80b1-37bd-4537-5982-08dbceea66ce X-LD-Processed: 43083d15-7273-40c1-b7db-39efd9ccc17a,ExtAddr X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: YZOYLCgllrmhLRrAqthA8LukrmvbSK6nBjGjBftP0vOgUW/NW6b+swIxy39zO9LK+aljkDow1dZMZzDUWGAlZa14HMMBiLTehsBfYRR1XWWE1m+K7D9MQ/DZ3MKDUsAnHj+zc255kGnDalcm5wYNOSaHQjeY5uUgrMsVOiflv4khfqxxIvHozGbzZ8G+G2IXGSUiOorAEzVQ5vT0pMd3KVBe7qQnBckcKD92N25Qrn6drHCoPYNZI5fzRaCA8g6vzX7xQF6IPCQ9ubg4MV4D5hgj/k3fT8C4yg5aupqb3AmUrHGGybR/QX2oUapLdrkQVs5o5bmVMwQ1SUUYw/glkKbg6nQ/3KkCY6/w0gl09YVueeNV2MzCuffSmJDk8OGYXYnV9TQBKgLFOwvbjmDtXKjODww1yoimEpouTVRiOzjghgTe7uX2obMpoe3T/XFxhKL2uuI1DCwzubOVPIj8RzsLtqmrIOPhAIlAmKrPNgHLCseKErlsmiFPgsLuh4at1OM1icXyWOadrDkseKXZ9hYWXhw8KPCUNkxtrKRLOQM3d2r7AEukqa59sMOATO2QsTLrztcH+n9HtDxCYSjFt/Ji+g51INgF0L3LPUr25FDZC5C9B3oDqMxh0Uc3BmWGJPE3blAvokj8m7RBLpZbypZc+Y6LZkTGaE/j9211NdZzsBwZ58FR74B6i/f+a/njsCFpvcyVD1PgfxLIc4dXNnLYvJxcC9udt5aBosxbMgLGVMywGQeok8KL+7VA3sgA X-Forefront-Antispam-Report: CIP:216.228.117.160; CTRY:US; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:mail.nvidia.com; PTR:dc6edge1.nvidia.com; CAT:NONE; SFS:(13230031)(4636009)(39860400002)(136003)(346002)(396003)(376002)(230922051799003)(1800799009)(82310400011)(186009)(64100799003)(451199024)(36840700001)(40470700004)(46966006)(110136005)(4744005)(2906002)(40480700001)(356005)(7636003)(86362001)(478600001)(41300700001)(36756003)(70206006)(70586007)(36860700001)(316002)(7696005)(6666004)(8676002)(55016003)(40460700003)(8936002)(6286002)(26005)(16526019)(2616005)(426003)(82740400003)(336012)(1076003)(4326008)(47076005)(5660300002); DIR:OUT; SFP:1101; X-OriginatorOrg: Nvidia.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 17 Oct 2023 08:23:54.4588 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: f63e80b1-37bd-4537-5982-08dbceea66ce X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=43083d15-7273-40c1-b7db-39efd9ccc17a; Ip=[216.228.117.160]; Helo=[mail.nvidia.com] X-MS-Exchange-CrossTenant-AuthSource: CO1PEPF000042AB.namprd03.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: BN9PR12MB5260 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org This commit adds the ops chcek to fix the coverity issue. Coverity issue: 403258 Fixes: c9dc03840873 ("ethdev: add indirect action async query") Signed-off-by: Suanming Mou Acked-by: Ori Kam --- lib/ethdev/rte_flow.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/lib/ethdev/rte_flow.c b/lib/ethdev/rte_flow.c index 874f845513..3a67f1aaba 100644 --- a/lib/ethdev/rte_flow.c +++ b/lib/ethdev/rte_flow.c @@ -2226,6 +2226,8 @@ rte_flow_async_action_handle_query(uint16_t port_id, const struct rte_flow_ops *ops = rte_flow_ops_get(port_id, error); int ret; + if (unlikely(!ops)) + return -rte_errno; ret = ops->async_action_handle_query(dev, queue_id, op_attr, action_handle, data, user_data, error); ret = flow_err(port_id, ret, error);