diff mbox series

[v2] crypto: fix element size for undefined crypto op

Message ID 201810091428.w99ESIjR028786@lectura.cs.arizona.edu (mailing list archive)
State Accepted, archived
Delegated to: akhil goyal
Headers
Series [v2] crypto: fix element size for undefined crypto op |

Checks

Context Check Description
ci/Intel-compilation success Compilation OK

Commit Message

Junxiao Shi Oct. 9, 2018, 2:16 p.m. UTC 
  The documentation of rte_crypto_op_pool_create indicates that
specifying RTE_CRYPTO_OP_TYPE_UNDEFINED would create a pool that
supports all operation types. This change makes the code
consistent with documentation.

Fixes: c0f87eb5252b ("cryptodev: change burst API to be crypto op
oriented")

Signed-off-by: Junxiao Shi <git@mail1.yoursunny.com>
---
 lib/librte_cryptodev/rte_cryptodev.c | 3 +++
 1 file changed, 3 insertions(+)

Comments

Akhil Goyal Oct. 10, 2018, 5:10 a.m. UTC | #1 
On 10/9/2018 7:46 PM, Junxiao Shi wrote:
> The documentation of rte_crypto_op_pool_create indicates that
> specifying RTE_CRYPTO_OP_TYPE_UNDEFINED would create a pool that
> supports all operation types. This change makes the code
> consistent with documentation.
>
> Fixes: c0f87eb5252b ("cryptodev: change burst API to be crypto op
> oriented")
>
> Signed-off-by: Junxiao Shi <git@mail1.yoursunny.com>
> ---
>
Acked-by: Akhil Goyal <akhil.goyal@nxp.com>
Akhil Goyal Oct. 10, 2018, 5:26 a.m. UTC | #2 
On 10/10/2018 10:40 AM, Akhil Goyal wrote:
>
>
> On 10/9/2018 7:46 PM, Junxiao Shi wrote:
>> The documentation of rte_crypto_op_pool_create indicates that
>> specifying RTE_CRYPTO_OP_TYPE_UNDEFINED would create a pool that
>> supports all operation types. This change makes the code
>> consistent with documentation.
>>
>> Fixes: c0f87eb5252b ("cryptodev: change burst API to be crypto op
>> oriented")
>>
>> Signed-off-by: Junxiao Shi <git@mail1.yoursunny.com>
>> ---
>>
> Acked-by: Akhil Goyal <akhil.goyal@nxp.com>
Applied to dpdk-next-crypto
modified the patch title to
crypto: fix pool element size for undefined crypto op

Thanks
diff mbox series

Patch

diff --git a/lib/librte_cryptodev/rte_cryptodev.c b/lib/librte_cryptodev/rte_cryptodev.c
index 63ae23f00..608323fdd 100644
--- a/lib/librte_cryptodev/rte_cryptodev.c
+++ b/lib/librte_cryptodev/rte_cryptodev.c
@@ -1477,6 +1477,9 @@  rte_crypto_op_pool_create(const char *name, enum rte_crypto_op_type type,
 		elt_size += sizeof(struct rte_crypto_sym_op);
 	} else if (type == RTE_CRYPTO_OP_TYPE_ASYMMETRIC) {
 		elt_size += sizeof(struct rte_crypto_asym_op);
+	} else if (type == RTE_CRYPTO_OP_TYPE_UNDEFINED) {
+		elt_size += RTE_MAX(sizeof(struct rte_crypto_sym_op),
+		                    sizeof(struct rte_crypto_asym_op));
 	} else {
 		CDEV_LOG_ERR("Invalid op_type\n");
 		return NULL;