From patchwork Tue Oct 9 14:16:23 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Junxiao Shi X-Patchwork-Id: 46389 X-Patchwork-Delegate: gakhil@marvell.com Return-Path: X-Original-To: patchwork@dpdk.org Delivered-To: patchwork@dpdk.org Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id DCECE1B56E; Tue, 9 Oct 2018 16:28:22 +0200 (CEST) Received: from mails2n0-route0.email.arizona.edu (mails2n0-route0.email.arizona.edu [128.196.130.122]) by dpdk.org (Postfix) with ESMTP id 473341B561; Tue, 9 Oct 2018 16:28:20 +0200 (CEST) X-IronPort-Anti-Spam-Filtered: true X-IronPort-Anti-Spam-Result: A2AqAACSurxbjAVFDMBjHAEBAQQBAQcEAQGBUQcBAQsBg2oojApfi1MBUAEBBoQzAYV6jXaCBQEBExgBiHshNA0NAQMBAQEBAQECFAEBASZYhjk8NGGDIYF1DaYEihuJd4FCF3mBB4ESiF2FCwKOJ49PCZBhj3+VUAIEBgUCEwGBQjeBVjMaCBsVgyeQcVN7AQGLVQEB X-IPAS-Result: A2AqAACSurxbjAVFDMBjHAEBAQQBAQcEAQGBUQcBAQsBg2oojApfi1MBUAEBBoQzAYV6jXaCBQEBExgBiHshNA0NAQMBAQEBAQECFAEBASZYhjk8NGGDIYF1DaYEihuJd4FCF3mBB4ESiF2FCwKOJ49PCZBhj3+VUAIEBgUCEwGBQjeBVjMaCBsVgyeQcVN7AQGLVQEB X-IronPort-AV: E=Sophos;i="5.54,360,1534834800"; d="scan'208";a="323890562" Received: from optima.cs.arizona.edu ([192.12.69.5]) by mails2n0out.email.arizona.edu with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 09 Oct 2018 07:28:19 -0700 Received: from lectura.cs.arizona.edu (lectura.cs.arizona.edu [192.12.69.186]) by optima.cs.arizona.edu (8.14.4/8.14.4/Debian-2ubuntu2.1) with ESMTP id w99ESJFv016382 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Tue, 9 Oct 2018 07:28:19 -0700 Received: from lectura.cs.arizona.edu (localhost [127.0.0.1]) by lectura.cs.arizona.edu (8.14.4/8.14.4/Debian-4.1ubuntu1) with ESMTP id w99ESJRY028787; Tue, 9 Oct 2018 07:28:19 -0700 Received: (from shijunxiao@localhost) by lectura.cs.arizona.edu (8.14.4/8.14.4/Submit) id w99ESIjR028786; Tue, 9 Oct 2018 07:28:18 -0700 Message-Id: <201810091428.w99ESIjR028786@lectura.cs.arizona.edu> From: Junxiao Shi Date: Tue, 9 Oct 2018 10:16:23 -0400 To: dev@dpdk.org Cc: stable@dpdk.org, akhil.goyal@nxp.com Subject: [dpdk-dev] [PATCH v2] crypto: fix element size for undefined crypto op X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" The documentation of rte_crypto_op_pool_create indicates that specifying RTE_CRYPTO_OP_TYPE_UNDEFINED would create a pool that supports all operation types. This change makes the code consistent with documentation. Fixes: c0f87eb5252b ("cryptodev: change burst API to be crypto op oriented") Signed-off-by: Junxiao Shi Acked-by: Akhil Goyal --- lib/librte_cryptodev/rte_cryptodev.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/lib/librte_cryptodev/rte_cryptodev.c b/lib/librte_cryptodev/rte_cryptodev.c index 63ae23f00..608323fdd 100644 --- a/lib/librte_cryptodev/rte_cryptodev.c +++ b/lib/librte_cryptodev/rte_cryptodev.c @@ -1477,6 +1477,9 @@ rte_crypto_op_pool_create(const char *name, enum rte_crypto_op_type type, elt_size += sizeof(struct rte_crypto_sym_op); } else if (type == RTE_CRYPTO_OP_TYPE_ASYMMETRIC) { elt_size += sizeof(struct rte_crypto_asym_op); + } else if (type == RTE_CRYPTO_OP_TYPE_UNDEFINED) { + elt_size += RTE_MAX(sizeof(struct rte_crypto_sym_op), + sizeof(struct rte_crypto_asym_op)); } else { CDEV_LOG_ERR("Invalid op_type\n"); return NULL;