diff mbox series

[v2,3/3] eal/thread: fix return codes for rte_ctrl_thread_create()

Message ID 20180710104447.16756-3-darek.stojaczyk@gmail.com (mailing list archive)
State Accepted, archived
Headers show
Series [v2,1/3] eal/thread: ignore rte_thread_setname() failure in ctrl thread | expand


Context Check Description
ci/checkpatch success coding style OK
ci/Intel-compilation success Compilation OK

Commit Message

Dariusz Stojaczyk July 10, 2018, 10:44 a.m. UTC
From: Dariusz Stojaczyk <dariuszx.stojaczyk@intel.com>

This function returned positive error numbers instead
of negative ones as desbribed in the doc. What's worse,
multiple of its callers only check for (rc < 0) to detect

It was incorrectly assumed that pthread_create
and pthread_setaffinity_np return negative errnos. They
always returns positive ones, so this patch negates their
return values before returning.

Fixes: 9e5afc72c909 ("eal: add function to create control threads")
Cc: olivier.matz@6wind.com
Cc: stable@dpdk.org

Signed-off-by: Dariusz Stojaczyk <dariuszx.stojaczyk@intel.com>
Acked-by: Anatoly Burakov <anatoly.burakov@intel.com>
Reviewed-by: Olivier Matz <olivier.matz@6wind.com>
 lib/librte_eal/common/eal_common_thread.c | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)
diff mbox series


diff --git a/lib/librte_eal/common/eal_common_thread.c b/lib/librte_eal/common/eal_common_thread.c
index 8110ac2ae..48ef4d6de 100644
--- a/lib/librte_eal/common/eal_common_thread.c
+++ b/lib/librte_eal/common/eal_common_thread.c
@@ -175,7 +175,7 @@  rte_ctrl_thread_create(pthread_t *thread, const char *name,
 	params = malloc(sizeof(*params));
 	if (!params)
-		return -1;
+		return -ENOMEM;
 	params->start_routine = start_routine;
 	params->arg = arg;
@@ -185,7 +185,7 @@  rte_ctrl_thread_create(pthread_t *thread, const char *name,
 	ret = pthread_create(thread, attr, rte_thread_init, (void *)params);
 	if (ret != 0) {
-		return ret;
+		return -ret;
 	if (name != NULL) {
@@ -228,5 +228,5 @@  rte_ctrl_thread_create(pthread_t *thread, const char *name,
 	pthread_join(*thread, NULL);
-	return ret;
+	return -ret;