diff mbox series

[v2,2/3] eal/thread: fix return codes for rte_thread_setname()

Message ID 20180710104447.16756-2-darek.stojaczyk@gmail.com (mailing list archive)
State Accepted, archived
Headers show
Series [v2,1/3] eal/thread: ignore rte_thread_setname() failure in ctrl thread | expand


Context Check Description
ci/checkpatch warning coding style issues
ci/Intel-compilation success Compilation OK

Commit Message

Dariusz Stojaczyk July 10, 2018, 10:44 a.m. UTC
From: Dariusz Stojaczyk <dariuszx.stojaczyk@intel.com>

The doc says this function returns negative errno
on error, but it currently returns either -1 or
positive errno.

It was incorrectly assumed that pthread_setname_np()
returns negative error numbers. It always returns
positive ones, so this patch negates its return value
before returning.

Fixes: 3901ed99c2f8 ("eal: fix thread naming on FreeBSD")
Cc: thomas.monjalon@6wind.com
Cc: stable@dpdk.org

Signed-off-by: Dariusz Stojaczyk <dariuszx.stojaczyk@intel.com>
Acked-by: Anatoly Burakov <anatoly.burakov@intel.com>
Reviewed-by: Olivier Matz <olivier.matz@6wind.com>
Changes from v1:
 * split this patch into two parts

 lib/librte_eal/linuxapp/eal/eal_thread.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)
diff mbox series


diff --git a/lib/librte_eal/linuxapp/eal/eal_thread.c b/lib/librte_eal/linuxapp/eal/eal_thread.c
index f652ff988..b496fc711 100644
--- a/lib/librte_eal/linuxapp/eal/eal_thread.c
+++ b/lib/librte_eal/linuxapp/eal/eal_thread.c
@@ -176,7 +176,7 @@  int rte_sys_gettid(void)
 int rte_thread_setname(pthread_t id, const char *name)
-	int ret = -1;
+	int ret = ENOSYS;
 #if defined(__GLIBC__) && defined(__GLIBC_PREREQ)
 #if __GLIBC_PREREQ(2, 12)
 	ret = pthread_setname_np(id, name);
@@ -184,5 +184,5 @@  int rte_thread_setname(pthread_t id, const char *name)
-	return ret;
+	return -ret;