diff mbox

[dpdk-dev] eal: shut up warning about master lcore

Message ID 20180426004839.4097-1-sthemmin@microsoft.com (mailing list archive)
State Accepted, archived
Delegated to: Thomas Monjalon
Headers

Checks

Context Check Description
ci/checkpatch success coding style OK
ci/Intel-compilation success Compilation OK

Commit Message

Stephen Hemminger April 26, 2018, 12:48 a.m. UTC 
  This message looks suspicious and seen on healthy testpmd.
 EAL: WARNING: Master core has no memory on local socket!

The message is wrong: the master lcore is 0 and its socket is 0
and there are multiple available memory segments on socket 0.

At that point in the startup process, the count value is zero,
meaning they are not used yet so the check_socket gets confused.

Fixes: 66cc45e293ed ("mem: replace memseg with memseg lists")
Signed-off-by: Stephen Hemminger <stephen@networkplumber.org>
---
 lib/librte_eal/linuxapp/eal/eal.c | 5 +----
 1 file changed, 1 insertion(+), 4 deletions(-)

Comments

Anatoly Burakov April 26, 2018, 7:44 a.m. UTC | #1 
On 26-Apr-18 1:48 AM, Stephen Hemminger wrote:
> This message looks suspicious and seen on healthy testpmd.
>   EAL: WARNING: Master core has no memory on local socket!
> 
> The message is wrong: the master lcore is 0 and its socket is 0
> and there are multiple available memory segments on socket 0.
> 
> At that point in the startup process, the count value is zero,
> meaning they are not used yet so the check_socket gets confused.
> 
> Fixes: 66cc45e293ed ("mem: replace memseg with memseg lists")
> Signed-off-by: Stephen Hemminger <stephen@networkplumber.org>
> ---

Was aware of this and going to fix it myself, but higher priority items 
popped up. Thanks for fixing this!

Acked-by: Anatoly Burakov <anatoly.burakov@intel.com>
Thomas Monjalon April 26, 2018, 3:41 p.m. UTC | #2 
26/04/2018 09:44, Burakov, Anatoly:
> On 26-Apr-18 1:48 AM, Stephen Hemminger wrote:
> > This message looks suspicious and seen on healthy testpmd.
> >   EAL: WARNING: Master core has no memory on local socket!
> > 
> > The message is wrong: the master lcore is 0 and its socket is 0
> > and there are multiple available memory segments on socket 0.
> > 
> > At that point in the startup process, the count value is zero,
> > meaning they are not used yet so the check_socket gets confused.
> > 
> > Fixes: 66cc45e293ed ("mem: replace memseg with memseg lists")
> > Signed-off-by: Stephen Hemminger <stephen@networkplumber.org>
> > ---
> 
> Was aware of this and going to fix it myself, but higher priority items 
> popped up. Thanks for fixing this!
> 
> Acked-by: Anatoly Burakov <anatoly.burakov@intel.com>

Applied, thanks
diff mbox

Patch

diff --git a/lib/librte_eal/linuxapp/eal/eal.c b/lib/librte_eal/linuxapp/eal/eal.c
index 200e879d241a..e2c0bd649429 100644
--- a/lib/librte_eal/linuxapp/eal/eal.c
+++ b/lib/librte_eal/linuxapp/eal/eal.c
@@ -645,10 +645,7 @@  check_socket(const struct rte_memseg_list *msl, void *arg)
 {
 	int *socket_id = arg;
 
-	if (msl->socket_id == *socket_id && msl->memseg_arr.count != 0)
-		return 1;
-
-	return 0;
+	return *socket_id == msl->socket_id;
 }
 
 static void