From patchwork Thu Apr 26 00:48:39 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Stephen Hemminger X-Patchwork-Id: 38977 X-Patchwork-Delegate: thomas@monjalon.net Return-Path: X-Original-To: patchwork@dpdk.org Delivered-To: patchwork@dpdk.org Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 48DAC6CA3; Thu, 26 Apr 2018 02:48:45 +0200 (CEST) Received: from mail-pf0-f195.google.com (mail-pf0-f195.google.com [209.85.192.195]) by dpdk.org (Postfix) with ESMTP id F12436841 for ; Thu, 26 Apr 2018 02:48:43 +0200 (CEST) Received: by mail-pf0-f195.google.com with SMTP id g14so16705949pfh.3 for ; Wed, 25 Apr 2018 17:48:43 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=networkplumber-org.20150623.gappssmtp.com; s=20150623; h=from:to:cc:subject:date:message-id; bh=L0wWLDFY1PUd8TDfutkv3Oad7wJJaKi66OF9wHxLSuo=; b=PM3gExdlC6o4k3pkqr1nBxXk17O+ciLsZIltU//zusLt2BLoZ9kPrmR6aNjjr2Z/XG u8geeavPsvLac48SMmEY0fVbtwyQV2ixdJT2+hVL+PIzB0zrojNfwXP+jhBX/iv9AOYg jcOWdue5Hnb5dTvhiJ1udbEmmUZ3KLYUmTUuzeVMJVWxfYupmRwE1hXGw/0RXY8jYPQu Vcptuv9SxDmGbQYwWKKSaznSVpEP+eOIMcph8KtP0k1CMNk3MieV/gVAivh0pI8Eo3ex I4dTK+tTMHdJQFLlDAjZp3x0xBD8MQawQyBXV+WdypW3Jj9SIGbsVhvqiQzK6PEG0Pcn 2wzA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id; bh=L0wWLDFY1PUd8TDfutkv3Oad7wJJaKi66OF9wHxLSuo=; b=Oc8sdOHb0vwPxSqHVybcRz6G4l3hZpHOCTLZ6VBPXDFUbgMl91N+4sGaU7fzG+L+jI zM9nkYXfztESM46NzlTlYBOgJ1R6mYtTd5g9dpHdHgWw8HDsejstb7YdKT0fEpQCOXiZ 59tHIiAZiFGPdX3sNNVGwJMz0dB4RRT+Ss+5AV0LJMMYvX7y5OHGYgbX9quqByhPmatz o4LkrG3x4vibkIOCZZwTF2Mpsh0NWLr3wmbfK/UF6+OKsCYeGhi11hqNJ4l7iByAu7F1 63k6Fko3BgqMFIPoprznRSKZy5Sa4rNX6+l4qWYciFG7QZjg4DdbGqcHMOKeiDycNfPH rVpA== X-Gm-Message-State: ALQs6tA3YZKTZeIWOHAmu0xXFIOTATf62SGELVoZb72gQcGTUq+kTQ+0 uS8iPHlZDuq3CzNe48HwcnHyqA== X-Google-Smtp-Source: AIpwx49SGX1e/kMq28xiYMetM/6xibbHaxNmARc9dmBBBAjMCvBrKSxB5DNvst+9IZYh1nc3vJcoJA== X-Received: by 2002:a17:902:848e:: with SMTP id c14-v6mr30810542plo.95.1524703722998; Wed, 25 Apr 2018 17:48:42 -0700 (PDT) Received: from xeon-e3.lan (204-195-71-95.wavecable.com. [204.195.71.95]) by smtp.gmail.com with ESMTPSA id p6sm30382161pfn.140.2018.04.25.17.48.41 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Wed, 25 Apr 2018 17:48:42 -0700 (PDT) From: Stephen Hemminger X-Google-Original-From: Stephen Hemminger To: anatoly.burakov@intel.com Cc: dev@dpdk.org, Stephen Hemminger , Stephen Hemminger Date: Wed, 25 Apr 2018 17:48:39 -0700 Message-Id: <20180426004839.4097-1-sthemmin@microsoft.com> X-Mailer: git-send-email 2.17.0 Subject: [dpdk-dev] [PATCH] eal: shut up warning about master lcore X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" This message looks suspicious and seen on healthy testpmd. EAL: WARNING: Master core has no memory on local socket! The message is wrong: the master lcore is 0 and its socket is 0 and there are multiple available memory segments on socket 0. At that point in the startup process, the count value is zero, meaning they are not used yet so the check_socket gets confused. Fixes: 66cc45e293ed ("mem: replace memseg with memseg lists") Signed-off-by: Stephen Hemminger Acked-by: Anatoly Burakov --- lib/librte_eal/linuxapp/eal/eal.c | 5 +---- 1 file changed, 1 insertion(+), 4 deletions(-) diff --git a/lib/librte_eal/linuxapp/eal/eal.c b/lib/librte_eal/linuxapp/eal/eal.c index 200e879d241a..e2c0bd649429 100644 --- a/lib/librte_eal/linuxapp/eal/eal.c +++ b/lib/librte_eal/linuxapp/eal/eal.c @@ -645,10 +645,7 @@ check_socket(const struct rte_memseg_list *msl, void *arg) { int *socket_id = arg; - if (msl->socket_id == *socket_id && msl->memseg_arr.count != 0) - return 1; - - return 0; + return *socket_id == msl->socket_id; } static void