diff mbox

[dpdk-dev] mk: fix default rule of test subdirectory

Message ID 1468318944-19477-1-git-send-email-thomas.monjalon@6wind.com (mailing list archive)
State Accepted, archived
Headers

Commit Message

Thomas Monjalon July 12, 2016, 10:22 a.m. UTC 
  When using "make -C app/test" (with RTE_SDK/RTE_TARGET adjusted)
without specifying the rule (all), the build is not done.
Indeed the default rule is not "all" anymore since there are some
rules added for external resources link.

It is fixed by adding a reference to "all" at the top of the file
which makes it the default rule.

Note that make app/test_sub (without environment variable) is preffered.

Fixes: ab64f5df8004 ("app/test: support resources externally linked")

Reported-by: Reshma Pattan <reshma.pattan@intel.com>
Signed-off-by: Thomas Monjalon <thomas.monjalon@6wind.com>
---
 app/test/Makefile | 3 +++
 1 file changed, 3 insertions(+)

Comments

Pattan, Reshma July 12, 2016, 11:16 a.m. UTC | #1 
Hi,

> -----Original Message-----
> From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Thomas Monjalon
> Sent: Tuesday, July 12, 2016 11:22 AM
> To: dev@dpdk.org
> Subject: [dpdk-dev] [PATCH] mk: fix default rule of test subdirectory
> 
> When using "make -C app/test" (with RTE_SDK/RTE_TARGET adjusted) without
> specifying the rule (all), the build is not done.
> Indeed the default rule is not "all" anymore since there are some rules added for
> external resources link.
> 
> It is fixed by adding a reference to "all" at the top of the file which makes it the
> default rule.
> 
> Note that make app/test_sub (without environment variable) is preffered.
> 

What is test_sub here? I could not execute the command make app/test_sub(without environment variable) . 

Thanks,
Reshma
Thomas Monjalon July 12, 2016, 11:38 a.m. UTC | #2 
2016-07-12 11:16, Pattan, Reshma:
> From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Thomas Monjalon
> > Note that make app/test_sub (without environment variable) is preffered.
> 
> What is test_sub here? I could not execute the command make app/test_sub(without environment variable) . 

It is a rule. You can check it here:
	http://dpdk.org/browse/dpdk/tree/mk/rte.sdkbuild.mk?id=11c5e45#n93
Thomas Monjalon July 12, 2016, 11:40 a.m. UTC | #3 
> 2016-07-12 11:16, Pattan, Reshma:
> > From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Thomas Monjalon
> > > Note that make app/test_sub (without environment variable) is preffered.
> > 
> > What is test_sub here? I could not execute the command make app/test_sub(without environment variable) . 
> 
> It is a rule. You can check it here:
> 	http://dpdk.org/browse/dpdk/tree/mk/rte.sdkbuild.mk?id=11c5e45#n93

The %_sub rule should match anything ending with _sub.
The syntax is "make <dir>_sub".
Pattan, Reshma July 15, 2016, 10:45 a.m. UTC | #4 
> -----Original Message-----
> From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Thomas Monjalon
> Sent: Tuesday, July 12, 2016 11:22 AM
> To: dev@dpdk.org
> Subject: [dpdk-dev] [PATCH] mk: fix default rule of test subdirectory
> 
> When using "make -C app/test" (with RTE_SDK/RTE_TARGET adjusted) without
> specifying the rule (all), the build is not done.
> Indeed the default rule is not "all" anymore since there are some rules added for
> external resources link.
> 
> It is fixed by adding a reference to "all" at the top of the file which makes it the
> default rule.
> 
> Note that make app/test_sub (without environment variable) is preffered.
> 
> Fixes: ab64f5df8004 ("app/test: support resources externally linked")
> 
> Reported-by: Reshma Pattan <reshma.pattan@intel.com>
> Signed-off-by: Thomas Monjalon <thomas.monjalon@6wind.com>

Acked-by: Reshma Pattan <reshma.pattan@intel.com>
Thomas Monjalon July 15, 2016, 3:24 p.m. UTC | #5 
> > When using "make -C app/test" (with RTE_SDK/RTE_TARGET adjusted) without
> > specifying the rule (all), the build is not done.
> > Indeed the default rule is not "all" anymore since there are some rules added for
> > external resources link.
> > 
> > It is fixed by adding a reference to "all" at the top of the file which makes it the
> > default rule.
> > 
> > Note that make app/test_sub (without environment variable) is preffered.
> > 
> > Fixes: ab64f5df8004 ("app/test: support resources externally linked")
> > 
> > Reported-by: Reshma Pattan <reshma.pattan@intel.com>
> > Signed-off-by: Thomas Monjalon <thomas.monjalon@6wind.com>
> 
> Acked-by: Reshma Pattan <reshma.pattan@intel.com>

Applied
diff mbox

Patch

diff --git a/app/test/Makefile b/app/test/Makefile
index 2de8c7a..6015b19 100644
--- a/app/test/Makefile
+++ b/app/test/Makefile
@@ -33,6 +33,9 @@  include $(RTE_SDK)/mk/rte.vars.mk
 
 ifeq ($(CONFIG_RTE_APP_TEST),y)
 
+# default rule
+all:
+
 # Define an externally linked resource. A linked resource is an arbitrary
 # file that is linked into the test binary. The application refers to this
 # resource by name. The linked generates identifiers beg_<name> and end_<name>