Message ID | 1468318944-19477-1-git-send-email-thomas.monjalon@6wind.com (mailing list archive) |
---|---|
State | Accepted, archived |
Headers |
Return-Path: <dev-bounces@dpdk.org> X-Original-To: patchwork@dpdk.org Delivered-To: patchwork@dpdk.org Received: from [92.243.14.124] (localhost [IPv6:::1]) by dpdk.org (Postfix) with ESMTP id 0BE8D2B91; Tue, 12 Jul 2016 12:22:32 +0200 (CEST) Received: from mail-wm0-f50.google.com (mail-wm0-f50.google.com [74.125.82.50]) by dpdk.org (Postfix) with ESMTP id 1CA0CDE3 for <dev@dpdk.org>; Tue, 12 Jul 2016 12:22:30 +0200 (CEST) Received: by mail-wm0-f50.google.com with SMTP id i5so19157847wmg.0 for <dev@dpdk.org>; Tue, 12 Jul 2016 03:22:30 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=6wind-com.20150623.gappssmtp.com; s=20150623; h=from:to:subject:date:message-id; bh=9xn+TsTydUqJpyVSaI3dtoW3lEdMJL5NaEeNkOLxVHA=; b=qt5u4N7ZykiFDBkDfu27Dg1qalZabL10jZT4jDD4tp1nlGLBd+09yxxQ97XesTi58W uLoyGrmEcHbCgaWgmz2Nxns5Qlpj8uhAGD1nd8SrBXSDeHq/akc28uTqveI9D+1M5kvS lx2qggCG6N9rcNJGjkAnoEYmZ/ob9bTw/tqdk81PtV4Z42BzdYl2lChe2ehfpv8KIqWk dF8VZzmgfnPdqSbTxmhxxFBcNYPPiZSWLEo7H90NADj9zMU/COYol+dA7cLWsdlpelK5 nBCm+DfyqrF4gRdJVoPQ1Mw5XiXl3cQokj/29zoTRaY21MQErWaqJH/P7OvyfnmOkjjn UqwQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:to:subject:date:message-id; bh=9xn+TsTydUqJpyVSaI3dtoW3lEdMJL5NaEeNkOLxVHA=; b=EeUAILW5sZ05eP0aYOppWTIRfFjMsRjWnA5ROzDHHoWqnpLBBpFDobL9vJT76Q5Jc+ Qe8YORtrRFkeMkucobw4VX4QdUoOv1hviEu7SLGuEVgd8c5mzlca0+RulR0SflkHhqQf I6gL+2lCCNZMjRJZ8QNEzBStQcCCF7SKY6rrwQ/S5N7lrWha4RK5DimDZcQh7t5JUuug YgMNPlGAP4LsR445wAYVpxR6Kx6B1S5VwMB1jfDPdpcoXLxt/TT854fjDbLO76kswqDT T8bVoYhr8Mu3SaVGyur3gx8IWDtPj24XZNbjDwpjatiboxUblhf1VuqK/LC1AFnNqV+N UgaQ== X-Gm-Message-State: ALyK8tKWeYADre2f0Pm+4PCUWcSP2iR2L8QbfPOgOyrwrVvqnJ+oVlXSAfUFR9TybK+bQri0 X-Received: by 10.28.26.69 with SMTP id a66mr3770128wma.8.1468318949600; Tue, 12 Jul 2016 03:22:29 -0700 (PDT) Received: from XPS13.dev.6wind.com (guy78-3-82-239-227-177.fbx.proxad.net. [82.239.227.177]) by smtp.gmail.com with ESMTPSA id c142sm4562281wme.18.2016.07.12.03.22.28 for <dev@dpdk.org> (version=TLS1_2 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Tue, 12 Jul 2016 03:22:29 -0700 (PDT) From: Thomas Monjalon <thomas.monjalon@6wind.com> To: dev@dpdk.org Date: Tue, 12 Jul 2016 12:22:24 +0200 Message-Id: <1468318944-19477-1-git-send-email-thomas.monjalon@6wind.com> X-Mailer: git-send-email 2.7.0 Subject: [dpdk-dev] [PATCH] mk: fix default rule of test subdirectory X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK <dev.dpdk.org> List-Unsubscribe: <http://dpdk.org/ml/options/dev>, <mailto:dev-request@dpdk.org?subject=unsubscribe> List-Archive: <http://dpdk.org/ml/archives/dev/> List-Post: <mailto:dev@dpdk.org> List-Help: <mailto:dev-request@dpdk.org?subject=help> List-Subscribe: <http://dpdk.org/ml/listinfo/dev>, <mailto:dev-request@dpdk.org?subject=subscribe> Errors-To: dev-bounces@dpdk.org Sender: "dev" <dev-bounces@dpdk.org> |
Commit Message
Thomas Monjalon
July 12, 2016, 10:22 a.m. UTC
When using "make -C app/test" (with RTE_SDK/RTE_TARGET adjusted)
without specifying the rule (all), the build is not done.
Indeed the default rule is not "all" anymore since there are some
rules added for external resources link.
It is fixed by adding a reference to "all" at the top of the file
which makes it the default rule.
Note that make app/test_sub (without environment variable) is preffered.
Fixes: ab64f5df8004 ("app/test: support resources externally linked")
Reported-by: Reshma Pattan <reshma.pattan@intel.com>
Signed-off-by: Thomas Monjalon <thomas.monjalon@6wind.com>
---
app/test/Makefile | 3 +++
1 file changed, 3 insertions(+)
Comments
Hi, > -----Original Message----- > From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Thomas Monjalon > Sent: Tuesday, July 12, 2016 11:22 AM > To: dev@dpdk.org > Subject: [dpdk-dev] [PATCH] mk: fix default rule of test subdirectory > > When using "make -C app/test" (with RTE_SDK/RTE_TARGET adjusted) without > specifying the rule (all), the build is not done. > Indeed the default rule is not "all" anymore since there are some rules added for > external resources link. > > It is fixed by adding a reference to "all" at the top of the file which makes it the > default rule. > > Note that make app/test_sub (without environment variable) is preffered. > What is test_sub here? I could not execute the command make app/test_sub(without environment variable) . Thanks, Reshma
2016-07-12 11:16, Pattan, Reshma: > From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Thomas Monjalon > > Note that make app/test_sub (without environment variable) is preffered. > > What is test_sub here? I could not execute the command make app/test_sub(without environment variable) . It is a rule. You can check it here: http://dpdk.org/browse/dpdk/tree/mk/rte.sdkbuild.mk?id=11c5e45#n93
> 2016-07-12 11:16, Pattan, Reshma: > > From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Thomas Monjalon > > > Note that make app/test_sub (without environment variable) is preffered. > > > > What is test_sub here? I could not execute the command make app/test_sub(without environment variable) . > > It is a rule. You can check it here: > http://dpdk.org/browse/dpdk/tree/mk/rte.sdkbuild.mk?id=11c5e45#n93 The %_sub rule should match anything ending with _sub. The syntax is "make <dir>_sub".
> -----Original Message----- > From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Thomas Monjalon > Sent: Tuesday, July 12, 2016 11:22 AM > To: dev@dpdk.org > Subject: [dpdk-dev] [PATCH] mk: fix default rule of test subdirectory > > When using "make -C app/test" (with RTE_SDK/RTE_TARGET adjusted) without > specifying the rule (all), the build is not done. > Indeed the default rule is not "all" anymore since there are some rules added for > external resources link. > > It is fixed by adding a reference to "all" at the top of the file which makes it the > default rule. > > Note that make app/test_sub (without environment variable) is preffered. > > Fixes: ab64f5df8004 ("app/test: support resources externally linked") > > Reported-by: Reshma Pattan <reshma.pattan@intel.com> > Signed-off-by: Thomas Monjalon <thomas.monjalon@6wind.com> Acked-by: Reshma Pattan <reshma.pattan@intel.com>
> > When using "make -C app/test" (with RTE_SDK/RTE_TARGET adjusted) without > > specifying the rule (all), the build is not done. > > Indeed the default rule is not "all" anymore since there are some rules added for > > external resources link. > > > > It is fixed by adding a reference to "all" at the top of the file which makes it the > > default rule. > > > > Note that make app/test_sub (without environment variable) is preffered. > > > > Fixes: ab64f5df8004 ("app/test: support resources externally linked") > > > > Reported-by: Reshma Pattan <reshma.pattan@intel.com> > > Signed-off-by: Thomas Monjalon <thomas.monjalon@6wind.com> > > Acked-by: Reshma Pattan <reshma.pattan@intel.com> Applied
diff --git a/app/test/Makefile b/app/test/Makefile index 2de8c7a..6015b19 100644 --- a/app/test/Makefile +++ b/app/test/Makefile @@ -33,6 +33,9 @@ include $(RTE_SDK)/mk/rte.vars.mk ifeq ($(CONFIG_RTE_APP_TEST),y) +# default rule +all: + # Define an externally linked resource. A linked resource is an arbitrary # file that is linked into the test binary. The application refers to this # resource by name. The linked generates identifiers beg_<name> and end_<name>