Message ID | 20230321235941.2169068-1-ferruh.yigit@amd.com (mailing list archive) |
---|---|
Headers |
Return-Path: <dev-bounces@dpdk.org> X-Original-To: patchwork@inbox.dpdk.org Delivered-To: patchwork@inbox.dpdk.org Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id F39CD427F9; Wed, 22 Mar 2023 01:00:05 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 1B82A427F2; Wed, 22 Mar 2023 01:00:02 +0100 (CET) Received: from NAM10-DM6-obe.outbound.protection.outlook.com (mail-dm6nam10on2051.outbound.protection.outlook.com [40.107.93.51]) by mails.dpdk.org (Postfix) with ESMTP id 69C6740A84 for <dev@dpdk.org>; Wed, 22 Mar 2023 00:59:58 +0100 (CET) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=cTmaX0BFbyriG1tJ7buCdctq7tZjCYkJpeNPrySSk+O6B/EeYsZh6q9QnEFBJmQ8gn9bCvUCipR4g0/r1HYypVzZYXB5AWt+YVJAeh0yGFnohXD50sT35FzwIhFCkj2hyGgbvF8dLkiRRS44Npf4b13cVOWgT1rCpb38wb2UEcOu7cHVEz9qYiInavUKjVG4FRULpvBx3qG092vkb8bhaPKVvdyaYwmgq7YHqTQY4taSP0f+nNQVuoWu6+954ciAI3hUXGJpLD9wfVeLu9tH3VGQbQYbs8w9eACwh5Xs8M1UQ/Kh3UHKpx+0vSPlMYOZIKjQBkoZ0cqWDUWdf3VyyQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=9MoImANXvBp+xDfOMfoGNr+g9S1Xhuon2upQg9wWbGU=; b=eekjbe+fbpFJ6h/8RUV4BG70h6yM7yUTc3/jbvhTICvr09kGK6ssHBWnXgFjd8cxG1LVApOlkHRmug7xaFQsLZBlP2mMpuqHy1xaPAS4fa4daDngqr3qjETq1rtBGFEsZR5j8LxLOqbX1lrHJT1OuaIlWzfCyyQaeu8r+bpDeFAZjgCA3tz3FdU3Ivym4HXIgPHdKMw1reIzoVDhSHnEhtbXu53NejiKS+LhXitOLF0IwVwTyLG6qzm7Q1C8xZGbpG0k7zqEgLOuEloh7MDIsKiheIpt7FKOyjltK+8OfFXHATtmcF8hhkymrnwV15YjT6B39hm7ErE/A+hJqPw39w== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 165.204.84.17) smtp.rcpttodomain=intel.com smtp.mailfrom=amd.com; dmarc=pass (p=quarantine sp=quarantine pct=100) action=none header.from=amd.com; dkim=none (message not signed); arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=9MoImANXvBp+xDfOMfoGNr+g9S1Xhuon2upQg9wWbGU=; b=bQN7XGl0tx0yVOkN3/hwb2D5ochEZRoX7I4/uoKdVNu7xh6iNkY3+Jja5uMz6QEWqXhI5kEfp+E3k+sOCoVa48WT6XCKwUPtFBvjHCVuOBBmNg1WZpgrvJT/tjfg+ca9bNUHJKQj+x+O8QO8taYqpTxpKx8MFWYbEG8tP+tx92w= Received: from MN2PR14CA0005.namprd14.prod.outlook.com (2603:10b6:208:23e::10) by IA1PR12MB7496.namprd12.prod.outlook.com (2603:10b6:208:418::10) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6178.37; Tue, 21 Mar 2023 23:59:52 +0000 Received: from BL02EPF000100D2.namprd05.prod.outlook.com (2603:10b6:208:23e:cafe::a3) by MN2PR14CA0005.outlook.office365.com (2603:10b6:208:23e::10) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6178.37 via Frontend Transport; Tue, 21 Mar 2023 23:59:52 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 165.204.84.17) smtp.mailfrom=amd.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=amd.com; Received-SPF: Pass (protection.outlook.com: domain of amd.com designates 165.204.84.17 as permitted sender) receiver=protection.outlook.com; client-ip=165.204.84.17; helo=SATLEXMB04.amd.com; pr=C Received: from SATLEXMB04.amd.com (165.204.84.17) by BL02EPF000100D2.mail.protection.outlook.com (10.167.241.206) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.20.6178.30 via Frontend Transport; Tue, 21 Mar 2023 23:59:52 +0000 Received: from telcodpdk.amd.com (10.180.168.240) by SATLEXMB04.amd.com (10.181.40.145) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.34; Tue, 21 Mar 2023 18:59:50 -0500 From: Ferruh Yigit <ferruh.yigit@amd.com> To: John McNamara <john.mcnamara@intel.com> CC: Thomas Monjalon <thomas@monjalon.net>, Andrew Rybchenko <andrew.rybchenko@oktetlabs.ru>, <dev@dpdk.org> Subject: [PATCH 00/33] Update net driver documentation Date: Tue, 21 Mar 2023 23:59:08 +0000 Message-ID: <20230321235941.2169068-1-ferruh.yigit@amd.com> X-Mailer: git-send-email 2.34.1 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Type: text/plain X-Originating-IP: [10.180.168.240] X-ClientProxiedBy: SATLEXMB03.amd.com (10.181.40.144) To SATLEXMB04.amd.com (10.181.40.145) X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: BL02EPF000100D2:EE_|IA1PR12MB7496:EE_ X-MS-Office365-Filtering-Correlation-Id: d0b26ab6-2d5b-460f-52f0-08db2a685cde X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: x2LwOgpRYw3ujFqbUcqrq6vF9obqRjfG9E4x/SL6ZFQyw4/zmWYCCzmIdYSg9eOUGKRX3xW8djuJSDjAyx1O7wL9c+9dCioqUJAADAECO9KQa8bWe9+BqG6T0QzQDn47st0H6+nevoDPZFSqmZQK6d5zHoC9nick2FkuLYHs9FxjaLvxHrZ6uGXXmg8a2HkjxyJw5rLoS7LB4LFv6Cly+UL5TOQg8LBJHD0mYHu94poK/XP9WlmW+Ul0byWY4gQJaaE9QpgmruGJIeG0eBilhNn+8Q294cMlByGxW2i+4K3V/Mxe2ih3kuvQMQ7YnA/NYh3vKloRnlnfCKM8EciQUChski3uBCRRxgTgEQypRq9rPFFFvTaVHHO2OlP+9ZI55/A8H4Y/zrFt/WzuQTVL304fyK3U6NkIa3FgVsIZWiDuYwn3MLe/N1WYPSjTvCs9GyGGYcHjVm1QIEclhmr7yR97oesDVZDd1/5shljN2SA/F6As24ww2+HM3KceMZ6RkFzYr/IIxqQtsDjonunkETxdk5ZkTJ9cSRmvRtGaLRQhoEPvdtSN2u4FcbgfG9RTx0EohwUCElHw84870zHk4ZqDawiHP+8zKT5pG7caJ4dXvq2N156DbEiRy+qQQU3zwkG9OOq+93uHCaPeg8B7bQtW5y34FZO1fQmFvtTbVDYqxV3GsItnSFuZNcmJc1WSM7MTcOKWYxmxDF7sSqj1CDwunjteE3rl/005b8lzpFw= X-Forefront-Antispam-Report: CIP:165.204.84.17; CTRY:US; LANG:en; SCL:1; SRV:; IPV:CAL; SFV:NSPM; H:SATLEXMB04.amd.com; PTR:InfoDomainNonexistent; CAT:NONE; SFS:(13230025)(4636009)(346002)(136003)(396003)(376002)(39860400002)(451199018)(46966006)(40470700004)(36840700001)(7696005)(2616005)(41300700001)(16526019)(186003)(426003)(4326008)(47076005)(83380400001)(6666004)(478600001)(336012)(316002)(8676002)(70206006)(70586007)(6916009)(1076003)(26005)(54906003)(36860700001)(44832011)(8936002)(5660300002)(82740400003)(81166007)(2906002)(36756003)(15650500001)(40460700003)(82310400005)(356005)(86362001)(40480700001)(36900700001); DIR:OUT; SFP:1101; X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 21 Mar 2023 23:59:52.5627 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: d0b26ab6-2d5b-460f-52f0-08db2a685cde X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=3dd8961f-e488-4e60-8e11-a82d994e183d; Ip=[165.204.84.17]; Helo=[SATLEXMB04.amd.com] X-MS-Exchange-CrossTenant-AuthSource: BL02EPF000100D2.namprd05.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: IA1PR12MB7496 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions <dev.dpdk.org> List-Unsubscribe: <https://mails.dpdk.org/options/dev>, <mailto:dev-request@dpdk.org?subject=unsubscribe> List-Archive: <http://mails.dpdk.org/archives/dev/> List-Post: <mailto:dev@dpdk.org> List-Help: <mailto:dev-request@dpdk.org?subject=help> List-Subscribe: <https://mails.dpdk.org/listinfo/dev>, <mailto:dev-request@dpdk.org?subject=subscribe> Errors-To: dev-bounces@dpdk.org |
Series |
Update net driver documentation
|
|
Message
Ferruh Yigit
March 21, 2023, 11:59 p.m. UTC
Some PMDs has "Pre-Installation Configuration" section in their documentation, although section is not clear I assume that is historical from times compile time parameters and 'make' build system used, where common make target was 'install', so section refers to compile time configuration. Right now device arguments ("Runtime configuration") is documented under this section which is confusing, so updating section name from "Pre-Installation Configuration" to "Configuration". While touching documents trying to keep following template in the documents, with section names and order, to have consistent documents without being too strict on applying the template: [Overview] Supported Devices Supported Features Prerequisites Configuration Compilation Options Environment variables Runtime Configuration Debugging Limitations or Known issues Testpmd driver specific commands Note: Patch sent as each driver separately to help review, it can be squashed while merging. Other further improvements not covered here can be visiting "Building DPDK" sections which has redundant and less useful information, and "Usage example" section which has testpmd log, most of the part is same for all drivers. . Ferruh Yigit (33): doc: update atlantic guide doc: update cpfl guide doc: update cxgbe guide doc: update dpaa guide doc: update ena guide doc: update enetc guide doc: update enetfec guide doc: update enic guide doc: update hns3 guide doc: update i40e guide doc: update ice guide doc: update idpf guide doc: update igb guide doc: update igc guide doc: update ipn3ke guide doc: update ixgbe guide doc: update kni guide doc: update mana guide doc: update mlx5 guide doc: update mvneta guide doc: update netvsc guide doc: update ngbe guide doc: update net null guide doc: update octeontx guide doc: update pfe guide doc: update qede guide doc: update sfc guide doc: update softnic guide doc: update thunderx guide doc: update txgbe guide doc: update vdev netvsc guide doc: update vhost guide doc: update virtio guide doc/guides/nics/atlantic.rst | 27 +++----- doc/guides/nics/cpfl.rst | 51 +++++++------- doc/guides/nics/cxgbe.rst | 61 ++++++++--------- doc/guides/nics/dpaa.rst | 5 +- doc/guides/nics/ena.rst | 60 +++++++++-------- doc/guides/nics/enetc.rst | 25 +++---- doc/guides/nics/enetfec.rst | 12 ++-- doc/guides/nics/enic.rst | 79 ++++++++++------------ doc/guides/nics/hns3.rst | 30 ++++----- doc/guides/nics/i40e.rst | 10 +-- doc/guides/nics/ice.rst | 8 +-- doc/guides/nics/idpf.rst | 8 +-- doc/guides/nics/igb.rst | 23 +++---- doc/guides/nics/igc.rst | 16 ++--- doc/guides/nics/ipn3ke.rst | 9 ++- doc/guides/nics/ixgbe.rst | 62 ++++++++--------- doc/guides/nics/kni.rst | 4 +- doc/guides/nics/mana.rst | 4 +- doc/guides/nics/mlx5.rst | 116 ++++++++++++++++---------------- doc/guides/nics/mvneta.rst | 4 +- doc/guides/nics/netvsc.rst | 4 +- doc/guides/nics/ngbe.rst | 4 +- doc/guides/nics/null.rst | 4 +- doc/guides/nics/octeontx.rst | 15 ++--- doc/guides/nics/pfe.rst | 25 +++---- doc/guides/nics/qede.rst | 14 ++-- doc/guides/nics/sfc_efx.rst | 94 +++++++++++++------------- doc/guides/nics/softnic.rst | 4 +- doc/guides/nics/thunderx.rst | 16 ++--- doc/guides/nics/txgbe.rst | 12 ++-- doc/guides/nics/vdev_netvsc.rst | 4 +- doc/guides/nics/vhost.rst | 4 +- doc/guides/nics/virtio.rst | 4 +- 33 files changed, 395 insertions(+), 423 deletions(-)
Comments
On 2023/3/22 7:59, Ferruh Yigit wrote: > Some PMDs has "Pre-Installation Configuration" section in their documentation, > although section is not clear I assume that is historical from times compile > time parameters and 'make' build system used, where common make target was > 'install', so section refers to compile time configuration. > > Right now device arguments ("Runtime configuration") is documented under this > section which is confusing, so updating section name > from "Pre-Installation Configuration" to "Configuration". > > While touching documents trying to keep following template in the documents, > with section names and order, to have consistent documents without being > too strict on applying the template: > > [Overview] > Supported Devices > Supported Features > Prerequisites > Configuration > Compilation Options > Environment variables > Runtime Configuration > Debugging > Limitations or Known issues > Testpmd driver specific commands Suggest document the template, so that new PMD will refer to it. I didn't find a guide about how to add a new PMD, the above templeate is good in it. And the guide could also includes which ops should mandatory implements, which ops is optional implements. > > Note: Patch sent as each driver separately to help review, it can be squashed > while merging. > > Other further improvements not covered here can be visiting > "Building DPDK" sections which has redundant and less useful information, > and "Usage example" section which has testpmd log, most of the part is same for > all drivers. > > . ...
> -----Original Message----- > From: Ferruh Yigit <ferruh.yigit@amd.com> > Sent: Wednesday, March 22, 2023 7:59 AM > To: Mcnamara, John <john.mcnamara@intel.com> > Cc: Thomas Monjalon <thomas@monjalon.net>; Andrew Rybchenko > <andrew.rybchenko@oktetlabs.ru>; dev@dpdk.org > Subject: [PATCH 00/33] Update net driver documentation > > Some PMDs has "Pre-Installation Configuration" section in their > documentation, although section is not clear I assume that is historical from > times compile time parameters and 'make' build system used, where > common make target was 'install', so section refers to compile time > configuration. > > Right now device arguments ("Runtime configuration") is documented under > this section which is confusing, so updating section name from "Pre- > Installation Configuration" to "Configuration". > > While touching documents trying to keep following template in the > documents, with section names and order, to have consistent documents > without being too strict on applying the template: > > [Overview] > Supported Devices > Supported Features > Prerequisites > Configuration > Compilation Options > Environment variables > Runtime Configuration > Debugging > Limitations or Known issues > Testpmd driver specific commands > > Note: Patch sent as each driver separately to help review, it can be squashed > while merging. > > Other further improvements not covered here can be visiting "Building > DPDK" sections which has redundant and less useful information, and > "Usage example" section which has testpmd log, most of the part is same for > all drivers. > > . > > Ferruh Yigit (33): > doc: update atlantic guide > doc: update cpfl guide > doc: update cxgbe guide > doc: update dpaa guide > doc: update ena guide > doc: update enetc guide > doc: update enetfec guide > doc: update enic guide > doc: update hns3 guide > doc: update i40e guide > doc: update ice guide > doc: update idpf guide > doc: update igb guide > doc: update igc guide > doc: update ipn3ke guide > doc: update ixgbe guide > doc: update kni guide > doc: update mana guide > doc: update mlx5 guide > doc: update mvneta guide > doc: update netvsc guide > doc: update ngbe guide > doc: update net null guide > doc: update octeontx guide > doc: update pfe guide > doc: update qede guide > doc: update sfc guide > doc: update softnic guide > doc: update thunderx guide > doc: update txgbe guide > doc: update vdev netvsc guide > doc: update vhost guide > doc: update virtio guide > > doc/guides/nics/atlantic.rst | 27 +++----- > doc/guides/nics/cpfl.rst | 51 +++++++------- > doc/guides/nics/cxgbe.rst | 61 ++++++++--------- > doc/guides/nics/dpaa.rst | 5 +- > doc/guides/nics/ena.rst | 60 +++++++++-------- > doc/guides/nics/enetc.rst | 25 +++---- > doc/guides/nics/enetfec.rst | 12 ++-- > doc/guides/nics/enic.rst | 79 ++++++++++------------ > doc/guides/nics/hns3.rst | 30 ++++----- > doc/guides/nics/i40e.rst | 10 +-- > doc/guides/nics/ice.rst | 8 +-- > doc/guides/nics/idpf.rst | 8 +-- > doc/guides/nics/igb.rst | 23 +++---- > doc/guides/nics/igc.rst | 16 ++--- > doc/guides/nics/ipn3ke.rst | 9 ++- > doc/guides/nics/ixgbe.rst | 62 ++++++++--------- > doc/guides/nics/kni.rst | 4 +- > doc/guides/nics/mana.rst | 4 +- > doc/guides/nics/mlx5.rst | 116 ++++++++++++++++---------------- > doc/guides/nics/mvneta.rst | 4 +- > doc/guides/nics/netvsc.rst | 4 +- > doc/guides/nics/ngbe.rst | 4 +- > doc/guides/nics/null.rst | 4 +- > doc/guides/nics/octeontx.rst | 15 ++--- > doc/guides/nics/pfe.rst | 25 +++---- > doc/guides/nics/qede.rst | 14 ++-- > doc/guides/nics/sfc_efx.rst | 94 +++++++++++++------------- > doc/guides/nics/softnic.rst | 4 +- > doc/guides/nics/thunderx.rst | 16 ++--- > doc/guides/nics/txgbe.rst | 12 ++-- > doc/guides/nics/vdev_netvsc.rst | 4 +- > doc/guides/nics/vhost.rst | 4 +- > doc/guides/nics/virtio.rst | 4 +- > 33 files changed, 395 insertions(+), 423 deletions(-) > > -- > 2.34.1 For Intel nic i40e/ice/ixgbe/idpf/cpfl/igb/igc/ipn3ke Acked-by: Qi Zhang <qi.z.zhang@intel.com> Thanks!
On 3/22/2023 12:48 AM, fengchengwen wrote: > On 2023/3/22 7:59, Ferruh Yigit wrote: >> Some PMDs has "Pre-Installation Configuration" section in their documentation, >> although section is not clear I assume that is historical from times compile >> time parameters and 'make' build system used, where common make target was >> 'install', so section refers to compile time configuration. >> >> Right now device arguments ("Runtime configuration") is documented under this >> section which is confusing, so updating section name >> from "Pre-Installation Configuration" to "Configuration". >> >> While touching documents trying to keep following template in the documents, >> with section names and order, to have consistent documents without being >> too strict on applying the template: >> >> [Overview] >> Supported Devices >> Supported Features >> Prerequisites >> Configuration >> Compilation Options >> Environment variables >> Runtime Configuration >> Debugging >> Limitations or Known issues >> Testpmd driver specific commands > > Suggest document the template, so that new PMD will refer to it. > +1 to document it, but not sure where to put this information. > I didn't find a guide about how to add a new PMD, the above templeate is good in it. > And the guide could also includes which ops should mandatory implements, which ops > is optional implements. > >> >> Note: Patch sent as each driver separately to help review, it can be squashed >> while merging. >> >> Other further improvements not covered here can be visiting >> "Building DPDK" sections which has redundant and less useful information, >> and "Usage example" section which has testpmd log, most of the part is same for >> all drivers. >> >> . > > ...
22/03/2023 00:59, Ferruh Yigit: > Some PMDs has "Pre-Installation Configuration" section in their documentation, > although section is not clear I assume that is historical from times compile > time parameters and 'make' build system used, where common make target was > 'install', so section refers to compile time configuration. > > Right now device arguments ("Runtime configuration") is documented under this > section which is confusing, so updating section name > from "Pre-Installation Configuration" to "Configuration". > > While touching documents trying to keep following template in the documents, > with section names and order, to have consistent documents without being > too strict on applying the template: > > [Overview] > Supported Devices > Supported Features > Prerequisites > Configuration > Compilation Options > Environment variables > Runtime Configuration > Debugging > Limitations or Known issues > Testpmd driver specific commands > > Note: Patch sent as each driver separately to help review, it can be squashed > while merging. Squashed and applied, thanks. > Other further improvements not covered here can be visiting > "Building DPDK" sections which has redundant and less useful information, > and "Usage example" section which has testpmd log, most of the part is same for > all drivers. Yes, good idea to remove redundant information and replace with good links.