| Message ID | 20190718143628.169623-1-ndabilpuram@marvell.com (mailing list archive) |
|---|---|
| Headers |
Return-Path: <dev-bounces@dpdk.org> X-Original-To: patchwork@dpdk.org Delivered-To: patchwork@dpdk.org Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id A8DB31B53; Thu, 18 Jul 2019 16:36:39 +0200 (CEST) Received: from mx0b-0016f401.pphosted.com (mx0a-0016f401.pphosted.com [67.231.148.174]) by dpdk.org (Postfix) with ESMTP id CD9571041 for <dev@dpdk.org>; Thu, 18 Jul 2019 16:36:37 +0200 (CEST) Received: from pps.filterd (m0045849.ppops.net [127.0.0.1]) by mx0a-0016f401.pphosted.com (8.16.0.42/8.16.0.42) with SMTP id x6IEWD0E021688; Thu, 18 Jul 2019 07:36:35 -0700 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=marvell.com; h=from : to : cc : subject : date : message-id : in-reply-to : references : mime-version : content-type; s=pfpt0818; bh=hIKGCLPnNAxkqgUXYGzSDDjQHNZ9GaknHE5BtrW6tGo=; b=cyVCrdxU7OXHlfwZjuuJgE/6PN2ZBK+t2mzO15oBkWMapojcCmT2Jn22tHbbNN5IvZvV ihkVeAoeOYuUn1wcdf7EN6hKaYCn+mlSF42qZF/cEt024c1z4CYdDBgYdmomdQPicT6x Wntb+yHfLtMuhh60fwy3GlaufRKj4A+Mb9cEYvjytIw0qSL/eWxsv3peJbTKHmgERFEG y06afCTHSLbKo2jb8xRJz2tl0bnGBFnIOGVZHmCn2BTIKyw6HATWrlzFY0LC3Yb24dTj Ess6s7ANRQe7Rg1KOn8vlQSoxgsX3pmSn1xQbPUQz3oAXGFp57xf/BT7pFUVgIuUIWtp 7Q== Received: from sc-exch02.marvell.com ([199.233.58.182]) by mx0a-0016f401.pphosted.com with ESMTP id 2ts07vn3qw-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-SHA384 bits=256 verify=NOT); Thu, 18 Jul 2019 07:36:35 -0700 Received: from SC-EXCH01.marvell.com (10.93.176.81) by SC-EXCH02.marvell.com (10.93.176.82) with Microsoft SMTP Server (TLS) id 15.0.1367.3; Thu, 18 Jul 2019 07:36:34 -0700 Received: from maili.marvell.com (10.93.176.43) by SC-EXCH01.marvell.com (10.93.176.81) with Microsoft SMTP Server id 15.0.1367.3 via Frontend Transport; Thu, 18 Jul 2019 07:36:34 -0700 Received: from hyd1588t430.marvell.com (unknown [10.29.52.204]) by maili.marvell.com (Postfix) with ESMTP id 6A31A3F703F; Thu, 18 Jul 2019 07:36:31 -0700 (PDT) From: Nithin Dabilpuram <ndabilpuram@marvell.com> To: Hyong Youb Kim <hyonkim@cisco.com>, David Marchand <david.marchand@redhat.com>, Thomas Monjalon <thomas@monjalon.net>, "Ferruh Yigit" <ferruh.yigit@intel.com> CC: <jerinj@marvell.com>, John Daley <johndale@cisco.com>, Shahed Shaikh <shshaikh@marvell.com>, <dev@dpdk.org>, Nithin Dabilpuram <ndabilpuram@marvell.com> Date: Thu, 18 Jul 2019 20:06:25 +0530 Message-ID: <20190718143628.169623-1-ndabilpuram@marvell.com> X-Mailer: git-send-email 2.8.4 In-Reply-To: <20190717115852.171416-1-ndabilpuram@marvell.com> References: <20190717115852.171416-1-ndabilpuram@marvell.com> MIME-Version: 1.0 Content-Type: text/plain X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10434:5.22.84,1.0.8 definitions=2019-07-18_07:2019-07-18,2019-07-18 signatures=0 Subject: [dpdk-dev] [PATCH v4 0/3] vfio: fix broken msix interrupt initialization X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions <dev.dpdk.org> List-Unsubscribe: <https://mails.dpdk.org/options/dev>, <mailto:dev-request@dpdk.org?subject=unsubscribe> List-Archive: <http://mails.dpdk.org/archives/dev/> List-Post: <mailto:dev@dpdk.org> List-Help: <mailto:dev-request@dpdk.org?subject=help> List-Subscribe: <https://mails.dpdk.org/listinfo/dev>, <mailto:dev-request@dpdk.org?subject=subscribe> Errors-To: dev-bounces@dpdk.org Sender: "dev" <dev-bounces@dpdk.org> |
| Series |
vfio: fix broken msix interrupt initialization
|
|
Message
Nithin Dabilpuram
July 18, 2019, 2:36 p.m. UTC
A final patch for below mentioned RFC patch discussions. [RFC PATCH v3 1/3] vfio: revert change that does intr eventfd setup at probe http://mails.dpdk.org/archives/dev/2019-July/138358.html [RFC PATCH v3 2/3] eal: add mask and unmask interrupt APIs http://mails.dpdk.org/archives/dev/2019-July/138357.html [RFC PATCH v3 3/3] drivers/net: use unmask API in interrupt handlers http://mails.dpdk.org/archives/dev/2019-July/138359.html Please also refer to below discussions http://mails.dpdk.org/archives/dev/2019-July/138184.html http://mails.dpdk.org/archives/dev/2019-July/138113.html This patch set basically reverts vfio patch that moves eventfd setup to probe time (1/3) because msix initialization is broken. It adds new ack interrupt api for purposes of simple and light weight ack method and also to avoid race conditions that was the root cause of this discussion. Nithin Dabilpuram (3): vfio: revert change that does intr eventfd setup at probe eal: add ack interrupt API drivers/net: use ack API in interrupt handlers drivers/bus/pci/linux/pci_vfio.c | 78 ++++--- drivers/net/atlantic/Makefile | 1 + drivers/net/atlantic/atl_ethdev.c | 2 +- drivers/net/atlantic/meson.build | 2 + drivers/net/avp/Makefile | 1 + drivers/net/avp/avp_ethdev.c | 2 +- drivers/net/avp/meson.build | 1 + drivers/net/axgbe/Makefile | 1 + drivers/net/axgbe/axgbe_ethdev.c | 4 +- drivers/net/axgbe/meson.build | 1 + drivers/net/bnx2x/Makefile | 1 + drivers/net/bnx2x/bnx2x_ethdev.c | 2 +- drivers/net/bnx2x/meson.build | 1 + drivers/net/e1000/em_ethdev.c | 4 +- drivers/net/e1000/igb_ethdev.c | 6 +- drivers/net/fm10k/Makefile | 1 + drivers/net/fm10k/fm10k_ethdev.c | 6 +- drivers/net/fm10k/meson.build | 1 + drivers/net/i40e/i40e_ethdev.c | 2 +- drivers/net/iavf/iavf_ethdev.c | 2 +- drivers/net/ice/Makefile | 1 + drivers/net/ice/ice_ethdev.c | 4 +- drivers/net/ice/meson.build | 1 + drivers/net/ixgbe/ixgbe_ethdev.c | 6 +- drivers/net/nfp/nfp_net.c | 2 +- drivers/net/qede/Makefile | 1 + drivers/net/qede/meson.build | 2 + drivers/net/qede/qede_ethdev.c | 8 +- drivers/net/sfc/sfc_intr.c | 4 +- drivers/net/virtio/virtio_ethdev.c | 16 +- drivers/net/vmxnet3/vmxnet3_ethdev.c | 2 +- lib/librte_eal/common/include/rte_interrupts.h | 18 ++ lib/librte_eal/freebsd/eal/eal_interrupts.c | 9 + lib/librte_eal/linux/eal/eal_interrupts.c | 291 +++++++++++++++++++++---- lib/librte_eal/rte_eal_version.map | 1 + 35 files changed, 368 insertions(+), 117 deletions(-)
Comments
On Thu, Jul 18, 2019 at 4:36 PM Nithin Dabilpuram <ndabilpuram@marvell.com> wrote: > > A final patch for below mentioned RFC patch discussions. > > [RFC PATCH v3 1/3] vfio: revert change that does intr eventfd setup at probe > http://mails.dpdk.org/archives/dev/2019-July/138358.html > [RFC PATCH v3 2/3] eal: add mask and unmask interrupt APIs > http://mails.dpdk.org/archives/dev/2019-July/138357.html > [RFC PATCH v3 3/3] drivers/net: use unmask API in interrupt handlers > http://mails.dpdk.org/archives/dev/2019-July/138359.html > > Please also refer to below discussions > http://mails.dpdk.org/archives/dev/2019-July/138184.html > http://mails.dpdk.org/archives/dev/2019-July/138113.html > > This patch set basically reverts vfio patch that moves eventfd setup > to probe time (1/3) because msix initialization is broken. > It adds new ack interrupt api for purposes of simple and light > weight ack method and also to avoid race conditions > that was the root cause of this discussion. Thanks a lot for working on this. I only have small comments (sent in separate mails), you already did all the work. I prepared incremental patches if you agree with those comments: - patch 2 https://github.com/david-marchand/dpdk/commit/374acb3409c206ffcb1bf6b5a7e8bb0bfca4e2b9 - patch 3 https://github.com/david-marchand/dpdk/commit/71102b9301b2a55a057a605f8e48e4a24f9d74a3 And a squashed branch: https://github.com/david-marchand/dpdk/commits/interrupt_fixes
On 7/23/2019 1:08 AM, David Marchand wrote: > External Email > > ---------------------------------------------------------------------- > On Thu, Jul 18, 2019 at 4:36 PM Nithin Dabilpuram > <ndabilpuram@marvell.com> wrote: >> A final patch for below mentioned RFC patch discussions. >> >> [RFC PATCH v3 1/3] vfio: revert change that does intr eventfd setup at probe >> http://mails.dpdk.org/archives/dev/2019-July/138358.html >> [RFC PATCH v3 2/3] eal: add mask and unmask interrupt APIs >> http://mails.dpdk.org/archives/dev/2019-July/138357.html >> [RFC PATCH v3 3/3] drivers/net: use unmask API in interrupt handlers >> http://mails.dpdk.org/archives/dev/2019-July/138359.html >> >> Please also refer to below discussions >> http://mails.dpdk.org/archives/dev/2019-July/138184.html >> http://mails.dpdk.org/archives/dev/2019-July/138113.html >> >> This patch set basically reverts vfio patch that moves eventfd setup >> to probe time (1/3) because msix initialization is broken. >> It adds new ack interrupt api for purposes of simple and light >> weight ack method and also to avoid race conditions >> that was the root cause of this discussion. > Thanks a lot for working on this. > > I only have small comments (sent in separate mails), you already did > all the work. > I prepared incremental patches if you agree with those comments: > - patch 2 https://github.com/david-marchand/dpdk/commit/374acb3409c206ffcb1bf6b5a7e8bb0bfca4e2b9 > - patch 3 https://github.com/david-marchand/dpdk/commit/71102b9301b2a55a057a605f8e48e4a24f9d74a3 > > And a squashed branch: > https://github.com/david-marchand/dpdk/commits/interrupt_fixes Thanks David. I'm fine with the comments and your incremental change. You can send a v3 or Thomas can pick from your repo, anything should be fine. > >