Message ID | 20190624164714.6560-1-stephen@networkplumber.org (mailing list archive) |
---|---|
Headers |
Return-Path: <dev-bounces@dpdk.org> X-Original-To: patchwork@dpdk.org Delivered-To: patchwork@dpdk.org Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 659271BCDA; Mon, 24 Jun 2019 18:47:24 +0200 (CEST) Received: from mail-pf1-f196.google.com (mail-pf1-f196.google.com [209.85.210.196]) by dpdk.org (Postfix) with ESMTP id B05FB1BCCE for <dev@dpdk.org>; Mon, 24 Jun 2019 18:47:22 +0200 (CEST) Received: by mail-pf1-f196.google.com with SMTP id q10so7837038pff.9 for <dev@dpdk.org>; Mon, 24 Jun 2019 09:47:22 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=networkplumber-org.20150623.gappssmtp.com; s=20150623; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=x+qDifaW704tqL25LQDuOLIyoorZ8EJD53enyw/5e+g=; b=aoEEg3k3Os36HQpnA4UJ/i6PZ/oQrqdoLmKGgoUbyOZqrhT6RCPYFWxYcoFCjnil4x volG5LjwF34VTsQbzJM5zi+y7+fK5hlvxPp5sOcXw++RdusYJ3I0RJvRzHNwy5DoUx2F 8h0z3zP4+N/ikvLQ44+V/cA/Er/Jm2Jta3dsFdE3UaBoLQlupASO1Z+zubhjpMJRzq9g fN4O+nyg5+J2dsMOca5hQ8lvVrhDErYzvoS86LMd1w+SZlWwzzDQXVNUC814gYuYU1BG i0UF4RjI+NgWOczU30b8urNJNU0yVOxC0xO9OJ1KcPN0a6BswxrXndbR6WVFLdf1fQjG 79mQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=x+qDifaW704tqL25LQDuOLIyoorZ8EJD53enyw/5e+g=; b=G+Hs3oYIH3W0LywssA9N3oxl8dFNEtjjcNayHvp+40ToclLpPGHbXsFw0z1SZJaAde iffjA8gt4AIC0gUoPrc1AhP/1RPmtrVlqkGkXlpe7hJItRdtB90CM4IuCCv7kISZLTDf x2TYrFzFlACKmOfSmeyH2azb+ZXk0YdZM3OJB7zzh70wGwoO38tY6ZjlfOUSitVKMpFj xaojBhdUkqrrpw213kB9STKZMAMdwXXJOxAU4ZiG4xpMl7NEy5/ViuK06Z6uWIjt5ow5 hLxSRHHnRaGiGwcT1Bqp44YEQbsea9BElSzirqu9e7e2mmaFbexrVt1f9ZhjqmAa6oy0 nd6Q== X-Gm-Message-State: APjAAAW6DF9IrcSCj/01ezgsUafscaW6ZsPBHQki06BzvXaVvamxf67I ndL9otp91D6Q75JsPp/bMM4GFf+TzD8= X-Google-Smtp-Source: APXvYqwLmPIPy/LOxFMbgHEcxC6bMj7h2JpJ5TGvasimR6GndqlB3trqfb206CR+a7W++Q1PABdjqg== X-Received: by 2002:a17:90a:d14a:: with SMTP id t10mr26059453pjw.85.1561394841269; Mon, 24 Jun 2019 09:47:21 -0700 (PDT) Received: from hermes.lan (204-195-22-127.wavecable.com. [204.195.22.127]) by smtp.gmail.com with ESMTPSA id f7sm12814023pfd.43.2019.06.24.09.47.20 (version=TLS1_3 cipher=AEAD-AES256-GCM-SHA384 bits=256/256); Mon, 24 Jun 2019 09:47:20 -0700 (PDT) From: Stephen Hemminger <stephen@networkplumber.org> To: dev@dpdk.org Cc: Stephen Hemminger <stephen@networkplumber.org> Date: Mon, 24 Jun 2019 09:47:05 -0700 Message-Id: <20190624164714.6560-1-stephen@networkplumber.org> X-Mailer: git-send-email 2.20.1 In-Reply-To: <20190610175155.21374-1-stephen@networkplumber.org> References: <20190610175155.21374-1-stephen@networkplumber.org> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Subject: [dpdk-dev] [PATCH v6 0/9] kni: fixes and cleanups X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions <dev.dpdk.org> List-Unsubscribe: <https://mails.dpdk.org/options/dev>, <mailto:dev-request@dpdk.org?subject=unsubscribe> List-Archive: <http://mails.dpdk.org/archives/dev/> List-Post: <mailto:dev@dpdk.org> List-Help: <mailto:dev-request@dpdk.org?subject=help> List-Subscribe: <https://mails.dpdk.org/listinfo/dev>, <mailto:dev-request@dpdk.org?subject=subscribe> Errors-To: dev-bounces@dpdk.org Sender: "dev" <dev-bounces@dpdk.org> |
Series |
kni: fixes and cleanups
|
|
Message
Stephen Hemminger
June 24, 2019, 4:47 p.m. UTC
While testing KNI with netvsc, saw lots of places more code could be safely removed from KNI kernel driver. v6 - more updates to documentation v5 - add minimal ethtool, fix checkpath author complaints v4 - add more style fixes v3 - rebase to current master, add style fix patch v2 - get rid of unnecessary padding, combine the unused field patches Stephen Hemminger (9): kni: don't need stubs for rx_mode or ioctl kni: use netdev_alloc_skb kni: don't keep stats in kni_net kni: drop unused fields kni: use proper type for kni fifo's kni: return -EFAULT if copy_from_user fails kni: fix style issues kni: add minimal ethtool doc: update KNI documentation .../prog_guide/kernel_nic_interface.rst | 9 +- .../sample_app_ug/kernel_nic_interface.rst | 24 +++-- kernel/linux/kni/kni_dev.h | 20 ++-- kernel/linux/kni/kni_misc.c | 18 ++-- kernel/linux/kni/kni_net.c | 100 +++++++----------- lib/librte_kni/rte_kni.c | 38 +++---- 6 files changed, 89 insertions(+), 120 deletions(-)
Comments
On 6/24/2019 5:47 PM, Stephen Hemminger wrote: > While testing KNI with netvsc, saw lots of places more code > could be safely removed from KNI kernel driver. > > v6 - more updates to documentation > v5 - add minimal ethtool, fix checkpath author complaints > v4 - add more style fixes > v3 - rebase to current master, add style fix patch > v2 - get rid of unnecessary padding, combine the unused field patches > > Stephen Hemminger (9): > kni: don't need stubs for rx_mode or ioctl > kni: use netdev_alloc_skb > kni: don't keep stats in kni_net > kni: drop unused fields > kni: use proper type for kni fifo's > kni: return -EFAULT if copy_from_user fails > kni: fix style issues > kni: add minimal ethtool > doc: update KNI documentation For series, Acked-by: Ferruh Yigit <ferruh.yigit@intel.com> Thanks for the cleanup. I am OK to get the set for rc2, but if we will do this please lets merge this early so that we can still have time to test and fix any possible issues before rc2.
12/07/2019 19:03, Ferruh Yigit: > On 6/24/2019 5:47 PM, Stephen Hemminger wrote: > > While testing KNI with netvsc, saw lots of places more code > > could be safely removed from KNI kernel driver. > > > > v6 - more updates to documentation > > v5 - add minimal ethtool, fix checkpath author complaints > > v4 - add more style fixes > > v3 - rebase to current master, add style fix patch > > v2 - get rid of unnecessary padding, combine the unused field patches > > > > Stephen Hemminger (9): > > kni: don't need stubs for rx_mode or ioctl > > kni: use netdev_alloc_skb > > kni: don't keep stats in kni_net > > kni: drop unused fields > > kni: use proper type for kni fifo's > > kni: return -EFAULT if copy_from_user fails > > kni: fix style issues > > kni: add minimal ethtool > > doc: update KNI documentation > > For series, > Acked-by: Ferruh Yigit <ferruh.yigit@intel.com> > > Thanks for the cleanup. > > I am OK to get the set for rc2, but if we will do this please lets merge this > early so that we can still have time to test and fix any possible issues before rc2. Applied, thanks