[V1] tests/cvl_fdir:fix testplan and testcase not synchronization issue

Message ID 20211009144205.25338-1-zhiminx.huang@intel.com (mailing list archive)
State Accepted
Headers
Series [V1] tests/cvl_fdir:fix testplan and testcase not synchronization issue |

Checks

Context Check Description
ci/Intel-doc-dts-test success Testing OK
ci/Intel-suite-dts-test fail Testing issues

Commit Message

Huang, ZhiminX Oct. 9, 2021, 2:42 p.m. UTC
  fixed testplan confusing description and sync testcase code with plan.
the last pkt need received by port 1 and not affect by rule in port 0.

Signed-off-by: Zhimin Huang <zhiminx.huang@intel.com>
---
 test_plans/cvl_fdir_test_plan.rst | 4 ++--
 tests/TestSuite_cvl_fdir.py       | 2 +-
 2 files changed, 3 insertions(+), 3 deletions(-)
  

Comments

Huang, ZhiminX Oct. 9, 2021, 6:21 a.m. UTC | #1
> -----Original Message-----
> From: Huang, ZhiminX <zhiminx.huang@intel.com>
> Sent: Saturday, October 9, 2021 10:42 PM
> To: dts@dpdk.org
> Cc: Huang, ZhiminX <zhiminx.huang@intel.com>
> Subject: [dts] [PATCH V1] tests/cvl_fdir:fix testplan and testcase not
> synchronization issue
> 
> fixed testplan confusing description and sync testcase code with plan.
> the last pkt need received by port 1 and not affect by rule in port 0.
> 
> Signed-off-by: Zhimin Huang <zhiminx.huang@intel.com>

Tested-by: Zhimin Huang <zhiminx.huang@intel.com >
  
Tu, Lijuan Oct. 25, 2021, 9:12 a.m. UTC | #2
> -----Original Message-----
> From: dts <dts-bounces@dpdk.org> On Behalf Of Huang, ZhiminX
> Sent: 2021年10月9日 14:21
> To: dts@dpdk.org
> Subject: Re: [dts] [PATCH V1] tests/cvl_fdir:fix testplan and testcase not
> synchronization issue
> 
> > -----Original Message-----
> > From: Huang, ZhiminX <zhiminx.huang@intel.com>
> > Sent: Saturday, October 9, 2021 10:42 PM
> > To: dts@dpdk.org
> > Cc: Huang, ZhiminX <zhiminx.huang@intel.com>
> > Subject: [dts] [PATCH V1] tests/cvl_fdir:fix testplan and testcase not
> > synchronization issue
> >
> > fixed testplan confusing description and sync testcase code with plan.
> > the last pkt need received by port 1 and not affect by rule in port 0.
> >
> > Signed-off-by: Zhimin Huang <zhiminx.huang@intel.com>
> 
> Tested-by: Zhimin Huang <zhiminx.huang@intel.com >

Applied
>
  

Patch

diff --git a/test_plans/cvl_fdir_test_plan.rst b/test_plans/cvl_fdir_test_plan.rst
index 24586016..1d8421e1 100644
--- a/test_plans/cvl_fdir_test_plan.rst
+++ b/test_plans/cvl_fdir_test_plan.rst
@@ -4011,8 +4011,8 @@  Subcase 3: two ports multi patterns count query
    packet 1 to queue 1 of port 1, packet 2 to queue 6-7 of port 1, packet 3 to queue 6-7 of port 1,
    packet 4 to queue 2 of port 1, packet 5 dropped of port 1,
    packet 6 to dropped of port 0, packet 7 to queue 1 of port 0.
-   packet 8 received by port 1.
-   all the received packets have specified FDIR matched ID.
+   the received packets have specified FDIR matched ID.
+   packet 8 received by port 1 and not have matched ID.
 
 3. query count::
 
diff --git a/tests/TestSuite_cvl_fdir.py b/tests/TestSuite_cvl_fdir.py
index 18836756..90acafd7 100644
--- a/tests/TestSuite_cvl_fdir.py
+++ b/tests/TestSuite_cvl_fdir.py
@@ -3273,7 +3273,7 @@  class TestCVLFdir(TestCase):
         out7 = self.send_pkts_getouput(pkts[6], port_id=0, count=10)
         rfc.check_mark(out7, pkt_num=10, check_param={"port_id": 0, "queue": 1, "mark_id": 1})
         out8 = self.send_pkts_getouput(pkts[7], port_id=1, count=10)
-        rfc.check_mark(out8, pkt_num=10, check_param={"port_id": 1, "mark_id": 0})
+        rfc.check_mark(out8, pkt_num=10, check_param={"port_id": 1})
         self.query_count(1, 20, 1, 0)
         self.query_count(1, 20, 1, 1)
         self.query_count(1, 10, 1, 2)