diff mbox series

[v1] windows/netuio: fix pci resouce translation

Message ID 20211008002243.88955-1-u9012063@gmail.com (mailing list archive)
State Rejected, archived
Delegated to: Thomas Monjalon
Headers
Series [v1] windows/netuio: fix pci resouce translation |

Checks

Context Check Description
ci/checkpatch warning coding style issues
ci/Intel-compilation warning apply issues
ci/iol-testing warning apply patch failure

Commit Message

William Tu Oct. 8, 2021, 12:22 a.m. UTC 
  When BAR array is filled like this
    * Bar[4] = c844000c <if this one is not the CM_RESOURCE_MEMORY_BAR>
    * Bar[5] = null
ex:
while ((descriptor->Type != CmResourceTypeMemory) ||
                 !(descriptor->Flags & CM_RESOURCE_MEMORY_BAR));
returns true, the loop continue and the decriptor will be NULL,
but it's not an error. So I fix it by setting the status to STATUS_SUCCESS.

Signed-off-by: William Tu <u9012063@gmail.com>
---
Found the issue when adding the e1000 PMD support.
http://inbox.dpdk.org/dev/20211007202451.90271-1-u9012063@gmail.com/T/#u
---
 windows/netuio/netuio_dev.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

William Tu Oct. 8, 2021, 12:39 p.m. UTC | #1 
On Thu, Oct 7, 2021 at 5:23 PM William Tu <u9012063@gmail.com> wrote:
>
> When BAR array is filled like this
>     * Bar[4] = c844000c <if this one is not the CM_RESOURCE_MEMORY_BAR>
>     * Bar[5] = null
> ex:
> while ((descriptor->Type != CmResourceTypeMemory) ||
>                  !(descriptor->Flags & CM_RESOURCE_MEMORY_BAR));
> returns true, the loop continue and the decriptor will be NULL,
> but it's not an error. So I fix it by setting the status to STATUS_SUCCESS.
>
> Signed-off-by: William Tu <u9012063@gmail.com>
> ---
> Found the issue when adding the e1000 PMD support.
> http://inbox.dpdk.org/dev/20211007202451.90271-1-u9012063@gmail.com/T/#u
> ---
Sorry, there are some format/spelling errors in this patch.
I will fix and resend v2.
William
diff mbox series

Patch

diff --git a/windows/netuio/netuio_dev.c b/windows/netuio/netuio_dev.c
index b2deb10..0dd0055 100644
--- a/windows/netuio/netuio_dev.c
+++ b/windows/netuio/netuio_dev.c
@@ -207,7 +207,7 @@  netuio_map_hw_resources(WDFDEVICE Device, WDFCMRESLIST Resources, WDFCMRESLIST R
             next_descriptor++;
 
             if (descriptor == NULL) {
-                status = STATUS_DEVICE_CONFIGURATION_ERROR;
+                status = STATUS_SUCCESS;
                 goto end;
             }
         } while ((descriptor->Type != CmResourceTypeMemory) ||