[v5,3/3] mempool: mempool build on Windows
Checks
Commit Message
Some eal functions are used by mempool lib but not exported on Windows.
The functions were exported.
Added mempool to supported libraries for Windows compilation.
Signed-off-by: Fady Bader <fady@mellanox.com>
---
lib/librte_eal/rte_eal_exports.def | 6 ++++++
lib/librte_eal/rte_eal_version.map | 1 +
lib/meson.build | 2 +-
3 files changed, 8 insertions(+), 1 deletion(-)
Comments
On Sun, Jul 5, 2020 at 1:47 PM Fady Bader <fady@mellanox.com> wrote:
> diff --git a/lib/librte_eal/rte_eal_version.map b/lib/librte_eal/rte_eal_version.map
> index 196eef5afa..9ad843c754 100644
> --- a/lib/librte_eal/rte_eal_version.map
> +++ b/lib/librte_eal/rte_eal_version.map
> @@ -395,4 +395,5 @@ INTERNAL {
> rte_mem_map;
> rte_mem_page_size;
> rte_mem_unmap;
> + __rte_trace_mem_per_thread_alloc;
The CI result is not there yet, but I expect issues.
This symbol is marked as experimental, not internal.
+ it is exported already in the experimental section of the EAL map.
Why did you need this line?
> -----Original Message-----
> From: David Marchand <david.marchand@redhat.com>
> Sent: Sunday, July 5, 2020 3:01 PM
> To: Fady Bader <fady@mellanox.com>
> Cc: dev <dev@dpdk.org>; Thomas Monjalon <thomas@monjalon.net>; Tasnim
> Bashar <tbashar@mellanox.com>; Tal Shnaiderman <talshn@mellanox.com>;
> Yohad Tor <yohadt@mellanox.com>; Dmitry Kozlyuk
> <dmitry.kozliuk@gmail.com>; Harini Ramakrishnan
> <harini.ramakrishnan@microsoft.com>; Omar Cardona
> <ocardona@microsoft.com>; Pallavi Kadam <pallavi.kadam@intel.com>; Ranjit
> Menon <ranjit.menon@intel.com>; Olivier Matz <olivier.matz@6wind.com>;
> Andrew Rybchenko <arybchenko@solarflare.com>; Ray Kinsella
> <mdr@ashroe.eu>; Neil Horman <nhorman@tuxdriver.com>
> Subject: Re: [dpdk-dev] [PATCH v5 3/3] mempool: mempool build on Windows
>
> On Sun, Jul 5, 2020 at 1:47 PM Fady Bader <fady@mellanox.com> wrote:
> > diff --git a/lib/librte_eal/rte_eal_version.map
> b/lib/librte_eal/rte_eal_version.map
> > index 196eef5afa..9ad843c754 100644
> > --- a/lib/librte_eal/rte_eal_version.map
> > +++ b/lib/librte_eal/rte_eal_version.map
> > @@ -395,4 +395,5 @@ INTERNAL {
> > rte_mem_map;
> > rte_mem_page_size;
> > rte_mem_unmap;
> > + __rte_trace_mem_per_thread_alloc;
>
> The CI result is not there yet, but I expect issues.
> This symbol is marked as experimental, not internal.
> + it is exported already in the experimental section of the EAL map.
You are right, I'll remove it in the next version of the patch.
>
> Why did you need this line?
>
>
> --
> David Marchand
@@ -1,6 +1,11 @@
EXPORTS
__rte_panic
+ __rte_trace_mem_per_thread_alloc
+ __rte_trace_point_emit_field
+ __rte_trace_point_register
per_lcore__rte_errno
+ per_lcore_trace_mem
+ per_lcore_trace_point_sz
rte_calloc
rte_calloc_socket
rte_bus_register
@@ -58,6 +63,7 @@ EXPORTS
rte_vfio_container_dma_unmap
rte_vlog
rte_realloc
+ rte_strscpy
rte_zmalloc
rte_zmalloc_socket
@@ -395,4 +395,5 @@ INTERNAL {
rte_mem_map;
rte_mem_page_size;
rte_mem_unmap;
+ __rte_trace_mem_per_thread_alloc;
};
@@ -40,7 +40,7 @@ if is_windows
'kvargs',
'eal',
'ring',
- 'pci',
+ 'mempool', 'pci',
] # only supported libraries for windows
endif