Message ID | 1566214919-32250-1-git-send-email-david.marchand@redhat.com (mailing list archive) |
---|---|
Headers |
Return-Path: <dev-bounces@dpdk.org> X-Original-To: patchwork@dpdk.org Delivered-To: patchwork@dpdk.org Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 568B21BEA2; Mon, 19 Aug 2019 13:42:13 +0200 (CEST) Received: from mx1.redhat.com (mx1.redhat.com [209.132.183.28]) by dpdk.org (Postfix) with ESMTP id 7BFF91BE9C for <dev@dpdk.org>; Mon, 19 Aug 2019 13:42:12 +0200 (CEST) Received: from smtp.corp.redhat.com (int-mx07.intmail.prod.int.phx2.redhat.com [10.5.11.22]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id ED9E58003E7 for <dev@dpdk.org>; Mon, 19 Aug 2019 11:42:11 +0000 (UTC) Received: from dmarchan.remote.csb (ovpn-204-32.brq.redhat.com [10.40.204.32]) by smtp.corp.redhat.com (Postfix) with ESMTP id 368531001947 for <dev@dpdk.org>; Mon, 19 Aug 2019 11:42:10 +0000 (UTC) From: David Marchand <david.marchand@redhat.com> To: dev@dpdk.org Date: Mon, 19 Aug 2019 13:41:48 +0200 Message-Id: <1566214919-32250-1-git-send-email-david.marchand@redhat.com> X-Scanned-By: MIMEDefang 2.84 on 10.5.11.22 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.6.2 (mx1.redhat.com [10.5.110.67]); Mon, 19 Aug 2019 11:42:11 +0000 (UTC) Subject: [dpdk-dev] [PATCH 00/11] Fixing log levels for dynamically loaded drivers X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions <dev.dpdk.org> List-Unsubscribe: <https://mails.dpdk.org/options/dev>, <mailto:dev-request@dpdk.org?subject=unsubscribe> List-Archive: <http://mails.dpdk.org/archives/dev/> List-Post: <mailto:dev@dpdk.org> List-Help: <mailto:dev-request@dpdk.org?subject=help> List-Subscribe: <https://mails.dpdk.org/listinfo/dev>, <mailto:dev-request@dpdk.org?subject=subscribe> Errors-To: dev-bounces@dpdk.org Sender: "dev" <dev-bounces@dpdk.org> |
Series |
Fixing log levels for dynamically loaded drivers
|
|
Message
David Marchand
Aug. 19, 2019, 11:41 a.m. UTC
All (but the Solarflare net driver) drivers currently do not care about the log level the user might have passed at init time. Convert existing drivers from rte_log_register to a new wrapper RTE_LOG_REGISTER that relies on rte_log_register_type_and_pick_level that handles this issue.
Comments
On 8/19/2019 12:41 PM, David Marchand wrote: > All (but the Solarflare net driver) drivers currently do not care about > the log level the user might have passed at init time. Is this comment for the shared libraries? Because otherwise drivers set loglevel during initialization and init time setting should be reflected to the logtypes before devices probed. > > Convert existing drivers from rte_log_register to a new wrapper > RTE_LOG_REGISTER that relies on rte_log_register_type_and_pick_level > that handles this issue. > >
On Mon, Sep 2, 2019 at 4:17 PM Ferruh Yigit <ferruh.yigit@intel.com> wrote: > > On 8/19/2019 12:41 PM, David Marchand wrote: > > All (but the Solarflare net driver) drivers currently do not care about > > the log level the user might have passed at init time. > > Is this comment for the shared libraries? > Because otherwise drivers set loglevel during initialization and init time > setting should be reflected to the logtypes before devices probed. Indeed, the issue is seen when building drivers as shared libraries. -- David Marchand