Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/99432/?format=api
{ "id": 99432, "url": "https://patches.dpdk.org/api/patches/99432/?format=api", "web_url": "https://patches.dpdk.org/project/dpdk/patch/20210922140953.19388-4-konstantin.ananyev@intel.com/", "project": { "id": 1, "url": "https://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20210922140953.19388-4-konstantin.ananyev@intel.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20210922140953.19388-4-konstantin.ananyev@intel.com", "date": "2021-09-22T14:09:51", "name": "[RFC,v2,3/5] ethdev: copy ethdev 'burst' API into separate structure", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": true, "hash": "11468ca1504307850ecbfbc258eb5edd27bfeb73", "submitter": { "id": 33, "url": "https://patches.dpdk.org/api/people/33/?format=api", "name": "Ananyev, Konstantin", "email": "konstantin.ananyev@intel.com" }, "delegate": { "id": 319, "url": "https://patches.dpdk.org/api/users/319/?format=api", "username": "fyigit", "first_name": "Ferruh", "last_name": "Yigit", "email": "ferruh.yigit@amd.com" }, "mbox": "https://patches.dpdk.org/project/dpdk/patch/20210922140953.19388-4-konstantin.ananyev@intel.com/mbox/", "series": [ { "id": 19084, "url": "https://patches.dpdk.org/api/series/19084/?format=api", "web_url": "https://patches.dpdk.org/project/dpdk/list/?series=19084", "date": "2021-09-22T14:09:48", "name": "hide eth dev related structures", "version": 2, "mbox": "https://patches.dpdk.org/series/19084/mbox/" } ], "comments": "https://patches.dpdk.org/api/patches/99432/comments/", "check": "warning", "checks": "https://patches.dpdk.org/api/patches/99432/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from mails.dpdk.org (mails.dpdk.org [217.70.189.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id 2740DA0C45;\n\tWed, 22 Sep 2021 16:12:23 +0200 (CEST)", "from [217.70.189.124] (localhost [127.0.0.1])\n\tby mails.dpdk.org (Postfix) with ESMTP id 090A7411A8;\n\tWed, 22 Sep 2021 16:12:23 +0200 (CEST)", "from mga18.intel.com (mga18.intel.com [134.134.136.126])\n by mails.dpdk.org (Postfix) with ESMTP id 672FA41198\n for <dev@dpdk.org>; Wed, 22 Sep 2021 16:12:21 +0200 (CEST)", "from fmsmga008.fm.intel.com ([10.253.24.58])\n by orsmga106.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384;\n 22 Sep 2021 07:11:38 -0700", "from sivswdev08.ir.intel.com ([10.237.217.47])\n by fmsmga008.fm.intel.com with ESMTP; 22 Sep 2021 07:11:25 -0700" ], "X-IronPort-AV": [ "E=McAfee;i=\"6200,9189,10114\"; a=\"210679651\"", "E=Sophos;i=\"5.85,314,1624345200\"; d=\"scan'208\";a=\"210679651\"", "E=Sophos;i=\"5.85,314,1624345200\"; d=\"scan'208\";a=\"512990508\"" ], "X-ExtLoop1": "1", "From": "Konstantin Ananyev <konstantin.ananyev@intel.com>", "To": "dev@dpdk.org", "Cc": "xiaoyun.li@intel.com, anoobj@marvell.com, jerinj@marvell.com,\n ndabilpuram@marvell.com, adwivedi@marvell.com,\n shepard.siegel@atomicrules.com, ed.czeck@atomicrules.com,\n john.miller@atomicrules.com, irusskikh@marvell.com,\n ajit.khaparde@broadcom.com, somnath.kotur@broadcom.com,\n rahul.lakkireddy@chelsio.com, hemant.agrawal@nxp.com,\n sachin.saxena@oss.nxp.com, haiyue.wang@intel.com, johndale@cisco.com,\n hyonkim@cisco.com, qi.z.zhang@intel.com, xiao.w.wang@intel.com,\n humin29@huawei.com, yisen.zhuang@huawei.com, oulijun@huawei.com,\n beilei.xing@intel.com, jingjing.wu@intel.com, qiming.yang@intel.com,\n matan@nvidia.com, viacheslavo@nvidia.com, sthemmin@microsoft.com,\n longli@microsoft.com, heinrich.kuhn@corigine.com, kirankumark@marvell.com,\n andrew.rybchenko@oktetlabs.ru, mczekaj@marvell.com,\n jiawenwu@trustnetic.com, jianwang@trustnetic.com,\n maxime.coquelin@redhat.com, chenbo.xia@intel.com, thomas@monjalon.net,\n ferruh.yigit@intel.com, mdr@ashroe.eu, jay.jayatheerthan@intel.com,\n Konstantin Ananyev <konstantin.ananyev@intel.com>", "Date": "Wed, 22 Sep 2021 15:09:51 +0100", "Message-Id": "<20210922140953.19388-4-konstantin.ananyev@intel.com>", "X-Mailer": "git-send-email 2.18.0", "In-Reply-To": "<20210922140953.19388-1-konstantin.ananyev@intel.com>", "References": "<20210820162834.12544-1-konstantin.ananyev@intel.com>\n <20210922140953.19388-1-konstantin.ananyev@intel.com>", "Subject": "[dpdk-dev] [RFC v2 3/5] ethdev: copy ethdev 'burst' API into\n separate structure", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "Copy public function pointers (rx_pkt_burst(), etc.) and related\npointers to internal data from rte_eth_dev structure into a separate flat\narray. We can keep it public to still use inline functions for 'fast' calls\n(like rte_eth_rx_burst(), etc.) to avoid/minimize slowdown.\nThe intention is to make rte_eth_dev and related structures internal.\nThat should allow future possible changes to core eth_dev strcutures\nto be transaprent to the user and help to avoid ABI/API breakages.\n\nSigned-off-by: Konstantin Ananyev <konstantin.ananyev@intel.com>\n---\n lib/ethdev/ethdev_private.c | 53 ++++++++++++++++++++++++++++++++++++\n lib/ethdev/ethdev_private.h | 7 +++++\n lib/ethdev/rte_ethdev.c | 17 ++++++++++++\n lib/ethdev/rte_ethdev_core.h | 45 ++++++++++++++++++++++++++++++\n 4 files changed, 122 insertions(+)", "diff": "diff --git a/lib/ethdev/ethdev_private.c b/lib/ethdev/ethdev_private.c\nindex 012cf73ca2..a1683da77b 100644\n--- a/lib/ethdev/ethdev_private.c\n+++ b/lib/ethdev/ethdev_private.c\n@@ -174,3 +174,56 @@ rte_eth_devargs_parse_representor_ports(char *str, void *data)\n \t\tRTE_LOG(ERR, EAL, \"wrong representor format: %s\\n\", str);\n \treturn str == NULL ? -1 : 0;\n }\n+\n+static uint16_t\n+dummy_eth_rx_burst(__rte_unused void *rxq,\n+\t\t__rte_unused struct rte_mbuf **rx_pkts,\n+\t\t__rte_unused uint16_t nb_pkts)\n+{\n+\tRTE_ETHDEV_LOG(ERR, \"rx_pkt_burst for unconfigured port\\n\");\n+\trte_errno = ENOTSUP;\n+\treturn 0;\n+}\n+\n+static uint16_t\n+dummy_eth_tx_burst(__rte_unused void *txq,\n+\t\t__rte_unused struct rte_mbuf **tx_pkts,\n+\t\t__rte_unused uint16_t nb_pkts)\n+{\n+\tRTE_ETHDEV_LOG(ERR, \"tx_pkt_burst for unconfigured port\\n\");\n+\trte_errno = ENOTSUP;\n+\treturn 0;\n+}\n+\n+void\n+eth_dev_burst_api_reset(struct rte_eth_burst_api *rba)\n+{\n+\tstatic void *dummy_data[RTE_MAX_QUEUES_PER_PORT];\n+\tstatic const struct rte_eth_burst_api dummy_api = {\n+\t\t.rx_pkt_burst = dummy_eth_rx_burst,\n+\t\t.tx_pkt_burst = dummy_eth_tx_burst,\n+\t\t.rxq = {.data = dummy_data, .clbk = dummy_data,},\n+\t\t.txq = {.data = dummy_data, .clbk = dummy_data,},\n+\t};\n+\n+\t*rba = dummy_api;\n+}\n+\n+void\n+eth_dev_burst_api_setup(struct rte_eth_burst_api *rba,\n+\t\tconst struct rte_eth_dev *dev)\n+{\n+\trba->rx_pkt_burst = dev->rx_pkt_burst;\n+\trba->tx_pkt_burst = dev->tx_pkt_burst;\n+\trba->tx_pkt_prepare = dev->tx_pkt_prepare;\n+\trba->rx_queue_count = dev->rx_queue_count;\n+\trba->rx_descriptor_status = dev->rx_descriptor_status;\n+\trba->tx_descriptor_status = dev->tx_descriptor_status;\n+\n+\trba->rxq.data = dev->data->rx_queues;\n+\trba->rxq.clbk = (void **)(uintptr_t)dev->post_rx_burst_cbs;\n+\n+\trba->txq.data = dev->data->tx_queues;\n+\trba->txq.clbk = (void **)(uintptr_t)dev->pre_tx_burst_cbs;\n+}\n+\ndiff --git a/lib/ethdev/ethdev_private.h b/lib/ethdev/ethdev_private.h\nindex 9bb0879538..54921f4860 100644\n--- a/lib/ethdev/ethdev_private.h\n+++ b/lib/ethdev/ethdev_private.h\n@@ -30,6 +30,13 @@ eth_find_device(const struct rte_eth_dev *_start, rte_eth_cmp_t cmp,\n /* Parse devargs value for representor parameter. */\n int rte_eth_devargs_parse_representor_ports(char *str, void *data);\n \n+/* reset eth 'burst' API to dummy values */\n+void eth_dev_burst_api_reset(struct rte_eth_burst_api *rba);\n+\n+/* setup eth 'burst' API to ethdev values */\n+void eth_dev_burst_api_setup(struct rte_eth_burst_api *rba,\n+\t\tconst struct rte_eth_dev *dev);\n+\n #ifdef __cplusplus\n }\n #endif\ndiff --git a/lib/ethdev/rte_ethdev.c b/lib/ethdev/rte_ethdev.c\nindex 424bc260fa..5904bb7bae 100644\n--- a/lib/ethdev/rte_ethdev.c\n+++ b/lib/ethdev/rte_ethdev.c\n@@ -44,6 +44,9 @@\n static const char *MZ_RTE_ETH_DEV_DATA = \"rte_eth_dev_data\";\n struct rte_eth_dev rte_eth_devices[RTE_MAX_ETHPORTS];\n \n+/* public 'fast/burst' API */\n+struct rte_eth_burst_api rte_eth_burst_api[RTE_MAX_ETHPORTS];\n+\n /* spinlock for eth device callbacks */\n static rte_spinlock_t eth_dev_cb_lock = RTE_SPINLOCK_INITIALIZER;\n \n@@ -1788,6 +1791,9 @@ rte_eth_dev_start(uint16_t port_id)\n \t\t(*dev->dev_ops->link_update)(dev, 0);\n \t}\n \n+\t/* expose selection of PMD rx/tx function */\n+\teth_dev_burst_api_setup(rte_eth_burst_api + port_id, dev);\n+\n \trte_ethdev_trace_start(port_id);\n \treturn 0;\n }\n@@ -1810,6 +1816,9 @@ rte_eth_dev_stop(uint16_t port_id)\n \t\treturn 0;\n \t}\n \n+\t/* point rx/tx functions to dummy ones */\n+\teth_dev_burst_api_reset(rte_eth_burst_api + port_id);\n+\n \tdev->data->dev_started = 0;\n \tret = (*dev->dev_ops->dev_stop)(dev);\n \trte_ethdev_trace_stop(port_id, ret);\n@@ -4568,6 +4577,14 @@ rte_eth_mirror_rule_reset(uint16_t port_id, uint8_t rule_id)\n \treturn eth_err(port_id, (*dev->dev_ops->mirror_rule_reset)(dev, rule_id));\n }\n \n+RTE_INIT(eth_dev_init_burst_api)\n+{\n+\tuint32_t i;\n+\n+\tfor (i = 0; i != RTE_DIM(rte_eth_burst_api); i++)\n+\t\teth_dev_burst_api_reset(rte_eth_burst_api + i);\n+}\n+\n RTE_INIT(eth_dev_init_cb_lists)\n {\n \tuint16_t i;\ndiff --git a/lib/ethdev/rte_ethdev_core.h b/lib/ethdev/rte_ethdev_core.h\nindex 00f27c643a..da6de5de43 100644\n--- a/lib/ethdev/rte_ethdev_core.h\n+++ b/lib/ethdev/rte_ethdev_core.h\n@@ -53,6 +53,51 @@ typedef int (*eth_rx_descriptor_status_t)(void *rxq, uint16_t offset);\n typedef int (*eth_tx_descriptor_status_t)(void *txq, uint16_t offset);\n /**< @internal Check the status of a Tx descriptor */\n \n+/**\n+ * @internal\n+ * Structure used to hold opaque pointernals to internal ethdev RX/TXi\n+ * queues data.\n+ * The main purpose to expose these pointers at all - allow compiler\n+ * to fetch this data for 'fast' ethdev inline functions in advance.\n+ */\n+struct rte_ethdev_qdata {\n+\tvoid **data;\n+\t/**< points to array of internal queue data pointers */\n+\tvoid **clbk;\n+\t/**< points to array of queue callback data pointers */\n+};\n+\n+/**\n+ * @internal\n+ * 'fast' ethdev funcions and related data are hold in a flat array.\n+ * one entry per ethdev.\n+ */\n+struct rte_eth_burst_api {\n+\n+\t/** first 64B line */\n+\teth_rx_burst_t rx_pkt_burst;\n+\t/**< PMD receive function. */\n+\teth_tx_burst_t tx_pkt_burst;\n+\t/**< PMD transmit function. */\n+\teth_tx_prep_t tx_pkt_prepare;\n+\t/**< PMD transmit prepare function. */\n+\teth_rx_queue_count_t rx_queue_count;\n+\t/**< Get the number of used RX descriptors. */\n+\teth_rx_descriptor_status_t rx_descriptor_status;\n+\t/**< Check the status of a Rx descriptor. */\n+\teth_tx_descriptor_status_t tx_descriptor_status;\n+\t/**< Check the status of a Tx descriptor. */\n+\tuintptr_t reserved[2];\n+\n+\t/** second 64B line */\n+\tstruct rte_ethdev_qdata rxq;\n+\tstruct rte_ethdev_qdata txq;\n+\tuintptr_t reserved2[4];\n+\n+} __rte_cache_aligned;\n+\n+extern struct rte_eth_burst_api rte_eth_burst_api[RTE_MAX_ETHPORTS];\n+\n \n /**\n * @internal\n", "prefixes": [ "RFC", "v2", "3/5" ] }