Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/98978/?format=api
{ "id": 98978, "url": "https://patches.dpdk.org/api/patches/98978/?format=api", "web_url": "https://patches.dpdk.org/project/dpdk/patch/20210916025636.48024-1-humin29@huawei.com/", "project": { "id": 1, "url": "https://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20210916025636.48024-1-humin29@huawei.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20210916025636.48024-1-humin29@huawei.com", "date": "2021-09-16T02:56:36", "name": "[RFC] ethdev: improve link speed to string", "commit_ref": null, "pull_url": null, "state": "rejected", "archived": true, "hash": "857fbfa6aa53918e351a16dd7bae5f68937a6ef1", "submitter": { "id": 1944, "url": "https://patches.dpdk.org/api/people/1944/?format=api", "name": "humin (Q)", "email": "humin29@huawei.com" }, "delegate": { "id": 319, "url": "https://patches.dpdk.org/api/users/319/?format=api", "username": "fyigit", "first_name": "Ferruh", "last_name": "Yigit", "email": "ferruh.yigit@amd.com" }, "mbox": "https://patches.dpdk.org/project/dpdk/patch/20210916025636.48024-1-humin29@huawei.com/mbox/", "series": [ { "id": 18957, "url": "https://patches.dpdk.org/api/series/18957/?format=api", "web_url": "https://patches.dpdk.org/project/dpdk/list/?series=18957", "date": "2021-09-16T02:56:36", "name": "[RFC] ethdev: improve link speed to string", "version": 1, "mbox": "https://patches.dpdk.org/series/18957/mbox/" } ], "comments": "https://patches.dpdk.org/api/patches/98978/comments/", "check": "fail", "checks": "https://patches.dpdk.org/api/patches/98978/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from mails.dpdk.org (mails.dpdk.org [217.70.189.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id 41504A0C41;\n\tThu, 16 Sep 2021 04:58:10 +0200 (CEST)", "from [217.70.189.124] (localhost [127.0.0.1])\n\tby mails.dpdk.org (Postfix) with ESMTP id CA5204003F;\n\tThu, 16 Sep 2021 04:58:09 +0200 (CEST)", "from szxga02-in.huawei.com (szxga02-in.huawei.com [45.249.212.188])\n by mails.dpdk.org (Postfix) with ESMTP id 972464003C\n for <dev@dpdk.org>; Thu, 16 Sep 2021 04:58:08 +0200 (CEST)", "from dggeme756-chm.china.huawei.com (unknown [172.30.72.57])\n by szxga02-in.huawei.com (SkyGuard) with ESMTP id 4H91ql2mDWz8yTZ;\n Thu, 16 Sep 2021 10:53:39 +0800 (CST)", "from localhost.localdomain (10.69.192.56) by\n dggeme756-chm.china.huawei.com (10.3.19.102) with Microsoft SMTP Server\n (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id\n 15.1.2308.8; Thu, 16 Sep 2021 10:58:06 +0800" ], "From": "\"Min Hu (Connor)\" <humin29@huawei.com>", "To": "<dev@dpdk.org>", "CC": "<ferruh.yigit@intel.com>, <thomas@monjalon.net>", "Date": "Thu, 16 Sep 2021 10:56:36 +0800", "Message-ID": "<20210916025636.48024-1-humin29@huawei.com>", "X-Mailer": "git-send-email 2.33.0", "In-Reply-To": "<29b75903-d212-c6e6-eedf-e3bc92ab816a@huawei.com>", "References": "<29b75903-d212-c6e6-eedf-e3bc92ab816a@huawei.com>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "Content-Type": "text/plain", "X-Originating-IP": "[10.69.192.56]", "X-ClientProxiedBy": "dggems703-chm.china.huawei.com (10.3.19.180) To\n dggeme756-chm.china.huawei.com (10.3.19.102)", "X-CFilter-Loop": "Reflected", "Subject": "[dpdk-dev] [RFC] ethdev: improve link speed to string", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "Currently, link speed to string only supports specific speeds, like 10M,\n100M, 1G etc.\n\nThis patch expands support for any link speed which is over 1M and one\ndecimal place will kept for display at most.\n\nSigned-off-by: Min Hu (Connor) <humin29@huawei.com>\n---\n lib/ethdev/rte_ethdev.c | 34 +++++++++++++++++-----------------\n 1 file changed, 17 insertions(+), 17 deletions(-)", "diff": "diff --git a/lib/ethdev/rte_ethdev.c b/lib/ethdev/rte_ethdev.c\nindex daf5ca9242..1d3b960305 100644\n--- a/lib/ethdev/rte_ethdev.c\n+++ b/lib/ethdev/rte_ethdev.c\n@@ -2750,24 +2750,24 @@ rte_eth_link_get_nowait(uint16_t port_id, struct rte_eth_link *eth_link)\n const char *\n rte_eth_link_speed_to_str(uint32_t link_speed)\n {\n-\tswitch (link_speed) {\n-\tcase ETH_SPEED_NUM_NONE: return \"None\";\n-\tcase ETH_SPEED_NUM_10M: return \"10 Mbps\";\n-\tcase ETH_SPEED_NUM_100M: return \"100 Mbps\";\n-\tcase ETH_SPEED_NUM_1G: return \"1 Gbps\";\n-\tcase ETH_SPEED_NUM_2_5G: return \"2.5 Gbps\";\n-\tcase ETH_SPEED_NUM_5G: return \"5 Gbps\";\n-\tcase ETH_SPEED_NUM_10G: return \"10 Gbps\";\n-\tcase ETH_SPEED_NUM_20G: return \"20 Gbps\";\n-\tcase ETH_SPEED_NUM_25G: return \"25 Gbps\";\n-\tcase ETH_SPEED_NUM_40G: return \"40 Gbps\";\n-\tcase ETH_SPEED_NUM_50G: return \"50 Gbps\";\n-\tcase ETH_SPEED_NUM_56G: return \"56 Gbps\";\n-\tcase ETH_SPEED_NUM_100G: return \"100 Gbps\";\n-\tcase ETH_SPEED_NUM_200G: return \"200 Gbps\";\n-\tcase ETH_SPEED_NUM_UNKNOWN: return \"Unknown\";\n-\tdefault: return \"Invalid\";\n+#define SPEED_STRING_LEN 16\n+\tstatic char name[SPEED_STRING_LEN];\n+\n+\tif (link_speed == ETH_SPEED_NUM_NONE)\n+\t\treturn \"None\";\n+\tif (link_speed == ETH_SPEED_NUM_UNKNOWN)\n+\t\treturn \"Unknown\";\n+\tif (link_speed < ETH_SPEED_NUM_1G) {\n+\t\tsnprintf(name, sizeof(name), \"%u Mbps\", link_speed);\n+\t} else if (link_speed % ETH_SPEED_NUM_1G != 0) {\n+\t\tsnprintf(name, sizeof(name), \"%.1f Gbps\",\n+\t\t(double)link_speed / ETH_SPEED_NUM_1G);\n+\t} else {\n+\t\tsnprintf(name, sizeof(name), \"%u Gbps\",\n+\t\tlink_speed / ETH_SPEED_NUM_1G);\n \t}\n+\n+\treturn (const char *)name;\n }\n \n int\n", "prefixes": [ "RFC" ] }