Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/98327/?format=api
{ "id": 98327, "url": "https://patches.dpdk.org/api/patches/98327/?format=api", "web_url": "https://patches.dpdk.org/project/dpdk/patch/20210908103016.1661914-13-kevin.laatz@intel.com/", "project": { "id": 1, "url": "https://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20210908103016.1661914-13-kevin.laatz@intel.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20210908103016.1661914-13-kevin.laatz@intel.com", "date": "2021-09-08T10:30:11", "name": "[v3,12/17] dma/idxd: add operation statistic tracking", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": true, "hash": "8065ee3c7e31de2e35ddcc9bbb82382ea32b12e3", "submitter": { "id": 921, "url": "https://patches.dpdk.org/api/people/921/?format=api", "name": "Kevin Laatz", "email": "kevin.laatz@intel.com" }, "delegate": { "id": 1, "url": "https://patches.dpdk.org/api/users/1/?format=api", "username": "tmonjalo", "first_name": "Thomas", "last_name": "Monjalon", "email": "thomas@monjalon.net" }, "mbox": "https://patches.dpdk.org/project/dpdk/patch/20210908103016.1661914-13-kevin.laatz@intel.com/mbox/", "series": [ { "id": 18762, "url": "https://patches.dpdk.org/api/series/18762/?format=api", "web_url": "https://patches.dpdk.org/project/dpdk/list/?series=18762", "date": "2021-09-08T10:29:59", "name": "add dmadev driver for idxd devices", "version": 3, "mbox": "https://patches.dpdk.org/series/18762/mbox/" } ], "comments": "https://patches.dpdk.org/api/patches/98327/comments/", "check": "success", "checks": "https://patches.dpdk.org/api/patches/98327/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from mails.dpdk.org (mails.dpdk.org [217.70.189.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id BE305A0C56;\n\tWed, 8 Sep 2021 12:31:34 +0200 (CEST)", "from [217.70.189.124] (localhost [127.0.0.1])\n\tby mails.dpdk.org (Postfix) with ESMTP id 34DE9411DC;\n\tWed, 8 Sep 2021 12:30:47 +0200 (CEST)", "from mga06.intel.com (mga06.intel.com [134.134.136.31])\n by mails.dpdk.org (Postfix) with ESMTP id E0E0F40041\n for <dev@dpdk.org>; Wed, 8 Sep 2021 12:30:43 +0200 (CEST)", "from orsmga001.jf.intel.com ([10.7.209.18])\n by orsmga104.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384;\n 08 Sep 2021 03:30:43 -0700", "from silpixa00401122.ir.intel.com ([10.55.128.10])\n by orsmga001.jf.intel.com with ESMTP; 08 Sep 2021 03:30:41 -0700" ], "X-IronPort-AV": [ "E=McAfee;i=\"6200,9189,10100\"; a=\"281461972\"", "E=Sophos;i=\"5.85,277,1624345200\"; d=\"scan'208\";a=\"281461972\"", "E=Sophos;i=\"5.85,277,1624345200\"; d=\"scan'208\";a=\"513213913\"" ], "X-ExtLoop1": "1", "From": "Kevin Laatz <kevin.laatz@intel.com>", "To": "dev@dpdk.org", "Cc": "bruce.richardson@intel.com, fengchengwen@huawei.com, jerinj@marvell.com,\n conor.walsh@intel.com, Kevin Laatz <kevin.laatz@intel.com>", "Date": "Wed, 8 Sep 2021 10:30:11 +0000", "Message-Id": "<20210908103016.1661914-13-kevin.laatz@intel.com>", "X-Mailer": "git-send-email 2.30.2", "In-Reply-To": "<20210908103016.1661914-1-kevin.laatz@intel.com>", "References": "<20210903105001.1179328-1-kevin.laatz@intel.com>\n <20210908103016.1661914-1-kevin.laatz@intel.com>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "Subject": "[dpdk-dev] [PATCH v3 12/17] dma/idxd: add operation statistic\n tracking", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "Add statistic tracking for DSA devices.\n\nSigned-off-by: Bruce Richardson <bruce.richardson@intel.com>\nSigned-off-by: Kevin Laatz <kevin.laatz@intel.com>\n---\n doc/guides/dmadevs/idxd.rst | 11 +++++++++++\n drivers/dma/idxd/idxd_bus.c | 2 ++\n drivers/dma/idxd/idxd_common.c | 27 +++++++++++++++++++++++++++\n drivers/dma/idxd/idxd_internal.h | 3 +++\n drivers/dma/idxd/idxd_pci.c | 2 ++\n 5 files changed, 45 insertions(+)", "diff": "diff --git a/doc/guides/dmadevs/idxd.rst b/doc/guides/dmadevs/idxd.rst\nindex b0b5632b48..634ef58985 100644\n--- a/doc/guides/dmadevs/idxd.rst\n+++ b/doc/guides/dmadevs/idxd.rst\n@@ -242,3 +242,14 @@ of memory is overwritten, or filled, with a short pattern of data.\n Fill operations can be performed in much the same was as copy operations\n described above, just using the ``rte_dmadev_fill()`` function rather than the\n ``rte_dmadev_copy()`` function.\n+\n+Querying Device Statistics\n+~~~~~~~~~~~~~~~~~~~~~~~~~~~\n+\n+The statistics from the IDXD dmadev device can be got via the stats functions in\n+the ``rte_dmadev`` library, i.e. ``rte_dmadev_stats_get()``. The statistics\n+returned for each device instance are:\n+\n+* ``submitted``\n+* ``completed``\n+* ``errors``\ndiff --git a/drivers/dma/idxd/idxd_bus.c b/drivers/dma/idxd/idxd_bus.c\nindex 7a6afabd27..8781195d59 100644\n--- a/drivers/dma/idxd/idxd_bus.c\n+++ b/drivers/dma/idxd/idxd_bus.c\n@@ -99,6 +99,8 @@ static const struct rte_dmadev_ops idxd_vdev_ops = {\n \t\t.dev_configure = idxd_configure,\n \t\t.vchan_setup = idxd_vchan_setup,\n \t\t.dev_info_get = idxd_info_get,\n+\t\t.stats_get = idxd_stats_get,\n+\t\t.stats_reset = idxd_stats_reset,\n };\n \n static void *\ndiff --git a/drivers/dma/idxd/idxd_common.c b/drivers/dma/idxd/idxd_common.c\nindex 8eb73fdcc6..66d1b3432e 100644\n--- a/drivers/dma/idxd/idxd_common.c\n+++ b/drivers/dma/idxd/idxd_common.c\n@@ -65,6 +65,8 @@ __submit(struct idxd_dmadev *idxd)\n \tif (++idxd->batch_idx_write > idxd->max_batches)\n \t\tidxd->batch_idx_write = 0;\n \n+\tidxd->stats.submitted += idxd->batch_size;\n+\n \tidxd->batch_start += idxd->batch_size;\n \tidxd->batch_size = 0;\n \tidxd->batch_idx_ring[idxd->batch_idx_write] = idxd->batch_start;\n@@ -278,6 +280,8 @@ batch_completed_status(struct idxd_dmadev *idxd, uint16_t max_ops, enum rte_dma_\n \tconst uint16_t b_len = b_end - b_start;\n \tif (b_len == 1) {/* not a batch */\n \t\t*status = get_comp_status(&idxd->batch_comp_ring[idxd->batch_idx_read]);\n+\t\tif (status != RTE_DMA_STATUS_SUCCESSFUL)\n+\t\t\tidxd->stats.errors++;\n \t\tidxd->ids_avail++;\n \t\tidxd->ids_returned++;\n \t\tidxd->batch_idx_read = next_batch;\n@@ -299,6 +303,8 @@ batch_completed_status(struct idxd_dmadev *idxd, uint16_t max_ops, enum rte_dma_\n \t\tstruct idxd_completion *c = (void *)\n \t\t\t\t&idxd->desc_ring[(b_start + ret) & idxd->desc_ring_mask];\n \t\tstatus[ret] = (ret < bcount) ? get_comp_status(c) : RTE_DMA_STATUS_NOT_ATTEMPTED;\n+\t\tif (status[ret] != RTE_DMA_STATUS_SUCCESSFUL)\n+\t\t\tidxd->stats.errors++;\n \t}\n \tidxd->ids_avail = idxd->ids_returned += ret;\n \n@@ -357,6 +363,7 @@ idxd_completed(struct rte_dmadev *dev, uint16_t qid __rte_unused, uint16_t max_o\n \t\tret += batch;\n \t} while (batch > 0 && *has_error == false);\n \n+\tidxd->stats.completed += ret;\n \t*last_idx = idxd->ids_returned - 1;\n \treturn ret;\n }\n@@ -374,6 +381,7 @@ idxd_completed_status(struct rte_dmadev *dev, uint16_t qid __rte_unused, uint16_\n \t\tret += batch;\n \t} while (batch > 0);\n \n+\tidxd->stats.completed += ret;\n \t*last_idx = idxd->ids_returned - 1;\n \treturn ret;\n }\n@@ -407,6 +415,25 @@ idxd_dump(const struct rte_dmadev *dev, FILE *f)\n \treturn 0;\n }\n \n+int\n+idxd_stats_get(const struct rte_dmadev *dev, uint16_t vchan __rte_unused,\n+\t\tstruct rte_dmadev_stats *stats, uint32_t stats_sz)\n+{\n+\tstruct idxd_dmadev *idxd = dev->dev_private;\n+\tif (stats_sz < sizeof(*stats))\n+\t\treturn -EINVAL;\n+\t*stats = idxd->stats;\n+\treturn 0;\n+}\n+\n+int\n+idxd_stats_reset(struct rte_dmadev *dev, uint16_t vchan __rte_unused)\n+{\n+\tstruct idxd_dmadev *idxd = dev->dev_private;\n+\tidxd->stats = (struct rte_dmadev_stats){0};\n+\treturn 0;\n+}\n+\n int\n idxd_info_get(const struct rte_dmadev *dev, struct rte_dmadev_info *info, uint32_t size)\n {\ndiff --git a/drivers/dma/idxd/idxd_internal.h b/drivers/dma/idxd/idxd_internal.h\nindex 84d45a09d6..c04ee002d8 100644\n--- a/drivers/dma/idxd/idxd_internal.h\n+++ b/drivers/dma/idxd/idxd_internal.h\n@@ -98,5 +98,8 @@ uint16_t idxd_completed(struct rte_dmadev *dev, uint16_t qid, uint16_t max_ops,\n uint16_t idxd_completed_status(struct rte_dmadev *dev, uint16_t qid __rte_unused,\n \t\tuint16_t max_ops, uint16_t *last_idx,\n \t\tenum rte_dma_status_code *status);\n+int idxd_stats_get(const struct rte_dmadev *dev, uint16_t vchan,\n+\t\tstruct rte_dmadev_stats *stats, uint32_t stats_sz);\n+int idxd_stats_reset(struct rte_dmadev *dev, uint16_t vchan);\n \n #endif /* _IDXD_INTERNAL_H_ */\ndiff --git a/drivers/dma/idxd/idxd_pci.c b/drivers/dma/idxd/idxd_pci.c\nindex 3c0e3086f7..a84232b6e9 100644\n--- a/drivers/dma/idxd/idxd_pci.c\n+++ b/drivers/dma/idxd/idxd_pci.c\n@@ -114,6 +114,8 @@ static const struct rte_dmadev_ops idxd_pci_ops = {\n \t.dev_configure = idxd_configure,\n \t.vchan_setup = idxd_vchan_setup,\n \t.dev_info_get = idxd_info_get,\n+\t.stats_get = idxd_stats_get,\n+\t.stats_reset = idxd_stats_reset,\n \t.dev_start = idxd_pci_dev_start,\n \t.dev_stop = idxd_pci_dev_stop,\n };\n", "prefixes": [ "v3", "12/17" ] }