Patch Detail

HTTP 200 OK
Allow: GET, PUT, PATCH, HEAD, OPTIONS
Content-Type: application/json
Vary: Accept

{
    "id": 97446,
    "url": "https://patches.dpdk.org/api/patches/97446/?format=api",
    "web_url": "https://patches.dpdk.org/project/dpdk/patch/20210827065717.1838258-26-andrew.rybchenko@oktetlabs.ru/",
    "project": {
        "id": 1,
        "url": "https://patches.dpdk.org/api/projects/1/?format=api",
        "name": "DPDK",
        "link_name": "dpdk",
        "list_id": "dev.dpdk.org",
        "list_email": "dev@dpdk.org",
        "web_url": "http://core.dpdk.org",
        "scm_url": "git://dpdk.org/dpdk",
        "webscm_url": "http://git.dpdk.org/dpdk",
        "list_archive_url": "https://inbox.dpdk.org/dev",
        "list_archive_url_format": "https://inbox.dpdk.org/dev/{}",
        "commit_url_format": ""
    },
    "msgid": "<20210827065717.1838258-26-andrew.rybchenko@oktetlabs.ru>",
    "list_archive_url": "https://inbox.dpdk.org/dev/20210827065717.1838258-26-andrew.rybchenko@oktetlabs.ru",
    "date": "2021-08-27T06:57:04",
    "name": "[25/38] net/sfc: implement representor Rx routine",
    "commit_ref": null,
    "pull_url": null,
    "state": "superseded",
    "archived": true,
    "hash": "6327f6a6ea603f673c85e6dedbf8d7bc88087e0e",
    "submitter": {
        "id": 2013,
        "url": "https://patches.dpdk.org/api/people/2013/?format=api",
        "name": "Andrew Rybchenko",
        "email": "Andrew.Rybchenko@oktetlabs.ru"
    },
    "delegate": {
        "id": 319,
        "url": "https://patches.dpdk.org/api/users/319/?format=api",
        "username": "fyigit",
        "first_name": "Ferruh",
        "last_name": "Yigit",
        "email": "ferruh.yigit@amd.com"
    },
    "mbox": "https://patches.dpdk.org/project/dpdk/patch/20210827065717.1838258-26-andrew.rybchenko@oktetlabs.ru/mbox/",
    "series": [
        {
            "id": 18492,
            "url": "https://patches.dpdk.org/api/series/18492/?format=api",
            "web_url": "https://patches.dpdk.org/project/dpdk/list/?series=18492",
            "date": "2021-08-27T06:56:39",
            "name": "net/sfc: support port representors",
            "version": 1,
            "mbox": "https://patches.dpdk.org/series/18492/mbox/"
        }
    ],
    "comments": "https://patches.dpdk.org/api/patches/97446/comments/",
    "check": "warning",
    "checks": "https://patches.dpdk.org/api/patches/97446/checks/",
    "tags": {},
    "related": [],
    "headers": {
        "Return-Path": "<dev-bounces@dpdk.org>",
        "X-Original-To": "patchwork@inbox.dpdk.org",
        "Delivered-To": "patchwork@inbox.dpdk.org",
        "Received": [
            "from mails.dpdk.org (mails.dpdk.org [217.70.189.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id 25B62A0C54;\n\tFri, 27 Aug 2021 09:00:47 +0200 (CEST)",
            "from [217.70.189.124] (localhost [127.0.0.1])\n\tby mails.dpdk.org (Postfix) with ESMTP id EE095412DA;\n\tFri, 27 Aug 2021 08:58:58 +0200 (CEST)",
            "from shelob.oktetlabs.ru (shelob.oktetlabs.ru [91.220.146.113])\n by mails.dpdk.org (Postfix) with ESMTP id 6AF72410E9\n for <dev@dpdk.org>; Fri, 27 Aug 2021 08:58:54 +0200 (CEST)",
            "by shelob.oktetlabs.ru (Postfix, from userid 122)\n id 40E477F6E3; Fri, 27 Aug 2021 09:58:54 +0300 (MSK)",
            "from aros.oktetlabs.ru (aros.oktetlabs.ru [192.168.38.17])\n by shelob.oktetlabs.ru (Postfix) with ESMTP id 8BC097F6EC;\n Fri, 27 Aug 2021 09:57:35 +0300 (MSK)"
        ],
        "X-Spam-Checker-Version": "SpamAssassin 3.4.2 (2018-09-13) on shelob.oktetlabs.ru",
        "X-Spam-Level": "",
        "X-Spam-Status": "No, score=0.8 required=5.0 tests=ALL_TRUSTED,\n DKIM_ADSP_DISCARD,\n URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.2",
        "DKIM-Filter": "OpenDKIM Filter v2.11.0 shelob.oktetlabs.ru 8BC097F6EC",
        "Authentication-Results": "shelob.oktetlabs.ru/8BC097F6EC; dkim=none;\n dkim-atps=neutral",
        "From": "Andrew Rybchenko <andrew.rybchenko@oktetlabs.ru>",
        "To": "dev@dpdk.org",
        "Cc": "Igor Romanov <igor.romanov@oktetlabs.ru>,\n Andy Moreton <amoreton@xilinx.com>, Ivan Malov <ivan.malov@oktetlabs.ru>",
        "Date": "Fri, 27 Aug 2021 09:57:04 +0300",
        "Message-Id": "<20210827065717.1838258-26-andrew.rybchenko@oktetlabs.ru>",
        "X-Mailer": "git-send-email 2.30.2",
        "In-Reply-To": "<20210827065717.1838258-1-andrew.rybchenko@oktetlabs.ru>",
        "References": "<20210827065717.1838258-1-andrew.rybchenko@oktetlabs.ru>",
        "MIME-Version": "1.0",
        "Content-Transfer-Encoding": "8bit",
        "Subject": "[dpdk-dev] [PATCH 25/38] net/sfc: implement representor Rx routine",
        "X-BeenThere": "dev@dpdk.org",
        "X-Mailman-Version": "2.1.29",
        "Precedence": "list",
        "List-Id": "DPDK patches and discussions <dev.dpdk.org>",
        "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>",
        "List-Archive": "<http://mails.dpdk.org/archives/dev/>",
        "List-Post": "<mailto:dev@dpdk.org>",
        "List-Help": "<mailto:dev-request@dpdk.org?subject=help>",
        "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>",
        "Errors-To": "dev-bounces@dpdk.org",
        "Sender": "\"dev\" <dev-bounces@dpdk.org>"
    },
    "content": "From: Igor Romanov <igor.romanov@oktetlabs.ru>\n\nImplement traffic forwarding for representor and representor proxy\nfrom virtual functions to representor Rx queues.\n\nSigned-off-by: Igor Romanov <igor.romanov@oktetlabs.ru>\nSigned-off-by: Andrew Rybchenko <andrew.rybchenko@oktetlabs.ru>\nReviewed-by: Andy Moreton <amoreton@xilinx.com>\nReviewed-by: Ivan Malov <ivan.malov@oktetlabs.ru>\n---\n drivers/net/sfc/sfc_repr.c       |  12 +++\n drivers/net/sfc/sfc_repr_proxy.c | 134 +++++++++++++++++++++++++++++++\n drivers/net/sfc/sfc_repr_proxy.h |  11 +++\n 3 files changed, 157 insertions(+)",
    "diff": "diff --git a/drivers/net/sfc/sfc_repr.c b/drivers/net/sfc/sfc_repr.c\nindex e7386fb480..a436b7e5e1 100644\n--- a/drivers/net/sfc/sfc_repr.c\n+++ b/drivers/net/sfc/sfc_repr.c\n@@ -168,6 +168,16 @@ sfc_repr_tx_queue_stop(void *queue)\n \trte_ring_reset(txq->ring);\n }\n \n+static uint16_t\n+sfc_repr_rx_burst(void *rx_queue, struct rte_mbuf **rx_pkts, uint16_t nb_pkts)\n+{\n+\tstruct sfc_repr_rxq *rxq = rx_queue;\n+\tvoid **objs = (void *)&rx_pkts[0];\n+\n+\t/* mbufs port is already filled correctly by representors proxy */\n+\treturn rte_ring_sc_dequeue_burst(rxq->ring, objs, nb_pkts, NULL);\n+}\n+\n static uint16_t\n sfc_repr_tx_burst(void *tx_queue, struct rte_mbuf **tx_pkts, uint16_t nb_pkts)\n {\n@@ -825,6 +835,7 @@ sfc_repr_dev_close(struct rte_eth_dev *dev)\n \n \t(void)sfc_repr_proxy_del_port(srs->pf_port_id, srs->repr_id);\n \n+\tdev->rx_pkt_burst = NULL;\n \tdev->tx_pkt_burst = NULL;\n \tdev->dev_ops = NULL;\n \n@@ -946,6 +957,7 @@ sfc_repr_eth_dev_init(struct rte_eth_dev *dev, void *init_params)\n \t\tgoto fail_mac_addrs;\n \t}\n \n+\tdev->rx_pkt_burst = sfc_repr_rx_burst;\n \tdev->tx_pkt_burst = sfc_repr_tx_burst;\n \tdev->dev_ops = &sfc_repr_dev_ops;\n \ndiff --git a/drivers/net/sfc/sfc_repr_proxy.c b/drivers/net/sfc/sfc_repr_proxy.c\nindex d8934bab65..535b07ea52 100644\n--- a/drivers/net/sfc/sfc_repr_proxy.c\n+++ b/drivers/net/sfc/sfc_repr_proxy.c\n@@ -18,6 +18,7 @@\n #include \"sfc_ev.h\"\n #include \"sfc_rx.h\"\n #include \"sfc_tx.h\"\n+#include \"sfc_dp_rx.h\"\n \n /**\n  * Amount of time to wait for the representor proxy routine (which is\n@@ -31,6 +32,8 @@\n  */\n #define SFC_REPR_PROXY_ROUTINE_TERMINATE_TIMEOUT_MS\t10000\n \n+#define SFC_REPR_INVALID_ROUTE_PORT_ID  (UINT16_MAX)\n+\n static struct sfc_repr_proxy *\n sfc_repr_proxy_by_adapter(struct sfc_adapter *sa)\n {\n@@ -187,6 +190,113 @@ sfc_repr_proxy_handle_tx(struct sfc_repr_proxy_dp_txq *rp_txq,\n \t}\n }\n \n+static struct sfc_repr_proxy_port *\n+sfc_repr_proxy_rx_route_mbuf(struct sfc_repr_proxy *rp, struct rte_mbuf *m)\n+{\n+\tstruct sfc_repr_proxy_port *port;\n+\tefx_mport_id_t mport_id;\n+\n+\tmport_id.id = *RTE_MBUF_DYNFIELD(m, sfc_dp_mport_offset,\n+\t\t\t\t\t typeof(&((efx_mport_id_t *)0)->id));\n+\n+\tTAILQ_FOREACH(port, &rp->ports, entries) {\n+\t\tif (port->egress_mport.id == mport_id.id) {\n+\t\t\tm->port = port->rte_port_id;\n+\t\t\tm->ol_flags &= ~sfc_dp_mport_override;\n+\t\t\treturn port;\n+\t\t}\n+\t}\n+\n+\treturn NULL;\n+}\n+\n+/*\n+ * Returns true if a packet is encountered which should be forwarded to a\n+ * port which is different from the one that is currently routed.\n+ */\n+static bool\n+sfc_repr_proxy_rx_route(struct sfc_repr_proxy *rp,\n+\t\t\tstruct sfc_repr_proxy_dp_rxq *rp_rxq)\n+{\n+\tunsigned int i;\n+\n+\tfor (i = rp_rxq->routed;\n+\t     i < rp_rxq->available && !rp_rxq->stop_route;\n+\t     i++, rp_rxq->routed++) {\n+\t\tstruct sfc_repr_proxy_port *port;\n+\t\tstruct rte_mbuf *m = rp_rxq->pkts[i];\n+\n+\t\tport = sfc_repr_proxy_rx_route_mbuf(rp, m);\n+\t\t/* Cannot find destination representor */\n+\t\tif (port == NULL) {\n+\t\t\t/* Effectively drop the packet */\n+\t\t\trp_rxq->forwarded++;\n+\t\t\tcontinue;\n+\t\t}\n+\n+\t\t/* Currently routed packets are mapped to a different port */\n+\t\tif (port->repr_id != rp_rxq->route_port_id &&\n+\t\t    rp_rxq->route_port_id != SFC_REPR_INVALID_ROUTE_PORT_ID)\n+\t\t\treturn true;\n+\n+\t\trp_rxq->route_port_id = port->repr_id;\n+\t}\n+\n+\treturn false;\n+}\n+\n+static void\n+sfc_repr_proxy_rx_forward(struct sfc_repr_proxy *rp,\n+\t\t\t  struct sfc_repr_proxy_dp_rxq *rp_rxq)\n+{\n+\tstruct sfc_repr_proxy_port *port;\n+\n+\tif (rp_rxq->route_port_id != SFC_REPR_INVALID_ROUTE_PORT_ID) {\n+\t\tport = sfc_repr_proxy_find_port(rp, rp_rxq->route_port_id);\n+\n+\t\tif (port != NULL && port->started) {\n+\t\t\trp_rxq->forwarded +=\n+\t\t\t    rte_ring_sp_enqueue_burst(port->rxq[0].ring,\n+\t\t\t\t(void **)(&rp_rxq->pkts[rp_rxq->forwarded]),\n+\t\t\t\trp_rxq->routed - rp_rxq->forwarded, NULL);\n+\t\t} else {\n+\t\t\t/* Drop all routed packets if the port is not started */\n+\t\t\trp_rxq->forwarded = rp_rxq->routed;\n+\t\t}\n+\t}\n+\n+\tif (rp_rxq->forwarded == rp_rxq->routed) {\n+\t\trp_rxq->route_port_id = SFC_REPR_INVALID_ROUTE_PORT_ID;\n+\t\trp_rxq->stop_route = false;\n+\t} else {\n+\t\t/* Stall packet routing if not all packets were forwarded */\n+\t\trp_rxq->stop_route = true;\n+\t}\n+\n+\tif (rp_rxq->available == rp_rxq->forwarded)\n+\t\trp_rxq->available = rp_rxq->forwarded = rp_rxq->routed = 0;\n+}\n+\n+static void\n+sfc_repr_proxy_handle_rx(struct sfc_repr_proxy *rp,\n+\t\t\t struct sfc_repr_proxy_dp_rxq *rp_rxq)\n+{\n+\tbool route_again;\n+\n+\tif (rp_rxq->available < RTE_DIM(rp_rxq->pkts)) {\n+\t\trp_rxq->available += rp_rxq->pkt_burst(rp_rxq->dp,\n+\t\t\t\t&rp_rxq->pkts[rp_rxq->available],\n+\t\t\t\tRTE_DIM(rp_rxq->pkts) - rp_rxq->available);\n+\t\tif (rp_rxq->available == rp_rxq->forwarded)\n+\t\t\treturn;\n+\t}\n+\n+\tdo {\n+\t\troute_again = sfc_repr_proxy_rx_route(rp, rp_rxq);\n+\t\tsfc_repr_proxy_rx_forward(rp, rp_rxq);\n+\t} while (route_again && !rp_rxq->stop_route);\n+}\n+\n static int32_t\n sfc_repr_proxy_routine(void *arg)\n {\n@@ -204,6 +314,9 @@ sfc_repr_proxy_routine(void *arg)\n \t\t\tsfc_repr_proxy_handle_tx(&rp->dp_txq[i], &port->txq[i]);\n \t}\n \n+\tfor (i = 0; i < rp->nb_rxq; i++)\n+\t\tsfc_repr_proxy_handle_rx(rp, &rp->dp_rxq[i]);\n+\n \treturn 0;\n }\n \n@@ -412,6 +525,18 @@ sfc_repr_proxy_rxq_detach(struct sfc_adapter *sa)\n \tsfc_log_init(sa, \"done\");\n }\n \n+static struct sfc_rxq_info *\n+sfc_repr_proxy_rxq_info_get(struct sfc_adapter *sa, unsigned int repr_queue_id)\n+{\n+\tstruct sfc_adapter_shared *sas = sfc_sa2shared(sa);\n+\tstruct sfc_repr_proxy_dp_rxq *dp_rxq;\n+\n+\tSFC_ASSERT(repr_queue_id < sfc_repr_nb_rxq(sas));\n+\tdp_rxq = &sa->repr_proxy.dp_rxq[repr_queue_id];\n+\n+\treturn &sas->rxq_info[dp_rxq->sw_index];\n+}\n+\n static int\n sfc_repr_proxy_rxq_init(struct sfc_adapter *sa,\n \t\t\tstruct sfc_repr_proxy_dp_rxq *rxq)\n@@ -539,6 +664,14 @@ sfc_repr_proxy_rxq_start(struct sfc_adapter *sa)\n \t\t\t\ti);\n \t\t\tgoto fail_start;\n \t\t}\n+\n+\t\trxq->dp = sfc_repr_proxy_rxq_info_get(sa, i)->dp;\n+\t\trxq->pkt_burst = sa->eth_dev->rx_pkt_burst;\n+\t\trxq->available = 0;\n+\t\trxq->routed = 0;\n+\t\trxq->forwarded = 0;\n+\t\trxq->stop_route = false;\n+\t\trxq->route_port_id = SFC_REPR_INVALID_ROUTE_PORT_ID;\n \t}\n \n \tsfc_log_init(sa, \"done\");\n@@ -993,6 +1126,7 @@ sfc_repr_proxy_start(struct sfc_adapter *sa)\n \t\tgoto fail_txq_start;\n \n \trp->nb_txq = sfc_repr_nb_txq(sas);\n+\trp->nb_rxq = sfc_repr_nb_rxq(sas);\n \n \t/* Service core may be in \"stopped\" state, start it */\n \trc = rte_service_lcore_start(rp->service_core_id);\ndiff --git a/drivers/net/sfc/sfc_repr_proxy.h b/drivers/net/sfc/sfc_repr_proxy.h\nindex d47e0a431a..b49b1a2a96 100644\n--- a/drivers/net/sfc/sfc_repr_proxy.h\n+++ b/drivers/net/sfc/sfc_repr_proxy.h\n@@ -75,6 +75,16 @@ struct sfc_repr_proxy_dp_rxq {\n \tstruct rte_mempool\t\t*mp;\n \tunsigned int\t\t\tref_count;\n \n+\teth_rx_burst_t\t\t\tpkt_burst;\n+\tstruct sfc_dp_rxq\t\t*dp;\n+\n+\tuint16_t\t\t\troute_port_id;\n+\tbool\t\t\t\tstop_route;\n+\tunsigned int\t\t\tavailable;\n+\tunsigned int\t\t\tforwarded;\n+\tunsigned int\t\t\trouted;\n+\tstruct rte_mbuf\t\t\t*pkts[SFC_REPR_PROXY_TX_BURST];\n+\n \tsfc_sw_index_t\t\t\tsw_index;\n };\n \n@@ -118,6 +128,7 @@ struct sfc_repr_proxy {\n \n \tstruct sfc_repr_proxy_mbox\tmbox;\n \tunsigned int\t\t\tnb_txq;\n+\tunsigned int\t\t\tnb_rxq;\n };\n \n struct sfc_adapter;\n",
    "prefixes": [
        "25/38"
    ]
}