Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/96652/?format=api
{ "id": 96652, "url": "https://patches.dpdk.org/api/patches/96652/?format=api", "web_url": "https://patches.dpdk.org/project/dts/patch/1628088115-756-2-git-send-email-lijuan.tu@intel.com/", "project": { "id": 3, "url": "https://patches.dpdk.org/api/projects/3/?format=api", "name": "DTS", "link_name": "dts", "list_id": "dts.dpdk.org", "list_email": "dts@dpdk.org", "web_url": "", "scm_url": "git://dpdk.org/tools/dts", "webscm_url": "http://git.dpdk.org/tools/dts/", "list_archive_url": "https://inbox.dpdk.org/dts", "list_archive_url_format": "https://inbox.dpdk.org/dts/{}", "commit_url_format": "" }, "msgid": "<1628088115-756-2-git-send-email-lijuan.tu@intel.com>", "list_archive_url": "https://inbox.dpdk.org/dts/1628088115-756-2-git-send-email-lijuan.tu@intel.com", "date": "2021-08-04T14:41:51", "name": "[v2,1/5] generic_filter: remove perf test case", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": false, "hash": "419f6e0d343025e451cfbe7771ab6a8b9727638d", "submitter": { "id": 1098, "url": "https://patches.dpdk.org/api/people/1098/?format=api", "name": "Tu, Lijuan", "email": "lijuan.tu@intel.com" }, "delegate": null, "mbox": "https://patches.dpdk.org/project/dts/patch/1628088115-756-2-git-send-email-lijuan.tu@intel.com/mbox/", "series": [ { "id": 18180, "url": "https://patches.dpdk.org/api/series/18180/?format=api", "web_url": "https://patches.dpdk.org/project/dts/list/?series=18180", "date": "2021-08-04T14:41:50", "name": "remove some run-down cases", "version": 2, "mbox": "https://patches.dpdk.org/series/18180/mbox/" } ], "comments": "https://patches.dpdk.org/api/patches/96652/comments/", "check": "pending", "checks": "https://patches.dpdk.org/api/patches/96652/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dts-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from mails.dpdk.org (mails.dpdk.org [217.70.189.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id A6DF0A0C50;\n\tWed, 4 Aug 2021 08:52:16 +0200 (CEST)", "from [217.70.189.124] (localhost [127.0.0.1])\n\tby mails.dpdk.org (Postfix) with ESMTP id 8C1594014F;\n\tWed, 4 Aug 2021 08:52:16 +0200 (CEST)", "from mga05.intel.com (mga05.intel.com [192.55.52.43])\n by mails.dpdk.org (Postfix) with ESMTP id 019554120E\n for <dts@dpdk.org>; Wed, 4 Aug 2021 08:52:13 +0200 (CEST)", "from fmsmga008.fm.intel.com ([10.253.24.58])\n by fmsmga105.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384;\n 03 Aug 2021 23:52:05 -0700", "from unknown (HELO dpdk-lijuan.sh.intel.com) ([10.67.119.192])\n by fmsmga008.fm.intel.com with ESMTP; 03 Aug 2021 23:52:04 -0700" ], "X-IronPort-AV": [ "E=McAfee;i=\"6200,9189,10065\"; a=\"299451055\"", "E=Sophos;i=\"5.84,293,1620716400\"; d=\"scan'208\";a=\"299451055\"", "E=Sophos;i=\"5.84,293,1620716400\"; d=\"scan'208\";a=\"479985057\"" ], "X-ExtLoop1": "1", "From": "Lijuan Tu <lijuan.tu@intel.com>", "To": "dts@dpdk.org", "Cc": "Lijuan Tu <lijuan.tu@intel.com>", "Date": "Wed, 4 Aug 2021 22:41:51 +0800", "Message-Id": "<1628088115-756-2-git-send-email-lijuan.tu@intel.com>", "X-Mailer": "git-send-email 1.8.3.1", "In-Reply-To": "<1628088115-756-1-git-send-email-lijuan.tu@intel.com>", "References": "<1628088115-756-1-git-send-email-lijuan.tu@intel.com>", "Subject": "[dts] [v2, 1/5] generic_filter: remove perf test case", "X-BeenThere": "dts@dpdk.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "test suite reviews and discussions <dts.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dts>,\n <mailto:dts-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dts/>", "List-Post": "<mailto:dts@dpdk.org>", "List-Help": "<mailto:dts-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dts>,\n <mailto:dts-request@dpdk.org?subject=subscribe>", "Errors-To": "dts-bounces@dpdk.org", "Sender": "\"dts\" <dts-bounces@dpdk.org>" }, "content": "the case is no longer maintained.\n\nSigned-off-by: Lijuan Tu <lijuan.tu@intel.com>\n---\n test_plans/generic_filter_test_plan.rst | 107 --------------------------------\n tests/TestSuite_generic_filter.py | 75 ----------------------\n 2 files changed, 182 deletions(-)", "diff": "diff --git a/test_plans/generic_filter_test_plan.rst b/test_plans/generic_filter_test_plan.rst\nindex de02f62..fda54e0 100644\n--- a/test_plans/generic_filter_test_plan.rst\n+++ b/test_plans/generic_filter_test_plan.rst\n@@ -522,110 +522,3 @@ Send packets(`dst_ip` = 2.2.2.5 `src_ip` = 2.2.2.4 `dst_port` = 1 `src_port` =\n sending packets. packets are received on the queue 64 and queue 127 When\n setting 5-tuple Filter with queue(128), it will display failure because the\n number of queues no more than 128.\n-\n-\n-\n-Test Case 11: 10G NIC Performance\n-=================================\n-\n-This case is designed for Niantic. It provides the performance data with and\n-without generic filter::\n-\n- Launch app without filter\n- ./testpmd -c fffff -n 4 -- -i --disable-rss --rxq=4 --txq=4 --nb-cores=16 --nb-ports=2\n- testpmd> start\n-\n-Send the packets stream from packet generator::\n-\n- testpmd> quit\n-\n-Enable the filters on app::\n-\n- ./testpmd -c fffff -n 4 -- -i --disable-rss --rxq=4 --txq=4 --nb-cores=16 --nb-ports=2\n-\n- testpmd>set stat_qmap rx 0 0 0\n- testpmd>set stat_qmap rx 0 1 1\n- testpmd>set stat_qmap rx 0 2 2\n- testpmd>set stat_qmap rx 0 3 3\n- testpmd>set flush_rx on\n- testpmd> add_syn_filter 0 priority high queue 1\n- testpmd> add_ethertype_filter 0 ethertype 0x0806 priority disable 0 queue 2 index 1\n- testpmd> add_5tuple_filter 0 dst_ip 2.2.2.5 src_ip 2.2.2.4 dst_port 1 src_port 1 protocol 0x06 mask 0x1f flags 0x02 priority 3 queue 3 index 1\n- testpmd> start\n-\n-Send the packets stream from packet generator::\n-\n- testpmd> quit\n-\n-\n-+-------+---------+---------+\n-| Frame | disable | enable |\n-| Size | filter | filter |\n-+-------+---------+---------+\n-| 64 | | |\n-+-------+---------+---------+\n-| 128 | | |\n-+-------+---------+---------+\n-| 256 | | |\n-+-------+---------+---------+\n-| 512 | | |\n-+-------+---------+---------+\n-| 1024 | | |\n-+-------+---------+---------+\n-| 1280 | | |\n-+-------+---------+---------+\n-| 1518 | | |\n-+-------+---------+---------+\n-\n-\n-Test Case 12: 1G NIC Performance\n-================================\n-\n-This case is designed for NIC (I350, 82580, and 82576). It provides the\n-performance data with and without generic filter::\n-\n- ./testpmd -c fffff -n 4 -- -i --disable-rss --rxq=4 --txq=4 --nb-cores=16 --nb-ports=2\n- testpmd> start\n-\n-Send the packets stream from packet generator::\n-\n- testpmd> quit\n-\n-Enable the filter::\n-\n- ./testpmd -c fffff -n 4 -- -i --disable-rss --rxq=4 --txq=4 --nb-cores=16 --nb-ports=2\n-\n- testpmd>set stat_qmap rx 0 0 0\n- testpmd>set stat_qmap rx 0 1 1\n- testpmd>set stat_qmap rx 0 2 2\n- testpmd>set stat_qmap rx 0 3 3\n- testpmd>set flush_rx on\n- testpmd> add_syn_filter 0 priority high queue 1\n- testpmd> add_ethertype_filter 0 ethertype 0x0806 priority disable 0 queue 2 index 1\n- testpmd> start\n-\n-\n-Send the packets stream from packet generator::\n-\n- testpmd> quit\n-\n-\n-\n-+-------+---------+---------+\n-| Frame | disable | enable |\n-| Size | filter | filter |\n-+-------+---------+---------+\n-| 64 | | |\n-+-------+---------+---------+\n-| 128 | | |\n-+-------+---------+---------+\n-| 256 | | |\n-+-------+---------+---------+\n-| 512 | | |\n-+-------+---------+---------+\n-| 1024 | | |\n-+-------+---------+---------+\n-| 1280 | | |\n-+-------+---------+---------+\n-| 1518 | | |\n-+-------+---------+---------+\ndiff --git a/tests/TestSuite_generic_filter.py b/tests/TestSuite_generic_filter.py\nindex b34c9dd..22f85bd 100644\n--- a/tests/TestSuite_generic_filter.py\n+++ b/tests/TestSuite_generic_filter.py\n@@ -773,81 +773,6 @@ class TestGeneric_filter(TestCase):\n else:\n self.verify(False, \"%s not support this test\" % self.nic)\n \n- def test_perf_generic_filter_perf(self):\n- self.pmdout.start_testpmd(\n- \"%s\" % self.cores, \"--disable-rss --rxq=4 --txq=4 --portmask=%s --nb-cores=4 --nb-ports=1\" % portMask)\n- self.port_config()\n- print(valports[0], valports[1])\n- tx_port = self.tester.get_local_port(valports[0])\n- tx_mac = self.dut.get_mac_address(valports[0])\n- txItf = self.tester.get_interface(tx_port)\n-\n- rx_port = self.tester.get_local_port(valports[1])\n- rxItf = self.tester.get_interface(rx_port)\n- package_sizes = [64, 128, 256, 512, 1024, 1280, 1518]\n- print(tx_mac)\n- print(self.dut.ports_info[valports[0]], self.dut.ports_info[valports[1]])\n- test_type = {\n- \"syn\": [\"syn_filter add 0 priority high queue 1\", \"syn_filter del 0 priority high queue 1\"],\n- \"ethertype\": [\"add_ethertype_filter 0 ethertype 0x0806 priority disable 0 queue 2 index 1\", \"remove_ethertype_filter 0 index 1\"],\n- \"5tuple\": [\"5tuple_filter 0 add dst_ip 2.2.2.5 src_ip 2.2.2.4 dst_port 1 src_port 1 protocol 0x06 mask 0x1f tcp_flags 0x02 priority 3 queue 3\", \"5tuple_filter 0 add dst_ip 2.2.2.5 src_ip 2.2.2.4 dst_port 1 src_port 1 protocol 0x06 mask 0x1f tcp_flags 0x02 priority 3 queue 3\"]\n- }\n- stream_config = {\n- \"syn\": 'Ether(dst=\"%s\")/IP(src=\"2.2.2.5\",dst=\"2.2.2.4\")/TCP(dport=80,flags=\"S\")/(\"X\"*64)',\n- \"ethertype\": 'Ether(dst=\"%s\")/ARP(pdst=\"192.168.1.1\")' % tx_mac,\n- \"5tuple\": 'flows.append(Ether(dst=\"%s\")/IP(src=\"2.2.2.4\",dst=\"2.2.2.5\")/TCP(sport=1,dport=1,flags=0)/(\"X\"*%d))',\n- }\n- self.result_table_create(\n- ['pack_size', \"filter_type\", \"enable\", \"disable\", \"perf_compare\"])\n- for key in list(test_type.keys()):\n- if \"5tuple\" != key:\n- pps_lists = []\n- for i in range(2):\n- self.dut.send_expect(test_type[key][i], \"testpmd> \", 15)\n- self.dut.send_expect(\"start\", \"testpmd> \", 120)\n- self.tester.scapy_append('flows = []')\n- self.tester.scapy_append(\n- 'flows.append(%s)' % stream_config[key])\n- self.tester.scapy_append(\n- 'wrpcap(\"generic_firlter.pcap\",flows)')\n- self.tester.scapy_execute()\n- tgen_input = []\n- tgen_input.append(\n- (tx_port, rx_port, \"generic_firlter.pcap\"))\n- _, pps = self.tester.traffic_generator_throughput(\n- tgen_input)\n- pps_lists.append(pps)\n- self.result_table_add(\n- [\"defult\", key, pps_lists[0], pps_lists[1], (pps_lists[0] - pps_lists[1]) / float(pps_lists[1])])\n- # this is a TCP/IP packet, need to test different payload_size\n- if (\"5tuple\" == key) and (\"niantic\" == self.nic):\n- for package_size in package_sizes:\n- payload_size = package_size - \\\n- HEADER_SIZE[\"tcp\"] - HEADER_SIZE[\n- 'ip'] - HEADER_SIZE['eth']\n- pps_lists = []\n- for i in range(2):\n- self.dut.send_expect(\n- test_type[key][i], \"testpmd> \", 15)\n- self.dut.send_expect(\"start\", \"testpmd> \", 120)\n- self.tester.scapy_append('flows = []')\n- self.tester.scapy_append('flows.append(%s)' % (\n- stream_config[key] % (tx_mac, payload_size)))\n- self.tester.scapy_append(\n- 'wrpcap(\"generic_firlter.pcap\",flows)')\n- self.tester.scapy_execute()\n- tgen_input = []\n- # tgen_input.append((txItf, rxItf, \"generic_firlter.pcap\"))\n- tgen_input.append(\n- (tx_port, rx_port, \"generic_firlter.pcap\"))\n- print(tgen_input)\n- _, pps = self.tester.traffic_generator_throughput(\n- tgen_input)\n- pps_lists.append(pps)\n- self.result_table_add(\n- [package_size, key, pps_lists[0], pps_lists[1], (pps_lists[0] - pps_lists[1]) / float(pps_lists[1])])\n- self.result_table_print()\n-\n def tear_down(self):\n \"\"\"\n Run after each test case.\n", "prefixes": [ "v2", "1/5" ] }