Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/95391/?format=api
{ "id": 95391, "url": "https://patches.dpdk.org/api/patches/95391/?format=api", "web_url": "https://patches.dpdk.org/project/dpdk/patch/20210706133257.3353-5-suanmingm@nvidia.com/", "project": { "id": 1, "url": "https://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20210706133257.3353-5-suanmingm@nvidia.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20210706133257.3353-5-suanmingm@nvidia.com", "date": "2021-07-06T13:32:35", "name": "[v4,04/26] net/mlx5: support index pool non-lcore operations", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": true, "hash": "c2340bc01e71a03dc8ebd05f727c4ad4bce17a83", "submitter": { "id": 1887, "url": "https://patches.dpdk.org/api/people/1887/?format=api", "name": "Suanming Mou", "email": "suanmingm@nvidia.com" }, "delegate": { "id": 3268, "url": "https://patches.dpdk.org/api/users/3268/?format=api", "username": "rasland", "first_name": "Raslan", "last_name": "Darawsheh", "email": "rasland@nvidia.com" }, "mbox": "https://patches.dpdk.org/project/dpdk/patch/20210706133257.3353-5-suanmingm@nvidia.com/mbox/", "series": [ { "id": 17668, "url": "https://patches.dpdk.org/api/series/17668/?format=api", "web_url": "https://patches.dpdk.org/project/dpdk/list/?series=17668", "date": "2021-07-06T13:32:31", "name": "net/mlx5: insertion rate optimization", "version": 4, "mbox": "https://patches.dpdk.org/series/17668/mbox/" } ], "comments": "https://patches.dpdk.org/api/patches/95391/comments/", "check": "success", "checks": "https://patches.dpdk.org/api/patches/95391/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from mails.dpdk.org (mails.dpdk.org [217.70.189.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id 177E1A0C47;\n\tTue, 6 Jul 2021 15:33:52 +0200 (CEST)", "from [217.70.189.124] (localhost [127.0.0.1])\n\tby mails.dpdk.org (Postfix) with ESMTP id 1C99A4120E;\n\tTue, 6 Jul 2021 15:33:33 +0200 (CEST)", "from NAM10-DM6-obe.outbound.protection.outlook.com\n (mail-dm6nam10on2084.outbound.protection.outlook.com [40.107.93.84])\n by mails.dpdk.org (Postfix) with ESMTP id ECE4F4120E\n for <dev@dpdk.org>; Tue, 6 Jul 2021 15:33:30 +0200 (CEST)", "from BN0PR02CA0050.namprd02.prod.outlook.com (2603:10b6:408:e5::25)\n by BY5PR12MB3698.namprd12.prod.outlook.com (2603:10b6:a03:194::30)\n with Microsoft SMTP Server (version=TLS1_2,\n cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4287.31; Tue, 6 Jul\n 2021 13:33:29 +0000", "from BN8NAM11FT047.eop-nam11.prod.protection.outlook.com\n (2603:10b6:408:e5:cafe::3f) by BN0PR02CA0050.outlook.office365.com\n (2603:10b6:408:e5::25) with Microsoft SMTP Server (version=TLS1_2,\n cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4287.22 via Frontend\n Transport; Tue, 6 Jul 2021 13:33:29 +0000", "from mail.nvidia.com (216.228.112.34) by\n BN8NAM11FT047.mail.protection.outlook.com (10.13.177.220) with Microsoft SMTP\n Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384) id\n 15.20.4287.22 via Frontend Transport; Tue, 6 Jul 2021 13:33:28 +0000", "from nvidia.com (172.20.187.6) by HQMAIL107.nvidia.com\n (172.20.187.13) with Microsoft SMTP Server (TLS) id 15.0.1497.2; Tue, 6 Jul\n 2021 13:33:24 +0000" ], "ARC-Seal": "i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;\n b=h5f0PkhJ7x1YpernAYvFyjrM5hUBOnheKkofSxFOm9ooLCQwvIDe6diNL50S9KzdbBhD2hyjk1gTGQFjZNYBR+i/OMOnO9ZGCStplW5KHc7R8F2z8uJBkCJLtX2Du2wCje+iExDWUxHwCRmBTJGsTbeLvoz8XX13b0jtcqtkC7tpOY8ck4gFO4+U2WrQFqzIzftT762iocyzXnfbw6LWtoDQiLOkzGMCXXCYOLj/MwaA2G3i9ZKEXIBr9sX/+a+AkpPXNJZ/Ee8QO0G6EAsBERAZUuy1VmlTKIoZyEhkZTS0doct91/0a452fJ4p2diO++ehJZtG+qIxQ2+gF8vV5Q==", "ARC-Message-Signature": "i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;\n s=arcselector9901;\n h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;\n bh=sGKkTxBRkki51x92gVo/ec3Xx05Ymp9Wu93yZ7GM/pg=;\n b=aVA9ZQ43wjkDFSX1xhYpU6qwIAP3a8x7A7geL3prqzoDtoKf0xgmLM1xWFcOR2SUIWu6CMk+hMfGTwO4zztoxDDTN4in8H2YjuE0HXxv+sxkkQA3RGQtfGZdA5+JVeRhXOA/gD3c/4fLczJ/OR1aD8Ox62Sn0D9QpQFUcj0UZrtkHkXZRSrqKG8aqQCzM1q8npdEjwCUcdb+BNdBXsrKLcER+JSlAMhIVvq/Mqd6eHv8YabgcBs59irKg9/wpxrRXkSn3JD8dzf62XniffU2PmYtKD35tGfnJOdQla6755b6AxXdgTqFfG1tza8Xs8XcRUE6+iW1AHE4bvOVmtC0rg==", "ARC-Authentication-Results": "i=1; mx.microsoft.com 1; spf=pass (sender ip is\n 216.228.112.34) smtp.rcpttodomain=dpdk.org smtp.mailfrom=nvidia.com;\n dmarc=pass (p=none sp=none pct=100) action=none header.from=nvidia.com;\n dkim=none (message not signed); arc=none", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed; d=Nvidia.com;\n s=selector2;\n h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;\n bh=sGKkTxBRkki51x92gVo/ec3Xx05Ymp9Wu93yZ7GM/pg=;\n b=FQwL+xWFW1ppAdISIMvaPOV7dLlDzsd60g8xdooKts1w5r9hDIGsdnjXt+FSRkj3aiNse91RgKgov1AQniEnodhcp2yWsDIOumNw5peCNn2XZ7NxpMEEBiE8UUtGy3TzbseXjtvUZte9xIsXcRF4QpMiqoEBfvRd0WpSBEHbskgxrSKrjmSi5RtwxX8XL+hoGj5CgP4zNIq2jUYv/3X7cgrGzLkdkmUte6yN51a57lTtdcPLwf/KgYnKNUptqCTiP7r5wm25kxgdZ8y11gSdeuSe+9jflv9+vFFZcyYOnnHxDUC7+FEXNAi5EBaeDjFdEcoBSz175oNPgHQP2J79tA==", "X-MS-Exchange-Authentication-Results": "spf=pass (sender IP is 216.228.112.34)\n smtp.mailfrom=nvidia.com; dpdk.org; dkim=none (message not signed)\n header.d=none;dpdk.org; dmarc=pass action=none header.from=nvidia.com;", "Received-SPF": "Pass (protection.outlook.com: domain of nvidia.com designates\n 216.228.112.34 as permitted sender) receiver=protection.outlook.com;\n client-ip=216.228.112.34; helo=mail.nvidia.com;", "From": "Suanming Mou <suanmingm@nvidia.com>", "To": "<viacheslavo@nvidia.com>, <matan@nvidia.com>", "CC": "<rasland@nvidia.com>, <orika@nvidia.com>, <dev@dpdk.org>", "Date": "Tue, 6 Jul 2021 16:32:35 +0300", "Message-ID": "<20210706133257.3353-5-suanmingm@nvidia.com>", "X-Mailer": "git-send-email 2.18.1", "In-Reply-To": "<20210706133257.3353-1-suanmingm@nvidia.com>", "References": "<20210527093403.1153127-1-suanmingm@nvidia.com>\n <20210706133257.3353-1-suanmingm@nvidia.com>", "MIME-Version": "1.0", "Content-Type": "text/plain", "X-Originating-IP": "[172.20.187.6]", "X-ClientProxiedBy": "HQMAIL101.nvidia.com (172.20.187.10) To\n HQMAIL107.nvidia.com (172.20.187.13)", "X-EOPAttributedMessage": "0", "X-MS-PublicTrafficType": "Email", "X-MS-Office365-Filtering-Correlation-Id": "fe22ce2f-29c7-4405-e95b-08d94082a3ff", "X-MS-TrafficTypeDiagnostic": "BY5PR12MB3698:", "X-Microsoft-Antispam-PRVS": "\n <BY5PR12MB3698267F281C6A0DDADAF581C11B9@BY5PR12MB3698.namprd12.prod.outlook.com>", "X-MS-Oob-TLC-OOBClassifiers": "OLM:72;", "X-MS-Exchange-SenderADCheck": "1", "X-Microsoft-Antispam": "BCL:0;", "X-Microsoft-Antispam-Message-Info": "\n 4bzdA4KrMcndnQBnl8i3vbpB3XVNLOTPOaXLrUljsf0RMcpuLacN1Der3ALQxT+kdAyTxG0J87kyir5AB67v0KM7IEHb9Cf0bdpwvMZUlT+Etw4qJNP91+IdJ96kQ7s6tC6TebSBC21GcWGoweKubEJFvURt3Hr6q1LZW1U3/W35X5XsVFn7Cgu9VNnVZNdY0wR/oUjnrNeY24lwSld1R3py2yOoj6Dg/1ueCYgvDWGD87Eutr+gAasRcotXLW+JtdhG9OsbkpuZrAhL1ugXY5A2T1nUny3TfnTLPbCDzhwoRlSZ5yWXwVoVf9d3/6L2TaaM6UHszZlZCN4cCTFuiEN9lGo00UfLF4XCSdo/B9bU61aml7yaCeOTylw1z6fzy0u9RgZ0Kpx/H2OsdPLUSpq6RMKvW4if5rnhRSpJyObCoGUym3vSxU2aj1SQtOcGlhp1dJP3+Djz8u8+2JzHkxN41aXQjm/t6SsEp+NByxb9pIya6sk0UoxO7wm9EpcgOdxrFkJh7wttEtdAu9UU3KyEcptIiigX0UH4JTBfUVJtCiu5e93QFKPhhNhtiAuuUEZR6pdYNv0F4t2BucanYlyF5bWyjQ+b16J6g02hvOgXfR839RBHr+VTM+f/uh6hhHsuMknY+07PkIRsLVe30VPYTRZyoFGuu9z2MX81vb6dcjlpHdhMTNfy7no0DNZRFnn+X/TFFYnFOvwkv18OYw==", "X-Forefront-Antispam-Report": "CIP:216.228.112.34; CTRY:US; LANG:en; SCL:1;\n SRV:;\n IPV:NLI; SFV:NSPM; H:mail.nvidia.com; PTR:schybrid03.nvidia.com; CAT:NONE;\n SFS:(4636009)(396003)(346002)(39860400002)(376002)(136003)(36840700001)(46966006)(8676002)(47076005)(86362001)(356005)(316002)(36860700001)(36756003)(2906002)(2616005)(426003)(1076003)(83380400001)(55016002)(478600001)(186003)(7696005)(6666004)(36906005)(7636003)(70586007)(6636002)(82310400003)(6286002)(82740400003)(336012)(5660300002)(16526019)(54906003)(8936002)(110136005)(4326008)(26005)(70206006);\n DIR:OUT; SFP:1101;", "X-OriginatorOrg": "Nvidia.com", "X-MS-Exchange-CrossTenant-OriginalArrivalTime": "06 Jul 2021 13:33:28.9260 (UTC)", "X-MS-Exchange-CrossTenant-Network-Message-Id": "\n fe22ce2f-29c7-4405-e95b-08d94082a3ff", "X-MS-Exchange-CrossTenant-Id": "43083d15-7273-40c1-b7db-39efd9ccc17a", "X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp": "\n TenantId=43083d15-7273-40c1-b7db-39efd9ccc17a; Ip=[216.228.112.34];\n Helo=[mail.nvidia.com]", "X-MS-Exchange-CrossTenant-AuthSource": "\n BN8NAM11FT047.eop-nam11.prod.protection.outlook.com", "X-MS-Exchange-CrossTenant-AuthAs": "Anonymous", "X-MS-Exchange-CrossTenant-FromEntityHeader": "HybridOnPrem", "X-MS-Exchange-Transport-CrossTenantHeadersStamped": "BY5PR12MB3698", "Subject": "[dpdk-dev] [PATCH v4 04/26] net/mlx5: support index pool non-lcore\n operations", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "This commit supports the index pool non-lcore operations with\nan extra cache and lcore lock.\n\nSigned-off-by: Suanming Mou <suanmingm@nvidia.com>\nAcked-by: Matan Azrad <matan@nvidia.com>\n---\n drivers/net/mlx5/mlx5_utils.c | 75 +++++++++++++++++++++++++----------\n drivers/net/mlx5/mlx5_utils.h | 3 +-\n 2 files changed, 56 insertions(+), 22 deletions(-)", "diff": "diff --git a/drivers/net/mlx5/mlx5_utils.c b/drivers/net/mlx5/mlx5_utils.c\nindex 32f8d65073..f9557c09ff 100644\n--- a/drivers/net/mlx5/mlx5_utils.c\n+++ b/drivers/net/mlx5/mlx5_utils.c\n@@ -275,6 +275,7 @@ mlx5_ipool_create(struct mlx5_indexed_pool_config *cfg)\n \t\t\tmlx5_trunk_idx_offset_get(pool, TRUNK_MAX_IDX + 1);\n \tif (!cfg->per_core_cache)\n \t\tpool->free_list = TRUNK_INVALID;\n+\trte_spinlock_init(&pool->lcore_lock);\n \treturn pool;\n }\n \n@@ -515,20 +516,14 @@ mlx5_ipool_allocate_from_global(struct mlx5_indexed_pool *pool, int cidx)\n }\n \n static void *\n-mlx5_ipool_get_cache(struct mlx5_indexed_pool *pool, uint32_t idx)\n+_mlx5_ipool_get_cache(struct mlx5_indexed_pool *pool, int cidx, uint32_t idx)\n {\n \tstruct mlx5_indexed_trunk *trunk;\n \tstruct mlx5_indexed_cache *lc;\n \tuint32_t trunk_idx;\n \tuint32_t entry_idx;\n-\tint cidx;\n \n \tMLX5_ASSERT(idx);\n-\tcidx = rte_lcore_index(rte_lcore_id());\n-\tif (unlikely(cidx == -1)) {\n-\t\trte_errno = ENOTSUP;\n-\t\treturn NULL;\n-\t}\n \tif (unlikely(!pool->cache[cidx])) {\n \t\tpool->cache[cidx] = pool->cfg.malloc(MLX5_MEM_ZERO,\n \t\t\tsizeof(struct mlx5_ipool_per_lcore) +\n@@ -549,15 +544,27 @@ mlx5_ipool_get_cache(struct mlx5_indexed_pool *pool, uint32_t idx)\n }\n \n static void *\n-mlx5_ipool_malloc_cache(struct mlx5_indexed_pool *pool, uint32_t *idx)\n+mlx5_ipool_get_cache(struct mlx5_indexed_pool *pool, uint32_t idx)\n {\n+\tvoid *entry;\n \tint cidx;\n \n \tcidx = rte_lcore_index(rte_lcore_id());\n \tif (unlikely(cidx == -1)) {\n-\t\trte_errno = ENOTSUP;\n-\t\treturn NULL;\n+\t\tcidx = RTE_MAX_LCORE;\n+\t\trte_spinlock_lock(&pool->lcore_lock);\n \t}\n+\tentry = _mlx5_ipool_get_cache(pool, cidx, idx);\n+\tif (unlikely(cidx == RTE_MAX_LCORE))\n+\t\trte_spinlock_unlock(&pool->lcore_lock);\n+\treturn entry;\n+}\n+\n+\n+static void *\n+_mlx5_ipool_malloc_cache(struct mlx5_indexed_pool *pool, int cidx,\n+\t\t\t uint32_t *idx)\n+{\n \tif (unlikely(!pool->cache[cidx])) {\n \t\tpool->cache[cidx] = pool->cfg.malloc(MLX5_MEM_ZERO,\n \t\t\tsizeof(struct mlx5_ipool_per_lcore) +\n@@ -570,29 +577,40 @@ mlx5_ipool_malloc_cache(struct mlx5_indexed_pool *pool, uint32_t *idx)\n \t} else if (pool->cache[cidx]->len) {\n \t\tpool->cache[cidx]->len--;\n \t\t*idx = pool->cache[cidx]->idx[pool->cache[cidx]->len];\n-\t\treturn mlx5_ipool_get_cache(pool, *idx);\n+\t\treturn _mlx5_ipool_get_cache(pool, cidx, *idx);\n \t}\n \t/* Not enough idx in global cache. Keep fetching from global. */\n \t*idx = mlx5_ipool_allocate_from_global(pool, cidx);\n \tif (unlikely(!(*idx)))\n \t\treturn NULL;\n-\treturn mlx5_ipool_get_cache(pool, *idx);\n+\treturn _mlx5_ipool_get_cache(pool, cidx, *idx);\n }\n \n-static void\n-mlx5_ipool_free_cache(struct mlx5_indexed_pool *pool, uint32_t idx)\n+static void *\n+mlx5_ipool_malloc_cache(struct mlx5_indexed_pool *pool, uint32_t *idx)\n {\n+\tvoid *entry;\n \tint cidx;\n+\n+\tcidx = rte_lcore_index(rte_lcore_id());\n+\tif (unlikely(cidx == -1)) {\n+\t\tcidx = RTE_MAX_LCORE;\n+\t\trte_spinlock_lock(&pool->lcore_lock);\n+\t}\n+\tentry = _mlx5_ipool_malloc_cache(pool, cidx, idx);\n+\tif (unlikely(cidx == RTE_MAX_LCORE))\n+\t\trte_spinlock_unlock(&pool->lcore_lock);\n+\treturn entry;\n+}\n+\n+static void\n+_mlx5_ipool_free_cache(struct mlx5_indexed_pool *pool, int cidx, uint32_t idx)\n+{\n \tstruct mlx5_ipool_per_lcore *ilc;\n \tstruct mlx5_indexed_cache *gc, *olc = NULL;\n \tuint32_t reclaim_num = 0;\n \n \tMLX5_ASSERT(idx);\n-\tcidx = rte_lcore_index(rte_lcore_id());\n-\tif (unlikely(cidx == -1)) {\n-\t\trte_errno = ENOTSUP;\n-\t\treturn;\n-\t}\n \t/*\n \t * When index was allocated on core A but freed on core B. In this\n \t * case check if local cache on core B was allocated before.\n@@ -635,6 +653,21 @@ mlx5_ipool_free_cache(struct mlx5_indexed_pool *pool, uint32_t idx)\n \tpool->cache[cidx]->len++;\n }\n \n+static void\n+mlx5_ipool_free_cache(struct mlx5_indexed_pool *pool, uint32_t idx)\n+{\n+\tint cidx;\n+\n+\tcidx = rte_lcore_index(rte_lcore_id());\n+\tif (unlikely(cidx == -1)) {\n+\t\tcidx = RTE_MAX_LCORE;\n+\t\trte_spinlock_lock(&pool->lcore_lock);\n+\t}\n+\t_mlx5_ipool_free_cache(pool, cidx, idx);\n+\tif (unlikely(cidx == RTE_MAX_LCORE))\n+\t\trte_spinlock_unlock(&pool->lcore_lock);\n+}\n+\n void *\n mlx5_ipool_malloc(struct mlx5_indexed_pool *pool, uint32_t *idx)\n {\n@@ -814,7 +847,7 @@ mlx5_ipool_destroy(struct mlx5_indexed_pool *pool)\n \tMLX5_ASSERT(pool);\n \tmlx5_ipool_lock(pool);\n \tif (pool->cfg.per_core_cache) {\n-\t\tfor (i = 0; i < RTE_MAX_LCORE; i++) {\n+\t\tfor (i = 0; i <= RTE_MAX_LCORE; i++) {\n \t\t\t/*\n \t\t\t * Free only old global cache. Pool gc will be\n \t\t\t * freed at last.\n@@ -883,7 +916,7 @@ mlx5_ipool_flush_cache(struct mlx5_indexed_pool *pool)\n \tfor (i = 0; i < gc->len; i++)\n \t\trte_bitmap_clear(ibmp, gc->idx[i] - 1);\n \t/* Clear core cache. */\n-\tfor (i = 0; i < RTE_MAX_LCORE; i++) {\n+\tfor (i = 0; i < RTE_MAX_LCORE + 1; i++) {\n \t\tstruct mlx5_ipool_per_lcore *ilc = pool->cache[i];\n \n \t\tif (!ilc)\ndiff --git a/drivers/net/mlx5/mlx5_utils.h b/drivers/net/mlx5/mlx5_utils.h\nindex 737dd7052d..a509b0a4eb 100644\n--- a/drivers/net/mlx5/mlx5_utils.h\n+++ b/drivers/net/mlx5/mlx5_utils.h\n@@ -248,6 +248,7 @@ struct mlx5_ipool_per_lcore {\n struct mlx5_indexed_pool {\n \tstruct mlx5_indexed_pool_config cfg; /* Indexed pool configuration. */\n \trte_spinlock_t rsz_lock; /* Pool lock for multiple thread usage. */\n+\trte_spinlock_t lcore_lock;\n \t/* Dim of trunk pointer array. */\n \tunion {\n \t\tstruct {\n@@ -259,7 +260,7 @@ struct mlx5_indexed_pool {\n \t\tstruct {\n \t\t\tstruct mlx5_indexed_cache *gc;\n \t\t\t/* Global cache. */\n-\t\t\tstruct mlx5_ipool_per_lcore *cache[RTE_MAX_LCORE];\n+\t\t\tstruct mlx5_ipool_per_lcore *cache[RTE_MAX_LCORE + 1];\n \t\t\t/* Local cache. */\n \t\t\tstruct rte_bitmap *ibmp;\n \t\t\tvoid *bmp_mem;\n", "prefixes": [ "v4", "04/26" ] }