Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/95111/?format=api
{ "id": 95111, "url": "https://patches.dpdk.org/api/patches/95111/?format=api", "web_url": "https://patches.dpdk.org/project/dpdk/patch/20210701093456.43426-1-bruce.richardson@intel.com/", "project": { "id": 1, "url": "https://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20210701093456.43426-1-bruce.richardson@intel.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20210701093456.43426-1-bruce.richardson@intel.com", "date": "2021-07-01T09:34:56", "name": "eal: create runtime dir even when shared data is not used", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": true, "hash": "e37f0604ae665a506c6eb7849322441b276c9750", "submitter": { "id": 20, "url": "https://patches.dpdk.org/api/people/20/?format=api", "name": "Bruce Richardson", "email": "bruce.richardson@intel.com" }, "delegate": { "id": 24651, "url": "https://patches.dpdk.org/api/users/24651/?format=api", "username": "dmarchand", "first_name": "David", "last_name": "Marchand", "email": "david.marchand@redhat.com" }, "mbox": "https://patches.dpdk.org/project/dpdk/patch/20210701093456.43426-1-bruce.richardson@intel.com/mbox/", "series": [ { "id": 17573, "url": "https://patches.dpdk.org/api/series/17573/?format=api", "web_url": "https://patches.dpdk.org/project/dpdk/list/?series=17573", "date": "2021-07-01T09:34:56", "name": "eal: create runtime dir even when shared data is not used", "version": 1, "mbox": "https://patches.dpdk.org/series/17573/mbox/" } ], "comments": "https://patches.dpdk.org/api/patches/95111/comments/", "check": "fail", "checks": "https://patches.dpdk.org/api/patches/95111/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from mails.dpdk.org (mails.dpdk.org [217.70.189.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id 97FB5A0A0C;\n\tThu, 1 Jul 2021 11:35:04 +0200 (CEST)", "from [217.70.189.124] (localhost [127.0.0.1])\n\tby mails.dpdk.org (Postfix) with ESMTP id 6294B40141;\n\tThu, 1 Jul 2021 11:35:04 +0200 (CEST)", "from mga17.intel.com (mga17.intel.com [192.55.52.151])\n by mails.dpdk.org (Postfix) with ESMTP id 61D8040040\n for <dev@dpdk.org>; Thu, 1 Jul 2021 11:35:02 +0200 (CEST)", "from fmsmga005.fm.intel.com ([10.253.24.32])\n by fmsmga107.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384;\n 01 Jul 2021 02:35:01 -0700", "from silpixa00399126.ir.intel.com ([10.237.223.29])\n by fmsmga005.fm.intel.com with ESMTP; 01 Jul 2021 02:35:00 -0700" ], "X-IronPort-AV": [ "E=McAfee;i=\"6200,9189,10031\"; a=\"188888237\"", "E=Sophos;i=\"5.83,313,1616482800\"; d=\"scan'208\";a=\"188888237\"", "E=Sophos;i=\"5.83,313,1616482800\"; d=\"scan'208\";a=\"644389173\"" ], "X-ExtLoop1": "1", "From": "Bruce Richardson <bruce.richardson@intel.com>", "To": "dev@dpdk.org", "Cc": "anatoly.burakov@intel.com,\n\tBruce Richardson <bruce.richardson@intel.com>", "Date": "Thu, 1 Jul 2021 10:34:56 +0100", "Message-Id": "<20210701093456.43426-1-bruce.richardson@intel.com>", "X-Mailer": "git-send-email 2.30.2", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "Subject": "[dpdk-dev] [PATCH] eal: create runtime dir even when shared data is\n not used", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "When multi-process is not wanted and DPDK is run with the \"no-shconf\"\nflag, the telemetry library still needs a runtime directory to place the\nunix socket for telemetry connections. Therefore, rather than not\ncreating the directory when this flag is set, we can change the code to\nattempt the creation anyway, but not error out if it fails. If it\nsucceeds, then telemetry will be available, but if it fails, the rest of\nDPDK will run without telemetry. This ensures that the \"in-memory\" flag\nwill allow DPDK to run even if the whole filesystem is read-only, for\nexample.\n\nSigned-off-by: Bruce Richardson <bruce.richardson@intel.com>\n---\n lib/eal/linux/eal.c | 5 ++---\n 1 file changed, 2 insertions(+), 3 deletions(-)", "diff": "diff --git a/lib/eal/linux/eal.c b/lib/eal/linux/eal.c\nindex ba19fc6347..1e05ba3847 100644\n--- a/lib/eal/linux/eal.c\n+++ b/lib/eal/linux/eal.c\n@@ -838,9 +838,8 @@ eal_parse_args(int argc, char **argv)\n \t\t}\n \t}\n \n-\t/* create runtime data directory */\n-\tif (internal_conf->no_shconf == 0 &&\n-\t\t\teal_create_runtime_dir() < 0) {\n+\t/* create runtime data directory. In no_shconf mode, skip any errors */\n+\tif (eal_create_runtime_dir() < 0 && internal_conf->no_shconf == 0) {\n \t\tRTE_LOG(ERR, EAL, \"Cannot create runtime directory\\n\");\n \t\tret = -1;\n \t\tgoto out;\n", "prefixes": [] }