Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/95051/?format=api
{ "id": 95051, "url": "https://patches.dpdk.org/api/patches/95051/?format=api", "web_url": "https://patches.dpdk.org/project/dpdk/patch/20210630110404.21209-1-mohsin.kazmi14@gmail.com/", "project": { "id": 1, "url": "https://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20210630110404.21209-1-mohsin.kazmi14@gmail.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20210630110404.21209-1-mohsin.kazmi14@gmail.com", "date": "2021-06-30T11:04:04", "name": "[v2] net: prepare the outer ipv4 hdr for checksum", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": true, "hash": "a730030a266cbe80b666c45f43f19340821ed9ab", "submitter": { "id": 2267, "url": "https://patches.dpdk.org/api/people/2267/?format=api", "name": "Mohsin Kazmi", "email": "mohsin.kazmi14@gmail.com" }, "delegate": { "id": 1, "url": "https://patches.dpdk.org/api/users/1/?format=api", "username": "tmonjalo", "first_name": "Thomas", "last_name": "Monjalon", "email": "thomas@monjalon.net" }, "mbox": "https://patches.dpdk.org/project/dpdk/patch/20210630110404.21209-1-mohsin.kazmi14@gmail.com/mbox/", "series": [ { "id": 17546, "url": "https://patches.dpdk.org/api/series/17546/?format=api", "web_url": "https://patches.dpdk.org/project/dpdk/list/?series=17546", "date": "2021-06-30T11:04:04", "name": "[v2] net: prepare the outer ipv4 hdr for checksum", "version": 2, "mbox": "https://patches.dpdk.org/series/17546/mbox/" } ], "comments": "https://patches.dpdk.org/api/patches/95051/comments/", "check": "fail", "checks": "https://patches.dpdk.org/api/patches/95051/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from mails.dpdk.org (mails.dpdk.org [217.70.189.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id 22454A0A0F;\n\tWed, 30 Jun 2021 13:06:11 +0200 (CEST)", "from [217.70.189.124] (localhost [127.0.0.1])\n\tby mails.dpdk.org (Postfix) with ESMTP id 0AA9040141;\n\tWed, 30 Jun 2021 13:06:11 +0200 (CEST)", "from mail-ej1-f54.google.com (mail-ej1-f54.google.com\n [209.85.218.54])\n by mails.dpdk.org (Postfix) with ESMTP id C964A40040;\n Wed, 30 Jun 2021 13:06:09 +0200 (CEST)", "by mail-ej1-f54.google.com with SMTP id gt10so2172467ejc.5;\n Wed, 30 Jun 2021 04:06:09 -0700 (PDT)", "from v6dc-3.cisco.com ([2001:420:44f1:10:225:b5ff:fe52:22])\n by smtp.gmail.com with ESMTPSA id g23sm2939629edp.74.2021.06.30.04.06.08\n (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n Wed, 30 Jun 2021 04:06:09 -0700 (PDT)" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025;\n h=from:to:cc:subject:date:message-id;\n bh=NL2HNGU1az6iLtFEhqIIa7zT2JUmACjSrdOwCaRhJRQ=;\n b=UWkqVQxx6LODAZ1KrIeET2PlhDKCww8fHAdZjgEV5Tj45HtQbyqYlIXXd9MYYmZlpJ\n X+DvkZjqg/iEbRR5mAT4mhbSZWqvU7Q8+xsKwCtx+MlY1Oax6H9LlQoTlY/OC81j96rI\n WH/Y9DZa6UmbfXDH6RwixtK6k/Xs0L/b7duvsdvXEvV5OXROWxaoVOSYsnHkxiPwHWGV\n LIhz+xQhY/CupoCg463h5iOi6FQ7PFrrSU0M3HpeHxvL/jF2MA6/L8YQHyXGXm8FKR2C\n UO4J3mh8WGTvKG/XuXHcdRSCt5wdKhGheMnH7Fe4W/4KwmtbEl+tzccte1VbVT6CZtVJ\n +VKQ==", "X-Google-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=1e100.net; s=20161025;\n h=x-gm-message-state:from:to:cc:subject:date:message-id;\n bh=NL2HNGU1az6iLtFEhqIIa7zT2JUmACjSrdOwCaRhJRQ=;\n b=Auwu48xk06oKGuBr1BiNmBQNo8WjeA7hrWkVk3a2wQY45NYaQMaSebhztL94OSAI8/\n IdNb1cFDswqIU71zeJDT7Rvnia3mmplQKZRZDoZm2SIx8KXWmJuK+aGfpFQTGpsLOy3A\n a1XzI279cSxZtOBe58ISZ2GyYJ2U2H+rZzulIOHAzA89bFw1E8YypU0MWa6dUjEDuXAU\n 3LuWDNPZqR4PLWqQ7NvUTagUFOn/kEiU11vrIEHVyzLJEpaD1uiIhVr1Y2/dFKdaA76Y\n H88xdDnLBJ2Vrl/Euh6wNwIZwP/39V4DlwbCpFWAXxPSqj27UHJSA7a7/bxu9dzN0Ak4\n iVlg==", "X-Gm-Message-State": "AOAM530M+EKip0z5hGHwsvGEFWil4ArDLLeTSj+yV3tibgg8n7WQ9RK2\n XTY/Q4dUakptISiroLYkBFdiJMBPa0vjLmpAALA=", "X-Google-Smtp-Source": "\n ABdhPJydJUto1ZT2DSfUTjRq57Fa0WPB01DE7RnRpLDh74J6QByuS+7iGFhHw32qlDYIHf+Es7B7vQ==", "X-Received": "by 2002:a17:906:ae85:: with SMTP id\n md5mr35042333ejb.93.1625051169282;\n Wed, 30 Jun 2021 04:06:09 -0700 (PDT)", "From": "Mohsin Kazmi <mohsin.kazmi14@gmail.com>", "To": "dev@dpdk.org", "Cc": "ray.kinsella@intel.com, Mohsin Kazmi <mohsin.kazmi14@gmail.com>,\n stable@dpdk.org, Olivier Matz <olivier.matz@6wind.com>,\n Tomasz Kulasek <tomaszx.kulasek@intel.com>,\n Konstantin Ananyev <konstantin.ananyev@intel.com>,\n Thomas Monjalon <thomas.monjalon@6wind.com>", "Date": "Wed, 30 Jun 2021 13:04:04 +0200", "Message-Id": "<20210630110404.21209-1-mohsin.kazmi14@gmail.com>", "X-Mailer": "git-send-email 2.17.1", "Subject": "[dpdk-dev] [PATCH v2] net: prepare the outer ipv4 hdr for checksum", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "Preparation the headers for the hardware offload\nmisses the outer ipv4 checksum offload.\nIt results in bad checksum computed by hardware NIC.\n\nThis patch fixes the issue by setting the outer ipv4\nchecksum field to 0.\n\nFixes: 4fb7e803eb1a (\"ethdev: add Tx preparation\")\nCc: stable@dpdk.org\n\nSigned-off-by: Mohsin Kazmi <mohsin.kazmi14@gmail.com>\nAcked-by: Qi Zhang <qi.z.zhang@intel.com>\n---\n\nv2:\n* Update the commit message with Fixes.\n---\n lib/net/rte_net.h | 12 +++++++++++-\n 1 file changed, 11 insertions(+), 1 deletion(-)", "diff": "diff --git a/lib/net/rte_net.h b/lib/net/rte_net.h\nindex 434435ffa2..e47365099e 100644\n--- a/lib/net/rte_net.h\n+++ b/lib/net/rte_net.h\n@@ -128,8 +128,18 @@ rte_net_intel_cksum_flags_prepare(struct rte_mbuf *m, uint64_t ol_flags)\n \tif (!(ol_flags & (PKT_TX_IP_CKSUM | PKT_TX_L4_MASK | PKT_TX_TCP_SEG)))\n \t\treturn 0;\n \n-\tif (ol_flags & (PKT_TX_OUTER_IPV4 | PKT_TX_OUTER_IPV6))\n+\tif (ol_flags & (PKT_TX_OUTER_IPV4 | PKT_TX_OUTER_IPV6)) {\n \t\tinner_l3_offset += m->outer_l2_len + m->outer_l3_len;\n+\t\t/*\n+\t\t * prepare outer ipv4 header checksum by setting it to 0,\n+\t\t * in order to be computed by hardware NICs.\n+\t\t */\n+\t\tif (ol_flags & PKT_TX_OUTER_IP_CKSUM) {\n+\t\t\tipv4_hdr = rte_pktmbuf_mtod_offset(m,\n+\t\t\t\t\tstruct rte_ipv4_hdr *, m->outer_l2_len);\n+\t\t\tipv4_hdr->hdr_checksum = 0;\n+\t\t}\n+\t}\n \n \t/*\n \t * Check if headers are fragmented.\n", "prefixes": [ "v2" ] }