Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/94874/?format=api
{ "id": 94874, "url": "https://patches.dpdk.org/api/patches/94874/?format=api", "web_url": "https://patches.dpdk.org/project/dts/patch/1624647032-22230-1-git-send-email-pvukkisala@marvell.com/", "project": { "id": 3, "url": "https://patches.dpdk.org/api/projects/3/?format=api", "name": "DTS", "link_name": "dts", "list_id": "dts.dpdk.org", "list_email": "dts@dpdk.org", "web_url": "", "scm_url": "git://dpdk.org/tools/dts", "webscm_url": "http://git.dpdk.org/tools/dts/", "list_archive_url": "https://inbox.dpdk.org/dts", "list_archive_url_format": "https://inbox.dpdk.org/dts/{}", "commit_url_format": "" }, "msgid": "<1624647032-22230-1-git-send-email-pvukkisala@marvell.com>", "list_archive_url": "https://inbox.dpdk.org/dts/1624647032-22230-1-git-send-email-pvukkisala@marvell.com", "date": "2021-06-25T18:50:32", "name": "hotplug.py: Change expected output to testpmd prompt.", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": false, "hash": "e73ec148933c2db54315188b888413ceb2d2bd6c", "submitter": { "id": 1538, "url": "https://patches.dpdk.org/api/people/1538/?format=api", "name": "Phanendra Vukkisala", "email": "pvukkisala@marvell.com" }, "delegate": null, "mbox": "https://patches.dpdk.org/project/dts/patch/1624647032-22230-1-git-send-email-pvukkisala@marvell.com/mbox/", "series": [ { "id": 17492, "url": "https://patches.dpdk.org/api/series/17492/?format=api", "web_url": "https://patches.dpdk.org/project/dts/list/?series=17492", "date": "2021-06-25T18:50:32", "name": "hotplug.py: Change expected output to testpmd prompt.", "version": 1, "mbox": "https://patches.dpdk.org/series/17492/mbox/" } ], "comments": "https://patches.dpdk.org/api/patches/94874/comments/", "check": "pending", "checks": "https://patches.dpdk.org/api/patches/94874/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dts-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from mails.dpdk.org (mails.dpdk.org [217.70.189.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id CA7D7A0547;\n\tFri, 25 Jun 2021 20:51:05 +0200 (CEST)", "from [217.70.189.124] (localhost [127.0.0.1])\n\tby mails.dpdk.org (Postfix) with ESMTP id 7CBA740698;\n\tFri, 25 Jun 2021 20:51:05 +0200 (CEST)", "from mx0b-0016f401.pphosted.com (mx0a-0016f401.pphosted.com\n [67.231.148.174])\n by mails.dpdk.org (Postfix) with ESMTP id 29FD84068A\n for <dts@dpdk.org>; Fri, 25 Jun 2021 20:51:03 +0200 (CEST)", "from pps.filterd (m0045849.ppops.net [127.0.0.1])\n by mx0a-0016f401.pphosted.com (8.16.0.43/8.16.0.43) with SMTP id\n 15PIl94E022514 for <dts@dpdk.org>; Fri, 25 Jun 2021 11:51:03 -0700", "from dc5-exch01.marvell.com ([199.233.59.181])\n by mx0a-0016f401.pphosted.com with ESMTP id 39d24dm1uk-1\n (version=TLSv1.2 cipher=ECDHE-RSA-AES256-SHA384 bits=256 verify=NOT)\n for <dts@dpdk.org>; Fri, 25 Jun 2021 11:51:03 -0700", "from DC5-EXCH01.marvell.com (10.69.176.38) by DC5-EXCH01.marvell.com\n (10.69.176.38) with Microsoft SMTP Server (TLS) id 15.0.1497.18;\n Fri, 25 Jun 2021 11:51:01 -0700", "from maili.marvell.com (10.69.176.80) by DC5-EXCH01.marvell.com\n (10.69.176.38) with Microsoft SMTP Server id 15.0.1497.18 via Frontend\n Transport; Fri, 25 Jun 2021 11:51:01 -0700", "from phanendra-system.marvell.com (phanendra-system.marvell.com\n [10.28.8.78])\n by maili.marvell.com (Postfix) with ESMTP id 830D63F7060;\n Fri, 25 Jun 2021 11:51:00 -0700 (PDT)" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed; d=marvell.com;\n h=from : to : cc :\n subject : date : message-id : mime-version : content-type; s=pfpt0220;\n bh=dYCU/pl+Ju7x/POqeQSkCyxamQf8WjRkEDqH9bCmLBM=;\n b=VQSG2KVUQUkbLGHszMkSS/AF0cCr7IIf0Ory+qYhVNEiwQixIipenEgtImupQ7sjFaVK\n FfEBAG2EhVih2u34Ilxrry3snJyecUaVeCdbW8NbOVxC/yUfZK0vohLNi4Z27/ZamHjA\n HOJA9OqPvJ+Lty6cY46tW3ClwjdIjBhY3m+uzVgQ+RMKJa5lhb0r39gHZ0jqKy5caG8t\n eqn9ZGZE6ZgLBRbihqo3BQgr4v9hsvIX3KL+OR3YksXwX0EaFiKVetK9c17qiSotcIvo\n usZmjN7gu67K5VSxXb+Fd5pilFhhq5j/S8bob2CMTYlot8e2vjBeYTgxZp6tjO2ixvqm 9A==", "From": "<pvukkisala@marvell.com>", "To": "<dts@dpdk.org>", "CC": "<sshankarnara@marvell.com>, Phanendra Vukkisala <pvukkisala@marvell.com>", "Date": "Sat, 26 Jun 2021 00:20:32 +0530", "Message-ID": "<1624647032-22230-1-git-send-email-pvukkisala@marvell.com>", "X-Mailer": "git-send-email 1.7.9.5", "MIME-Version": "1.0", "Content-Type": "text/plain", "X-Proofpoint-GUID": "RNy2BFQTCPmcGAVxkUDNvJam5Hsx6PNw", "X-Proofpoint-ORIG-GUID": "RNy2BFQTCPmcGAVxkUDNvJam5Hsx6PNw", "X-Proofpoint-Virus-Version": "vendor=fsecure engine=2.50.10434:6.0.391, 18.0.790\n definitions=2021-06-25_07:2021-06-25,\n 2021-06-25 signatures=0", "Subject": "[dts] [PATCH] hotplug.py: Change expected output to testpmd prompt.", "X-BeenThere": "dts@dpdk.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "test suite reviews and discussions <dts.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dts>,\n <mailto:dts-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dts/>", "List-Post": "<mailto:dts@dpdk.org>", "List-Help": "<mailto:dts-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dts>,\n <mailto:dts-request@dpdk.org?subject=subscribe>", "Errors-To": "dts-bounces@dpdk.org", "Sender": "\"dts\" <dts-bounces@dpdk.org>" }, "content": "From: Phanendra Vukkisala <pvukkisala@marvell.com>\n\nDue to not having testpmd as expected prompt, show port stats gets old output\ncausing test failure\n\nSigned-off-by: Phanendra Vukkisala <pvukkisala@marvell.com>\n---\n tests/TestSuite_hotplug.py | 27 ++++++++++++++++++---------\n 1 file changed, 18 insertions(+), 9 deletions(-)", "diff": "diff --git a/tests/TestSuite_hotplug.py b/tests/TestSuite_hotplug.py\nindex f40c291..bb31a9d 100644\n--- a/tests/TestSuite_hotplug.py\n+++ b/tests/TestSuite_hotplug.py\n@@ -75,8 +75,10 @@ class TestPortHotPlug(TestCase):\n attach port\n \"\"\"\n # dpdk hotplug discern NIC by pci bus and include domid\n- self.dut.send_expect(\"port attach %s\" % self.dut.ports_info[port]['pci'], \"is attached\", 60)\n- self.dut.send_expect(\"port start %s\" % port, \"Configuring Port\", 120)\n+ out = self.dut.send_expect(\"port attach %s\" % self.dut.ports_info[port]['pci'], \"testpmd>\", 60)\n+ self.verify(\"is attached\" in out, \"Failed to attach\")\n+ out = self.dut.send_expect(\"port start %s\" % port, \"testpmd>\", 120)\n+ self.verify(\"Configuring Port\" in out, \"Failed to start port\")\n # sleep 10 seconds for fortville update link stats\n time.sleep(10)\n self.dut.send_expect(\"show port info %s\" % port, \"testpmd>\", 60)\n@@ -85,10 +87,12 @@ class TestPortHotPlug(TestCase):\n \"\"\"\n detach port\n \"\"\"\n- self.dut.send_expect(\"port stop %s\" % port, \"Stopping ports\", 60)\n+ out = self.dut.send_expect(\"port stop %s\" % port, \"testpmd>\", 60)\n+ self.verify(\"Stopping ports\" in out, \"Failed to stop port\")\n # sleep 10 seconds for fortville update link stats\n time.sleep(10)\n- self.dut.send_expect(\"port detach %s\" % port, \"is detached\", 60)\n+ out = self.dut.send_expect(\"port detach %s\" % port, \"testpmd>\", 60)\n+ self.verify(\"is detached\" in out, \"Failed to detach port\")\n \n def test_after_attach(self):\n \"\"\"\n@@ -103,13 +107,15 @@ class TestPortHotPlug(TestCase):\n self.dut.close_session(session_secondary)\n self.attach(self.port)\n self.dut.send_expect(\"start\", \"testpmd>\", 60)\n- self.dut.send_expect(\"port detach %s\" % self.port, \"Port not stopped\", 60)\n+ out = self.dut.send_expect(\"port detach %s\" % self.port, \"testpmd>\", 60)\n+ self.verify(\"Port not stopped\" in out, \"able to detach port without stopping\")\n self.dut.send_expect(\"stop\", \"testpmd>\", 60)\n self.detach(self.port)\n self.attach(self.port)\n \n self.dut.send_expect(\"start\", \"testpmd>\", 60)\n- self.dut.send_expect(\"port detach %s\" % self.port, \"Port not stopped\", 60)\n+ out = self.dut.send_expect(\"port detach %s\" % self.port, \"testpmd>\", 60)\n+ self.verify(\"Port not stopped\" in out, \"able to detach port without stopping\")\n self.dut.send_expect(\"clear port stats %s\" % self.port, \"testpmd>\", 60)\n self.send_packet(self.port)\n out = self.dut.send_expect(\"show port stats %s\" % self.port, \"testpmd>\", 60)\n@@ -144,7 +150,8 @@ class TestPortHotPlug(TestCase):\n self.attach(self.port)\n \n self.dut.send_expect(\"start\", \"testpmd>\", 60)\n- self.dut.send_expect(\"port detach %s\" % self.port, \"Port not stopped\", 60)\n+ out = self.dut.send_expect(\"port detach %s\" % self.port, \"testpmd>\", 60)\n+ self.verify(\"Port not stopped\" in out, \"able to detach port without stopping\")\n self.dut.send_expect(\"clear port stats %s\" % self.port, \"testpmd>\", 60)\n self.send_packet(self.port)\n out = self.dut.send_expect(\"show port stats %s\" % self.port, \"testpmd>\", 60)\n@@ -165,12 +172,14 @@ class TestPortHotPlug(TestCase):\n testpmd_cmd = \"%s \" % self.path + eal_param + ' -- -i'\n self.dut.send_expect(testpmd_cmd, \"testpmd>\", timeout=60)\n self.dut.send_expect(\"port stop 0\", \"testpmd>\")\n- self.dut.send_expect(\"port detach 0\", \"Device is detached\")\n+ out = self.dut.send_expect(\"port detach 0\", \"testpmd>\")\n+ self.verify(\"Device is detached\" in out, \"Failed to detach\")\n stats = self.dut.send_expect(\"ls %s\" % path, \"#\", timeout=3,\n alt_session=True, verify=True)\n self.verify(stats == 2, 'port detach failed')\n time.sleep(1)\n- self.dut.send_expect(\"port attach eth_vhost1,iface=%s,queues=1\" % iface, \"Port 0 is attached.\")\n+ out = self.dut.send_expect(\"port attach eth_vhost1,iface=%s,queues=1\" % iface, \"testpmd>\")\n+ self.verify(\"Port 0 is attached.\" in out, \"Failed to attach\")\n self.dut.send_expect(\"port start 0\", \"testpmd>\")\n out = self.dut.send_expect(\"ls %s\" % path, \"#\", timeout=3,\n alt_session=True, verify=True)\n", "prefixes": [] }