Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/94801/?format=api
{ "id": 94801, "url": "https://patches.dpdk.org/api/patches/94801/?format=api", "web_url": "https://patches.dpdk.org/project/dpdk/patch/20210624152802.40249-1-mohsin.kazmi14@gmail.com/", "project": { "id": 1, "url": "https://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20210624152802.40249-1-mohsin.kazmi14@gmail.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20210624152802.40249-1-mohsin.kazmi14@gmail.com", "date": "2021-06-24T15:28:02", "name": "net: prepare the outer ipv4 hdr for checksum", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": true, "hash": "a730030a266cbe80b666c45f43f19340821ed9ab", "submitter": { "id": 2267, "url": "https://patches.dpdk.org/api/people/2267/?format=api", "name": "Mohsin Kazmi", "email": "mohsin.kazmi14@gmail.com" }, "delegate": null, "mbox": "https://patches.dpdk.org/project/dpdk/patch/20210624152802.40249-1-mohsin.kazmi14@gmail.com/mbox/", "series": [ { "id": 17479, "url": "https://patches.dpdk.org/api/series/17479/?format=api", "web_url": "https://patches.dpdk.org/project/dpdk/list/?series=17479", "date": "2021-06-24T15:28:02", "name": "net: prepare the outer ipv4 hdr for checksum", "version": 1, "mbox": "https://patches.dpdk.org/series/17479/mbox/" } ], "comments": "https://patches.dpdk.org/api/patches/94801/comments/", "check": "success", "checks": "https://patches.dpdk.org/api/patches/94801/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from mails.dpdk.org (mails.dpdk.org [217.70.189.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id 8EDC2A0547;\n\tThu, 24 Jun 2021 17:30:06 +0200 (CEST)", "from [217.70.189.124] (localhost [127.0.0.1])\n\tby mails.dpdk.org (Postfix) with ESMTP id 1227240040;\n\tThu, 24 Jun 2021 17:30:06 +0200 (CEST)", "from mail-ej1-f46.google.com (mail-ej1-f46.google.com\n [209.85.218.46]) by mails.dpdk.org (Postfix) with ESMTP id 519514003C\n for <dev@dpdk.org>; Thu, 24 Jun 2021 17:30:05 +0200 (CEST)", "by mail-ej1-f46.google.com with SMTP id hq39so10184083ejc.5\n for <dev@dpdk.org>; Thu, 24 Jun 2021 08:30:05 -0700 (PDT)", "from v6dc-3.cisco.com ([2001:420:44f1:10:225:b5ff:fe52:22])\n by smtp.gmail.com with ESMTPSA id ar14sm1335329ejc.108.2021.06.24.08.30.04\n (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n Thu, 24 Jun 2021 08:30:04 -0700 (PDT)" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025;\n h=from:to:cc:subject:date:message-id;\n bh=edAU+lNVA949xjpeI/qSuwYSFC4GuWIx7durhr5zFoo=;\n b=b91M07MxAGQEvNub9VnrnaS3Y5W7j8ToH3zXPuRgX5alwECQPaeu4UrywFi0H6qAwX\n 10qPLav4bOU9NrJ2j1sxPkgexMZVCMnKgWVLd3nquNzhoNi/EKUVgGbkdEDX2EEzQwQq\n 8l7rSp1Ttq+/hQyquyvoDjpX2rlonfxd/CP4jZvMXUW/OxHCTOcxkuw0b0rWbSJgIg0o\n qEyJBQyOtd+v6KY8C4A63mhAv25cZHmjRMcGnSbie5OqfZ8VF1NnY9ndObQ6vyNS+lBP\n Mfby0ZCRfxmf02RKXoH2vDAT2O+Yoxz/MnxMV4Gk3w9aGNXOsjfTSBJKauIW44tAYO0l\n JChQ==", "X-Google-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=1e100.net; s=20161025;\n h=x-gm-message-state:from:to:cc:subject:date:message-id;\n bh=edAU+lNVA949xjpeI/qSuwYSFC4GuWIx7durhr5zFoo=;\n b=l4SoF23sRHrcUZXlwvMTTFMgeh25nxZhG6gxK2Wij4oCUMdxvPamMWyxo2KSnw7SRH\n 9INiK4rE+sm4RmN4MRN5q9QMXvXS6H/KBCCnJsT71ENwF3YgbXWjjhgcvBgl2JlWGdCF\n jqYvBtFqGpfM+bko2kLShlMsmtvi1cp/yfgA6Dnk0JyNCrpmFz1vivhrDKfaJZYtTeMi\n jwwZl29gOxhSxW/H4N9U4UG0Upt8tmXyX0SQScDKzHEiH/BsrAFn8yPpHzcxRwDx/Xim\n vsF2IP6T6ah68QgkYuVTB0Ksc6sfHMKf0HN0FhwJaz1gMPfPw2EmYn1tOIlzKhAcDheQ\n TQBA==", "X-Gm-Message-State": "AOAM531MrFp6L05IXUPmtzk8SueExM2pSJFLurGGLjugOIYf71sfFCTC\n 5vDE0EdWzGNIH3V+Ugs8nCZKQrpA3v/zhW+dD/6O2xZQ", "X-Google-Smtp-Source": "\n ABdhPJxRRPaTVP0r8FTZyzqj3ypAfyn9EGB6WWvHzvih/ZLW+yODQSmyjap7qdPXzbuw+gabyBhWlA==", "X-Received": "by 2002:a17:907:264c:: with SMTP id\n ar12mr5843862ejc.391.1624548604820;\n Thu, 24 Jun 2021 08:30:04 -0700 (PDT)", "From": "Mohsin Kazmi <mohsin.kazmi14@gmail.com>", "To": "dev@dpdk.org", "Cc": "Mohsin Kazmi <mohsin.kazmi14@gmail.com>, ray.kinsella@intel.com,\n Olivier Matz <olivier.matz@6wind.com>", "Date": "Thu, 24 Jun 2021 17:28:02 +0200", "Message-Id": "<20210624152802.40249-1-mohsin.kazmi14@gmail.com>", "X-Mailer": "git-send-email 2.17.1", "Subject": "[dpdk-dev] [PATCH] net: prepare the outer ipv4 hdr for checksum", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "Preparation the headers for the hardware offload\nmisses the outer ipv4 checksum offload.\nIt results in bad checksum computed by hardware NIC.\n\nThis patch fixes the issue by setting the outer ipv4\nchecksum field to 0.\n\nCc: ray.kinsella@intel.com\n\nSigned-off-by: Mohsin Kazmi <mohsin.kazmi14@gmail.com>\n---\n lib/net/rte_net.h | 12 +++++++++++-\n 1 file changed, 11 insertions(+), 1 deletion(-)", "diff": "diff --git a/lib/net/rte_net.h b/lib/net/rte_net.h\nindex 434435ffa2..e47365099e 100644\n--- a/lib/net/rte_net.h\n+++ b/lib/net/rte_net.h\n@@ -128,8 +128,18 @@ rte_net_intel_cksum_flags_prepare(struct rte_mbuf *m, uint64_t ol_flags)\n \tif (!(ol_flags & (PKT_TX_IP_CKSUM | PKT_TX_L4_MASK | PKT_TX_TCP_SEG)))\n \t\treturn 0;\n \n-\tif (ol_flags & (PKT_TX_OUTER_IPV4 | PKT_TX_OUTER_IPV6))\n+\tif (ol_flags & (PKT_TX_OUTER_IPV4 | PKT_TX_OUTER_IPV6)) {\n \t\tinner_l3_offset += m->outer_l2_len + m->outer_l3_len;\n+\t\t/*\n+\t\t * prepare outer ipv4 header checksum by setting it to 0,\n+\t\t * in order to be computed by hardware NICs.\n+\t\t */\n+\t\tif (ol_flags & PKT_TX_OUTER_IP_CKSUM) {\n+\t\t\tipv4_hdr = rte_pktmbuf_mtod_offset(m,\n+\t\t\t\t\tstruct rte_ipv4_hdr *, m->outer_l2_len);\n+\t\t\tipv4_hdr->hdr_checksum = 0;\n+\t\t}\n+\t}\n \n \t/*\n \t * Check if headers are fragmented.\n", "prefixes": [] }