Patch Detail

HTTP 200 OK
Allow: GET, PUT, PATCH, HEAD, OPTIONS
Content-Type: application/json
Vary: Accept

{
    "id": 94782,
    "url": "https://patches.dpdk.org/api/patches/94782/?format=api",
    "web_url": "https://patches.dpdk.org/project/dpdk/patch/1624487698-31136-7-git-send-email-jizh@linux.microsoft.com/",
    "project": {
        "id": 1,
        "url": "https://patches.dpdk.org/api/projects/1/?format=api",
        "name": "DPDK",
        "link_name": "dpdk",
        "list_id": "dev.dpdk.org",
        "list_email": "dev@dpdk.org",
        "web_url": "http://core.dpdk.org",
        "scm_url": "git://dpdk.org/dpdk",
        "webscm_url": "http://git.dpdk.org/dpdk",
        "list_archive_url": "https://inbox.dpdk.org/dev",
        "list_archive_url_format": "https://inbox.dpdk.org/dev/{}",
        "commit_url_format": ""
    },
    "msgid": "<1624487698-31136-7-git-send-email-jizh@linux.microsoft.com>",
    "list_archive_url": "https://inbox.dpdk.org/dev/1624487698-31136-7-git-send-email-jizh@linux.microsoft.com",
    "date": "2021-06-23T22:34:55",
    "name": "[v14,6/9] app/testpmd: fix parse_fec_mode return type name",
    "commit_ref": null,
    "pull_url": null,
    "state": "superseded",
    "archived": true,
    "hash": "c569a8df1c6a2d07664c7b953eaf67a30fc1e9b9",
    "submitter": {
        "id": 1934,
        "url": "https://patches.dpdk.org/api/people/1934/?format=api",
        "name": "Jie Zhou",
        "email": "jizh@linux.microsoft.com"
    },
    "delegate": {
        "id": 3961,
        "url": "https://patches.dpdk.org/api/users/3961/?format=api",
        "username": "arybchenko",
        "first_name": "Andrew",
        "last_name": "Rybchenko",
        "email": "andrew.rybchenko@oktetlabs.ru"
    },
    "mbox": "https://patches.dpdk.org/project/dpdk/patch/1624487698-31136-7-git-send-email-jizh@linux.microsoft.com/mbox/",
    "series": [
        {
            "id": 17465,
            "url": "https://patches.dpdk.org/api/series/17465/?format=api",
            "web_url": "https://patches.dpdk.org/project/dpdk/list/?series=17465",
            "date": "2021-06-23T22:34:50",
            "name": "app/testpmd: enable testpmd on Windows",
            "version": 14,
            "mbox": "https://patches.dpdk.org/series/17465/mbox/"
        }
    ],
    "comments": "https://patches.dpdk.org/api/patches/94782/comments/",
    "check": "success",
    "checks": "https://patches.dpdk.org/api/patches/94782/checks/",
    "tags": {},
    "related": [],
    "headers": {
        "Return-Path": "<dev-bounces@dpdk.org>",
        "X-Original-To": "patchwork@inbox.dpdk.org",
        "Delivered-To": "patchwork@inbox.dpdk.org",
        "Received": [
            "from mails.dpdk.org (mails.dpdk.org [217.70.189.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id AB743A0C41;\n\tThu, 24 Jun 2021 00:35:40 +0200 (CEST)",
            "from [217.70.189.124] (localhost [127.0.0.1])\n\tby mails.dpdk.org (Postfix) with ESMTP id 3EED541172;\n\tThu, 24 Jun 2021 00:35:13 +0200 (CEST)",
            "from linux.microsoft.com (linux.microsoft.com [13.77.154.182])\n by mails.dpdk.org (Postfix) with ESMTP id BFEE64003C;\n Thu, 24 Jun 2021 00:35:05 +0200 (CEST)",
            "from\n linuxonhyperv3.guj3yctzbm1etfxqx2vob5hsef.xx.internal.cloudapp.net\n (linux.microsoft.com [13.77.154.182])\n by linux.microsoft.com (Postfix) with ESMTPSA id C507B20B83F5;\n Wed, 23 Jun 2021 15:35:04 -0700 (PDT)"
        ],
        "DKIM-Filter": "OpenDKIM Filter v2.11.0 linux.microsoft.com C507B20B83F5",
        "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.microsoft.com;\n s=default; t=1624487704;\n bh=OcVp/XratC6K1oPIKPHAwL6AROu67uj1fHFEF5u1bLw=;\n h=From:To:Cc:Subject:Date:In-Reply-To:References:From;\n b=rWsHRy23M21qDXpR+us9IyV+LpCUO21b1afckgIP1qz1Cv7YmPHeC3cqpnnh2Hd2V\n 7VN0UxL9Lgs8TUHLxzmFkmChB83xBQ5GGVxqhgqaEfIfSE9oq6J4aon9xUGG4hiLu0\n AghuTAtOkRpok5zkn0hexc7oGpskhMvo9VGTiyOM=",
        "From": "Jie Zhou <jizh@linux.microsoft.com>",
        "To": "dev@dpdk.org",
        "Cc": "dmitry.kozliuk@gmail.com, xiaoyun.li@intel.com, roretzla@microsoft.com,\n talshn@nvidia.com, pallavi.kadam@intel.com, andrew.rybchenko@oktetlabs.ru,\n thomas@monjalon.net, bruce.richardson@intel.com, ferruh.yigit@intel.com,\n konstantin.ananyev@intel.com, stable@dpdk.org",
        "Date": "Wed, 23 Jun 2021 15:34:55 -0700",
        "Message-Id": "<1624487698-31136-7-git-send-email-jizh@linux.microsoft.com>",
        "X-Mailer": "git-send-email 1.8.3.1",
        "In-Reply-To": "<1624487698-31136-1-git-send-email-jizh@linux.microsoft.com>",
        "References": "<1620241931-28435-1-git-send-email-jizh@linux.microsoft.com>\n <1624487698-31136-1-git-send-email-jizh@linux.microsoft.com>",
        "Subject": "[dpdk-dev] [PATCH v14 6/9] app/testpmd: fix parse_fec_mode return\n type name",
        "X-BeenThere": "dev@dpdk.org",
        "X-Mailman-Version": "2.1.29",
        "Precedence": "list",
        "List-Id": "DPDK patches and discussions <dev.dpdk.org>",
        "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>",
        "List-Archive": "<http://mails.dpdk.org/archives/dev/>",
        "List-Post": "<mailto:dev@dpdk.org>",
        "List-Help": "<mailto:dev-request@dpdk.org?subject=help>",
        "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>",
        "Errors-To": "dev-bounces@dpdk.org",
        "Sender": "\"dev\" <dev-bounces@dpdk.org>"
    },
    "content": "Replace parse_fec_mode misleading return type name mode with fec_capa\n\nFixes: b19da32e3151 (\"app/testpmd: add FEC command\")\nCc: stable@dpdk.org\n\nSigned-off-by: Jie Zhou <jizh@microsoft.com>\nSigned-off-by: Jie Zhou <jizh@linux.microsoft.com>\n---\n app/test-pmd/cmdline.c | 6 +++---\n app/test-pmd/config.c  | 4 ++--\n app/test-pmd/testpmd.h | 2 +-\n 3 files changed, 6 insertions(+), 6 deletions(-)",
    "diff": "diff --git a/app/test-pmd/cmdline.c b/app/test-pmd/cmdline.c\nindex 0268b18f95..dff5a75ec5 100644\n--- a/app/test-pmd/cmdline.c\n+++ b/app/test-pmd/cmdline.c\n@@ -16997,17 +16997,17 @@ cmd_set_port_fec_mode_parsed(\n {\n \tstruct cmd_set_port_fec_mode *res = parsed_result;\n \tuint16_t port_id = res->port_id;\n-\tuint32_t mode;\n+\tuint32_t fec_capa;\n \tint ret;\n \n-\tret = parse_fec_mode(res->fec_value, &mode);\n+\tret = parse_fec_mode(res->fec_value, &fec_capa);\n \tif (ret < 0) {\n \t\tprintf(\"Unknown fec mode: %s for Port %d\\n\", res->fec_value,\n \t\t\tport_id);\n \t\treturn;\n \t}\n \n-\tret = rte_eth_fec_set(port_id, mode);\n+\tret = rte_eth_fec_set(port_id, fec_capa);\n \tif (ret == -ENOTSUP) {\n \t\tprintf(\"Function not implemented\\n\");\n \t\treturn;\ndiff --git a/app/test-pmd/config.c b/app/test-pmd/config.c\nindex 43c79b5021..79526796e9 100644\n--- a/app/test-pmd/config.c\n+++ b/app/test-pmd/config.c\n@@ -3617,13 +3617,13 @@ set_tx_pkt_split(const char *name)\n }\n \n int\n-parse_fec_mode(const char *name, uint32_t *mode)\n+parse_fec_mode(const char *name, uint32_t *fec_capa)\n {\n \tuint8_t i;\n \n \tfor (i = 0; i < RTE_DIM(fec_mode_name); i++) {\n \t\tif (strcmp(fec_mode_name[i].name, name) == 0) {\n-\t\t\t*mode = RTE_ETH_FEC_MODE_TO_CAPA(fec_mode_name[i].mode);\n+\t\t\t*fec_capa = RTE_ETH_FEC_MODE_TO_CAPA(fec_mode_name[i].mode);\n \t\t\treturn 0;\n \t\t}\n \t}\ndiff --git a/app/test-pmd/testpmd.h b/app/test-pmd/testpmd.h\nindex 283b5e3680..9ae4d90dd1 100644\n--- a/app/test-pmd/testpmd.h\n+++ b/app/test-pmd/testpmd.h\n@@ -885,7 +885,7 @@ void show_tx_pkt_segments(void);\n void set_tx_pkt_times(unsigned int *tx_times);\n void show_tx_pkt_times(void);\n void set_tx_pkt_split(const char *name);\n-int parse_fec_mode(const char *name, enum rte_eth_fec_mode *mode);\n+int parse_fec_mode(const char *name, uint32_t *fec_capa);\n void show_fec_capability(uint32_t num, struct rte_eth_fec_capa *speed_fec_capa);\n void set_nb_pkt_per_burst(uint16_t pkt_burst);\n char *list_pkt_forwarding_modes(void);\n",
    "prefixes": [
        "v14",
        "6/9"
    ]
}