Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/94587/?format=api
{ "id": 94587, "url": "https://patches.dpdk.org/api/patches/94587/?format=api", "web_url": "https://patches.dpdk.org/project/dpdk/patch/20210621063708.4014937-14-robinx.zhang@intel.com/", "project": { "id": 1, "url": "https://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20210621063708.4014937-14-robinx.zhang@intel.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20210621063708.4014937-14-robinx.zhang@intel.com", "date": "2021-06-21T06:37:07", "name": "[v2,13/14] net/i40e/base: fix potentially uninitialized variables in NVM code", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": true, "hash": "8cc99a17bb1ac7a9af56a96f6d703574b4b905db", "submitter": { "id": 2004, "url": "https://patches.dpdk.org/api/people/2004/?format=api", "name": "Robin Zhang", "email": "robinx.zhang@intel.com" }, "delegate": null, "mbox": "https://patches.dpdk.org/project/dpdk/patch/20210621063708.4014937-14-robinx.zhang@intel.com/mbox/", "series": [ { "id": 17414, "url": "https://patches.dpdk.org/api/series/17414/?format=api", "web_url": "https://patches.dpdk.org/project/dpdk/list/?series=17414", "date": "2021-06-21T06:36:54", "name": "i40e base code update", "version": 2, "mbox": "https://patches.dpdk.org/series/17414/mbox/" } ], "comments": "https://patches.dpdk.org/api/patches/94587/comments/", "check": "success", "checks": "https://patches.dpdk.org/api/patches/94587/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from mails.dpdk.org (mails.dpdk.org [217.70.189.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id 1187EA0547;\n\tMon, 21 Jun 2021 08:47:39 +0200 (CEST)", "from [217.70.189.124] (localhost [127.0.0.1])\n\tby mails.dpdk.org (Postfix) with ESMTP id E3D5441169;\n\tMon, 21 Jun 2021 08:47:12 +0200 (CEST)", "from mga07.intel.com (mga07.intel.com [134.134.136.100])\n by mails.dpdk.org (Postfix) with ESMTP id 7EF0D41159;\n Mon, 21 Jun 2021 08:47:10 +0200 (CEST)", "from orsmga001.jf.intel.com ([10.7.209.18])\n by orsmga105.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384;\n 20 Jun 2021 23:47:10 -0700", "from unknown (HELO intel-npg-odc-srv03.cd.intel.com)\n ([10.240.178.145])\n by orsmga001-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384;\n 20 Jun 2021 23:47:08 -0700" ], "IronPort-SDR": [ "\n 7FjmokSQhpTr9dzda5qySDuWhGVYGHV4IzNEGmHAT22zZqKpTd4UnKQ6KoAwl/HYs9R1CLF+Wf\n 6xnCfC8IvDLw==", "\n gHxWvQoSTs9kR1eBCuO3OdHHh0406k2dKWh31155WOQe6lLUswgFx8XAq1m1myCixaFoopyIgY\n TJ/RgcXUqEig==" ], "X-IronPort-AV": [ "E=McAfee;i=\"6200,9189,10021\"; a=\"270633648\"", "E=Sophos;i=\"5.83,289,1616482800\"; d=\"scan'208\";a=\"270633648\"", "E=Sophos;i=\"5.83,289,1616482800\"; d=\"scan'208\";a=\"486380621\"" ], "From": "Robin Zhang <robinx.zhang@intel.com>", "To": "dev@dpdk.org", "Cc": "beilei.xing@intel.com, junfeng.guo@intel.com, stevex.yang@intel.com,\n Robin Zhang <robinx.zhang@intel.com>, stable@dpdk.org,\n Christopher Pau <christopher.pau@intel.com>", "Date": "Mon, 21 Jun 2021 06:37:07 +0000", "Message-Id": "<20210621063708.4014937-14-robinx.zhang@intel.com>", "X-Mailer": "git-send-email 2.25.1", "In-Reply-To": "<20210621063708.4014937-1-robinx.zhang@intel.com>", "References": "<20210618063851.3694702-1-robinx.zhang@intel.com>\n <20210621063708.4014937-1-robinx.zhang@intel.com>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "Subject": "[dpdk-dev] [PATCH v2 13/14] net/i40e/base: fix potentially\n uninitialized variables in NVM code", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "The status of i40e_read_nvm_word is not checked, so variables set\nfrom this function could be used uninitialized. In this case, preserve\nthe existing flow that does not block initialization by initializing\nthese values from the start.\n\nThe variable checksum from i40e_calc_nvm_checksum is used before return\nvalue is checked. Fix this logic.\n\nFixes: 8d6c51fcd24b (\"i40e/base: get OEM version\")\nFixes: 2db70574247b (\"net/i40e/base: limit PF/VF specific code to that driver only\")\nFixes: 8db9e2a1b232 (\"i40e: base driver\")\nFixes: 3ed6c3246f43 (\"i40e/base: handle AQ timeout when releasing NVM\")\nCc: stable@dpdk.org\n\nSigned-off-by: Christopher Pau <christopher.pau@intel.com>\nSigned-off-by: Robin Zhang <robinx.zhang@intel.com>\n---\n drivers/net/i40e/base/i40e_adminq.c | 6 ++++--\n drivers/net/i40e/base/i40e_nvm.c | 5 +++--\n 2 files changed, 7 insertions(+), 4 deletions(-)", "diff": "diff --git a/drivers/net/i40e/base/i40e_adminq.c b/drivers/net/i40e/base/i40e_adminq.c\nindex eafacbdbec..d27ccde29a 100644\n--- a/drivers/net/i40e/base/i40e_adminq.c\n+++ b/drivers/net/i40e/base/i40e_adminq.c\n@@ -648,8 +648,10 @@ enum i40e_status_code i40e_init_adminq(struct i40e_hw *hw)\n {\n \tstruct i40e_adminq_info *aq = &hw->aq;\n \tenum i40e_status_code ret_code;\n-\tu16 cfg_ptr, oem_hi, oem_lo;\n-\tu16 eetrack_lo, eetrack_hi;\n+\tu16 oem_hi = 0, oem_lo = 0;\n+\tu16 eetrack_hi = 0;\n+\tu16 eetrack_lo = 0;\n+\tu16 cfg_ptr = 0;\n \tint retry = 0;\n \n \t/* verify input for valid configuration */\ndiff --git a/drivers/net/i40e/base/i40e_nvm.c b/drivers/net/i40e/base/i40e_nvm.c\nindex 67e58cc195..f385042601 100644\n--- a/drivers/net/i40e/base/i40e_nvm.c\n+++ b/drivers/net/i40e/base/i40e_nvm.c\n@@ -755,10 +755,11 @@ enum i40e_status_code i40e_update_nvm_checksum(struct i40e_hw *hw)\n \tDEBUGFUNC(\"i40e_update_nvm_checksum\");\n \n \tret_code = i40e_calc_nvm_checksum(hw, &checksum);\n-\tle_sum = CPU_TO_LE16(checksum);\n-\tif (ret_code == I40E_SUCCESS)\n+\tif (ret_code == I40E_SUCCESS) {\n+\t\tle_sum = CPU_TO_LE16(checksum);\n \t\tret_code = i40e_write_nvm_aq(hw, 0x00, I40E_SR_SW_CHECKSUM_WORD,\n \t\t\t\t\t 1, &le_sum, true);\n+\t}\n \n \treturn ret_code;\n }\n", "prefixes": [ "v2", "13/14" ] }