Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/94328/?format=api
{ "id": 94328, "url": "https://patches.dpdk.org/api/patches/94328/?format=api", "web_url": "https://patches.dpdk.org/project/dpdk/patch/20210617110005.4132926-4-jiawenwu@trustnetic.com/", "project": { "id": 1, "url": "https://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20210617110005.4132926-4-jiawenwu@trustnetic.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20210617110005.4132926-4-jiawenwu@trustnetic.com", "date": "2021-06-17T10:59:49", "name": "[v6,03/19] net/ngbe: add log type and error type", "commit_ref": null, "pull_url": null, "state": "changes-requested", "archived": true, "hash": "9d1e94e59302ec457bfef23437b1e68124926d64", "submitter": { "id": 1932, "url": "https://patches.dpdk.org/api/people/1932/?format=api", "name": "Jiawen Wu", "email": "jiawenwu@trustnetic.com" }, "delegate": { "id": 3961, "url": "https://patches.dpdk.org/api/users/3961/?format=api", "username": "arybchenko", "first_name": "Andrew", "last_name": "Rybchenko", "email": "andrew.rybchenko@oktetlabs.ru" }, "mbox": "https://patches.dpdk.org/project/dpdk/patch/20210617110005.4132926-4-jiawenwu@trustnetic.com/mbox/", "series": [ { "id": 17372, "url": "https://patches.dpdk.org/api/series/17372/?format=api", "web_url": "https://patches.dpdk.org/project/dpdk/list/?series=17372", "date": "2021-06-17T10:59:46", "name": "net: ngbe PMD", "version": 6, "mbox": "https://patches.dpdk.org/series/17372/mbox/" } ], "comments": "https://patches.dpdk.org/api/patches/94328/comments/", "check": "warning", "checks": "https://patches.dpdk.org/api/patches/94328/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from mails.dpdk.org (mails.dpdk.org [217.70.189.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id 06865A0C4D;\n\tThu, 17 Jun 2021 12:58:31 +0200 (CEST)", "from [217.70.189.124] (localhost [127.0.0.1])\n\tby mails.dpdk.org (Postfix) with ESMTP id 86A5D410F6;\n\tThu, 17 Jun 2021 12:58:17 +0200 (CEST)", "from smtpproxy21.qq.com (smtpbg704.qq.com [203.205.195.105])\n by mails.dpdk.org (Postfix) with ESMTP id 10922410EC\n for <dev@dpdk.org>; Thu, 17 Jun 2021 12:58:15 +0200 (CEST)", "from wxdbg.localdomain.com (unknown [183.129.236.74])\n by esmtp6.qq.com (ESMTP) with\n id ; Thu, 17 Jun 2021 18:58:08 +0800 (CST)" ], "X-QQ-mid": "bizesmtp46t1623927488toqh6x52", "X-QQ-SSF": "01400000000000D0E000B00A0000000", "X-QQ-FEAT": "PXOtw599/AZY25nWjLXFqs6pT2KubEwx+5LbNpz/6LBE4WLAx8eH7v1sGDONH\n qTmoPfRZp9CFR3JIYHYKkb0TsP0Y72sAsDxxY6LkzPR9G5WLP3PyeLwkc8SxG6VkBCjq8IZ\n GGdhooHhRBZwvuPFXDwBRXmPxYCAUYldacT0+m5VC9bQbr8wg0/gfIVv6rQn35pCAJfqbUM\n 2WxMz0bFDqbIDoUG7/wpSA3Y4PeWFhakWitm66d0k3CX2TJ82LFlL4adh3N16BJuGBVuYvx\n rnhhW+w4f2o7dHwU8jPyquN4Kvy7qoxlFVN+jPskZGOcBo+z5MDVZBM9xXa+DpSyS+l+T8J\n oQC298/InbeTUO0+tHA4ohuUq/CdA==", "X-QQ-GoodBg": "2", "From": "Jiawen Wu <jiawenwu@trustnetic.com>", "To": "dev@dpdk.org", "Cc": "Jiawen Wu <jiawenwu@trustnetic.com>", "Date": "Thu, 17 Jun 2021 18:59:49 +0800", "Message-Id": "<20210617110005.4132926-4-jiawenwu@trustnetic.com>", "X-Mailer": "git-send-email 2.27.0", "In-Reply-To": "<20210617110005.4132926-1-jiawenwu@trustnetic.com>", "References": "<20210617110005.4132926-1-jiawenwu@trustnetic.com>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "X-QQ-SENDSIZE": "520", "Feedback-ID": "bizesmtp:trustnetic.com:qybgforeign:qybgforeign2", "X-QQ-Bgrelay": "1", "Subject": "[dpdk-dev] [PATCH v6 03/19] net/ngbe: add log type and error type", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "Add log type and error type to trace functions.\n\nSigned-off-by: Jiawen Wu <jiawenwu@trustnetic.com>\n---\n doc/guides/nics/ngbe.rst | 21 +++++++++\n drivers/net/ngbe/base/ngbe_status.h | 73 +++++++++++++++++++++++++++++\n drivers/net/ngbe/ngbe_ethdev.c | 14 ++++++\n drivers/net/ngbe/ngbe_logs.h | 46 ++++++++++++++++++\n 4 files changed, 154 insertions(+)\n create mode 100644 drivers/net/ngbe/base/ngbe_status.h\n create mode 100644 drivers/net/ngbe/ngbe_logs.h", "diff": "diff --git a/doc/guides/nics/ngbe.rst b/doc/guides/nics/ngbe.rst\nindex 37502627a3..54d0665db9 100644\n--- a/doc/guides/nics/ngbe.rst\n+++ b/doc/guides/nics/ngbe.rst\n@@ -17,6 +17,27 @@ Prerequisites\n - Follow the DPDK :ref:`Getting Started Guide for Linux <linux_gsg>` to setup the basic DPDK environment.\n \n \n+Pre-Installation Configuration\n+------------------------------\n+\n+Dynamic Logging Parameters\n+~~~~~~~~~~~~~~~~~~~~~~~~~~\n+\n+One may leverage EAL option \"--log-level\" to change default levels\n+for the log types supported by the driver. The option is used with\n+an argument typically consisting of two parts separated by a colon.\n+\n+NGBE PMD provides the following log types available for control:\n+\n+- ``pmd.net.ngbe.driver`` (default level is **notice**)\n+\n+ Affects driver-wide messages unrelated to any particular devices.\n+\n+- ``pmd.net.ngbe.init`` (default level is **notice**)\n+\n+ Extra logging of the messages during PMD initialization.\n+\n+\n Driver compilation and testing\n ------------------------------\n \ndiff --git a/drivers/net/ngbe/base/ngbe_status.h b/drivers/net/ngbe/base/ngbe_status.h\nnew file mode 100644\nindex 0000000000..917b7da8aa\n--- /dev/null\n+++ b/drivers/net/ngbe/base/ngbe_status.h\n@@ -0,0 +1,73 @@\n+/* SPDX-License-Identifier: BSD-3-Clause\n+ * Copyright(c) 2018-2020 Beijing WangXun Technology Co., Ltd.\n+ * Copyright(c) 2010-2017 Intel Corporation\n+ */\n+\n+#ifndef _NGBE_STATUS_H_\n+#define _NGBE_STATUS_H_\n+\n+/* Error Codes:\n+ * common error\n+ * module error(simple)\n+ * module error(detailed)\n+ *\n+ * (-256, 256): reserved for non-ngbe defined error code\n+ */\n+#define TERR_BASE (0x100)\n+\n+/* WARNING: just for legacy compatibility */\n+#define NGBE_NOT_IMPLEMENTED 0x7FFFFFFF\n+#define NGBE_ERR_OPS_DUMMY 0x3FFFFFFF\n+\n+/* Error Codes */\n+#define NGBE_ERR_EEPROM\t\t\t\t-(TERR_BASE + 1)\n+#define NGBE_ERR_EEPROM_CHECKSUM\t\t-(TERR_BASE + 2)\n+#define NGBE_ERR_PHY\t\t\t\t-(TERR_BASE + 3)\n+#define NGBE_ERR_CONFIG\t\t\t\t-(TERR_BASE + 4)\n+#define NGBE_ERR_PARAM\t\t\t\t-(TERR_BASE + 5)\n+#define NGBE_ERR_MAC_TYPE\t\t\t-(TERR_BASE + 6)\n+#define NGBE_ERR_UNKNOWN_PHY\t\t\t-(TERR_BASE + 7)\n+#define NGBE_ERR_LINK_SETUP\t\t\t-(TERR_BASE + 8)\n+#define NGBE_ERR_ADAPTER_STOPPED\t\t-(TERR_BASE + 9)\n+#define NGBE_ERR_INVALID_MAC_ADDR\t\t-(TERR_BASE + 10)\n+#define NGBE_ERR_DEVICE_NOT_SUPPORTED\t\t-(TERR_BASE + 11)\n+#define NGBE_ERR_MASTER_REQUESTS_PENDING\t-(TERR_BASE + 12)\n+#define NGBE_ERR_INVALID_LINK_SETTINGS\t\t-(TERR_BASE + 13)\n+#define NGBE_ERR_AUTONEG_NOT_COMPLETE\t\t-(TERR_BASE + 14)\n+#define NGBE_ERR_RESET_FAILED\t\t\t-(TERR_BASE + 15)\n+#define NGBE_ERR_SWFW_SYNC\t\t\t-(TERR_BASE + 16)\n+#define NGBE_ERR_PHY_ADDR_INVALID\t\t-(TERR_BASE + 17)\n+#define NGBE_ERR_I2C\t\t\t\t-(TERR_BASE + 18)\n+#define NGBE_ERR_SFP_NOT_SUPPORTED\t\t-(TERR_BASE + 19)\n+#define NGBE_ERR_SFP_NOT_PRESENT\t\t-(TERR_BASE + 20)\n+#define NGBE_ERR_SFP_NO_INIT_SEQ_PRESENT\t-(TERR_BASE + 21)\n+#define NGBE_ERR_NO_SAN_ADDR_PTR\t\t-(TERR_BASE + 22)\n+#define NGBE_ERR_FDIR_REINIT_FAILED\t\t-(TERR_BASE + 23)\n+#define NGBE_ERR_EEPROM_VERSION\t\t\t-(TERR_BASE + 24)\n+#define NGBE_ERR_NO_SPACE\t\t\t-(TERR_BASE + 25)\n+#define NGBE_ERR_OVERTEMP\t\t\t-(TERR_BASE + 26)\n+#define NGBE_ERR_FC_NOT_NEGOTIATED\t\t-(TERR_BASE + 27)\n+#define NGBE_ERR_FC_NOT_SUPPORTED\t\t-(TERR_BASE + 28)\n+#define NGBE_ERR_SFP_SETUP_NOT_COMPLETE\t\t-(TERR_BASE + 30)\n+#define NGBE_ERR_PBA_SECTION\t\t\t-(TERR_BASE + 31)\n+#define NGBE_ERR_INVALID_ARGUMENT\t\t-(TERR_BASE + 32)\n+#define NGBE_ERR_HOST_INTERFACE_COMMAND\t\t-(TERR_BASE + 33)\n+#define NGBE_ERR_OUT_OF_MEM\t\t\t-(TERR_BASE + 34)\n+#define NGBE_ERR_FEATURE_NOT_SUPPORTED\t\t-(TERR_BASE + 36)\n+#define NGBE_ERR_EEPROM_PROTECTED_REGION\t-(TERR_BASE + 37)\n+#define NGBE_ERR_FDIR_CMD_INCOMPLETE\t\t-(TERR_BASE + 38)\n+#define NGBE_ERR_FW_RESP_INVALID\t\t-(TERR_BASE + 39)\n+#define NGBE_ERR_TOKEN_RETRY\t\t\t-(TERR_BASE + 40)\n+#define NGBE_ERR_FLASH_LOADING_FAILED\t\t-(TERR_BASE + 41)\n+\n+#define NGBE_ERR_NOSUPP -(TERR_BASE + 42)\n+#define NGBE_ERR_UNDERTEMP -(TERR_BASE + 43)\n+#define NGBE_ERR_XPCS_POWER_UP_FAILED -(TERR_BASE + 44)\n+#define NGBE_ERR_PHY_INIT_NOT_DONE -(TERR_BASE + 45)\n+#define NGBE_ERR_TIMEOUT -(TERR_BASE + 46)\n+#define NGBE_ERR_REGISTER -(TERR_BASE + 47)\n+#define NGBE_ERR_MNG_ACCESS_FAILED -(TERR_BASE + 49)\n+#define NGBE_ERR_PHY_TYPE -(TERR_BASE + 50)\n+#define NGBE_ERR_PHY_TIMEOUT -(TERR_BASE + 51)\n+\n+#endif /* _NGBE_STATUS_H_ */\ndiff --git a/drivers/net/ngbe/ngbe_ethdev.c b/drivers/net/ngbe/ngbe_ethdev.c\nindex d8df7ef896..e05766752a 100644\n--- a/drivers/net/ngbe/ngbe_ethdev.c\n+++ b/drivers/net/ngbe/ngbe_ethdev.c\n@@ -7,6 +7,7 @@\n #include <rte_common.h>\n #include <ethdev_pci.h>\n \n+#include \"ngbe_logs.h\"\n #include <base/ngbe_devids.h>\n #include \"ngbe_ethdev.h\"\n \n@@ -34,6 +35,8 @@ eth_ngbe_dev_init(struct rte_eth_dev *eth_dev, void *init_params __rte_unused)\n {\n \tstruct rte_pci_device *pci_dev = RTE_ETH_DEV_TO_PCI(eth_dev);\n \n+\tPMD_INIT_FUNC_TRACE();\n+\n \tif (rte_eal_process_type() != RTE_PROC_PRIMARY)\n \t\treturn 0;\n \n@@ -45,6 +48,8 @@ eth_ngbe_dev_init(struct rte_eth_dev *eth_dev, void *init_params __rte_unused)\n static int\n eth_ngbe_dev_uninit(struct rte_eth_dev *eth_dev)\n {\n+\tPMD_INIT_FUNC_TRACE();\n+\n \tif (rte_eal_process_type() != RTE_PROC_PRIMARY)\n \t\treturn 0;\n \n@@ -85,3 +90,12 @@ RTE_PMD_REGISTER_PCI(net_ngbe, rte_ngbe_pmd);\n RTE_PMD_REGISTER_PCI_TABLE(net_ngbe, pci_id_ngbe_map);\n RTE_PMD_REGISTER_KMOD_DEP(net_ngbe, \"* igb_uio | uio_pci_generic | vfio-pci\");\n \n+RTE_LOG_REGISTER(ngbe_logtype_init, pmd.net.ngbe.init, NOTICE);\n+RTE_LOG_REGISTER(ngbe_logtype_driver, pmd.net.ngbe.driver, NOTICE);\n+\n+#ifdef RTE_ETHDEV_DEBUG_RX\n+\tRTE_LOG_REGISTER(ngbe_logtype_rx, pmd.net.ngbe.rx, DEBUG);\n+#endif\n+#ifdef RTE_ETHDEV_DEBUG_TX\n+\tRTE_LOG_REGISTER(ngbe_logtype_tx, pmd.net.ngbe.tx, DEBUG);\n+#endif\ndiff --git a/drivers/net/ngbe/ngbe_logs.h b/drivers/net/ngbe/ngbe_logs.h\nnew file mode 100644\nindex 0000000000..c5d1ab0930\n--- /dev/null\n+++ b/drivers/net/ngbe/ngbe_logs.h\n@@ -0,0 +1,46 @@\n+/* SPDX-License-Identifier: BSD-3-Clause\n+ * Copyright(c) 2018-2020 Beijing WangXun Technology Co., Ltd.\n+ * Copyright(c) 2010-2017 Intel Corporation\n+ */\n+\n+#ifndef _NGBE_LOGS_H_\n+#define _NGBE_LOGS_H_\n+\n+/*\n+ * PMD_USER_LOG: for user\n+ */\n+extern int ngbe_logtype_init;\n+#define PMD_INIT_LOG(level, fmt, args...) \\\n+\trte_log(RTE_LOG_ ## level, ngbe_logtype_init, \\\n+\t\t\"%s(): \" fmt \"\\n\", __func__, ##args)\n+\n+extern int ngbe_logtype_driver;\n+#define PMD_DRV_LOG(level, fmt, args...) \\\n+\trte_log(RTE_LOG_ ## level, ngbe_logtype_driver, \\\n+\t\t\"%s(): \" fmt \"\\n\", __func__, ##args)\n+\n+#ifdef RTE_ETHDEV_DEBUG_RX\n+extern int ngbe_logtype_rx;\n+#define PMD_RX_LOG(level, fmt, args...) \\\n+\trte_log(RTE_LOG_ ## level, ngbe_logtype_rx,\t\\\n+\t\t\"%s(): \" fmt \"\\n\", __func__, ##args)\n+#else\n+#define PMD_RX_LOG(level, fmt, args...) do { } while (0)\n+#endif\n+\n+#ifdef RTE_ETHDEV_DEBUG_TX\n+extern int ngbe_logtype_tx;\n+#define PMD_TX_LOG(level, fmt, args...) \\\n+\trte_log(RTE_LOG_ ## level, ngbe_logtype_tx,\t\\\n+\t\t\"%s(): \" fmt \"\\n\", __func__, ##args)\n+#else\n+#define PMD_TX_LOG(level, fmt, args...) do { } while (0)\n+#endif\n+\n+#define TLOG_DEBUG(fmt, args...) PMD_DRV_LOG(DEBUG, fmt, ##args)\n+\n+#define DEBUGOUT(fmt, args...) TLOG_DEBUG(fmt, ##args)\n+#define PMD_INIT_FUNC_TRACE() TLOG_DEBUG(\" >>\")\n+#define DEBUGFUNC(fmt) TLOG_DEBUG(fmt)\n+\n+#endif /* _NGBE_LOGS_H_ */\n", "prefixes": [ "v6", "03/19" ] }