Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/94304/?format=api
{ "id": 94304, "url": "https://patches.dpdk.org/api/patches/94304/?format=api", "web_url": "https://patches.dpdk.org/project/dpdk/patch/20210616180724.355217-1-ohilyard@iol.unh.edu/", "project": { "id": 1, "url": "https://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20210616180724.355217-1-ohilyard@iol.unh.edu>", "list_archive_url": "https://inbox.dpdk.org/dev/20210616180724.355217-1-ohilyard@iol.unh.edu", "date": "2021-06-16T18:07:24", "name": "tests/cmdline: fix memory leaks", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": true, "hash": "c08e3ff2ef9a71dabf79ffdf4aec8a08ef5f9b57", "submitter": { "id": 1829, "url": "https://patches.dpdk.org/api/people/1829/?format=api", "name": "Owen Hilyard", "email": "ohilyard@iol.unh.edu" }, "delegate": { "id": 24651, "url": "https://patches.dpdk.org/api/users/24651/?format=api", "username": "dmarchand", "first_name": "David", "last_name": "Marchand", "email": "david.marchand@redhat.com" }, "mbox": "https://patches.dpdk.org/project/dpdk/patch/20210616180724.355217-1-ohilyard@iol.unh.edu/mbox/", "series": [ { "id": 17363, "url": "https://patches.dpdk.org/api/series/17363/?format=api", "web_url": "https://patches.dpdk.org/project/dpdk/list/?series=17363", "date": "2021-06-16T18:07:24", "name": "tests/cmdline: fix memory leaks", "version": 1, "mbox": "https://patches.dpdk.org/series/17363/mbox/" } ], "comments": "https://patches.dpdk.org/api/patches/94304/comments/", "check": "fail", "checks": "https://patches.dpdk.org/api/patches/94304/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from mails.dpdk.org (mails.dpdk.org [217.70.189.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id BEBCBA0C43;\n\tWed, 16 Jun 2021 20:07:30 +0200 (CEST)", "from [217.70.189.124] (localhost [127.0.0.1])\n\tby mails.dpdk.org (Postfix) with ESMTP id 01305410DA;\n\tWed, 16 Jun 2021 20:07:30 +0200 (CEST)", "from mail-ua1-f99.google.com (mail-ua1-f99.google.com\n [209.85.222.99]) by mails.dpdk.org (Postfix) with ESMTP id 299A940683\n for <dev@dpdk.org>; Wed, 16 Jun 2021 20:07:29 +0200 (CEST)", "by mail-ua1-f99.google.com with SMTP id f34so1094881uae.4\n for <dev@dpdk.org>; Wed, 16 Jun 2021 11:07:29 -0700 (PDT)", "from postal.iol.unh.edu (postal.iol.unh.edu. [132.177.123.84])\n by smtp-relay.gmail.com with ESMTPS id d72sm1137530vkf.7.2021.06.16.11.07.27\n (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128);\n Wed, 16 Jun 2021 11:07:27 -0700 (PDT)", "from iol.unh.edu (unknown\n [IPv6:2606:4100:3880:1220:5e2f:685e:142b:54c3])\n by postal.iol.unh.edu (Postfix) with ESMTP id 39F21605246B;\n Wed, 16 Jun 2021 14:07:27 -0400 (EDT)" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed; d=iol.unh.edu;\n s=unh-iol;\n h=from:to:cc:subject:date:message-id:in-reply-to:references\n :mime-version:content-transfer-encoding;\n bh=OGyFlzWCfQIxD4ZcKldWiRHStRmEHk5zBxu1qYGJyks=;\n b=GvzRGkscJoZfgi0APV855Bdf+ccmlhtWIh4LzVzKqO4g3AUf11df0evJ30NbUsNz7g\n SblsrV6KkYQnNMueaTkglaHn93ok9791v/ZNNSJbgIqKbppuj7TVUGfbN+/rGdzK77si\n SJs9kJC2vOgm/yf/Mm6qatpVELeLazBjxSUoY=", "X-Google-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=1e100.net; s=20161025;\n h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to\n :references:mime-version:content-transfer-encoding;\n bh=OGyFlzWCfQIxD4ZcKldWiRHStRmEHk5zBxu1qYGJyks=;\n b=LwV8CgSmdFIdeIlSh7wDOxMxvT+uz/rOY0mxUFt0KhX9RVR34vdbK3DsIUtsjwEi34\n 3W4wcJjkdvfOewoniEaXEdmg9onoOPOc8ERoGc61N/kIsmc0L6q7NuotUy/yq+6lyVEd\n XQoYutM4SegXTGygn6x1rBFk/fmM0OzBrHtJo1Iqyp/8nVaaw9j+DOhe995yipiA0gHJ\n McQ/35CQ4+K7t+mPU5PHVDCbS2b0nhDwafL9e0W15wOpuLBHCgw7GEA9378i8MQvfhKw\n 1qoyxb4AkZkTy+aKQWw1sZR/U262KL7Y3wGptBO3bS4UhigldlDsiYpzcHd9atf3ECDr\n 67mQ==", "X-Gm-Message-State": "AOAM533aIa/j031BPT4f1SN+GE7B7Qn1gCy0a5e3SpdLOvxhacK4dLdu\n TmCXk9EP/RFM2DYkvhelHpgfkxWmuAiiU3XG0yiZ3yXEOK1xwg==", "X-Google-Smtp-Source": "\n ABdhPJwnf5bz1JjStqCGUnVPzi89fBeO+vYD4u7r7Rza2LF4a/MmpYjktW4LtXybZgbo7/3c7kUVpRGZh92S", "X-Received": "by 2002:a9f:374c:: with SMTP id a12mr994122uae.91.1623866847891;\n Wed, 16 Jun 2021 11:07:27 -0700 (PDT)", "X-Relaying-Domain": "iol.unh.edu", "From": "ohilyard@iol.unh.edu", "To": "olivier.matz@6wind.com", "Cc": "dev@dpdk.org, david.marchand@redhat.com, stable@dpdk.org,\n Owen Hilyard <ohilyard@iol.unh.edu>", "Date": "Wed, 16 Jun 2021 14:07:24 -0400", "Message-Id": "<20210616180724.355217-1-ohilyard@iol.unh.edu>", "X-Mailer": "git-send-email 2.30.2", "In-Reply-To": "<20210616162553.350074-1-ohilyard@iol.unh.edu>", "References": "<20210616162553.350074-1-ohilyard@iol.unh.edu>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "Subject": "[dpdk-dev] [PATCH] tests/cmdline: fix memory leaks", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "From: Owen Hilyard <ohilyard@iol.unh.edu>\n\nFixes for a few memory leaks in the cmdline_autotest unit test.\n\nAll of the leaks were related to not freeing the commandline struct\nafter testing had completed.\n\nFixes: dbb860e03e (\"cmdline: tests\")\n\nSigned-off-by: Owen Hilyard <ohilyard@iol.unh.edu>\nReviewed-by: David Marchand <david.marchand@redhat.com>\n---\n app/test/test_cmdline_lib.c | 30 ++++++++++++++++++++++--------\n 1 file changed, 22 insertions(+), 8 deletions(-)", "diff": "diff --git a/app/test/test_cmdline_lib.c b/app/test/test_cmdline_lib.c\nindex bd72df0da..19228c9a5 100644\n--- a/app/test/test_cmdline_lib.c\n+++ b/app/test/test_cmdline_lib.c\n@@ -71,10 +71,12 @@ test_cmdline_parse_fns(void)\n \tif (cmdline_complete(cl, \"buffer\", &i, NULL, sizeof(dst)) >= 0)\n \t\tgoto error;\n \n+\tcmdline_free(cl);\n \treturn 0;\n \n error:\n \tprintf(\"Error: function accepted null parameter!\\n\");\n+\tcmdline_free(cl);\n \treturn -1;\n }\n \n@@ -140,32 +142,43 @@ static int\n test_cmdline_socket_fns(void)\n {\n \tcmdline_parse_ctx_t ctx;\n+\tstruct cmdline *cl;\n \n-\tif (cmdline_stdin_new(NULL, \"prompt\") != NULL)\n+\tcl = cmdline_stdin_new(NULL, \"prompt\");\n+\tif (cl != NULL)\n \t\tgoto error;\n-\tif (cmdline_stdin_new(&ctx, NULL) != NULL)\n+\tcl = cmdline_stdin_new(&ctx, NULL);\n+\tif (cl != NULL)\n \t\tgoto error;\n-\tif (cmdline_file_new(NULL, \"prompt\", \"/dev/null\") != NULL)\n+\tcl = cmdline_file_new(NULL, \"prompt\", \"/dev/null\");\n+\tif (cl != NULL)\n \t\tgoto error;\n-\tif (cmdline_file_new(&ctx, NULL, \"/dev/null\") != NULL)\n+\tcl = cmdline_file_new(&ctx, NULL, \"/dev/null\");\n+\tif (cl != NULL)\n \t\tgoto error;\n-\tif (cmdline_file_new(&ctx, \"prompt\", NULL) != NULL)\n+\tcl = cmdline_file_new(&ctx, \"prompt\", NULL);\n+\tif (cl != NULL)\n \t\tgoto error;\n-\tif (cmdline_file_new(&ctx, \"prompt\", \"-/invalid/~/path\") != NULL) {\n+\tcl = cmdline_file_new(&ctx, \"prompt\", \"-/invalid/~/path\");\n+\tif (cl != NULL) {\n \t\tprintf(\"Error: succeeded in opening invalid file for reading!\");\n+\t\tcmdline_free(cl);\n \t\treturn -1;\n \t}\n-\tif (cmdline_file_new(&ctx, \"prompt\", \"/dev/null\") == NULL) {\n+\tcl = cmdline_file_new(&ctx, \"prompt\", \"/dev/null\");\n+\tif (cl == NULL) {\n \t\tprintf(\"Error: failed to open /dev/null for reading!\");\n+\t\tcmdline_free(cl);\n \t\treturn -1;\n \t}\n \n \t/* void functions */\n \tcmdline_stdin_exit(NULL);\n-\n+\tcmdline_free(cl);\n \treturn 0;\n error:\n \tprintf(\"Error: function accepted null parameter!\\n\");\n+\tcmdline_free(cl);\n \treturn -1;\n }\n \n@@ -198,6 +211,7 @@ test_cmdline_fns(void)\n \tcmdline_interact(NULL);\n \tcmdline_quit(NULL);\n \n+\tcmdline_free(cl);\n \treturn 0;\n \n error:\n", "prefixes": [] }