Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/94300/?format=api
{ "id": 94300, "url": "https://patches.dpdk.org/api/patches/94300/?format=api", "web_url": "https://patches.dpdk.org/project/dpdk/patch/20210616160730.348523-1-ohilyard@iol.unh.edu/", "project": { "id": 1, "url": "https://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20210616160730.348523-1-ohilyard@iol.unh.edu>", "list_archive_url": "https://inbox.dpdk.org/dev/20210616160730.348523-1-ohilyard@iol.unh.edu", "date": "2021-06-16T16:07:29", "name": "lib/rte_rib6: fix stack buffer overflow", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": true, "hash": "50819107fe0a7bc1f274ffca6aade29feb613bd5", "submitter": { "id": 1829, "url": "https://patches.dpdk.org/api/people/1829/?format=api", "name": "Owen Hilyard", "email": "ohilyard@iol.unh.edu" }, "delegate": { "id": 24651, "url": "https://patches.dpdk.org/api/users/24651/?format=api", "username": "dmarchand", "first_name": "David", "last_name": "Marchand", "email": "david.marchand@redhat.com" }, "mbox": "https://patches.dpdk.org/project/dpdk/patch/20210616160730.348523-1-ohilyard@iol.unh.edu/mbox/", "series": [ { "id": 17359, "url": "https://patches.dpdk.org/api/series/17359/?format=api", "web_url": "https://patches.dpdk.org/project/dpdk/list/?series=17359", "date": "2021-06-16T16:07:29", "name": "lib/rte_rib6: fix stack buffer overflow", "version": 1, "mbox": "https://patches.dpdk.org/series/17359/mbox/" } ], "comments": "https://patches.dpdk.org/api/patches/94300/comments/", "check": "fail", "checks": "https://patches.dpdk.org/api/patches/94300/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from mails.dpdk.org (mails.dpdk.org [217.70.189.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id 900DBA0548;\n\tWed, 16 Jun 2021 18:07:36 +0200 (CEST)", "from [217.70.189.124] (localhost [127.0.0.1])\n\tby mails.dpdk.org (Postfix) with ESMTP id 529B54067A;\n\tWed, 16 Jun 2021 18:07:36 +0200 (CEST)", "from mail-vs1-f98.google.com (mail-vs1-f98.google.com\n [209.85.217.98]) by mails.dpdk.org (Postfix) with ESMTP id 4BEFD40140\n for <dev@dpdk.org>; Wed, 16 Jun 2021 18:07:35 +0200 (CEST)", "by mail-vs1-f98.google.com with SMTP id q2so1330393vsr.1\n for <dev@dpdk.org>; Wed, 16 Jun 2021 09:07:35 -0700 (PDT)", "from postal.iol.unh.edu (postal.iol.unh.edu. [132.177.123.84])\n by smtp-relay.gmail.com with ESMTPS id 128sm1048663vkb.12.2021.06.16.09.07.34\n (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128);\n Wed, 16 Jun 2021 09:07:34 -0700 (PDT)", "from iol.unh.edu (unknown\n [IPv6:2606:4100:3880:1220:5e2f:685e:142b:54c3])\n by postal.iol.unh.edu (Postfix) with ESMTP id E4826605246B;\n Wed, 16 Jun 2021 12:07:33 -0400 (EDT)" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed; d=iol.unh.edu;\n s=unh-iol;\n h=from:to:cc:subject:date:message-id:mime-version\n :content-transfer-encoding;\n bh=ITDpmsqEalvuSFulTj0s2wGYdoOKCyH/VuH48FpKFec=;\n b=IQtAX42YPx7AxGOYo495KLfd06Gcj4pNGyAsLOsJnuHpjTJxPdA3rzvjZiaZQAVa2M\n ECuZRFrZycVqxr4ry1a6kLXbvQPGARbC/ak+1Pm9oR6TSlBYZ4FYQD0n1a9m93QChImK\n z87gHBBdLl1HryNVmDxIUuUh9oxIHwEMWbUTY=", "X-Google-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=1e100.net; s=20161025;\n h=x-gm-message-state:from:to:cc:subject:date:message-id:mime-version\n :content-transfer-encoding;\n bh=ITDpmsqEalvuSFulTj0s2wGYdoOKCyH/VuH48FpKFec=;\n b=fWZmD2pJ80e553k8Nu/s06Ui6YqXehR5B2C7ahMeEOgQOA8zcDh7VxYDG8iy0OEXK6\n 7VQQbIaM7hfSUDRBCFvoyGqNLmFs42WWI4MJfqxADS2PMJyZV1D1cgnP/fK3OeqOvt8z\n Q9SrQkHx1uAYXSM+R8LHo/rBrbJjetObK1JzjO+FF8l9ZWWBuq+EP2k2yDjDgFG+BovC\n Lk8PiE6CxS0NlQkVD7OYtG6eI/JetjQkdliEI2KoEIjUG9C+mfuy2zHX2nFflFKu/Dtk\n 2cebhm8W+UgZZBXIgBlVgLcZijjPRTq47X1eAPn3nqRhD0pN0jWqDfdPjbj91K+AlCM+\n UypQ==", "X-Gm-Message-State": "AOAM533GsWhAvxBxsJXyNoZz70f08lC1AxrPynfYxElTyO0HaIC3C6VF\n 15C+Gjkxwu4gCKIKwBuNbMWTSHyV7BaBhNp5EEYE6bT1bgV8KrzTG7n79A2mxOhOi0GX85IN2c2\n xA35FSk/r5R76pq8/hugIDqwxwOmiDPuRMt1IeV95CdQu3ep8t2yMCwvqUy1/HQ3gBEm7yf58hw\n ==", "X-Google-Smtp-Source": "\n ABdhPJw3sGWDuYQH1+pCblCThgrd4ljPJ1b34pNd7emH3G0tSx4LBIv5AfjWyBnoQpRmOLDQlsmIO6oItrzw", "X-Received": "by 2002:a67:fe0a:: with SMTP id l10mr809814vsr.33.1623859654502;\n Wed, 16 Jun 2021 09:07:34 -0700 (PDT)", "X-Relaying-Domain": "iol.unh.edu", "From": "ohilyard@iol.unh.edu", "To": "vladimir.medvedkin@intel.com", "Cc": "dev@dpdk.org, david.marchand@redhat.com,\n Owen Hilyard <ohilyard@iol.unh.edu>", "Date": "Wed, 16 Jun 2021 12:07:29 -0400", "Message-Id": "<20210616160730.348523-1-ohilyard@iol.unh.edu>", "X-Mailer": "git-send-email 2.30.2", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "Subject": "[dpdk-dev] [PATCH] lib/rte_rib6: fix stack buffer overflow", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "From: Owen Hilyard <ohilyard@iol.unh.edu>\n\nASAN found a stack buffer overflow in lib/rib/rte_rib6.c:get_dir.\nThe fix for the stack buffer overflow was to make sure depth\nwas always < 128, since when depth = 128 it caused the index\ninto the ip address to be 16, which read off the end of the array.\n\nWhile trying to solve the buffer overflow, I noticed that a few\nchanges could be made to remove the for loop entirely.\n\nSigned-off-by: Owen Hilyard <ohilyard@iol.unh.edu>\n---\n lib/rib/rte_rib6.c | 22 ++++++++++++++--------\n 1 file changed, 14 insertions(+), 8 deletions(-)", "diff": "diff --git a/lib/rib/rte_rib6.c b/lib/rib/rte_rib6.c\nindex f6c55ee45..2de50449d 100644\n--- a/lib/rib/rte_rib6.c\n+++ b/lib/rib/rte_rib6.c\n@@ -79,14 +79,20 @@ is_covered(const uint8_t ip1[RTE_RIB6_IPV6_ADDR_SIZE],\n static inline int\n get_dir(const uint8_t ip[RTE_RIB6_IPV6_ADDR_SIZE], uint8_t depth)\n {\n-\tint i = 0;\n-\tuint8_t p_depth, msk;\n-\n-\tfor (p_depth = depth; p_depth >= 8; p_depth -= 8)\n-\t\ti++;\n-\n-\tmsk = 1 << (7 - p_depth);\n-\treturn (ip[i] & msk) != 0;\n+\tint index, msk;\n+\t/* depth & 127 clamps depth to values that will not\n+\t * read off the end of ip.\n+\t * depth is the number of bits deep into ip to traverse, and\n+\t * is incremented in blocks of 8 (1 byte). This means the last\n+\t * 3 bits are irrelevant to what the index of ip should be.\n+\t */\n+\tindex = (depth & 127) >> 3;\n+\t/*\n+\t * msk is the bitmask used to extract the bit used to decide the\n+\t * direction of the next step of the binary search.\n+\t */\n+\tmsk = 1 << (7 - (depth & 7));\n+\treturn (ip[index] & msk) != 0;\n }\n \n static inline struct rte_rib6_node *\n", "prefixes": [] }