Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/9300/?format=api
{ "id": 9300, "url": "https://patches.dpdk.org/api/patches/9300/?format=api", "web_url": "https://patches.dpdk.org/project/dpdk/patch/1449150340-21984-6-git-send-email-thomas.monjalon@6wind.com/", "project": { "id": 1, "url": "https://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<1449150340-21984-6-git-send-email-thomas.monjalon@6wind.com>", "list_archive_url": "https://inbox.dpdk.org/dev/1449150340-21984-6-git-send-email-thomas.monjalon@6wind.com", "date": "2015-12-03T13:45:32", "name": "[dpdk-dev,v3,05/13] mk: introduce new install syntax", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": true, "hash": "0348e50688758043b48622c07f3bcbfc29c50e87", "submitter": { "id": 1, "url": "https://patches.dpdk.org/api/people/1/?format=api", "name": "Thomas Monjalon", "email": "thomas.monjalon@6wind.com" }, "delegate": null, "mbox": "https://patches.dpdk.org/project/dpdk/patch/1449150340-21984-6-git-send-email-thomas.monjalon@6wind.com/mbox/", "series": [], "comments": "https://patches.dpdk.org/api/patches/9300/comments/", "check": "pending", "checks": "https://patches.dpdk.org/api/patches/9300/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@dpdk.org", "Delivered-To": "patchwork@dpdk.org", "Received": [ "from [92.243.14.124] (localhost [IPv6:::1])\n\tby dpdk.org (Postfix) with ESMTP id E8BC28E78;\n\tThu, 3 Dec 2015 14:47:06 +0100 (CET)", "from mail-wm0-f52.google.com (mail-wm0-f52.google.com\n\t[74.125.82.52]) by dpdk.org (Postfix) with ESMTP id D5E728E7E\n\tfor <dev@dpdk.org>; Thu, 3 Dec 2015 14:47:03 +0100 (CET)", "by wmuu63 with SMTP id u63so21791628wmu.0\n\tfor <dev@dpdk.org>; Thu, 03 Dec 2015 05:47:03 -0800 (PST)", "from XPS13.dev.6wind.com (guy78-3-82-239-227-177.fbx.proxad.net.\n\t[82.239.227.177]) by smtp.gmail.com with ESMTPSA id\n\tk133sm8063912wmg.18.2015.12.03.05.47.02\n\t(version=TLSv1/SSLv3 cipher=OTHER);\n\tThu, 03 Dec 2015 05:47:03 -0800 (PST)" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=6wind-com.20150623.gappssmtp.com; s=20150623;\n\th=from:to:cc:subject:date:message-id:in-reply-to:references;\n\tbh=GFed/xhgQlTs+8UBFq9JBnDvAGg3eouEhayXixgIYfc=;\n\tb=Y+/UEkIiNqqq6ELnqmhsMVNNAJFQun9DKNCrpbPgisIvtFwURLs54bBRFoTW+Xhew1\n\tJis0Bi1/yMr6BuPXAbx8H1MGXya4EplcOwnLbkGLW7mEtrRr0yk5eROhEy8S+j2u4IWW\n\thXWJd8TuUz4e3QXanxjnvlO/nHm2jBFb8njP8ajj5CbL6KG7UfIinfDdH0NX7/3VwfNp\n\tJ7yVZB8iBi83qC5FTvUn+MU0a+REHmYvuuh1PdZwhztm5WT1P/NLMHzWSbVeruNjZSep\n\tYdmt9v9ODyYg9r1lzm5iOJ5Gf9GfKKp9vQYd7A6/BXOZIek/enYgCkKWSHb9u6pwrcFP\n\t/9YQ==", "X-Google-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20130820;\n\th=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to\n\t:references;\n\tbh=GFed/xhgQlTs+8UBFq9JBnDvAGg3eouEhayXixgIYfc=;\n\tb=GNANO2z4Yn0Vp5+oV+nytdwhEVKtHurXSnYoTr2CadMK7VMQhipibLaH0ipZgNTTAu\n\tOK9EHcusomABAvqkdLxvqOZHUB5NHtt7m7VLLLUI4xHeFhzT+KI4NDpTP1nCmM/IgZgH\n\tdHcdPx/YsAymZmGm6rkc+mkHOF/8vb0LklJq7ZpZPiPkiRHGN2nk37laCH7FNTKbrKkk\n\tfuTouwcZO2dGTPuOrqajXJsDUSPa3caEWDCvR7kWdDH60o46G3kj2+J6TPANyBKU4LFl\n\txkYFN28Fi2myEDCDmk2qAGELC7ZqMTEgCQ0HAJOsO+tU+P2qeZ2pOWIGKLRYhhdFMnxO\n\tcdUg==", "X-Gm-Message-State": "ALoCoQlIT2t+7Mvjq/mzd7hCMUeaczwsuFRdwv8kLUX/LoLNQyF96WoK+YfGbWH7CNFE6dy1q8BR", "X-Received": "by 10.194.142.45 with SMTP id rt13mr10834475wjb.45.1449150423759;\n\tThu, 03 Dec 2015 05:47:03 -0800 (PST)", "From": "Thomas Monjalon <thomas.monjalon@6wind.com>", "To": "dev@dpdk.org", "Date": "Thu, 3 Dec 2015 14:45:32 +0100", "Message-Id": "<1449150340-21984-6-git-send-email-thomas.monjalon@6wind.com>", "X-Mailer": "git-send-email 2.5.2", "In-Reply-To": "<1449150340-21984-1-git-send-email-thomas.monjalon@6wind.com>", "References": "<1449118929-19962-1-git-send-email-thomas.monjalon@6wind.com>\n\t<1449150340-21984-1-git-send-email-thomas.monjalon@6wind.com>", "Subject": "[dpdk-dev] [PATCH v3 05/13] mk: introduce new install syntax", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "patches and discussions about DPDK <dev.dpdk.org>", "List-Unsubscribe": "<http://dpdk.org/ml/options/dev>,\n\t<mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://dpdk.org/ml/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<http://dpdk.org/ml/listinfo/dev>,\n\t<mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "The old install command was:\n\tmake install T=x86_64-native-linuxapp-gcc DESTDIR=install\nIt still works and can be replaced by these more standard commands:\n\tmake config T=x86_64-native-linuxapp-gcc 0=x86_64-native-linuxapp-gcc\n\tmake O=x86_64-native-linuxapp-gcc\n\tmake install O=x86_64-native-linuxapp-gcc prefix= DESTDIR=install\n\nIt means the \"make install\" do not perform any compilation anymore when T\nis not used. It is done only in pre_install to keep compatibility with the\nold syntax based on T= option.\n\nThe default prefix /usr/local is empty in the T= case which is\nused only for a local install.\n\nSigned-off-by: Thomas Monjalon <thomas.monjalon@6wind.com>\nAcked-by: Panu Matilainen <pmatilai@redhat.com>\n---\n doc/build-sdk-quick.txt | 7 ++++---\n doc/guides/prog_guide/dev_kit_root_make_help.rst | 4 +---\n mk/rte.sdkinstall.mk | 12 ++++++++++++\n 3 files changed, 17 insertions(+), 6 deletions(-)", "diff": "diff --git a/doc/build-sdk-quick.txt b/doc/build-sdk-quick.txt\nindex 662ef63..acd1bfe 100644\n--- a/doc/build-sdk-quick.txt\n+++ b/doc/build-sdk-quick.txt\n@@ -5,7 +5,8 @@ Build commands\n \tall same as build (default rule)\n \tbuild build in a configured directory\n \tclean remove files but keep configuration\n-\tinstall configure, build and install a target in DESTDIR\n+\tinstall T= configure, build and install a target in DESTDIR\n+\tinstall install optionally staged in DESTDIR\n \texamples build examples for given targets (T=)\n \texamples_clean clean examples for given targets (T=)\n Build variables\n@@ -17,8 +18,8 @@ Build variables\n \tCROSS toolchain prefix\n \tV verbose\n \tD debug dependencies\n-\tO build directory (default: build/ - install default: ./)\n-\tDESTDIR second-stage install directory\n+\tO build directory (default: build/ - install T= default: ./)\n+\tDESTDIR staging install directory\n \tprefix root install directory\n \tT target template - used with config or install\n \t\t\tformat: <arch-machine-execenv-toolchain>\ndiff --git a/doc/guides/prog_guide/dev_kit_root_make_help.rst b/doc/guides/prog_guide/dev_kit_root_make_help.rst\nindex b0429d8..fb3520e 100644\n--- a/doc/guides/prog_guide/dev_kit_root_make_help.rst\n+++ b/doc/guides/prog_guide/dev_kit_root_make_help.rst\n@@ -107,8 +107,6 @@ Install Targets\n \n * Install\n \n- Build the DPDK binary.\n- The name of the target to install is specified using T=mytarget.\n The list of available targets are in $(RTE_SDK)/config (remove the defconfig\\_ prefix).\n \n The GNU standards variables may be used:\n@@ -119,7 +117,7 @@ Install Targets\n \n .. code-block:: console\n \n- make install T=x86_64-native-linuxapp-gcc prefix=/usr\n+ make install DESTDIR=myinstall prefix=/usr\n \n Test Targets\n ------------\ndiff --git a/mk/rte.sdkinstall.mk b/mk/rte.sdkinstall.mk\nindex 3201b5b..dc57baf 100644\n--- a/mk/rte.sdkinstall.mk\n+++ b/mk/rte.sdkinstall.mk\n@@ -33,11 +33,21 @@\n # Configuration, compilation and installation can be done at once\n # with make install T=<config>\n \n+ifdef T # config, build and install combined\n # The build directory is T and may be prepended with O\n O ?= .\n RTE_OUTPUT := $O/$T\n+else # standard install\n+# Build directory is given with O=\n+O ?= build\n+RTE_OUTPUT := $O\n+endif\n \n+ifdef T # defaults with T= will install an almost flat staging tree\n+export prefix ?=\n+else\n prefix ?= /usr/local\n+endif\n exec_prefix ?= $(prefix)\n bindir ?= $(exec_prefix)/bin\n libdir ?= $(exec_prefix)/lib\n@@ -58,6 +68,7 @@ rte_symlink = ln -snf $$($(RTE_SDK)/scripts/relpath.sh $1 $(dir $2)) $2\n \n .PHONY: pre_install\n pre_install:\n+ifdef T\n \t$(Q)if [ ! -f $(RTE_OUTPUT)/.config ]; then \\\n \t\t$(MAKE) config O=$(RTE_OUTPUT); \\\n \telif cmp -s $(RTE_OUTPUT)/.config.orig $(RTE_OUTPUT)/.config; then \\\n@@ -74,6 +85,7 @@ pre_install:\n \t\techo \"Using local configuration\"; \\\n \tfi\n \t$(Q)$(MAKE) all O=$(RTE_OUTPUT)\n+endif\n \n .PHONY: install\n install:\n", "prefixes": [ "dpdk-dev", "v3", "05/13" ] }