Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/9265/?format=api
{ "id": 9265, "url": "https://patches.dpdk.org/api/patches/9265/?format=api", "web_url": "https://patches.dpdk.org/project/dpdk/patch/1449116714-17711-1-git-send-email-thomas.monjalon@6wind.com/", "project": { "id": 1, "url": "https://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<1449116714-17711-1-git-send-email-thomas.monjalon@6wind.com>", "list_archive_url": "https://inbox.dpdk.org/dev/1449116714-17711-1-git-send-email-thomas.monjalon@6wind.com", "date": "2015-12-03T04:25:14", "name": "[dpdk-dev] eal: fix build with Xen dom0 enabled", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": true, "hash": "e869706b8b9997bc2f163ffa2865bb06b8cb58c7", "submitter": { "id": 1, "url": "https://patches.dpdk.org/api/people/1/?format=api", "name": "Thomas Monjalon", "email": "thomas.monjalon@6wind.com" }, "delegate": null, "mbox": "https://patches.dpdk.org/project/dpdk/patch/1449116714-17711-1-git-send-email-thomas.monjalon@6wind.com/mbox/", "series": [], "comments": "https://patches.dpdk.org/api/patches/9265/comments/", "check": "pending", "checks": "https://patches.dpdk.org/api/patches/9265/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@dpdk.org", "Delivered-To": "patchwork@dpdk.org", "Received": [ "from [92.243.14.124] (localhost [IPv6:::1])\n\tby dpdk.org (Postfix) with ESMTP id DEE2E8DB2;\n\tThu, 3 Dec 2015 05:26:37 +0100 (CET)", "from mail-wm0-f52.google.com (mail-wm0-f52.google.com\n\t[74.125.82.52]) by dpdk.org (Postfix) with ESMTP id 4BE638D86\n\tfor <dev@dpdk.org>; Thu, 3 Dec 2015 05:26:37 +0100 (CET)", "by wmec201 with SMTP id c201so8657699wme.0\n\tfor <dev@dpdk.org>; Wed, 02 Dec 2015 20:26:37 -0800 (PST)", "from XPS13.ibrowse.com ([93.158.46.55])\n\tby smtp.gmail.com with ESMTPSA id\n\twh10sm5581078wjb.45.2015.12.02.20.26.35\n\t(version=TLSv1/SSLv3 cipher=OTHER);\n\tWed, 02 Dec 2015 20:26:36 -0800 (PST)" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=6wind-com.20150623.gappssmtp.com; s=20150623;\n\th=from:to:cc:subject:date:message-id;\n\tbh=FdT9w7BRQwGDvWsEzPty9ufXkfJ/pedYS5iaTcc8bZc=;\n\tb=VgNzlGRrvD32YcshPHgBm6+iWtRxEuwfrjc0frYsfkjoSwTndLzttLRaPyhPWVUahQ\n\twzVcnZYFnBuzIudziOtb2KiJnoZ5JS1NruMSqF9cmBES3dHO6/UyjDp1yQk258zFX7en\n\tgml0xn6gnuEWHR9Vc88u/DeC5Uwptk5YowA99IemlCZwl/jnsp4ngq7UbRMGpB5n/I0S\n\t8WlIVCw4lWlhJozfYuc030cxS/UoGhlCJ++dIgaAXOE0LzRPc0MA/UYjoO7EGSMG6agE\n\t5/1JXJkbfVC4dnzc9RHe+cdVDGubcxz5Re1Wo2A+/qevIULXjJPywkDaQMHptmoFtawR\n\tCQcw==", "X-Google-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20130820;\n\th=x-gm-message-state:from:to:cc:subject:date:message-id;\n\tbh=FdT9w7BRQwGDvWsEzPty9ufXkfJ/pedYS5iaTcc8bZc=;\n\tb=mSzagTgnniEcWC2BMvySsYskaHBafAcx0N1jCx+OT+x9I6nB4ugylA5FxrGcshMNg3\n\tavKne6sxqImVc6HMOtNCOQEac9xDqpQR8GnShdHnE0ve6zRyYGoBPcNePdP+hPyf5IXe\n\tUUMNRiOsaDhn+YxoYlrrOXPEdC1pJf4m4hqsdnwAYsWwUemPwiSn1+8BmDNMa4WbNQiP\n\tRQVMu204tYtwVMShQ+HV4Usi2Mn4WFmiSDcbAPRHAv1rqV839x0FmeTiz9yGJsKmIkd/\n\ttXeYqCRNP2m99FuYf0XaGBfwF4ca0wNYZsq3PPO3Bdtg2hopez0OgZ5IYJ4I8LL3BgS3\n\t2i6A==", "X-Gm-Message-State": "ALoCoQlFu9j0wO9E4bwGxmJ5ki0hhLrRCWtCSolUDBumDfYCrmHfNfzOwtIu/PZulqlG7sAUw0Cz", "X-Received": "by 10.194.88.200 with SMTP id bi8mr9831398wjb.178.1449116797113; \n\tWed, 02 Dec 2015 20:26:37 -0800 (PST)", "From": "Thomas Monjalon <thomas.monjalon@6wind.com>", "To": "Stephen Hemminger <stephen@networkplumber.org>", "Date": "Thu, 3 Dec 2015 05:25:14 +0100", "Message-Id": "<1449116714-17711-1-git-send-email-thomas.monjalon@6wind.com>", "X-Mailer": "git-send-email 2.5.2", "Cc": "dev@dpdk.org", "Subject": "[dpdk-dev] [PATCH] eal: fix build with Xen dom0 enabled", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "patches and discussions about DPDK <dev.dpdk.org>", "List-Unsubscribe": "<http://dpdk.org/ml/options/dev>,\n\t<mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://dpdk.org/ml/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<http://dpdk.org/ml/listinfo/dev>,\n\t<mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "There is a new function in the EAL API for internal use.\nIt has neither a proper prefix nor a .map export:\nlibethdev.so: undefined reference to `is_xen_dom0_supported'\n\nFixes: 719dbebceb81 (\"xen: allow determining DOM0 at runtime\")\n\nSigned-off-by: Thomas Monjalon <thomas.monjalon@6wind.com>\n---\n drivers/net/i40e/i40e_rxtx.c | 2 +-\n lib/librte_eal/bsdapp/eal/rte_eal_version.map | 1 +\n lib/librte_eal/common/include/rte_memory.h | 6 +++---\n lib/librte_eal/linuxapp/eal/eal_memory.c | 2 +-\n lib/librte_eal/linuxapp/eal/rte_eal_version.map | 1 +\n lib/librte_ether/rte_ethdev.c | 2 +-\n lib/librte_mempool/rte_mempool.c | 2 +-\n 7 files changed, 9 insertions(+), 7 deletions(-)", "diff": "diff --git a/drivers/net/i40e/i40e_rxtx.c b/drivers/net/i40e/i40e_rxtx.c\nindex 13abd67..c6a18b5 100644\n--- a/drivers/net/i40e/i40e_rxtx.c\n+++ b/drivers/net/i40e/i40e_rxtx.c\n@@ -2531,7 +2531,7 @@ i40e_memzone_reserve(const char *name, uint32_t len, int socket_id)\n \tif (mz)\n \t\treturn mz;\n \n-\tif (is_xen_dom0_supported())\n+\tif (rte_xen_dom0_supported())\n \t\tmz = rte_memzone_reserve_bounded(name, len,\n \t\t\t\tsocket_id, 0, I40E_RING_BASE_ALIGN, RTE_PGSIZE_2M);\n \telse\ndiff --git a/lib/librte_eal/bsdapp/eal/rte_eal_version.map b/lib/librte_eal/bsdapp/eal/rte_eal_version.map\nindex f9d4b1c..7a88387 100644\n--- a/lib/librte_eal/bsdapp/eal/rte_eal_version.map\n+++ b/lib/librte_eal/bsdapp/eal/rte_eal_version.map\n@@ -134,5 +134,6 @@ DPDK_2.2 {\n \trte_keepalive_dispatch_pings;\n \trte_keepalive_mark_alive;\n \trte_keepalive_register_core;\n+\trte_xen_dom0_supported;\n \n } DPDK_2.1;\ndiff --git a/lib/librte_eal/common/include/rte_memory.h b/lib/librte_eal/common/include/rte_memory.h\nindex 33f5a77..9c9e40f 100644\n--- a/lib/librte_eal/common/include/rte_memory.h\n+++ b/lib/librte_eal/common/include/rte_memory.h\n@@ -184,7 +184,7 @@ unsigned rte_memory_get_nrank(void);\n #ifdef RTE_LIBRTE_XEN_DOM0\n \n /**< Internal use only - should DOM0 memory mapping be used */\n-extern int is_xen_dom0_supported(void);\n+extern int rte_xen_dom0_supported(void);\n \n /**< Internal use only - phys to virt mapping for xen */\n phys_addr_t rte_xen_mem_phy2mch(uint32_t, const phys_addr_t);\n@@ -203,7 +203,7 @@ phys_addr_t rte_xen_mem_phy2mch(uint32_t, const phys_addr_t);\n static inline phys_addr_t\n rte_mem_phy2mch(uint32_t memseg_id, const phys_addr_t phy_addr)\n {\n-\tif (is_xen_dom0_supported())\n+\tif (rte_xen_dom0_supported())\n \t\treturn rte_xen_mem_phy2mch(memseg_id, phy_addr);\n \telse\n \t\treturn phy_addr;\n@@ -231,7 +231,7 @@ int rte_xen_dom0_memory_init(void);\n */\n int rte_xen_dom0_memory_attach(void);\n #else\n-static inline int is_xen_dom0_supported(void)\n+static inline int rte_xen_dom0_supported(void)\n {\n \treturn 0;\n }\ndiff --git a/lib/librte_eal/linuxapp/eal/eal_memory.c b/lib/librte_eal/linuxapp/eal/eal_memory.c\nindex 0de75cd..846fd31 100644\n--- a/lib/librte_eal/linuxapp/eal/eal_memory.c\n+++ b/lib/librte_eal/linuxapp/eal/eal_memory.c\n@@ -98,7 +98,7 @@\n #include \"eal_hugepages.h\"\n \n #ifdef RTE_LIBRTE_XEN_DOM0\n-int is_xen_dom0_supported(void)\n+int rte_xen_dom0_supported(void)\n {\n \treturn internal_config.xen_dom0_support;\n }\ndiff --git a/lib/librte_eal/linuxapp/eal/rte_eal_version.map b/lib/librte_eal/linuxapp/eal/rte_eal_version.map\nindex 54d496e..828496f 100644\n--- a/lib/librte_eal/linuxapp/eal/rte_eal_version.map\n+++ b/lib/librte_eal/linuxapp/eal/rte_eal_version.map\n@@ -137,5 +137,6 @@ DPDK_2.2 {\n \trte_keepalive_dispatch_pings;\n \trte_keepalive_mark_alive;\n \trte_keepalive_register_core;\n+\trte_xen_dom0_supported;\n \n } DPDK_2.1;\ndiff --git a/lib/librte_ether/rte_ethdev.c b/lib/librte_ether/rte_ethdev.c\nindex 3840775..c3eed49 100644\n--- a/lib/librte_ether/rte_ethdev.c\n+++ b/lib/librte_ether/rte_ethdev.c\n@@ -2605,7 +2605,7 @@ rte_eth_dma_zone_reserve(const struct rte_eth_dev *dev, const char *ring_name,\n \tif (mz)\n \t\treturn mz;\n \n-\tif (is_xen_dom0_supported())\n+\tif (rte_xen_dom0_supported())\n \t\treturn rte_memzone_reserve_bounded(z_name, size, socket_id,\n \t\t\t\t\t\t 0, align, RTE_PGSIZE_2M);\n \telse\ndiff --git a/lib/librte_mempool/rte_mempool.c b/lib/librte_mempool/rte_mempool.c\nindex f53076a..aff5f6d 100644\n--- a/lib/librte_mempool/rte_mempool.c\n+++ b/lib/librte_mempool/rte_mempool.c\n@@ -403,7 +403,7 @@ rte_mempool_create(const char *name, unsigned n, unsigned elt_size,\n \t\t rte_mempool_obj_ctor_t *obj_init, void *obj_init_arg,\n \t\t int socket_id, unsigned flags)\n {\n-\tif (is_xen_dom0_supported())\n+\tif (rte_xen_dom0_supported())\n \t\treturn rte_dom0_mempool_create(name, n, elt_size,\n \t\t\t\t\t cache_size, private_data_size,\n \t\t\t\t\t mp_init, mp_init_arg,\n", "prefixes": [ "dpdk-dev" ] }