Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/92281/?format=api
{ "id": 92281, "url": "https://patches.dpdk.org/api/patches/92281/?format=api", "web_url": "https://patches.dpdk.org/project/dpdk/patch/20210427153811.11554-17-bingz@nvidia.com/", "project": { "id": 1, "url": "https://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20210427153811.11554-17-bingz@nvidia.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20210427153811.11554-17-bingz@nvidia.com", "date": "2021-04-27T15:38:10", "name": "[16/17] net/mlx5: reduce the reference count of CT", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": true, "hash": "a2306cdbbc32a1d50d1406b4bda58b24efc3138c", "submitter": { "id": 1976, "url": "https://patches.dpdk.org/api/people/1976/?format=api", "name": "Bing Zhao", "email": "bingz@nvidia.com" }, "delegate": { "id": 3268, "url": "https://patches.dpdk.org/api/users/3268/?format=api", "username": "rasland", "first_name": "Raslan", "last_name": "Darawsheh", "email": "rasland@nvidia.com" }, "mbox": "https://patches.dpdk.org/project/dpdk/patch/20210427153811.11554-17-bingz@nvidia.com/mbox/", "series": [ { "id": 16705, "url": "https://patches.dpdk.org/api/series/16705/?format=api", "web_url": "https://patches.dpdk.org/project/dpdk/list/?series=16705", "date": "2021-04-27T15:37:54", "name": "conntrack support in mlx5 PMD", "version": 1, "mbox": "https://patches.dpdk.org/series/16705/mbox/" } ], "comments": "https://patches.dpdk.org/api/patches/92281/comments/", "check": "success", "checks": "https://patches.dpdk.org/api/patches/92281/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from mails.dpdk.org (mails.dpdk.org [217.70.189.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id E38FBA0A02;\n\tTue, 27 Apr 2021 17:40:29 +0200 (CEST)", "from [217.70.189.124] (localhost [127.0.0.1])\n\tby mails.dpdk.org (Postfix) with ESMTP id 07234412B0;\n\tTue, 27 Apr 2021 17:39:24 +0200 (CEST)", "from NAM10-BN7-obe.outbound.protection.outlook.com\n (mail-bn7nam10on2070.outbound.protection.outlook.com [40.107.92.70])\n by mails.dpdk.org (Postfix) with ESMTP id 8E1E8410F5\n for <dev@dpdk.org>; Tue, 27 Apr 2021 17:39:21 +0200 (CEST)", "from MW4PR04CA0327.namprd04.prod.outlook.com (2603:10b6:303:82::32)\n by MN2PR12MB4093.namprd12.prod.outlook.com (2603:10b6:208:198::11)\n with Microsoft SMTP Server (version=TLS1_2,\n cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4065.23; Tue, 27 Apr\n 2021 15:39:20 +0000", "from CO1NAM11FT068.eop-nam11.prod.protection.outlook.com\n (2603:10b6:303:82:cafe::4e) by MW4PR04CA0327.outlook.office365.com\n (2603:10b6:303:82::32) with Microsoft SMTP Server (version=TLS1_2,\n cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4065.22 via Frontend\n Transport; Tue, 27 Apr 2021 15:39:20 +0000", "from mail.nvidia.com (216.228.112.34) by\n CO1NAM11FT068.mail.protection.outlook.com (10.13.175.142) with Microsoft SMTP\n Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384) id\n 15.20.4065.21 via Frontend Transport; Tue, 27 Apr 2021 15:39:20 +0000", "from nvidia.com (172.20.145.6) by HQMAIL107.nvidia.com\n (172.20.187.13) with Microsoft SMTP Server (TLS) id 15.0.1497.2; Tue, 27 Apr\n 2021 15:39:18 +0000" ], "ARC-Seal": "i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;\n b=fClo9CyGbFNVMHNs2oGjCV7zN5iu+HW9+TypMXZjZg4uYdB9KYaIn7nV+HbTcJmKbJNutcaQCKtu307mUJeKHAJIh4pCxsukB3qkSimBuiwVtbgwlnky6BpIGPvRU7ap0Isffz+OFHfapdt7vftH2PIV/1wbjR7dgtYoWMWZRSD4QfPJmwz6VhAXcMyhrRDxiTYJjbuJayxZJnob1HYCy4VqfIDkwyTK2rOk1SFfWPsfuIf/fwVdal0p23+ZVAE7vboGqRiCVGSsoE+E3Sf1htFPuaJBlAMd9mdlb0Jb5D2irHO8mZhKIIeDflMxDvN7Q1XODIq9PTDMdoPhKEbGzw==", "ARC-Message-Signature": "i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;\n s=arcselector9901;\n h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;\n bh=syYuTayrmspYgp/kvWZNDeFr/n8om5GI874RD+Ol3iM=;\n b=kDXKYw8MscY9cZfTSVdmYPdwtgWAHV6wF6eAbnpvv4DC6+MNUtfxH1J6YSKEXwqkdrY3jW64LOXqYG5a+S+X6F81JMqseA3J+HVPSwuPjCKUj9j6nHv+74bMDoordF77yL6pQiPyiyJIO3uRN3iXG5RWfKngYCBkwhlVQ9Yf6UULwQG3BjTWfITwkj1LhxcWv8FRchouidiVl0mueLL5B1clEQJ9sVFx1/Kp7386uFVoctIxGhtrsLjZjArw3Y7MfAyE5HKwk0HGXtyIcaUSQc6L6UnYU58i35T13kVKk5ERWKjrMq6dR3jWMEcTrcW7opxO5PzQpVmB8pkDCYSJxA==", "ARC-Authentication-Results": "i=1; mx.microsoft.com 1; spf=pass (sender ip is\n 216.228.112.34) smtp.rcpttodomain=dpdk.org smtp.mailfrom=nvidia.com;\n dmarc=pass (p=none sp=none pct=100) action=none header.from=nvidia.com;\n dkim=none (message not signed); arc=none", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed; d=Nvidia.com;\n s=selector2;\n h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;\n bh=syYuTayrmspYgp/kvWZNDeFr/n8om5GI874RD+Ol3iM=;\n b=F5BdGYeEFC5+IhRA8pRa6PylTEN38ZoCGZQ/3X3g8nFss5zGlllxDuEHSXeMYaaakghB+BsiPqLsgq8bVSOB9wxH/MtaqAcIDdsCxIvoxL2BgsiobvRGYI1KULwG99KmkrLOASBWg1jhb7s1AXe5D5+o2I2V6bRovt7J1LDXLCdJOwE3VSZMOZP5kIJn9a812CD/hG4e3q5N0e/IQnx7MYBhu5mc7cXbxyH2YvoAGlFo+LGoD71O5H2WnIpl7YwYco8LwKcmydxCrpPPgRYkNOwCpgSD4Nk7WJa0uQC2glFI/KBXnVT6r8i3SrV89zCDiDF1MtdRndR1hKR7PZi1mA==", "X-MS-Exchange-Authentication-Results": "spf=pass (sender IP is 216.228.112.34)\n smtp.mailfrom=nvidia.com; dpdk.org; dkim=none (message not signed)\n header.d=none;dpdk.org; dmarc=pass action=none header.from=nvidia.com;", "Received-SPF": "Pass (protection.outlook.com: domain of nvidia.com designates\n 216.228.112.34 as permitted sender) receiver=protection.outlook.com;\n client-ip=216.228.112.34; helo=mail.nvidia.com;", "From": "Bing Zhao <bingz@nvidia.com>", "To": "<viacheslavo@nvidia.com>, <matan@nvidia.com>", "CC": "<dev@dpdk.org>, <orika@nvidia.com>, <rasland@nvidia.com>", "Date": "Tue, 27 Apr 2021 18:38:10 +0300", "Message-ID": "<20210427153811.11554-17-bingz@nvidia.com>", "X-Mailer": "git-send-email 2.27.0", "In-Reply-To": "<20210427153811.11554-1-bingz@nvidia.com>", "References": "<20210427153811.11554-1-bingz@nvidia.com>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "Content-Type": "text/plain", "X-Originating-IP": "[172.20.145.6]", "X-ClientProxiedBy": "HQMAIL107.nvidia.com (172.20.187.13) To\n HQMAIL107.nvidia.com (172.20.187.13)", "X-EOPAttributedMessage": "0", "X-MS-PublicTrafficType": "Email", "X-MS-Office365-Filtering-Correlation-Id": "0e0e1728-3e77-4337-56ba-08d909929fe6", "X-MS-TrafficTypeDiagnostic": "MN2PR12MB4093:", "X-Microsoft-Antispam-PRVS": "\n <MN2PR12MB4093F15D52BBE0926522304ED0419@MN2PR12MB4093.namprd12.prod.outlook.com>", "X-MS-Oob-TLC-OOBClassifiers": "OLM:3826;", "X-MS-Exchange-SenderADCheck": "1", "X-Microsoft-Antispam": "BCL:0;", "X-Microsoft-Antispam-Message-Info": "\n 3aNhJUhMtRWHfDfTn6wixnKevKrq0tOk1Wp/Zryhwf+2CovwLUOIasWWFjxRxjGpxUA3t9G5rbYwrRW+pFRKHfQP6zaAAXZ+EPscU3ozL6LmCdiaQro1bxO//St/t8QfVJgsphSJKMM10H5MoKPn7MCPTvqy2bjg1to3ACFZhemolFQVV/cSpIs/jRpv0r9fLYwQjPWnnUkYoNqwbA1mdIkJawK7SoC/wnlmWMg0/6JwZO5MtmNerTBBa9ls5oKbrTzZShx2gqFYZ90htgTPQ2XZUlRHh9LIvMwnzKFQ9YibkZeqf8Vp+i1SNFMAj8+htcMTqqMvtcYtPpBuGkyE/1w5kbXWoJR6LZjRHR0gGb8h4SfBVt4VwRy8xUql7/cyc0aAyesRAQ9ohx+YsO7nGxTbitTW4EkZK+PA4iUsVtzJZFY+lG/NKjGgnoULBXW0Lsfoc1WORbnhqqCPjpL0HfbQ3WKqZsb40ot48ujpJtH35Yg5Wx16+O8yIFXc4GhfP5K500I8oX40Cikymw+s0Epefs/uTusHegxxI4mbUflK/ivaPeytpft6H4gSNA1STkBtJnd6DNOMV2WH1hqpd4ETwGBnaCusvr8oXnmoE63gOI9LeuC/tOKtpQ7jTTdcZtJAjGBPaGSmyAQVsPbTMw==", "X-Forefront-Antispam-Report": "CIP:216.228.112.34; CTRY:US; LANG:en; SCL:1;\n SRV:;\n IPV:NLI; SFV:NSPM; H:mail.nvidia.com; PTR:schybrid03.nvidia.com; CAT:NONE;\n SFS:(4636009)(396003)(376002)(39860400002)(136003)(346002)(46966006)(36840700001)(36860700001)(70206006)(47076005)(186003)(478600001)(86362001)(7696005)(54906003)(36756003)(82310400003)(110136005)(316002)(356005)(36906005)(6636002)(336012)(6666004)(2616005)(426003)(1076003)(55016002)(2906002)(8936002)(82740400003)(83380400001)(6286002)(5660300002)(4326008)(7636003)(26005)(8676002)(70586007)(16526019)(107886003);\n DIR:OUT; SFP:1101;", "X-OriginatorOrg": "Nvidia.com", "X-MS-Exchange-CrossTenant-OriginalArrivalTime": "27 Apr 2021 15:39:20.1124 (UTC)", "X-MS-Exchange-CrossTenant-Network-Message-Id": "\n 0e0e1728-3e77-4337-56ba-08d909929fe6", "X-MS-Exchange-CrossTenant-Id": "43083d15-7273-40c1-b7db-39efd9ccc17a", "X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp": "\n TenantId=43083d15-7273-40c1-b7db-39efd9ccc17a; Ip=[216.228.112.34];\n Helo=[mail.nvidia.com]", "X-MS-Exchange-CrossTenant-AuthSource": "\n CO1NAM11FT068.eop-nam11.prod.protection.outlook.com", "X-MS-Exchange-CrossTenant-AuthAs": "Anonymous", "X-MS-Exchange-CrossTenant-FromEntityHeader": "HybridOnPrem", "X-MS-Exchange-Transport-CrossTenantHeadersStamped": "MN2PR12MB4093", "Subject": "[dpdk-dev] [PATCH 16/17] net/mlx5: reduce the reference count of CT", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "In order to release the DR actions and reuse the context of a CT,\nthe reference count should be handled correctly, especially in the\nflow destroying.\n\nThe CT index will be recorded in the rte_flow by reusing the age\nindex. The action context type should be saved for CT also. When\ndestroying a flow, if the context type is CT and the index valid.\nThe release process should be handled.\n\nBy default, the handling will fall back to release the age.\n\nSigned-off-by: Bing Zhao <bingz@nvidia.com>\n---\n drivers/net/mlx5/mlx5_flow.h | 6 +++++-\n drivers/net/mlx5/mlx5_flow_dv.c | 7 ++++++-\n 2 files changed, 11 insertions(+), 2 deletions(-)", "diff": "diff --git a/drivers/net/mlx5/mlx5_flow.h b/drivers/net/mlx5/mlx5_flow.h\nindex 3b896e3..4ad9910 100644\n--- a/drivers/net/mlx5/mlx5_flow.h\n+++ b/drivers/net/mlx5/mlx5_flow.h\n@@ -977,11 +977,15 @@ struct rte_flow {\n \tuint32_t drv_type:2; /**< Driver type. */\n \tuint32_t tunnel:1;\n \tuint32_t meter:24; /**< Holds flow meter id. */\n+\tuint32_t indirect_type:2; /**< Indirect action type. */\n \tuint32_t rix_mreg_copy;\n \t/**< Index to metadata register copy table resource. */\n \tuint32_t counter; /**< Holds flow counter. */\n \tuint32_t tunnel_id; /**< Tunnel id */\n-\tuint32_t age; /**< Holds ASO age bit index. */\n+\tunion {\n+\t\tuint32_t age; /**< Holds ASO age bit index. */\n+\t\tuint32_t ct; /**< Holds ASO CT index. */\n+\t};\n \tuint32_t geneve_tlv_option; /**< Holds Geneve TLV option id. > */\n } __rte_packed;\n \ndiff --git a/drivers/net/mlx5/mlx5_flow_dv.c b/drivers/net/mlx5/mlx5_flow_dv.c\nindex 6478625..3e85d5e 100644\n--- a/drivers/net/mlx5/mlx5_flow_dv.c\n+++ b/drivers/net/mlx5/mlx5_flow_dv.c\n@@ -12185,6 +12185,8 @@ flow_dv_translate(struct rte_eth_dev *dev,\n \t\t\telse\n \t\t\t\tdev_flow->dv.actions[actions_n] =\n \t\t\t\t\t\t\tct->dr_action_rply;\n+\t\t\tflow->indirect_type = MLX5_INDIRECT_ACTION_TYPE_CT;\n+\t\t\tflow->ct = ct_idx;\n \t\t\t__atomic_fetch_add(&ct->refcnt, 1, __ATOMIC_RELAXED);\n \t\t\tactions_n++;\n \t\t\taction_flags |= MLX5_FLOW_ACTION_CT;\n@@ -13328,7 +13330,10 @@ flow_dv_destroy(struct rte_eth_dev *dev, struct rte_flow *flow)\n \t\t\tmlx5_flow_meter_detach(priv, fm);\n \t\tflow->meter = 0;\n \t}\n-\tif (flow->age)\n+\t/* Keep the current age handling by default. */\n+\tif (flow->indirect_type == MLX5_INDIRECT_ACTION_TYPE_CT && flow->ct)\n+\t\tflow_dv_aso_ct_release(dev, flow->ct);\n+\telse if (flow->age)\n \t\tflow_dv_aso_age_release(dev, flow->age);\n \tif (flow->geneve_tlv_option) {\n \t\tflow_dv_geneve_tlv_option_resource_release(dev);\n", "prefixes": [ "16/17" ] }