Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/8976/?format=api
{ "id": 8976, "url": "https://patches.dpdk.org/api/patches/8976/?format=api", "web_url": "https://patches.dpdk.org/project/dpdk/patch/1447843689-32315-3-git-send-email-harry.van.haaren@intel.com/", "project": { "id": 1, "url": "https://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<1447843689-32315-3-git-send-email-harry.van.haaren@intel.com>", "list_archive_url": "https://inbox.dpdk.org/dev/1447843689-32315-3-git-send-email-harry.van.haaren@intel.com", "date": "2015-11-18T10:48:08", "name": "[dpdk-dev,v2,2/3] ixgbe: remove crc size from all byte counters", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": true, "hash": "87393d17bb2bd24905c0b59783b09a363f20ff4d", "submitter": { "id": 317, "url": "https://patches.dpdk.org/api/people/317/?format=api", "name": "Van Haaren, Harry", "email": "harry.van.haaren@intel.com" }, "delegate": null, "mbox": "https://patches.dpdk.org/project/dpdk/patch/1447843689-32315-3-git-send-email-harry.van.haaren@intel.com/mbox/", "series": [], "comments": "https://patches.dpdk.org/api/patches/8976/comments/", "check": "pending", "checks": "https://patches.dpdk.org/api/patches/8976/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@dpdk.org", "Delivered-To": "patchwork@dpdk.org", "Received": [ "from [92.243.14.124] (localhost [IPv6:::1])\n\tby dpdk.org (Postfix) with ESMTP id 68A1F8DA7;\n\tWed, 18 Nov 2015 11:48:35 +0100 (CET)", "from mga03.intel.com (mga03.intel.com [134.134.136.65])\n\tby dpdk.org (Postfix) with ESMTP id 81C388D99\n\tfor <dev@dpdk.org>; Wed, 18 Nov 2015 11:48:31 +0100 (CET)", "from orsmga003.jf.intel.com ([10.7.209.27])\n\tby orsmga103.jf.intel.com with ESMTP; 18 Nov 2015 02:48:30 -0800", "from sie-lab-212-222.ir.intel.com (HELO\n\tsilpixa00366884.ir.intel.com) ([10.237.212.222])\n\tby orsmga003.jf.intel.com with ESMTP; 18 Nov 2015 02:48:29 -0800" ], "X-ExtLoop1": "1", "X-IronPort-AV": "E=Sophos;i=\"5.20,312,1444719600\"; d=\"scan'208\";a=\"688363531\"", "From": "Harry van Haaren <harry.van.haaren@intel.com>", "To": "dev@dpdk.org", "Date": "Wed, 18 Nov 2015 10:48:08 +0000", "Message-Id": "<1447843689-32315-3-git-send-email-harry.van.haaren@intel.com>", "X-Mailer": "git-send-email 1.9.1", "In-Reply-To": "<1447843689-32315-1-git-send-email-harry.van.haaren@intel.com>", "References": "<1447670117-17723-1-git-send-email-harry.van.haaren@intel.com>\n\t<1447843689-32315-1-git-send-email-harry.van.haaren@intel.com>", "Cc": "shemming@brocade.com", "Subject": "[dpdk-dev] [PATCH v2 2/3] ixgbe: remove crc size from all byte\n\tcounters", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "patches and discussions about DPDK <dev.dpdk.org>", "List-Unsubscribe": "<http://dpdk.org/ml/options/dev>,\n\t<mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://dpdk.org/ml/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<http://dpdk.org/ml/listinfo/dev>,\n\t<mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "This patch removes the crc bytes from byte counter statistics.\n\nSigned-off-by: Harry van Haaren <harry.van.haaren@intel.com>\n---\n drivers/net/ixgbe/ixgbe_ethdev.c | 55 +++++++++++++++++++++++++++++++---------\n 1 file changed, 43 insertions(+), 12 deletions(-)", "diff": "diff --git a/drivers/net/ixgbe/ixgbe_ethdev.c b/drivers/net/ixgbe/ixgbe_ethdev.c\nindex 80801f0..0124b1c 100644\n--- a/drivers/net/ixgbe/ixgbe_ethdev.c\n+++ b/drivers/net/ixgbe/ixgbe_ethdev.c\n@@ -2331,13 +2331,21 @@ ixgbe_dev_close(struct rte_eth_dev *dev)\n }\n \n static void\n-ixgbe_read_stats_registers(struct ixgbe_hw *hw, struct ixgbe_hw_stats\n-\t\t\t\t\t\t *hw_stats, uint64_t *total_missed_rx,\n-\t\t\t\t\t\t uint64_t *total_qbrc, uint64_t *total_qprc,\n-\t\t\t\t\t\t uint64_t *total_qprdc)\n+ixgbe_read_stats_registers(struct ixgbe_hw *hw,\n+\t\t\t struct ixgbe_hw_stats *hw_stats,\n+\t\t\t uint64_t *total_missed_rx, uint64_t *total_qbrc,\n+\t\t\t uint64_t *total_qprc, uint64_t *total_qprdc)\n {\n \tuint32_t bprc, lxon, lxoff, total;\n+\tuint32_t delta_gprc = 0;\n+\tuint32_t delta_gptc = 0;\n \tunsigned i;\n+\t/* Workaround for RX byte count not including CRC bytes when CRC\n++\t * strip is enabled. CRC bytes are removed from counters when crc_strip\n+\t * is disabled.\n++\t */\n+\tint crc_strip = (IXGBE_READ_REG(hw, IXGBE_HLREG0) &\n+\t\t\tIXGBE_HLREG0_RXCRCSTRP);\n \n \thw_stats->crcerrs += IXGBE_READ_REG(hw, IXGBE_CRCERRS);\n \thw_stats->illerrc += IXGBE_READ_REG(hw, IXGBE_ILLERRC);\n@@ -2372,16 +2380,28 @@ ixgbe_read_stats_registers(struct ixgbe_hw *hw, struct ixgbe_hw_stats\n \t\t IXGBE_READ_REG(hw, IXGBE_PXOFFTXC(i));\n \t}\n \tfor (i = 0; i < IXGBE_QUEUE_STAT_COUNTERS; i++) {\n-\t\thw_stats->qprc[i] += IXGBE_READ_REG(hw, IXGBE_QPRC(i));\n-\t\thw_stats->qptc[i] += IXGBE_READ_REG(hw, IXGBE_QPTC(i));\n+\t\tuint32_t delta_qprc = IXGBE_READ_REG(hw, IXGBE_QPRC(i));\n+\t\tuint32_t delta_qptc = IXGBE_READ_REG(hw, IXGBE_QPTC(i));\n+\t\tuint32_t delta_qprdc = IXGBE_READ_REG(hw, IXGBE_QPRDC(i));\n+\n+\t\tdelta_gprc += delta_qprc;\n+\t\tdelta_gptc += delta_qptc;\n+\n+\t\thw_stats->qprc[i] += delta_qprc;\n+\t\thw_stats->qptc[i] += delta_qptc;\n+\n \t\thw_stats->qbrc[i] += IXGBE_READ_REG(hw, IXGBE_QBRC_L(i));\n \t\thw_stats->qbrc[i] +=\n \t\t ((uint64_t)IXGBE_READ_REG(hw, IXGBE_QBRC_H(i)) << 32);\n+\t\tif (crc_strip == 0)\n+\t\t\thw_stats->qbrc[i] -= delta_qprc * ETHER_CRC_LEN;\n+\n \t\thw_stats->qbtc[i] += IXGBE_READ_REG(hw, IXGBE_QBTC_L(i));\n \t\thw_stats->qbtc[i] +=\n \t\t ((uint64_t)IXGBE_READ_REG(hw, IXGBE_QBTC_H(i)) << 32);\n-\t\t*total_qprdc += hw_stats->qprdc[i] +=\n-\t\t\t\tIXGBE_READ_REG(hw, IXGBE_QPRDC(i));\n+\n+\t\thw_stats->qprdc[i] += delta_qprdc;\n+\t\t*total_qprdc += hw_stats->qprdc[i];\n \n \t\t*total_qprc += hw_stats->qprc[i];\n \t\t*total_qbrc += hw_stats->qbrc[i];\n@@ -2390,8 +2410,11 @@ ixgbe_read_stats_registers(struct ixgbe_hw *hw, struct ixgbe_hw_stats\n \thw_stats->mrfc += IXGBE_READ_REG(hw, IXGBE_MRFC);\n \thw_stats->rlec += IXGBE_READ_REG(hw, IXGBE_RLEC);\n \n-\t/* Note that gprc counts missed packets */\n-\thw_stats->gprc += IXGBE_READ_REG(hw, IXGBE_GPRC);\n+\t/*\n+\t * An errata states that gprc actually counts good + missed packets:\n+\t * Workaround to set gprc to summated queue packet recieves\n+\t */\n+\thw_stats->gprc = *total_qprc;\n \n \tif (hw->mac.type != ixgbe_mac_82598EB) {\n \t\thw_stats->gorc += IXGBE_READ_REG(hw, IXGBE_GORCL);\n@@ -2410,6 +2433,16 @@ ixgbe_read_stats_registers(struct ixgbe_hw *hw, struct ixgbe_hw_stats\n \t\thw_stats->gotc += IXGBE_READ_REG(hw, IXGBE_GOTCH);\n \t\thw_stats->tor += IXGBE_READ_REG(hw, IXGBE_TORH);\n \t}\n+\tuint64_t old_tpr = hw_stats->tpr;\n+\n+\thw_stats->tpr += IXGBE_READ_REG(hw, IXGBE_TPR);\n+\thw_stats->tpt += IXGBE_READ_REG(hw, IXGBE_TPT);\n+\n+\tif (crc_strip == 0)\n+\t\thw_stats->gorc -= delta_gprc * ETHER_CRC_LEN;\n+\n+\thw_stats->gotc -= delta_gptc * ETHER_CRC_LEN;\n+\thw_stats->tor -= (hw_stats->tpr - old_tpr) * ETHER_CRC_LEN;\n \n \t/*\n \t * Workaround: mprc hardware is incorrectly counting\n@@ -2449,8 +2482,6 @@ ixgbe_read_stats_registers(struct ixgbe_hw *hw, struct ixgbe_hw_stats\n \thw_stats->mngprc += IXGBE_READ_REG(hw, IXGBE_MNGPRC);\n \thw_stats->mngpdc += IXGBE_READ_REG(hw, IXGBE_MNGPDC);\n \thw_stats->mngptc += IXGBE_READ_REG(hw, IXGBE_MNGPTC);\n-\thw_stats->tpr += IXGBE_READ_REG(hw, IXGBE_TPR);\n-\thw_stats->tpt += IXGBE_READ_REG(hw, IXGBE_TPT);\n \thw_stats->ptc127 += IXGBE_READ_REG(hw, IXGBE_PTC127);\n \thw_stats->ptc255 += IXGBE_READ_REG(hw, IXGBE_PTC255);\n \thw_stats->ptc511 += IXGBE_READ_REG(hw, IXGBE_PTC511);\n", "prefixes": [ "dpdk-dev", "v2", "2/3" ] }