Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/88319/?format=api
{ "id": 88319, "url": "https://patches.dpdk.org/api/patches/88319/?format=api", "web_url": "https://patches.dpdk.org/project/dpdk/patch/1614595291-112120-1-git-send-email-matan@nvidia.com/", "project": { "id": 1, "url": "https://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<1614595291-112120-1-git-send-email-matan@nvidia.com>", "list_archive_url": "https://inbox.dpdk.org/dev/1614595291-112120-1-git-send-email-matan@nvidia.com", "date": "2021-03-01T10:41:31", "name": "vdpa/mlx5: fix virtq cleaning", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": true, "hash": "7e94d71a6fc4d62a24ff2a9e186162a68c162d67", "submitter": { "id": 1911, "url": "https://patches.dpdk.org/api/people/1911/?format=api", "name": "Matan Azrad", "email": "matan@nvidia.com" }, "delegate": { "id": 2642, "url": "https://patches.dpdk.org/api/users/2642/?format=api", "username": "mcoquelin", "first_name": "Maxime", "last_name": "Coquelin", "email": "maxime.coquelin@redhat.com" }, "mbox": "https://patches.dpdk.org/project/dpdk/patch/1614595291-112120-1-git-send-email-matan@nvidia.com/mbox/", "series": [ { "id": 15419, "url": "https://patches.dpdk.org/api/series/15419/?format=api", "web_url": "https://patches.dpdk.org/project/dpdk/list/?series=15419", "date": "2021-03-01T10:41:31", "name": "vdpa/mlx5: fix virtq cleaning", "version": 1, "mbox": "https://patches.dpdk.org/series/15419/mbox/" } ], "comments": "https://patches.dpdk.org/api/patches/88319/comments/", "check": "fail", "checks": "https://patches.dpdk.org/api/patches/88319/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from mails.dpdk.org (mails.dpdk.org [217.70.189.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id BA07DA054F;\n\tMon, 1 Mar 2021 11:41:43 +0100 (CET)", "from [217.70.189.124] (localhost [127.0.0.1])\n\tby mails.dpdk.org (Postfix) with ESMTP id 7EFE61CC563;\n\tMon, 1 Mar 2021 11:41:43 +0100 (CET)", "from mellanox.co.il (mail-il-dmz.mellanox.com [193.47.165.129])\n by mails.dpdk.org (Postfix) with ESMTP id BE48F4067B\n for <dev@dpdk.org>; Mon, 1 Mar 2021 11:41:41 +0100 (CET)", "from Internal Mail-Server by MTLPINE1 (envelope-from\n matan@nvidia.com) with SMTP; 1 Mar 2021 12:41:38 +0200", "from pegasus25.mtr.labs.mlnx. (pegasus25.mtr.labs.mlnx\n [10.210.16.10])\n by labmailer.mlnx (8.13.8/8.13.8) with ESMTP id 121Afc2H015685;\n Mon, 1 Mar 2021 12:41:38 +0200" ], "From": "Matan Azrad <matan@nvidia.com>", "To": "dev@dpdk.org", "Cc": "Maxime Coquelin <maxime.coquelin@redhat.com>, stable@dpdk.org", "Date": "Mon, 1 Mar 2021 10:41:31 +0000", "Message-Id": "<1614595291-112120-1-git-send-email-matan@nvidia.com>", "X-Mailer": "git-send-email 1.8.3.1", "Subject": "[dpdk-dev] [PATCH] vdpa/mlx5: fix virtq cleaning", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "The HW virtq object can be destroyed ether when the device is closed or\nwhen the state of the virtq becomes disabled.\n\nSome parameters of the virtq should continue to be managed when the\nvirtq state is changed but all of them must be initialized when the\ndevice is closed.\n\nWrongly, the enable parameter stayed on when the device is closed what\nmight cause creation of invalid virtq in the next time a device is\nassigned to the driver.\n\nClean all the virtqs memory when the device is closed.\n\nFixes: c47d6e83334e (\"vdpa/mlx5: support queue update\")\nCc: stable@dpdk.org\n\nSigned-off-by: Matan Azrad <matan@nvidia.com>\nAcked-by: Xueming Li <xuemingl@nvidia.com>\n---\n drivers/vdpa/mlx5/mlx5_vdpa_virtq.c | 8 ++------\n 1 file changed, 2 insertions(+), 6 deletions(-)", "diff": "diff --git a/drivers/vdpa/mlx5/mlx5_vdpa_virtq.c b/drivers/vdpa/mlx5/mlx5_vdpa_virtq.c\nindex ef2642a..024c5c4 100644\n--- a/drivers/vdpa/mlx5/mlx5_vdpa_virtq.c\n+++ b/drivers/vdpa/mlx5/mlx5_vdpa_virtq.c\n@@ -103,13 +103,8 @@\n \tfor (i = 0; i < priv->nr_virtqs; i++) {\n \t\tvirtq = &priv->virtqs[i];\n \t\tmlx5_vdpa_virtq_unset(virtq);\n-\t\tif (virtq->counters) {\n+\t\tif (virtq->counters)\n \t\t\tclaim_zero(mlx5_devx_cmd_destroy(virtq->counters));\n-\t\t\tvirtq->counters = NULL;\n-\t\t\tmemset(&virtq->reset, 0, sizeof(virtq->reset));\n-\t\t}\n-\t\tmemset(virtq->err_time, 0, sizeof(virtq->err_time));\n-\t\tvirtq->n_retry = 0;\n \t}\n \tfor (i = 0; i < priv->num_lag_ports; i++) {\n \t\tif (priv->tiss[i]) {\n@@ -126,6 +121,7 @@\n \t\tpriv->virtq_db_addr = NULL;\n \t}\n \tpriv->features = 0;\n+\tmemset(priv->virtqs, 0, sizeof(*virtq) * priv->nr_virtqs);\n \tpriv->nr_virtqs = 0;\n }\n \n", "prefixes": [] }