Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/87963/?format=api
{ "id": 87963, "url": "https://patches.dpdk.org/api/patches/87963/?format=api", "web_url": "https://patches.dpdk.org/project/dpdk/patch/20210217162656.1983277-1-ferruh.yigit@intel.com/", "project": { "id": 1, "url": "https://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20210217162656.1983277-1-ferruh.yigit@intel.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20210217162656.1983277-1-ferruh.yigit@intel.com", "date": "2021-02-17T16:26:55", "name": "[v3] net/bonding: fix LACP system address check", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": true, "hash": "e05261801efc1c3ffc05da1366bbcb9c44e84106", "submitter": { "id": 324, "url": "https://patches.dpdk.org/api/people/324/?format=api", "name": "Ferruh Yigit", "email": "ferruh.yigit@intel.com" }, "delegate": { "id": 319, "url": "https://patches.dpdk.org/api/users/319/?format=api", "username": "fyigit", "first_name": "Ferruh", "last_name": "Yigit", "email": "ferruh.yigit@amd.com" }, "mbox": "https://patches.dpdk.org/project/dpdk/patch/20210217162656.1983277-1-ferruh.yigit@intel.com/mbox/", "series": [ { "id": 15275, "url": "https://patches.dpdk.org/api/series/15275/?format=api", "web_url": "https://patches.dpdk.org/project/dpdk/list/?series=15275", "date": "2021-02-17T16:26:55", "name": "[v3] net/bonding: fix LACP system address check", "version": 3, "mbox": "https://patches.dpdk.org/series/15275/mbox/" } ], "comments": "https://patches.dpdk.org/api/patches/87963/comments/", "check": "fail", "checks": "https://patches.dpdk.org/api/patches/87963/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from mails.dpdk.org (mails.dpdk.org [217.70.189.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id 873FCA054D;\n\tWed, 17 Feb 2021 17:27:11 +0100 (CET)", "from [217.70.189.124] (localhost [127.0.0.1])\n\tby mails.dpdk.org (Postfix) with ESMTP id F3DF34069D;\n\tWed, 17 Feb 2021 17:27:10 +0100 (CET)", "from mga07.intel.com (mga07.intel.com [134.134.136.100])\n by mails.dpdk.org (Postfix) with ESMTP id 363AA40690;\n Wed, 17 Feb 2021 17:27:07 +0100 (CET)", "from fmsmga004.fm.intel.com ([10.253.24.48])\n by orsmga105.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384;\n 17 Feb 2021 08:27:05 -0800", "from silpixa00399752.ir.intel.com (HELO\n silpixa00399752.ger.corp.intel.com) ([10.237.222.27])\n by fmsmga004.fm.intel.com with ESMTP; 17 Feb 2021 08:27:02 -0800" ], "IronPort-SDR": [ "\n /wp4Dtm3onbnAa2u2Wi11VDRZoKhiMD94kQi9MFFggnxjIOQ5FmBzZKtsm2fARnFfWRL4jSrsN\n FMzDX9EIi7jA==", "\n O9JYvlrde3uvalNqqiITqKDuRv79ht5XeK3hlRtzHWn1xs6fUF2f6lGq/fWQ3kfHbytn+BqRrK\n 9Az/ROllULAA==" ], "X-IronPort-AV": [ "E=McAfee;i=\"6000,8403,9897\"; a=\"247310784\"", "E=Sophos;i=\"5.81,184,1610438400\"; d=\"scan'208\";a=\"247310784\"", "E=Sophos;i=\"5.81,184,1610438400\"; d=\"scan'208\";a=\"419135602\"" ], "X-ExtLoop1": "1", "From": "Ferruh Yigit <ferruh.yigit@intel.com>", "To": "Chas Williams <chas3@att.com>, \"Min Hu (Connor)\" <humin29@huawei.com>,\n Liang Zhang <zhangliang@bigo.sg>", "Cc": "Ferruh Yigit <ferruh.yigit@intel.com>, dev@dpdk.org,\n Vadim Podovinnikov <podovinnikov@protei.ru>, stable@dpdk.org,\n Declan Doherty <declan.doherty@intel.com>", "Date": "Wed, 17 Feb 2021 16:26:55 +0000", "Message-Id": "<20210217162656.1983277-1-ferruh.yigit@intel.com>", "X-Mailer": "git-send-email 2.29.2", "In-Reply-To": "<20191126115508.11138-1-podovinnikov@protei.ru>", "References": "<20191126115508.11138-1-podovinnikov@protei.ru>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "Subject": "[dpdk-dev] [PATCH v3] net/bonding: fix LACP system address check", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "From: Vadim Podovinnikov <podovinnikov@protei.ru>\n\nIn bond (LACP) we have several NICs (ports), when we have negotiation\nwith peer about what port we prefer, we send information about what\nsystem we preferred in partner system name field. Peer also sends us\nwhat partner system name it prefer.\n\nWhen we receive a message from it we must compare its preferred system\nname with our system name, but not with our port mac address\n\nIn my test I have several problems with that:\n1. If master port (mac address same as system address) shuts down (I\n have two ports) I loose connection\n2. If secondary port (mac address not same as system address) receives\n message before master port, my connection is not established.\n\nFixes: 56cbc0817399 (\"net/bonding: fix LACP negotiation\")\nCc: stable@dpdk.org\n\nSigned-off-by: Vadim Podovinnikov <podovinnikov@protei.ru>\n---\nCc: zhangliang@bigo.sg\nCc: Declan Doherty <declan.doherty@intel.com>\n\nv3: Re-sent with rebase\n* Patch title updated, commit log updated with info shared in email\n* Sign-off updated with full name\n* Debug log slightly updated\n* Syntax slightly updated\n---\n drivers/net/bonding/rte_eth_bond_8023ad.c | 17 ++++++++++++++++-\n 1 file changed, 16 insertions(+), 1 deletion(-)", "diff": "diff --git a/drivers/net/bonding/rte_eth_bond_8023ad.c b/drivers/net/bonding/rte_eth_bond_8023ad.c\nindex 5fe004e551de..128754f4595a 100644\n--- a/drivers/net/bonding/rte_eth_bond_8023ad.c\n+++ b/drivers/net/bonding/rte_eth_bond_8023ad.c\n@@ -804,19 +804,34 @@ rx_machine_update(struct bond_dev_private *internals, uint16_t slave_id,\n \t\tstruct rte_mbuf *lacp_pkt) {\n \tstruct lacpdu_header *lacp;\n \tstruct lacpdu_actor_partner_params *partner;\n+\tstruct port *port, *agg;\n \n \tif (lacp_pkt != NULL) {\n \t\tlacp = rte_pktmbuf_mtod(lacp_pkt, struct lacpdu_header *);\n \t\tRTE_ASSERT(lacp->lacpdu.subtype == SLOW_SUBTYPE_LACP);\n \n \t\tpartner = &lacp->lacpdu.partner;\n+\t\tport = &bond_mode_8023ad_ports[slave_id];\n+\t\tagg = &bond_mode_8023ad_ports[port->aggregator_port_id];\n+\n \t\tif (rte_is_zero_ether_addr(&partner->port_params.system) ||\n \t\t\trte_is_same_ether_addr(&partner->port_params.system,\n-\t\t\t&internals->mode4.mac_addr)) {\n+\t\t\t\t&agg->actor.system)) {\n \t\t\t/* This LACP frame is sending to the bonding port\n \t\t\t * so pass it to rx_machine.\n \t\t\t */\n \t\t\trx_machine(internals, slave_id, &lacp->lacpdu);\n+\t\t} else {\n+\t\t\tchar preferred_system_name[RTE_ETHER_ADDR_FMT_SIZE];\n+\t\t\tchar self_system_name[RTE_ETHER_ADDR_FMT_SIZE];\n+\n+\t\t\trte_ether_format_addr(preferred_system_name,\n+\t\t\t\tRTE_ETHER_ADDR_FMT_SIZE, &partner->port_params.system);\n+\t\t\trte_ether_format_addr(self_system_name,\n+\t\t\t\tRTE_ETHER_ADDR_FMT_SIZE, &agg->actor.system);\n+\t\t\tMODE4_DEBUG(\"preferred partner system %s \"\n+\t\t\t\t\"is not equal with self system: %s\\n\",\n+\t\t\t\tpreferred_system_name, self_system_name);\n \t\t}\n \t\trte_pktmbuf_free(lacp_pkt);\n \t} else\n", "prefixes": [ "v3" ] }