Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/87576/?format=api
{ "id": 87576, "url": "https://patches.dpdk.org/api/patches/87576/?format=api", "web_url": "https://patches.dpdk.org/project/dpdk/patch/20210131130613.55631-1-Cheng1.jiang@intel.com/", "project": { "id": 1, "url": "https://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20210131130613.55631-1-Cheng1.jiang@intel.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20210131130613.55631-1-Cheng1.jiang@intel.com", "date": "2021-01-31T13:06:13", "name": "[v2] examples/vhost: remove async inflight packet counter", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": true, "hash": "217d84ded6b9a9652b5a118f334e524f9285513f", "submitter": { "id": 1530, "url": "https://patches.dpdk.org/api/people/1530/?format=api", "name": "Jiang, Cheng1", "email": "Cheng1.jiang@intel.com" }, "delegate": { "id": 2642, "url": "https://patches.dpdk.org/api/users/2642/?format=api", "username": "mcoquelin", "first_name": "Maxime", "last_name": "Coquelin", "email": "maxime.coquelin@redhat.com" }, "mbox": "https://patches.dpdk.org/project/dpdk/patch/20210131130613.55631-1-Cheng1.jiang@intel.com/mbox/", "series": [ { "id": 15046, "url": "https://patches.dpdk.org/api/series/15046/?format=api", "web_url": "https://patches.dpdk.org/project/dpdk/list/?series=15046", "date": "2021-01-31T13:06:13", "name": "[v2] examples/vhost: remove async inflight packet counter", "version": 2, "mbox": "https://patches.dpdk.org/series/15046/mbox/" } ], "comments": "https://patches.dpdk.org/api/patches/87576/comments/", "check": "fail", "checks": "https://patches.dpdk.org/api/patches/87576/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from mails.dpdk.org (mails.dpdk.org [217.70.189.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id 42F86A0A0D;\n\tSun, 31 Jan 2021 14:17:19 +0100 (CET)", "from [217.70.189.124] (localhost [127.0.0.1])\n\tby mails.dpdk.org (Postfix) with ESMTP id 0549340693;\n\tSun, 31 Jan 2021 14:17:19 +0100 (CET)", "from mga05.intel.com (mga05.intel.com [192.55.52.43])\n by mails.dpdk.org (Postfix) with ESMTP id AC1EF40692\n for <dev@dpdk.org>; Sun, 31 Jan 2021 14:17:16 +0100 (CET)", "from fmsmga008.fm.intel.com ([10.253.24.58])\n by fmsmga105.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384;\n 31 Jan 2021 05:17:15 -0800", "from dpdk_jiangcheng.sh.intel.com ([10.67.119.112])\n by fmsmga008.fm.intel.com with ESMTP; 31 Jan 2021 05:17:14 -0800" ], "IronPort-SDR": [ "\n oJolKLRG0kUe2ilXQW9qfR1X6nO9ghUt6BMdWaj3hlntiVsOwgXqCVe58cOBjQRsg20dUPbsl5\n jUKOSI77iBTw==", "\n X3s7O7qdnA9oa7bKnYI0TxAs95tQY+QbGPJimxxuCLI2fdGsmxwXX6nXxfavaWbXW/FCc5wR9/\n pO6NmTieW6sw==" ], "X-IronPort-AV": [ "E=McAfee;i=\"6000,8403,9880\"; a=\"265419622\"", "E=Sophos;i=\"5.79,390,1602572400\"; d=\"scan'208\";a=\"265419622\"", "E=Sophos;i=\"5.79,390,1602572400\"; d=\"scan'208\";a=\"367555160\"" ], "X-ExtLoop1": "1", "From": "Cheng Jiang <Cheng1.jiang@intel.com>", "To": "maxime.coquelin@redhat.com,\n\tchenbo.xia@intel.com", "Cc": "dev@dpdk.org, jiayu.hu@intel.com, yvonnex.yang@intel.com,\n yinan.wang@intel.com, Cheng Jiang <Cheng1.jiang@intel.com>", "Date": "Sun, 31 Jan 2021 13:06:13 +0000", "Message-Id": "<20210131130613.55631-1-Cheng1.jiang@intel.com>", "X-Mailer": "git-send-email 2.29.2", "In-Reply-To": "<20210131125617.53078-1-Cheng1.jiang@intel.com>", "References": "<20210131125617.53078-1-Cheng1.jiang@intel.com>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "Subject": "[dpdk-dev] [PATCH v2] examples/vhost: remove async inflight packet\n counter", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "Remove async inflight packet counter since there is no need to keep\ntracking it. Increase MAX_ENQUEUED_SIZE to prevent packet segment number\ntracking ring from being exhausted.\n\nFixes: 63dabdeda690 (\"examples/vhost: refactor vhost data path\")\n\nSigned-off-by: Cheng Jiang <Cheng1.jiang@intel.com>\n---\nv2: fixed a typo\n\n examples/vhost/ioat.h | 2 +-\n examples/vhost/main.c | 10 +---------\n examples/vhost/main.h | 1 -\n 3 files changed, 2 insertions(+), 11 deletions(-)\n\n--\n2.29.2", "diff": "diff --git a/examples/vhost/ioat.h b/examples/vhost/ioat.h\nindex 0a1dbb811..1aa28ed6a 100644\n--- a/examples/vhost/ioat.h\n+++ b/examples/vhost/ioat.h\n@@ -11,7 +11,7 @@\n\n #define MAX_VHOST_DEVICE 1024\n #define IOAT_RING_SIZE 4096\n-#define MAX_ENQUEUED_SIZE 512\n+#define MAX_ENQUEUED_SIZE 4096\n\n struct dma_info {\n \tstruct rte_pci_addr addr;\ndiff --git a/examples/vhost/main.c b/examples/vhost/main.c\nindex 233a2dc6e..99e8d9c69 100644\n--- a/examples/vhost/main.c\n+++ b/examples/vhost/main.c\n@@ -831,11 +831,8 @@ complete_async_pkts(struct vhost_dev *vdev)\n\n \tcomplete_count = rte_vhost_poll_enqueue_completed(vdev->vid,\n \t\t\t\t\tVIRTIO_RXQ, p_cpl, MAX_PKT_BURST);\n-\tif (complete_count) {\n-\t\t__atomic_sub_fetch(&vdev->nr_async_pkts, complete_count,\n-\t\t\t__ATOMIC_SEQ_CST);\n+\tif (complete_count)\n \t\tfree_pkts(p_cpl, complete_count);\n-\t}\n }\n\n static __rte_always_inline void\n@@ -878,8 +875,6 @@ drain_vhost(struct vhost_dev *vdev)\n \t\tcomplete_async_pkts(vdev);\n \t\tret = rte_vhost_submit_enqueue_burst(vdev->vid, VIRTIO_RXQ,\n \t\t\t\t\tm, nr_xmit, m_cpu_cpl, &cpu_cpl_nr);\n-\t\t__atomic_add_fetch(&vdev->nr_async_pkts, ret - cpu_cpl_nr,\n-\t\t\t\t__ATOMIC_SEQ_CST);\n\n \t\tif (cpu_cpl_nr)\n \t\t\tfree_pkts(m_cpu_cpl, cpu_cpl_nr);\n@@ -1210,9 +1205,6 @@ drain_eth_rx(struct vhost_dev *vdev)\n \t\tenqueue_count = rte_vhost_submit_enqueue_burst(vdev->vid,\n \t\t\t\t\tVIRTIO_RXQ, pkts, rx_count,\n \t\t\t\t\tm_cpu_cpl, &cpu_cpl_nr);\n-\t\t__atomic_add_fetch(&vdev->nr_async_pkts,\n-\t\t\t\t\tenqueue_count - cpu_cpl_nr,\n-\t\t\t\t\t__ATOMIC_SEQ_CST);\n \t\tif (cpu_cpl_nr)\n \t\t\tfree_pkts(m_cpu_cpl, cpu_cpl_nr);\n\ndiff --git a/examples/vhost/main.h b/examples/vhost/main.h\nindex 2d6c05fd7..0ccdce4b4 100644\n--- a/examples/vhost/main.h\n+++ b/examples/vhost/main.h\n@@ -51,7 +51,6 @@ struct vhost_dev {\n \tuint64_t features;\n \tsize_t hdr_len;\n \tuint16_t nr_vrings;\n-\tuint64_t nr_async_pkts;\n \tstruct rte_vhost_memory *mem;\n \tstruct device_statistics stats;\n \tTAILQ_ENTRY(vhost_dev) global_vdev_entry;\n", "prefixes": [ "v2" ] }