Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/87400/?format=api
{ "id": 87400, "url": "https://patches.dpdk.org/api/patches/87400/?format=api", "web_url": "https://patches.dpdk.org/project/dpdk/patch/20210127135305.15260-1-viacheslavo@nvidia.com/", "project": { "id": 1, "url": "https://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20210127135305.15260-1-viacheslavo@nvidia.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20210127135305.15260-1-viacheslavo@nvidia.com", "date": "2021-01-27T13:53:05", "name": "net/mlx5: fix wire vport hint", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": true, "hash": "4c4ac9811503ac6aed2477d5417846f2dd445144", "submitter": { "id": 1926, "url": "https://patches.dpdk.org/api/people/1926/?format=api", "name": "Slava Ovsiienko", "email": "viacheslavo@nvidia.com" }, "delegate": { "id": 3268, "url": "https://patches.dpdk.org/api/users/3268/?format=api", "username": "rasland", "first_name": "Raslan", "last_name": "Darawsheh", "email": "rasland@nvidia.com" }, "mbox": "https://patches.dpdk.org/project/dpdk/patch/20210127135305.15260-1-viacheslavo@nvidia.com/mbox/", "series": [ { "id": 14971, "url": "https://patches.dpdk.org/api/series/14971/?format=api", "web_url": "https://patches.dpdk.org/project/dpdk/list/?series=14971", "date": "2021-01-27T13:53:05", "name": "net/mlx5: fix wire vport hint", "version": 1, "mbox": "https://patches.dpdk.org/series/14971/mbox/" } ], "comments": "https://patches.dpdk.org/api/patches/87400/comments/", "check": "fail", "checks": "https://patches.dpdk.org/api/patches/87400/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from mails.dpdk.org (mails.dpdk.org [217.70.189.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id 77D92A052A;\n\tWed, 27 Jan 2021 14:53:12 +0100 (CET)", "from [217.70.189.124] (localhost [127.0.0.1])\n\tby mails.dpdk.org (Postfix) with ESMTP id F30C3140DBE;\n\tWed, 27 Jan 2021 14:53:10 +0100 (CET)", "from mellanox.co.il (mail-il-dmz.mellanox.com [193.47.165.129])\n by mails.dpdk.org (Postfix) with ESMTP id 354B1140DA2\n for <dev@dpdk.org>; Wed, 27 Jan 2021 14:53:09 +0100 (CET)", "from Internal Mail-Server by MTLPINE1 (envelope-from\n viacheslavo@nvidia.com) with SMTP; 27 Jan 2021 15:53:06 +0200", "from nvidia.com (pegasus11.mtr.labs.mlnx [10.210.16.104])\n by labmailer.mlnx (8.13.8/8.13.8) with ESMTP id 10RDr6Q2012409;\n Wed, 27 Jan 2021 15:53:06 +0200" ], "From": "Viacheslav Ovsiienko <viacheslavo@nvidia.com>", "To": "dev@dpdk.org", "Cc": "rasland@nvidia.com, matan@nvidia.com, orika@nvidia.com,\n thomas@monjalon.net, stable@dpdk.org", "Date": "Wed, 27 Jan 2021 15:53:05 +0200", "Message-Id": "<20210127135305.15260-1-viacheslavo@nvidia.com>", "X-Mailer": "git-send-email 2.18.1", "Subject": "[dpdk-dev] [PATCH] net/mlx5: fix wire vport hint", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "In order to optimize number of hops in the steering tables there\nwas the hint field of source vport in the matcher. If this hint\nwas provided for the wire port the actual vport match, used by\nkernel, was not set in the matcher metadata register field.\nThis could led to not creating the rule in hardware and E-Switch\nmalfunction if kernel used non-zero metadata value for the wire\nvport.\n\nThis patch always sets the match for the vport metadata register\nvalue besides the hint.\n\nFixes: aaf34de5d801 (\"net/mlx5: add wire vport hint\")\nCc: stable@dpdk.org\n\nSigned-off-by: Viacheslav Ovsiienko <viacheslavo@nvidia.com>\n---\n drivers/net/mlx5/mlx5_flow_dv.c | 14 +++++++++-----\n 1 file changed, 9 insertions(+), 5 deletions(-)", "diff": "diff --git a/drivers/net/mlx5/mlx5_flow_dv.c b/drivers/net/mlx5/mlx5_flow_dv.c\nindex 1a0c0be680..15f778a509 100644\n--- a/drivers/net/mlx5/mlx5_flow_dv.c\n+++ b/drivers/net/mlx5/mlx5_flow_dv.c\n@@ -7964,11 +7964,15 @@ flow_dv_translate_item_port_id(struct rte_eth_dev *dev, void *matcher,\n \t\t priv->pf_bond < 0 && attr->transfer)\n \t\t\tflow_dv_translate_item_source_vport\n \t\t\t\t(matcher, key, priv->vport_id, mask);\n-\t\telse\n-\t\t\tflow_dv_translate_item_meta_vport\n-\t\t\t\t(matcher, key,\n-\t\t\t\t priv->vport_meta_tag,\n-\t\t\t\t priv->vport_meta_mask);\n+\t\t/*\n+\t\t * We should always set the vport metadata register,\n+\t\t * otherwise the SW steering library can drop\n+\t\t * the rule if wire vport metadata value is not zero,\n+\t\t * it depends on kernel configuration.\n+\t\t */\n+\t\tflow_dv_translate_item_meta_vport(matcher, key,\n+\t\t\t\t\t\t priv->vport_meta_tag,\n+\t\t\t\t\t\t priv->vport_meta_mask);\n \t} else {\n \t\tflow_dv_translate_item_source_vport(matcher, key,\n \t\t\t\t\t\t priv->vport_id, mask);\n", "prefixes": [] }