Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/87343/?format=api
{ "id": 87343, "url": "https://patches.dpdk.org/api/patches/87343/?format=api", "web_url": "https://patches.dpdk.org/project/dpdk/patch/20210126141857.1029916-7-bruce.richardson@intel.com/", "project": { "id": 1, "url": "https://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20210126141857.1029916-7-bruce.richardson@intel.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20210126141857.1029916-7-bruce.richardson@intel.com", "date": "2021-01-26T14:18:55", "name": "[v4,6/7] devtools: remove check-includes script", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": true, "hash": "3446a4fbca496b645190804810bd0ee50896b2ed", "submitter": { "id": 20, "url": "https://patches.dpdk.org/api/people/20/?format=api", "name": "Bruce Richardson", "email": "bruce.richardson@intel.com" }, "delegate": { "id": 24651, "url": "https://patches.dpdk.org/api/users/24651/?format=api", "username": "dmarchand", "first_name": "David", "last_name": "Marchand", "email": "david.marchand@redhat.com" }, "mbox": "https://patches.dpdk.org/project/dpdk/patch/20210126141857.1029916-7-bruce.richardson@intel.com/mbox/", "series": [ { "id": 14953, "url": "https://patches.dpdk.org/api/series/14953/?format=api", "web_url": "https://patches.dpdk.org/project/dpdk/list/?series=14953", "date": "2021-01-26T14:18:49", "name": "add checking of header includes", "version": 4, "mbox": "https://patches.dpdk.org/series/14953/mbox/" } ], "comments": "https://patches.dpdk.org/api/patches/87343/comments/", "check": "success", "checks": "https://patches.dpdk.org/api/patches/87343/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from mails.dpdk.org (mails.dpdk.org [217.70.189.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id 209A5A052A;\n\tTue, 26 Jan 2021 15:20:06 +0100 (CET)", "from [217.70.189.124] (localhost [127.0.0.1])\n\tby mails.dpdk.org (Postfix) with ESMTP id E58FA140F55;\n\tTue, 26 Jan 2021 15:19:42 +0100 (CET)", "from mga18.intel.com (mga18.intel.com [134.134.136.126])\n by mails.dpdk.org (Postfix) with ESMTP id 8B259140EE9\n for <dev@dpdk.org>; Tue, 26 Jan 2021 15:19:38 +0100 (CET)", "from fmsmga008.fm.intel.com ([10.253.24.58])\n by orsmga106.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384;\n 26 Jan 2021 06:19:38 -0800", "from silpixa00399126.ir.intel.com ([10.237.222.4])\n by fmsmga008.fm.intel.com with ESMTP; 26 Jan 2021 06:19:36 -0800" ], "IronPort-SDR": [ "\n sIjHpTMR5VAf+fSgrVCqwEKLhi73owHMxdOsdqm8puvhEZ0OusqaN+QhA7vwAiSJc+kP8KfAzo\n SnwrSmQ4J3Qw==", "\n hYgJL4cnYVU6XT7EAvAMnFO2p0y/INh/w0YdV+Ic+ES4GvStZn2iRiO/ZIH1ebVh3B1BljXeqk\n 1pPa21rSdlmA==" ], "X-IronPort-AV": [ "E=McAfee;i=\"6000,8403,9875\"; a=\"167577359\"", "E=Sophos;i=\"5.79,375,1602572400\"; d=\"scan'208\";a=\"167577359\"", "E=Sophos;i=\"5.79,375,1602572400\"; d=\"scan'208\";a=\"361995541\"" ], "X-ExtLoop1": "1", "From": "Bruce Richardson <bruce.richardson@intel.com>", "To": "dev@dpdk.org", "Cc": "david.marchand@redhat.com, Bruce Richardson <bruce.richardson@intel.com>,\n Thomas Monjalon <thomas@monjalon.net>", "Date": "Tue, 26 Jan 2021 14:18:55 +0000", "Message-Id": "<20210126141857.1029916-7-bruce.richardson@intel.com>", "X-Mailer": "git-send-email 2.27.0", "In-Reply-To": "<20210126141857.1029916-1-bruce.richardson@intel.com>", "References": "<20210114110606.21142-1-bruce.richardson@intel.com>\n <20210126141857.1029916-1-bruce.richardson@intel.com>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "Subject": "[dpdk-dev] [PATCH v4 6/7] devtools: remove check-includes script", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "The check-includes script allowed checking header files in a given\ndirectory to ensure that each header compiled alone without requiring\nany other header inclusions.\n\nWith header checking now being done by the chkincs app in the build\nsystem this script can be removed.\n\nSigned-off-by: Bruce Richardson <bruce.richardson@intel.com>\n---\n MAINTAINERS | 1 -\n devtools/check-includes.sh | 259 -------------------------------------\n 2 files changed, 260 deletions(-)\n delete mode 100755 devtools/check-includes.sh", "diff": "diff --git a/MAINTAINERS b/MAINTAINERS\nindex d4f9ebe46d..8498b402db 100644\n--- a/MAINTAINERS\n+++ b/MAINTAINERS\n@@ -81,7 +81,6 @@ F: devtools/check-dup-includes.sh\n F: devtools/check-maintainers.sh\n F: devtools/check-forbidden-tokens.awk\n F: devtools/check-git-log.sh\n-F: devtools/check-includes.sh\n F: devtools/check-spdx-tag.sh\n F: devtools/check-symbol-maps.sh\n F: devtools/checkpatches.sh\ndiff --git a/devtools/check-includes.sh b/devtools/check-includes.sh\ndeleted file mode 100755\nindex 940cf0eb2a..0000000000\n--- a/devtools/check-includes.sh\n+++ /dev/null\n@@ -1,259 +0,0 @@\n-#!/bin/sh -e\n-# SPDX-License-Identifier: BSD-3-Clause\n-# Copyright 2016 6WIND S.A.\n-\n-# This script checks that header files in a given directory do not miss\n-# dependencies when included on their own, do not conflict and accept being\n-# compiled with the strictest possible flags.\n-#\n-# Files are looked up in the directory provided as the first argument,\n-# otherwise build/include by default.\n-#\n-# Recognized environment variables:\n-#\n-# VERBOSE=1 is the same as -v.\n-#\n-# QUIET=1 is the same as -q.\n-#\n-# SUMMARY=1 is the same as -s.\n-#\n-# CC, CPPFLAGS, CFLAGS, CXX, CXXFLAGS are taken into account.\n-#\n-# PEDANTIC_CFLAGS, PEDANTIC_CXXFLAGS and PEDANTIC_CPPFLAGS provide strict\n-# C/C++ compilation flags.\n-#\n-# IGNORE contains a list of globbing patterns matching files (relative to the\n-# include directory) to avoid. It is set by default to known DPDK headers\n-# which must not be included on their own.\n-#\n-# IGNORE_CXX provides additional files for C++.\n-\n-while getopts hqvs arg; do\n-\tcase $arg in\n-\th)\n-\t\tcat <<EOF\n-usage: $0 [-h] [-q] [-v] [-s] [DIR]\n-\n-This script checks that header files in a given directory do not miss\n-dependencies when included on their own, do not conflict and accept being\n-compiled with the strictest possible flags.\n-\n- -h display this help and exit\n- -q quiet mode, disable normal output\n- -v show command lines being executed\n- -s show summary\n-\n-With no DIR, default to build/include.\n-\n-Any failed header check yields a nonzero exit status.\n-EOF\n-\t\texit\n-\t\t;;\n-\tq)\n-\t\tQUIET=1\n-\t\t;;\n-\tv)\n-\t\tVERBOSE=1\n-\t\t;;\n-\ts)\n-\t\tSUMMARY=1\n-\t\t;;\n-\t*)\n-\t\texit 1\n-\t\t;;\n-\tesac\n-done\n-\n-shift $(($OPTIND - 1))\n-\n-include_dir=${1:-build/include}\n-\n-: ${PEDANTIC_CFLAGS=-std=c99 -pedantic -Wall -Wextra -Werror}\n-: ${PEDANTIC_CXXFLAGS=}\n-: ${PEDANTIC_CPPFLAGS=-D_XOPEN_SOURCE=600}\n-: ${CC:=cc}\n-: ${CXX:=c++}\n-: ${IGNORE= \\\n-\t'rte_atomic_32.h' \\\n-\t'rte_atomic_64.h' \\\n-\t'rte_byteorder_32.h' \\\n-\t'rte_byteorder_64.h' \\\n-\t'generic/*' \\\n-\t'rte_vhost.h' \\\n-\t'rte_eth_vhost.h' \\\n-\t'rte_eal_interrupts.h' \\\n-}\n-: ${IGNORE_CXX= \\\n-\t'rte_vhost.h' \\\n-\t'rte_eth_vhost.h' \\\n-}\n-\n-temp_cc=$(mktemp -t dpdk.${0##*/}.XXX.c)\n-pass_cc=\n-failures_cc=0\n-\n-temp_cxx=$(mktemp -t dpdk.${0##*/}.XXX.cc)\n-pass_cxx=\n-failures_cxx=0\n-\n-# Process output parameters.\n-\n-[ \"$QUIET\" = 1 ] &&\n-exec 1> /dev/null\n-\n-[ \"$VERBOSE\" = 1 ] &&\n-output ()\n-{\n-\tlocal CCV\n-\tlocal CXXV\n-\n-\tshift\n-\tCCV=$CC\n-\tCXXV=$CXX\n-\tCC=\"echo $CC\" CXX=\"echo $CXX\" \"$@\"\n-\tCC=$CCV\n-\tCXX=$CXXV\n-\n-\t\"$@\"\n-} ||\n-output ()\n-{\n-\n-\tprintf ' %s\\n' \"$1\"\n-\tshift\n-\t\"$@\"\n-}\n-\n-trap 'rm -f \"$temp_cc\" \"$temp_cxx\"' EXIT\n-\n-compile_cc ()\n-{\n-\t${CC} -I\"$include_dir\" \\\n-\t\t${PEDANTIC_CPPFLAGS} ${CPPFLAGS} \\\n-\t\t${PEDANTIC_CFLAGS} ${CFLAGS} \\\n-\t\t-c -o /dev/null \"${temp_cc}\"\n-}\n-\n-compile_cxx ()\n-{\n-\t${CXX} -I\"$include_dir\" \\\n-\t\t${PEDANTIC_CPPFLAGS} ${CPPFLAGS} \\\n-\t\t${PEDANTIC_CXXFLAGS} ${CXXFLAGS} \\\n-\t\t-c -o /dev/null \"${temp_cxx}\"\n-}\n-\n-ignore ()\n-{\n-\tfile=\"$1\"\n-\tshift\n-\twhile [ $# -ne 0 ]; do\n-\t\tcase \"$file\" in\n-\t\t$1)\n-\t\t\treturn 0\n-\t\t\t;;\n-\t\tesac\n-\t\tshift\n-\tdone\n-\treturn 1\n-}\n-\n-# Check C/C++ compilation for each header file.\n-\n-while read -r path\n-do\n-\tfile=${path#$include_dir}\n-\tfile=${file##/}\n-\tif ignore \"$file\" $IGNORE; then\n-\t\toutput \"SKIP $file\" :\n-\t\tcontinue\n-\tfi\n-\tif printf \"\\\n-#include <%s>\n-\n-int main(void)\n-{\n-\treturn 0;\n-}\n-\" \"$file\" > \"$temp_cc\" &&\n-\t\toutput \"CC $file\" compile_cc\n-\tthen\n-\t\tpass_cc=\"$pass_cc $file\"\n-\telse\n-\t\tfailures_cc=$(($failures_cc + 1))\n-\tfi\n-\tif ignore \"$file\" $IGNORE_CXX; then\n-\t\toutput \"SKIP CXX $file\" :\n-\t\tcontinue\n-\tfi\n-\tif printf \"\\\n-#include <%s>\n-\n-int main()\n-{\n-}\n-\" \"$file\" > \"$temp_cxx\" &&\n-\t\toutput \"CXX $file\" compile_cxx\n-\tthen\n-\t\tpass_cxx=\"$pass_cxx $file\"\n-\telse\n-\t\tfailures_cxx=$(($failures_cxx + 1))\n-\tfi\n-done <<EOF\n-$(find \"$include_dir\" -name '*.h')\n-EOF\n-\n-# Check C compilation with all includes.\n-\n-: > \"$temp_cc\" &&\n-for file in $pass_cc; do\n-\tprintf \"\\\n-#include <%s>\n-\" \"$file\" >> $temp_cc\n-done\n-if printf \"\\\n-int main(void)\n-{\n-\treturn 0;\n-}\n-\" >> \"$temp_cc\" &&\n-\toutput \"CC (all includes that did not fail)\" compile_cc\n-then\n-\t:\n-else\n-\tfailures_cc=$(($failures_cc + 1))\n-fi\n-\n-# Check C++ compilation with all includes.\n-\n-: > \"$temp_cxx\" &&\n-for file in $pass_cxx; do\n-\tprintf \"\\\n-#include <%s>\n-\" \"$file\" >> $temp_cxx\n-done\n-if printf \"\\\n-int main()\n-{\n-}\n-\" >> \"$temp_cxx\" &&\n-\toutput \"CXX (all includes that did not fail)\" compile_cxx\n-then\n-\t:\n-else\n-\tfailures_cxx=$(($failures_cxx + 1))\n-fi\n-\n-# Report results.\n-\n-if [ \"$SUMMARY\" = 1 ]; then\n-\tprintf \"\\\n-Summary:\n- %u failure(s) for C using '%s'.\n- %u failure(s) for C++ using '%s'.\n-\" $failures_cc \"$CC\" $failures_cxx \"$CXX\" 1>&2\n-fi\n-\n-# Exit with nonzero status if there are failures.\n-\n-[ $failures_cc -eq 0 ] &&\n-[ $failures_cxx -eq 0 ]\n", "prefixes": [ "v4", "6/7" ] }