Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/87339/?format=api
{ "id": 87339, "url": "https://patches.dpdk.org/api/patches/87339/?format=api", "web_url": "https://patches.dpdk.org/project/dpdk/patch/20210126141857.1029916-3-bruce.richardson@intel.com/", "project": { "id": 1, "url": "https://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20210126141857.1029916-3-bruce.richardson@intel.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20210126141857.1029916-3-bruce.richardson@intel.com", "date": "2021-01-26T14:18:51", "name": "[v4,2/7] eal: fix error attribute use for clang", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": true, "hash": "95e201de44ac542216bbb52de6821ac0272b09bd", "submitter": { "id": 20, "url": "https://patches.dpdk.org/api/people/20/?format=api", "name": "Bruce Richardson", "email": "bruce.richardson@intel.com" }, "delegate": { "id": 24651, "url": "https://patches.dpdk.org/api/users/24651/?format=api", "username": "dmarchand", "first_name": "David", "last_name": "Marchand", "email": "david.marchand@redhat.com" }, "mbox": "https://patches.dpdk.org/project/dpdk/patch/20210126141857.1029916-3-bruce.richardson@intel.com/mbox/", "series": [ { "id": 14953, "url": "https://patches.dpdk.org/api/series/14953/?format=api", "web_url": "https://patches.dpdk.org/project/dpdk/list/?series=14953", "date": "2021-01-26T14:18:49", "name": "add checking of header includes", "version": 4, "mbox": "https://patches.dpdk.org/series/14953/mbox/" } ], "comments": "https://patches.dpdk.org/api/patches/87339/comments/", "check": "warning", "checks": "https://patches.dpdk.org/api/patches/87339/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from mails.dpdk.org (mails.dpdk.org [217.70.189.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id 96525A052A;\n\tTue, 26 Jan 2021 15:19:28 +0100 (CET)", "from [217.70.189.124] (localhost [127.0.0.1])\n\tby mails.dpdk.org (Postfix) with ESMTP id 707CF140E59;\n\tTue, 26 Jan 2021 15:19:23 +0100 (CET)", "from mga05.intel.com (mga05.intel.com [192.55.52.43])\n by mails.dpdk.org (Postfix) with ESMTP id E7273140CD6\n for <dev@dpdk.org>; Tue, 26 Jan 2021 15:19:21 +0100 (CET)", "from fmsmga008.fm.intel.com ([10.253.24.58])\n by fmsmga105.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384;\n 26 Jan 2021 06:19:19 -0800", "from silpixa00399126.ir.intel.com ([10.237.222.4])\n by fmsmga008.fm.intel.com with ESMTP; 26 Jan 2021 06:19:18 -0800" ], "IronPort-SDR": [ "\n NOqYMXD5CM/Qa/JPWeapQTzChAvDbjeEmYioDzcAz3ClmRfmZWaodN5ljZ1u53WnZeCTPJym/y\n GRMDJPuHri3Q==", "\n dzqfBHBUbubLtiQjNGG2S7B6BEnp3TTT26WQO1bvGs+gReJtU8Z7XHsnifHmqqhLYeREJbKeAz\n x90EKIFbRChQ==" ], "X-IronPort-AV": [ "E=McAfee;i=\"6000,8403,9875\"; a=\"264729152\"", "E=Sophos;i=\"5.79,375,1602572400\"; d=\"scan'208\";a=\"264729152\"", "E=Sophos;i=\"5.79,375,1602572400\"; d=\"scan'208\";a=\"361995459\"" ], "X-ExtLoop1": "1", "From": "Bruce Richardson <bruce.richardson@intel.com>", "To": "dev@dpdk.org", "Cc": "david.marchand@redhat.com, Bruce Richardson <bruce.richardson@intel.com>,\n haiyue.wang@intel.com, Ray Kinsella <mdr@ashroe.eu>,\n Neil Horman <nhorman@tuxdriver.com>", "Date": "Tue, 26 Jan 2021 14:18:51 +0000", "Message-Id": "<20210126141857.1029916-3-bruce.richardson@intel.com>", "X-Mailer": "git-send-email 2.27.0", "In-Reply-To": "<20210126141857.1029916-1-bruce.richardson@intel.com>", "References": "<20210114110606.21142-1-bruce.richardson@intel.com>\n <20210126141857.1029916-1-bruce.richardson@intel.com>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "Subject": "[dpdk-dev] [PATCH v4 2/7] eal: fix error attribute use for clang", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "Clang does not have an \"error\" attribute for functions, so for marking\ninternal functions we need to check for the error attribute, and provide\na fallback if it is not present. For clang, we can use \"diagnose_if\"\nattribute, similarly checking for its presence before use.\n\nFixes: fba5af82adc8 (\"eal: add internal ABI tag definition\")\nCc: haiyue.wang@intel.com\n\nSigned-off-by: Bruce Richardson <bruce.richardson@intel.com>\n---\n lib/librte_eal/include/rte_compat.h | 8 +++++++-\n 1 file changed, 7 insertions(+), 1 deletion(-)", "diff": "diff --git a/lib/librte_eal/include/rte_compat.h b/lib/librte_eal/include/rte_compat.h\nindex 4cd8f68d68..c30f072aa3 100644\n--- a/lib/librte_eal/include/rte_compat.h\n+++ b/lib/librte_eal/include/rte_compat.h\n@@ -19,12 +19,18 @@ __attribute__((section(\".text.experimental\")))\n \n #endif\n \n-#ifndef ALLOW_INTERNAL_API\n+#if !defined ALLOW_INTERNAL_API && __has_attribute(error) /* For GCC */\n \n #define __rte_internal \\\n __attribute__((error(\"Symbol is not public ABI\"), \\\n section(\".text.internal\")))\n \n+#elif !defined ALLOW_INTERNAL_API && __has_attribute(diagnose_if) /* For clang */\n+\n+#define __rte_internal \\\n+__attribute__((diagnose_if(1, \"Symbol is not public ABI\", \"error\"), \\\n+section(\".text.internal\")))\n+\n #else\n \n #define __rte_internal \\\n", "prefixes": [ "v4", "2/7" ] }