Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/87321/?format=api
{ "id": 87321, "url": "https://patches.dpdk.org/api/patches/87321/?format=api", "web_url": "https://patches.dpdk.org/project/dpdk/patch/20210126101639.250481-34-maxime.coquelin@redhat.com/", "project": { "id": 1, "url": "https://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20210126101639.250481-34-maxime.coquelin@redhat.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20210126101639.250481-34-maxime.coquelin@redhat.com", "date": "2021-01-26T10:16:28", "name": "[v4,33/44] net/virtio: add Virtio-user status ops", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": true, "hash": "baec81da60c0e557cd5dfcfe3e42b172f4aabebe", "submitter": { "id": 512, "url": "https://patches.dpdk.org/api/people/512/?format=api", "name": "Maxime Coquelin", "email": "maxime.coquelin@redhat.com" }, "delegate": { "id": 2642, "url": "https://patches.dpdk.org/api/users/2642/?format=api", "username": "mcoquelin", "first_name": "Maxime", "last_name": "Coquelin", "email": "maxime.coquelin@redhat.com" }, "mbox": "https://patches.dpdk.org/project/dpdk/patch/20210126101639.250481-34-maxime.coquelin@redhat.com/mbox/", "series": [ { "id": 14950, "url": "https://patches.dpdk.org/api/series/14950/?format=api", "web_url": "https://patches.dpdk.org/project/dpdk/list/?series=14950", "date": "2021-01-26T10:15:55", "name": "net/virtio: Virtio PMD rework", "version": 4, "mbox": "https://patches.dpdk.org/series/14950/mbox/" } ], "comments": "https://patches.dpdk.org/api/patches/87321/comments/", "check": "success", "checks": "https://patches.dpdk.org/api/patches/87321/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from mails.dpdk.org (mails.dpdk.org [217.70.189.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id BEADDA052A;\n\tTue, 26 Jan 2021 11:22:23 +0100 (CET)", "from [217.70.189.124] (localhost [127.0.0.1])\n\tby mails.dpdk.org (Postfix) with ESMTP id BE17C141405;\n\tTue, 26 Jan 2021 11:18:28 +0100 (CET)", "from us-smtp-delivery-124.mimecast.com\n (us-smtp-delivery-124.mimecast.com [216.205.24.124])\n by mails.dpdk.org (Postfix) with ESMTP id 931851413DD\n for <dev@dpdk.org>; Tue, 26 Jan 2021 11:18:22 +0100 (CET)", "from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com\n [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id\n us-mta-143-LDg4gcZzOuS8BjRejNkwAw-1; Tue, 26 Jan 2021 05:18:18 -0500", "from smtp.corp.redhat.com (int-mx01.intmail.prod.int.phx2.redhat.com\n [10.5.11.11])\n (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))\n (No client certificate requested)\n by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 1110918C8C0D;\n Tue, 26 Jan 2021 10:18:17 +0000 (UTC)", "from max-t490s.redhat.com (unknown [10.36.110.31])\n by smtp.corp.redhat.com (Postfix) with ESMTP id 94FA472163;\n Tue, 26 Jan 2021 10:18:15 +0000 (UTC)" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com;\n s=mimecast20190719; t=1611656301;\n h=from:from:reply-to:subject:subject:date:date:message-id:message-id:\n to:to:cc:cc:mime-version:mime-version:content-type:content-type:\n content-transfer-encoding:content-transfer-encoding:\n in-reply-to:in-reply-to:references:references;\n bh=+1/r+4Kap4cGRhQLDyNXhss34eFKM+8PnZwbagQGmpQ=;\n b=YhPd357OxYgVw7DjslP9NNXk6scksuLa6greS9fBSVYSVUMgfMJOqqmsDQGs0niQy9dsjy\n sdEXhAuVkdJyXg/Z/SEP1aa96NW+EABgiVCE0q4vZtJcKSyd4SMTlF315xJka5fA3g+V9K\n 7pNO4hUoaA2vfPMZ+UO3OpEJDAstnWA=", "X-MC-Unique": "LDg4gcZzOuS8BjRejNkwAw-1", "From": "Maxime Coquelin <maxime.coquelin@redhat.com>", "To": "dev@dpdk.org, chenbo.xia@intel.com, olivier.matz@6wind.com,\n amorenoz@redhat.com, david.marchand@redhat.com", "Cc": "Maxime Coquelin <maxime.coquelin@redhat.com>", "Date": "Tue, 26 Jan 2021 11:16:28 +0100", "Message-Id": "<20210126101639.250481-34-maxime.coquelin@redhat.com>", "In-Reply-To": "<20210126101639.250481-1-maxime.coquelin@redhat.com>", "References": "<20210126101639.250481-1-maxime.coquelin@redhat.com>", "MIME-Version": "1.0", "X-Scanned-By": "MIMEDefang 2.79 on 10.5.11.11", "Authentication-Results": "relay.mimecast.com;\n auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=maxime.coquelin@redhat.com", "X-Mimecast-Spam-Score": "0", "X-Mimecast-Originator": "redhat.com", "Content-Transfer-Encoding": "8bit", "Content-Type": "text/plain; charset=\"US-ASCII\"", "Subject": "[dpdk-dev] [PATCH v4 33/44] net/virtio: add Virtio-user status ops", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "This patch introduces new callbacks to\nget and set the device status.\n\nSigned-off-by: Maxime Coquelin <maxime.coquelin@redhat.com>\nReviewed-by: Chenbo Xia <chenbo.xia@intel.com>\n---\n drivers/net/virtio/virtio_user/vhost.h | 2 +\n drivers/net/virtio/virtio_user/vhost_kernel.c | 14 ++\n drivers/net/virtio/virtio_user/vhost_user.c | 121 +++++++++++++-----\n drivers/net/virtio/virtio_user/vhost_vdpa.c | 16 ++-\n .../net/virtio/virtio_user/virtio_user_dev.c | 42 ++----\n 5 files changed, 129 insertions(+), 66 deletions(-)", "diff": "diff --git a/drivers/net/virtio/virtio_user/vhost.h b/drivers/net/virtio/virtio_user/vhost.h\nindex 19040dfdc2..c896f0836d 100644\n--- a/drivers/net/virtio/virtio_user/vhost.h\n+++ b/drivers/net/virtio/virtio_user/vhost.h\n@@ -121,6 +121,8 @@ struct virtio_user_backend_ops {\n \tint (*set_vring_call)(struct virtio_user_dev *dev, struct vhost_vring_file *file);\n \tint (*set_vring_kick)(struct virtio_user_dev *dev, struct vhost_vring_file *file);\n \tint (*set_vring_addr)(struct virtio_user_dev *dev, struct vhost_vring_addr *addr);\n+\tint (*get_status)(struct virtio_user_dev *dev, uint8_t *status);\n+\tint (*set_status)(struct virtio_user_dev *dev, uint8_t status);\n \tint (*send_request)(struct virtio_user_dev *dev,\n \t\t\t enum vhost_user_request req,\n \t\t\t void *arg);\ndiff --git a/drivers/net/virtio/virtio_user/vhost_kernel.c b/drivers/net/virtio/virtio_user/vhost_kernel.c\nindex 48eeb77aec..4de4b669d2 100644\n--- a/drivers/net/virtio/virtio_user/vhost_kernel.c\n+++ b/drivers/net/virtio/virtio_user/vhost_kernel.c\n@@ -316,6 +316,18 @@ vhost_kernel_set_vring_addr(struct virtio_user_dev *dev, struct vhost_vring_addr\n \treturn 0;\n }\n \n+static int\n+vhost_kernel_get_status(struct virtio_user_dev *dev __rte_unused, uint8_t *status __rte_unused)\n+{\n+\treturn -ENOTSUP;\n+}\n+\n+static int\n+vhost_kernel_set_status(struct virtio_user_dev *dev __rte_unused, uint8_t status __rte_unused)\n+{\n+\treturn -ENOTSUP;\n+}\n+\n static uint64_t vhost_req_user_to_kernel[] = {\n \t[VHOST_USER_RESET_OWNER] = VHOST_RESET_OWNER,\n };\n@@ -487,6 +499,8 @@ struct virtio_user_backend_ops virtio_ops_kernel = {\n \t.set_vring_call = vhost_kernel_set_vring_call,\n \t.set_vring_kick = vhost_kernel_set_vring_kick,\n \t.set_vring_addr = vhost_kernel_set_vring_addr,\n+\t.get_status = vhost_kernel_get_status,\n+\t.set_status = vhost_kernel_set_status,\n \t.send_request = vhost_kernel_send_request,\n \t.enable_qp = vhost_kernel_enable_queue_pair\n };\ndiff --git a/drivers/net/virtio/virtio_user/vhost_user.c b/drivers/net/virtio/virtio_user/vhost_user.c\nindex 9ff49d2b1d..91ecb50342 100644\n--- a/drivers/net/virtio/virtio_user/vhost_user.c\n+++ b/drivers/net/virtio/virtio_user/vhost_user.c\n@@ -559,13 +559,100 @@ vhost_user_set_vring_addr(struct virtio_user_dev *dev, struct vhost_vring_addr *\n \treturn 0;\n }\n \n+static int\n+vhost_user_get_status(struct virtio_user_dev *dev, uint8_t *status)\n+{\n+\tint ret;\n+\tstruct vhost_user_msg msg = {\n+\t\t.request = VHOST_USER_GET_STATUS,\n+\t\t.flags = VHOST_USER_VERSION,\n+\t};\n+\n+\t/*\n+\t * If features have not been negotiated, we don't know if the backend\n+\t * supports protocol features\n+\t */\n+\tif (!(dev->status & VIRTIO_CONFIG_STATUS_FEATURES_OK))\n+\t\treturn -ENOTSUP;\n+\n+\t/* Status protocol feature requires protocol features support */\n+\tif (!(dev->device_features & (1ULL << VHOST_USER_F_PROTOCOL_FEATURES)))\n+\t\treturn -ENOTSUP;\n+\n+\tif (!(dev->protocol_features & (1ULL << VHOST_USER_PROTOCOL_F_STATUS)))\n+\t\treturn -ENOTSUP;\n+\n+\tret = vhost_user_write(dev->vhostfd, &msg, NULL, 0);\n+\tif (ret < 0) {\n+\t\tPMD_DRV_LOG(ERR, \"Failed to send request\");\n+\t\tgoto err;\n+\t}\n+\n+\tret = vhost_user_read(dev->vhostfd, &msg);\n+\tif (ret < 0) {\n+\t\tPMD_DRV_LOG(ERR, \"Failed to recv request\");\n+\t\tgoto err;\n+\t}\n+\n+\tif (msg.request != VHOST_USER_GET_STATUS) {\n+\t\tPMD_DRV_LOG(ERR, \"Unexpected request type (%d)\", msg.request);\n+\t\tgoto err;\n+\t}\n+\n+\tif (msg.size != sizeof(msg.payload.u64)) {\n+\t\tPMD_DRV_LOG(ERR, \"Unexpected payload size (%u)\", msg.size);\n+\t\tgoto err;\n+\t}\n+\n+\t*status = (uint8_t)msg.payload.u64;\n+\n+\treturn 0;\n+err:\n+\tPMD_DRV_LOG(ERR, \"Failed to get device status\");\n+\treturn -1;\n+}\n+\n+static int\n+vhost_user_set_status(struct virtio_user_dev *dev, uint8_t status)\n+{\n+\tint ret;\n+\tstruct vhost_user_msg msg = {\n+\t\t.request = VHOST_USER_SET_STATUS,\n+\t\t.flags = VHOST_USER_VERSION,\n+\t\t.size = sizeof(msg.payload.u64),\n+\t\t.payload.u64 = status,\n+\t};\n+\n+\t/*\n+\t * If features have not been negotiated, we don't know if the backend\n+\t * supports protocol features\n+\t */\n+\tif (!(dev->status & VIRTIO_CONFIG_STATUS_FEATURES_OK))\n+\t\treturn -ENOTSUP;\n+\n+\t/* Status protocol feature requires protocol features support */\n+\tif (!(dev->device_features & (1ULL << VHOST_USER_F_PROTOCOL_FEATURES)))\n+\t\treturn -ENOTSUP;\n+\n+\tif (!(dev->protocol_features & (1ULL << VHOST_USER_PROTOCOL_F_STATUS)))\n+\t\treturn -ENOTSUP;\n+\n+\tif (dev->protocol_features & (1ULL << VHOST_USER_PROTOCOL_F_REPLY_ACK))\n+\t\tmsg.flags |= VHOST_USER_NEED_REPLY_MASK;\n+\n+\tret = vhost_user_write(dev->vhostfd, &msg, NULL, 0);\n+\tif (ret < 0) {\n+\t\tPMD_DRV_LOG(ERR, \"Failed to send get status request\");\n+\t\treturn -1;\n+\t}\n+\n+\treturn vhost_user_check_reply_ack(dev, &msg);\n+}\n \n static struct vhost_user_msg m;\n \n const char * const vhost_msg_strings[] = {\n \t[VHOST_USER_RESET_OWNER] = \"VHOST_RESET_OWNER\",\n-\t[VHOST_USER_SET_STATUS] = \"VHOST_SET_STATUS\",\n-\t[VHOST_USER_GET_STATUS] = \"VHOST_GET_STATUS\",\n };\n \n static int\n@@ -576,7 +663,6 @@ vhost_user_sock(struct virtio_user_dev *dev,\n \tstruct vhost_user_msg msg;\n \tstruct vhost_vring_file *file = 0;\n \tint need_reply = 0;\n-\tint has_reply_ack = 0;\n \tint fds[VHOST_MEMORY_MAX_NREGIONS];\n \tint fd_num = 0;\n \tint vhostfd = dev->vhostfd;\n@@ -588,31 +674,11 @@ vhost_user_sock(struct virtio_user_dev *dev,\n \tif (dev->is_server && vhostfd < 0)\n \t\treturn -1;\n \n-\tif (dev->protocol_features & (1ULL << VHOST_USER_PROTOCOL_F_REPLY_ACK))\n-\t\thas_reply_ack = 1;\n-\n \tmsg.request = req;\n \tmsg.flags = VHOST_USER_VERSION;\n \tmsg.size = 0;\n \n \tswitch (req) {\n-\tcase VHOST_USER_GET_STATUS:\n-\t\tif (!(dev->status & VIRTIO_CONFIG_STATUS_FEATURES_OK) ||\n-\t\t (!(dev->protocol_features &\n-\t\t\t\t(1ULL << VHOST_USER_PROTOCOL_F_STATUS))))\n-\t\t\treturn -ENOTSUP;\n-\t\tneed_reply = 1;\n-\t\tbreak;\n-\n-\tcase VHOST_USER_SET_STATUS:\n-\t\tif (!(dev->status & VIRTIO_CONFIG_STATUS_FEATURES_OK) ||\n-\t\t (!(dev->protocol_features &\n-\t\t\t\t(1ULL << VHOST_USER_PROTOCOL_F_STATUS))))\n-\t\t\treturn -ENOTSUP;\n-\n-\t\tif (has_reply_ack)\n-\t\t\tmsg.flags |= VHOST_USER_NEED_REPLY_MASK;\n-\t\t/* Fallthrough */\n \tcase VHOST_USER_SET_LOG_BASE:\n \t\tmsg.payload.u64 = *((__u64 *)arg);\n \t\tmsg.size = sizeof(m.payload.u64);\n@@ -665,13 +731,6 @@ vhost_user_sock(struct virtio_user_dev *dev,\n \t\t}\n \n \t\tswitch (req) {\n-\t\tcase VHOST_USER_GET_STATUS:\n-\t\t\tif (msg.size != sizeof(m.payload.u64)) {\n-\t\t\t\tPMD_DRV_LOG(ERR, \"Received bad msg size\");\n-\t\t\t\treturn -1;\n-\t\t\t}\n-\t\t\t*((__u64 *)arg) = msg.payload.u64;\n-\t\t\tbreak;\n \t\tdefault:\n \t\t\t/* Reply-ack handling */\n \t\t\tif (msg.size != sizeof(m.payload.u64)) {\n@@ -804,6 +863,8 @@ struct virtio_user_backend_ops virtio_ops_user = {\n \t.set_vring_call = vhost_user_set_vring_call,\n \t.set_vring_kick = vhost_user_set_vring_kick,\n \t.set_vring_addr = vhost_user_set_vring_addr,\n+\t.get_status = vhost_user_get_status,\n+\t.set_status = vhost_user_set_status,\n \t.send_request = vhost_user_sock,\n \t.enable_qp = vhost_user_enable_queue_pair\n };\ndiff --git a/drivers/net/virtio/virtio_user/vhost_vdpa.c b/drivers/net/virtio/virtio_user/vhost_vdpa.c\nindex 1ec6bb26f2..8ebc679f1b 100644\n--- a/drivers/net/virtio/virtio_user/vhost_vdpa.c\n+++ b/drivers/net/virtio/virtio_user/vhost_vdpa.c\n@@ -38,8 +38,6 @@\n \n static uint64_t vhost_req_user_to_vdpa[] = {\n \t[VHOST_USER_RESET_OWNER] = VHOST_RESET_OWNER,\n-\t[VHOST_USER_SET_STATUS] = VHOST_VDPA_SET_STATUS,\n-\t[VHOST_USER_GET_STATUS] = VHOST_VDPA_GET_STATUS,\n };\n \n /* no alignment requirement */\n@@ -379,6 +377,18 @@ vhost_vdpa_set_vring_addr(struct virtio_user_dev *dev, struct vhost_vring_addr *\n \treturn vhost_vdpa_ioctl(dev->vhostfd, VHOST_SET_VRING_ADDR, addr);\n }\n \n+static int\n+vhost_vdpa_get_status(struct virtio_user_dev *dev, uint8_t *status)\n+{\n+\treturn vhost_vdpa_ioctl(dev->vhostfd, VHOST_VDPA_GET_STATUS, status);\n+}\n+\n+static int\n+vhost_vdpa_set_status(struct virtio_user_dev *dev, uint8_t status)\n+{\n+\treturn vhost_vdpa_ioctl(dev->vhostfd, VHOST_VDPA_SET_STATUS, &status);\n+}\n+\n /* with below features, vhost vdpa does not need to do the checksum and TSO,\n * these info will be passed to virtio_user through virtio net header.\n */\n@@ -490,6 +500,8 @@ struct virtio_user_backend_ops virtio_ops_vdpa = {\n \t.set_vring_call = vhost_vdpa_set_vring_call,\n \t.set_vring_kick = vhost_vdpa_set_vring_kick,\n \t.set_vring_addr = vhost_vdpa_set_vring_addr,\n+\t.get_status = vhost_vdpa_get_status,\n+\t.set_status = vhost_vdpa_set_status,\n \t.send_request = vhost_vdpa_send_request,\n \t.enable_qp = vhost_vdpa_enable_queue_pair,\n \t.dma_map = vhost_vdpa_dma_map_batch,\ndiff --git a/drivers/net/virtio/virtio_user/virtio_user_dev.c b/drivers/net/virtio/virtio_user/virtio_user_dev.c\nindex 7e365d0570..33a25f4684 100644\n--- a/drivers/net/virtio/virtio_user/virtio_user_dev.c\n+++ b/drivers/net/virtio/virtio_user/virtio_user_dev.c\n@@ -814,21 +814,12 @@ int\n virtio_user_dev_set_status(struct virtio_user_dev *dev, uint8_t status)\n {\n \tint ret;\n-\tuint64_t arg = status;\n \n \tpthread_mutex_lock(&dev->mutex);\n \tdev->status = status;\n-\tif (dev->backend_type == VIRTIO_USER_BACKEND_VHOST_USER)\n-\t\tret = dev->ops->send_request(dev,\n-\t\t\t\tVHOST_USER_SET_STATUS, &arg);\n-\telse if (dev->backend_type == VIRTIO_USER_BACKEND_VHOST_VDPA)\n-\t\tret = dev->ops->send_request(dev,\n-\t\t\t\tVHOST_USER_SET_STATUS, &status);\n-\telse\n-\t\tret = -ENOTSUP;\n-\n+\tret = dev->ops->set_status(dev, status);\n \tif (ret && ret != -ENOTSUP) {\n-\t\tPMD_INIT_LOG(ERR, \"VHOST_USER_SET_STATUS failed (%d): %s\", ret,\n+\t\tPMD_INIT_LOG(ERR, \"Virtio-user set status failed (%d): %s\", ret,\n \t\t\t strerror(errno));\n \t}\n \n@@ -839,29 +830,13 @@ virtio_user_dev_set_status(struct virtio_user_dev *dev, uint8_t status)\n int\n virtio_user_dev_update_status(struct virtio_user_dev *dev)\n {\n-\tuint64_t ret;\n+\tint ret;\n \tuint8_t status;\n-\tint err;\n \n \tpthread_mutex_lock(&dev->mutex);\n-\tif (dev->backend_type == VIRTIO_USER_BACKEND_VHOST_USER) {\n-\t\terr = dev->ops->send_request(dev, VHOST_USER_GET_STATUS, &ret);\n-\t\tif (!err && ret > UINT8_MAX) {\n-\t\t\tPMD_INIT_LOG(ERR, \"Invalid VHOST_USER_GET_STATUS \"\n-\t\t\t\t\t\"response 0x%\" PRIx64 \"\\n\", ret);\n-\t\t\terr = -1;\n-\t\t\tgoto error;\n-\t\t}\n \n-\t\tstatus = ret;\n-\t} else if (dev->backend_type == VIRTIO_USER_BACKEND_VHOST_VDPA) {\n-\t\terr = dev->ops->send_request(dev, VHOST_USER_GET_STATUS,\n-\t\t\t\t&status);\n-\t} else {\n-\t\terr = -ENOTSUP;\n-\t}\n-\n-\tif (!err) {\n+\tret = dev->ops->get_status(dev, &status);\n+\tif (!ret) {\n \t\tdev->status = status;\n \t\tPMD_INIT_LOG(DEBUG, \"Updated Device Status(0x%08x):\\n\"\n \t\t\t\"\\t-RESET: %u\\n\"\n@@ -879,12 +854,11 @@ virtio_user_dev_update_status(struct virtio_user_dev *dev)\n \t\t\t!!(dev->status & VIRTIO_CONFIG_STATUS_FEATURES_OK),\n \t\t\t!!(dev->status & VIRTIO_CONFIG_STATUS_DEV_NEED_RESET),\n \t\t\t!!(dev->status & VIRTIO_CONFIG_STATUS_FAILED));\n-\t} else if (err != -ENOTSUP) {\n-\t\tPMD_INIT_LOG(ERR, \"VHOST_USER_GET_STATUS failed (%d): %s\", err,\n+\t} else if (ret != -ENOTSUP) {\n+\t\tPMD_INIT_LOG(ERR, \"Virtio-user get status failed (%d): %s\", ret,\n \t\t\t strerror(errno));\n \t}\n \n-error:\n \tpthread_mutex_unlock(&dev->mutex);\n-\treturn err;\n+\treturn ret;\n }\n", "prefixes": [ "v4", "33/44" ] }