Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/87308/?format=api
{ "id": 87308, "url": "https://patches.dpdk.org/api/patches/87308/?format=api", "web_url": "https://patches.dpdk.org/project/dpdk/patch/20210126101639.250481-21-maxime.coquelin@redhat.com/", "project": { "id": 1, "url": "https://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20210126101639.250481-21-maxime.coquelin@redhat.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20210126101639.250481-21-maxime.coquelin@redhat.com", "date": "2021-01-26T10:16:15", "name": "[v4,20/44] net/virtio: move virtqueue defines in generic header", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": true, "hash": "537bde728744496d8b0952542a64e3353bff8b56", "submitter": { "id": 512, "url": "https://patches.dpdk.org/api/people/512/?format=api", "name": "Maxime Coquelin", "email": "maxime.coquelin@redhat.com" }, "delegate": { "id": 2642, "url": "https://patches.dpdk.org/api/users/2642/?format=api", "username": "mcoquelin", "first_name": "Maxime", "last_name": "Coquelin", "email": "maxime.coquelin@redhat.com" }, "mbox": "https://patches.dpdk.org/project/dpdk/patch/20210126101639.250481-21-maxime.coquelin@redhat.com/mbox/", "series": [ { "id": 14950, "url": "https://patches.dpdk.org/api/series/14950/?format=api", "web_url": "https://patches.dpdk.org/project/dpdk/list/?series=14950", "date": "2021-01-26T10:15:55", "name": "net/virtio: Virtio PMD rework", "version": 4, "mbox": "https://patches.dpdk.org/series/14950/mbox/" } ], "comments": "https://patches.dpdk.org/api/patches/87308/comments/", "check": "success", "checks": "https://patches.dpdk.org/api/patches/87308/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from mails.dpdk.org (mails.dpdk.org [217.70.189.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id 2004BA052A;\n\tTue, 26 Jan 2021 11:20:14 +0100 (CET)", "from [217.70.189.124] (localhost [127.0.0.1])\n\tby mails.dpdk.org (Postfix) with ESMTP id A952D14138B;\n\tTue, 26 Jan 2021 11:17:49 +0100 (CET)", "from us-smtp-delivery-124.mimecast.com\n (us-smtp-delivery-124.mimecast.com [63.128.21.124])\n by mails.dpdk.org (Postfix) with ESMTP id 8C7E4141385\n for <dev@dpdk.org>; Tue, 26 Jan 2021 11:17:45 +0100 (CET)", "from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com\n [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id\n us-mta-428-V3ffHJFVM_O_rMU29MP0Dg-1; Tue, 26 Jan 2021 05:17:43 -0500", "from smtp.corp.redhat.com (int-mx01.intmail.prod.int.phx2.redhat.com\n [10.5.11.11])\n (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))\n (No client certificate requested)\n by mimecast-mx01.redhat.com (Postfix) with ESMTPS id EA235107ACE4;\n Tue, 26 Jan 2021 10:17:41 +0000 (UTC)", "from max-t490s.redhat.com (unknown [10.36.110.31])\n by smtp.corp.redhat.com (Postfix) with ESMTP id 52EF872163;\n Tue, 26 Jan 2021 10:17:40 +0000 (UTC)" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com;\n s=mimecast20190719; t=1611656264;\n h=from:from:reply-to:subject:subject:date:date:message-id:message-id:\n to:to:cc:cc:mime-version:mime-version:content-type:content-type:\n content-transfer-encoding:content-transfer-encoding:\n in-reply-to:in-reply-to:references:references;\n bh=um0lDGqM4NGyIOdKzdhBAKuhcSah5FwXUJeZHtFxLi0=;\n b=hv9n2UoSVyZ/BGPvZcwwYlSCeJO0NJ98wZhfu4oPyExnZQLTzeMzdUtCNaxttmvzUy7XGp\n U7KZJK0jSmdQhpLMU2Us+8NU0nKObyGmHGxLYQPqa8PePZu5JgZytke0QPk453fuNt1JwP\n N8sMm+c4vgyRdg4u3GQ/zTXNChIUwpM=", "X-MC-Unique": "V3ffHJFVM_O_rMU29MP0Dg-1", "From": "Maxime Coquelin <maxime.coquelin@redhat.com>", "To": "dev@dpdk.org, chenbo.xia@intel.com, olivier.matz@6wind.com,\n amorenoz@redhat.com, david.marchand@redhat.com", "Cc": "Maxime Coquelin <maxime.coquelin@redhat.com>", "Date": "Tue, 26 Jan 2021 11:16:15 +0100", "Message-Id": "<20210126101639.250481-21-maxime.coquelin@redhat.com>", "In-Reply-To": "<20210126101639.250481-1-maxime.coquelin@redhat.com>", "References": "<20210126101639.250481-1-maxime.coquelin@redhat.com>", "MIME-Version": "1.0", "X-Scanned-By": "MIMEDefang 2.79 on 10.5.11.11", "Authentication-Results": "relay.mimecast.com;\n auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=maxime.coquelin@redhat.com", "X-Mimecast-Spam-Score": "0", "X-Mimecast-Originator": "redhat.com", "Content-Transfer-Encoding": "8bit", "Content-Type": "text/plain; charset=\"US-ASCII\"", "Subject": "[dpdk-dev] [PATCH v4 20/44] net/virtio: move virtqueue defines in\n generic header", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "This patch moves the virtqueues defines from PCI header\nto the generic one.\n\nSigned-off-by: Maxime Coquelin <maxime.coquelin@redhat.com>\nReviewed-by: Chenbo Xia <chenbo.xia@intel.com>\n---\n drivers/net/virtio/virtio.h | 18 ++++++++++++++++++\n drivers/net/virtio/virtio_ethdev.h | 4 +++-\n drivers/net/virtio/virtio_pci.h | 17 -----------------\n .../net/virtio/virtio_user/virtio_user_dev.h | 3 ++-\n 4 files changed, 23 insertions(+), 19 deletions(-)", "diff": "diff --git a/drivers/net/virtio/virtio.h b/drivers/net/virtio/virtio.h\nindex cdfee5d182..0c2b3525d5 100644\n--- a/drivers/net/virtio/virtio.h\n+++ b/drivers/net/virtio/virtio.h\n@@ -88,6 +88,24 @@\n #define VIRTIO_NET_S_LINK_UP\t1\t/* Link is up */\n #define VIRTIO_NET_S_ANNOUNCE\t2\t/* Announcement is needed */\n \n+/*\n+ * Each virtqueue indirect descriptor list must be physically contiguous.\n+ * To allow us to malloc(9) each list individually, limit the number\n+ * supported to what will fit in one page. With 4KB pages, this is a limit\n+ * of 256 descriptors. If there is ever a need for more, we can switch to\n+ * contigmalloc(9) for the larger allocations, similar to what\n+ * bus_dmamem_alloc(9) does.\n+ *\n+ * Note the sizeof(struct vring_desc) is 16 bytes.\n+ */\n+#define VIRTIO_MAX_INDIRECT ((int)(PAGE_SIZE / 16))\n+\n+/*\n+ * Maximum number of virtqueues per device.\n+ */\n+#define VIRTIO_MAX_VIRTQUEUE_PAIRS 8\n+#define VIRTIO_MAX_VIRTQUEUES (VIRTIO_MAX_VIRTQUEUE_PAIRS * 2 + 1)\n+\n struct virtio_hw {\n \tstruct virtqueue **vqs;\n \tuint64_t guest_features;\ndiff --git a/drivers/net/virtio/virtio_ethdev.h b/drivers/net/virtio/virtio_ethdev.h\nindex 13395937c8..d82856df9b 100644\n--- a/drivers/net/virtio/virtio_ethdev.h\n+++ b/drivers/net/virtio/virtio_ethdev.h\n@@ -7,7 +7,9 @@\n \n #include <stdint.h>\n \n-#include \"virtio_pci.h\"\n+#include <rte_ethdev_driver.h>\n+\n+#include \"virtio.h\"\n \n #ifndef PAGE_SIZE\n #define PAGE_SIZE 4096\ndiff --git a/drivers/net/virtio/virtio_pci.h b/drivers/net/virtio/virtio_pci.h\nindex 3d93e74f36..2c27c906fb 100644\n--- a/drivers/net/virtio/virtio_pci.h\n+++ b/drivers/net/virtio/virtio_pci.h\n@@ -67,23 +67,6 @@ struct virtnet_ctl;\n #define VIRTIO_CONFIG_STATUS_DEV_NEED_RESET\t0x40\n #define VIRTIO_CONFIG_STATUS_FAILED\t\t0x80\n \n-/*\n- * Each virtqueue indirect descriptor list must be physically contiguous.\n- * To allow us to malloc(9) each list individually, limit the number\n- * supported to what will fit in one page. With 4KB pages, this is a limit\n- * of 256 descriptors. If there is ever a need for more, we can switch to\n- * contigmalloc(9) for the larger allocations, similar to what\n- * bus_dmamem_alloc(9) does.\n- *\n- * Note the sizeof(struct vring_desc) is 16 bytes.\n- */\n-#define VIRTIO_MAX_INDIRECT ((int) (PAGE_SIZE / 16))\n-\n-/*\n- * Maximum number of virtqueues per device.\n- */\n-#define VIRTIO_MAX_VIRTQUEUE_PAIRS 8\n-#define VIRTIO_MAX_VIRTQUEUES (VIRTIO_MAX_VIRTQUEUE_PAIRS * 2 + 1)\n \n /* Common configuration */\n #define VIRTIO_PCI_CAP_COMMON_CFG\t1\ndiff --git a/drivers/net/virtio/virtio_user/virtio_user_dev.h b/drivers/net/virtio/virtio_user/virtio_user_dev.h\nindex b3776cc7a0..ab62463a5b 100644\n--- a/drivers/net/virtio/virtio_user/virtio_user_dev.h\n+++ b/drivers/net/virtio/virtio_user/virtio_user_dev.h\n@@ -7,7 +7,8 @@\n \n #include <limits.h>\n #include <stdbool.h>\n-#include \"../virtio_pci.h\"\n+\n+#include \"../virtio.h\"\n #include \"../virtio_ring.h\"\n \n enum virtio_user_backend_type {\n", "prefixes": [ "v4", "20/44" ] }